* refactored error managment for deleteUsersCmdF
* updated tests related to deleteUsersCmdF
* updated user_e2e_test to reflect changes made to the deleteUsersCmdF function
* Empty-Commit to retrigger workflow
* applied gofmt formating reqs to user_test.go
* added suggested changes to the deleteUsersCmdF regarding error gathering
* added requested changes regarding error aggragation on deleteUsersCmdF
* style(mmctl): removing trailing whitespace
* feat(mmctl): returning errors in deleteUserCmdF on err
* fix(mmctl): returns when err parsing args
* test(mmctl): updated tests to expect err instead of reading printer
* style: updating returned errs
* tests: updated test to reflect error change
* tests(mmctl): updated e2e DeleteUserCmd test
* Update server/cmd/mmctl/commands/user.go
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
* refactor: changing error to return username instead of email
* refactor: changing email to username for errors
---------
Co-authored-by: Arnaud Wanet <andrewwanet9@gmail.com>
Co-authored-by: Antonis Stamatiou <stamatiou.antonis@gmail.com>
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
* MM-64417 Change permissions table to use a grid for animation
* Don't change padding on permissions table when animating
* Update snapshots
* Combine CSS for AdminPanel and AdminPanelTogglable
* Removed leftover reference to old CSS file
---------
Co-authored-by: Mattermost Build <build@mattermost.com>
* Stop explicitly passing autocompleteUrlSchemes into text formatting code
This is the first part of changing how autocompleteUrlSchemes works so
that it can be moved to be part of the parser like in mobile instead of
happening in the renderer.
I'm not a fan of using the global store directly in utils/markdown, but
this seems like the only way to have this apply to all the Markdown
that's rendered in various helpers throughout the app. Ideally, we'd
have some getMarkdownParser selector and a hook which provides the
config, but that's a future improvement to make"
* MM-62744 Move URL filtering to the Markdown parser instead of the renderer
MM-62744 is caused by two things:
1. URL autolinking takes place in the Markdown parser which occurs
before at-mention parsing which (despite the "parsing" part) happens
in the Markdown renderer in the web app.
2. The autolinking in marked is very aggressive and identifies anything
that looks like some:text as a link.
Those lead to remote mentions like `@user:server` being incorrectly
parsed by Markdown as a link to `user:server`. It isn't renderered as a
link because the URL filtering logic in the Markdown parser blocks that,
but at that point, the Markdown renderer won't check if it's an
at-mention.
By moving the URL filtering to occur earlier, like it does in the mobile
app, the Markdown code won't autolink `@user:server` (unless the server
has `user` configured as a custom URL scheme for some reason), so it's
free to be turned into an at-mention by the renderer code.
* MM-62744 Ensure various regexes and features support remote mentions
* Update marked back to master
* Improve clarity of channel notification limit messages
- Update user-facing messages to explain performance reasoning and provide guidance
- Enhance admin setting descriptions to be more informative about user experience
- Change admin setting title to better reflect purpose
Fixes#32159
Co-authored-by: Sven Hüster <svelle@users.noreply.github.com>
* Update webapp/channels/src/i18n/en.json
Co-authored-by: Matthew Birtch <mattbirtch@gmail.com>
* Update server/i18n/en.json
Co-authored-by: Matthew Birtch <mattbirtch@gmail.com>
* Update server/i18n/en.json
* Update server/i18n/en.json
---------
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Co-authored-by: Sven Hüster <svelle@users.noreply.github.com>
Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>
Co-authored-by: Matthew Birtch <mattbirtch@gmail.com>
* Add defensive fallback for userHasReadPermissionOnSomeResources
When called with a string instead of an object, the function now falls back
to checking a single resource permission instead of failing.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
* Revert "Add defensive fallback for userHasReadPermissionOnSomeResources"
This reverts commit f9c32bc3e2598467e7c8a520319ac5ae49135cbf.
* simpler fix -- remove string as a possible parameter
---------
Co-authored-by: Claude <noreply@anthropic.com>
* Link post actions menu button to existing menu
That menu isn't fully accessible because it uses the old Menu widget,
but the readout will at least be correct when tabbing through the post
controls.
* MM-61595 Use dedicated popover component for post actions menu when empty
* Update unit tests
* Split out ActionsMenuEmptyPopover to start of separate Popover component
Fix navigation to custom data retention policy form by correcting permission
checking functions. The routes for creating and editing custom data retention
policies were using userHasReadPermissionOnSomeResources() with a single
string resource key, causing permission checks to fail and routes to be
hidden.
Changed both custom_policy_form and custom_policy_form_edit routes to use
userHasReadPermissionOnResource() instead, making them consistent with
other working data retention routes.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-authored-by: Claude <noreply@anthropic.com>
Only log a warning when the created user exceeds the `MaxUserLimits` if
`MaxUsersLimit > 0`. This was showing up spuriously on licensed servers
for which no limit applied.
Note that this is distinct from blocking user creation past
`MaxHardUsersLimit`.
* Replace SELECT * with explicit column lists in channel store
Migrates channel_store.go away from SELECT * patterns to explicit column
lists for better performance, maintainability, and schema safety.
- Replace GetPinnedPosts raw SQL with query builder using postSliceColumns()
- Replace "cc.*" in group channel search with channelSliceColumns()
- Replace GetChannelsBatchForIndexing raw SQL with query builder
- Replace channel member and team queries with respective column helpers
- Use SelectBuilder helper instead of manual ToSql() calls
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
* Replace SELECT * with COUNT(*) in user_test.go
Replaces unnecessary SELECT * queries with SELECT COUNT(*) in
TestPermanentDeleteUser bot count verification. Only needs to check
the count of bots, not retrieve full bot records.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
* MM-64428 - user tag invite filtering
* fix lint issues
* remove unnecesary line
* update translations and skip mysql tests
* simplify the solution so in abac channels the invitation link is never shown
* finish clean up of unnecessary code
* clean up and remove no longer necessary translations
* remove leftover props and remove no longer needed tests after simplification
---------
Co-authored-by: Mattermost Build <build@mattermost.com>
