Properly handle analytics client life cycle
This change improves the life cycle management of the analytics
client. It does so in two primary ways:
- Move the client from being a shared pointer to belonging to the
Server struct.
- Expose the client.Close() method for proper shutdown of the
client.
* Add ability to get bot counts per day
Modify tests using AnalyticsPostCountsByDay to include extra input
(botsOnly)
Correctly generate the mock file with 'make store-mocks' target. Didn't
see these comments earlier
* Initial commit for calculating total posts previous day and total posts
from bots previous day
* - Refactor to use asserts instead of if statements in tests
- Capture inputs to AnalyticsPostCountsByDay() function into an
options struct
- Remove bot creation from diagnostics_test.go.
* Remove utils library
* create AnalyticsPostCountsOptions struct which is accepted as an input
to AnalyticsPostCountsByDay method
* Go vet fixes
* [MM-11345] Migrated TokenStore.RemoveAllTokensByType to Sync by default (#11345)
* changed TokenStore.RemoveAllTokensByType to return *model.AppError
* changed test coverage accordingly in store/storetest/mocks
* Fixing mocks
* Migrates Channel.AutocompleteInTeam, Channel.SearchInTeam and Channel.SearchMore to sync by default
* Migrates Channel.GetMembersForUserWithPagination to sync by default
* Test
* Revert "Test"
This reverts commit 2bbf335ee93ae7cd1dfeea4c805efcafeec8dae5.
* Fixed typo in Makefile, line 564: 'persistent' misspelled
* Fixed return of status_store.Get to return model.Status and model.AppError, removed connections to result var in same method, generated new mocks and fixed tests.
* Fixed status_store.go under /sqlstore and /storetest in addition to removing personal comments
* SQL Indentation fix for consistency
* Revert merge change to store.go for SaveOrUpdate to avoid error introduced by merge
* Changed StoreChannel back to *model.Apperror for SaveOrUpdate in store.go, fixed resulting error in storetest/status_store.go so it did not have conflicting types. Fixed spelling errors in same file
* Test for status, err changed according to recommendation upon second look
* Changed status variable on line 77 to blank identifier to stop it from shadowing line 24 declaration
* It appears last statement in test was using 'status' variable where status is model.STATUS_ONLINE instead of model.STATUS_OFFLINE like status3, making comparison always be 'online != offline', which is always true, proceeding into if statement, guaranteeing test failure
* Build fails consistently when line 75 has 'status' in if statement due to shadowing issue due to existing declaration Jenkins complains about in line 24. If this fails then new variable will be necessary
* Renamed parameter to avoid overshadowing issue
* Undid code addition mistake in storetest/status_store.go and updated line 29 accordingly to account for multiple values.
* Remove status3 as used in line 71 in status_store.go.
* Undid change in storetest/status_store.go on line 67 which checked for wrong thing
* when converting a bot to a user, set the role to system_user
* correct govet shadow error
* Change from inline error checking and fix shadow error
* Add SYSTEM_USER_ROLE_ID to the bot user model instead of updating the
role after the bot user is created
* modify UserFromBot test to include Roles field
* Add KV helper methods to Helpers interface
* Address code-review comments, add unit tests
* Update documentation for KVCompareAndSetJSON.
* Update assertions for helpers_bots_test.go
* Fix assertion not called name in test.
* Updated ResetAll function to return object
* Modified the defined interface
* Changed the data type where ResetAll was referrenced
* Refactored code
Changed user's email
* Fixed indentation
* Initial implementation of plugin remote source
* Implement API route
* Test API route
* Add i18n
* Handle different error cases in API route
* Include missing i18n translation
* Include AllowInsecureDownloadUrl in telemetry capture
* Updates from PR feedback
* Use HTTPService instead of http.Get
* Remove InstallPluginFromUrlForced from client4
* Use net/url library to inspect url scheme
* remove PluginDownloadUrl from web/params.go
* Allow plugin downloads from internal sources
* Update LinkMetadata.Get store and interface
* Update mocks with make store-mocks
* Update tests and implementation
* Avoid casting LinkMetadata.Data
* Fix indent
* Make error more explicit
* Fix indent (was containing spaces)
* Test value returned by LinkMetadata().Get()
