mostlymatter

Files

Jesse Hallam 74533371b2 MM-18115: fix segment v3 usage (#12317 )

* diagnostics_test.go: fix spacing

* diagnostics_test.go: explicitly assert payload

This fails, since the package is currently receiving struct pointers and won't set the MessageId or Timestamp on the corresponding Message.

* MM-18115: fix segment v3 usage

In v5.14, we updated [github.com/segmentio/analytics-go](https://github.com/segmentio/analytics-go) to v3 as part of https://mattermost.atlassian.net/browse/MM-12389. As noted in the [migration guide](https://segment.com/docs/sources/server/go/#migrating-from-v2), the API subtly changed to expect a struct value and not a struct pointer:

```go
// in v2, you would call the `Track` method with a `Track` struct.
client.Track(&track)

// in v3, you would call the `Enqueue` method with a `Track` struct.
// Note that a pointer is not used here.
client.Enqueue(track)
```

Unfortunately, we kept passing a pointer, and the package didn't complain since it only required an interface -- which the pointer to these structs still implemented. Internally, it only checked for the value types, and failed to annotate our payloads with the requisite metadata. Upstream, segment.io accepted the payload, but then discarded it silently.

This has since been reported and fixed in https://github.com/segmentio/analytics-go/pull/146, but isn't yet part of a tagged release of the package.

Fix our code to pass struct values instead.

Fixes: MM-18115

2019-09-26 23:49:43 -03:00

admin.go

[MM-14521] New endpoint to validate site urls (#11944 )

2019-09-06 12:52:14 +02:00

analytics.go

Converting to structured logging the file app/analytics.go (#12171 )

2019-09-12 17:58:16 +02:00

app_test.go

Guest accounts feature (#11428 )

2019-07-22 22:13:39 +02:00

app.go

[MM-15639] Add config setting to explicitly define which IP headers are trusted (#10907 )

2019-05-24 20:22:13 +02:00

audit.go

Initial migration of the store to be sync (#10592 )

2019-04-15 22:53:52 +02:00

authentication_test.go

User based rate limiting (#8152 )

2018-01-31 09:49:15 -08:00

authentication.go

Migrate User.UpdateFailedPasswordAttempts to sync by default (#11507 )

2019-07-06 09:05:44 +02:00

authorization_test.go

[MM-18323] Migrate tests from "app/authorization_test.go" to use testify (#12078 )

2019-09-09 13:43:17 +02:00

authorization.go

Refactor "app/authorization.go" to use structured logging (#12233 )

2019-09-18 20:02:22 +02:00

auto_channels.go

MM-8708 Remove api package (#8784 )

2018-05-16 13:43:22 -04:00

auto_constants.go

general cleanup (#8387 )

2018-03-07 12:36:40 -06:00

auto_environment.go

MM-8708 Remove api package (#8784 )

2018-05-16 13:43:22 -04:00

auto_posts.go

MM-17468 - Improving performance of fetching threads (#11980 )

2019-09-17 14:37:10 +01:00

auto_responder_test.go

MM-17071 Remove auto responder logic from App.SendNotifications (#11789 )

2019-08-19 14:15:09 -04:00

auto_responder.go

MM-17071 Remove auto responder logic from App.SendNotifications (#11789 )

2019-08-19 14:15:09 -04:00

auto_teams.go

MM-8708 Remove api package (#8784 )

2018-05-16 13:43:22 -04:00

auto_users.go

[MM-16174] Migrate Team.SaveMember to Sync by default #11125 (#11354 )

2019-07-29 11:30:16 +02:00

bot_test.go

MM-16872 - Extend Plugin API to set LHS bot icon (#11601 )

2019-07-11 12:00:12 -04:00

bot.go

MM-16872 - Extend Plugin API to set LHS bot icon (#11601 )

2019-07-11 12:00:12 -04:00

brand.go

MM-17607: large [brand, team, profile] images crash the server (#11827 )

2019-08-08 17:23:37 -04:00

channel_test.go

GH-12100 Mirgrated tests in app/channel_test.go (#12217 )

2019-09-24 15:22:09 +02:00

channel.go

MM-10272: Add a count for pinned posts header icon (#11840 )

2019-09-04 13:41:29 +02:00

cluster_discovery_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

cluster_discovery.go

Converting to structured logging the file app/cluster_discover… (#12204 )

2019-09-17 12:20:23 +02:00

cluster_handlers.go

MM-16261: Synchronize plugins in HA (#11657 )

2019-07-18 15:05:53 -03:00

cluster.go

Migrate cluster to use Server struct directly. (#10101 )

2019-01-15 09:09:25 -08:00

command_away.go

Move to the mattermost/go-i18n fork (#10669 )

2019-04-23 09:33:42 -04:00

command_channel_header_test.go

MM-14845: Updates default permissions. (#10590 )

2019-04-12 18:00:57 +01:00

command_channel_header.go

Move to the mattermost/go-i18n fork (#10669 )

2019-04-23 09:33:42 -04:00

command_channel_purpose_test.go

MM-14845: Updates default permissions. (#10590 )

2019-04-12 18:00:57 +01:00

command_channel_purpose.go

Move to the mattermost/go-i18n fork (#10669 )

2019-04-23 09:33:42 -04:00

command_channel_rename_test.go

MM-16115: Channel name max length in /rename to match UI. (#11114 )

2019-06-18 10:44:29 +01:00

command_channel_rename.go

MM-16115: Channel name max length in /rename to match UI. (#11114 )

2019-06-18 10:44:29 +01:00

command_code_test.go

remove more global references (#7442 )

2017-09-14 13:01:44 -04:00

command_code.go

Move to the mattermost/go-i18n fork (#10669 )

2019-04-23 09:33:42 -04:00

command_dnd.go

Move to the mattermost/go-i18n fork (#10669 )

2019-04-23 09:33:42 -04:00

command_echo.go

Converting to structured logging the file app/command_echo.go (#12144 )

2019-09-10 14:08:29 +02:00

command_expand_collapse.go

[GH-10866] Preferrence.Save - Remove preference length return arg (#10962 )

2019-05-29 09:54:56 -04:00

command_groupmsg_test.go

MM-18383: updated tests using fatal to use assert (#12175 )

2019-09-24 15:10:58 +02:00

command_groupmsg.go

Restricting groupmsg command to only allow to create group chats with know people (#12148 )

2019-09-13 10:57:47 +02:00

command_help.go

Move to the mattermost/go-i18n fork (#10669 )

2019-04-23 09:33:42 -04:00

command_invite_people_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

command_invite_people.go

Move to the mattermost/go-i18n fork (#10669 )

2019-04-23 09:33:42 -04:00

command_invite_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

command_invite.go

[MM-16667] Migrate User.GetByUsername to Sync by default #11453 (#11520 )

2019-07-10 10:46:03 +02:00

command_join_test.go

Move to the mattermost/go-i18n fork (#10669 )

2019-04-23 09:33:42 -04:00

command_join.go

Migrates Channel.GetByName to sync by default (#11187 )

2019-06-20 15:21:36 +02:00

command_leave_test.go

Guest accounts feature (#11428 )

2019-07-22 22:13:39 +02:00

command_leave.go

Guest accounts feature (#11428 )

2019-07-22 22:13:39 +02:00

command_loadtest.go

MM-17468 - Improving performance of fetching threads (#11980 )

2019-09-17 14:37:10 +01:00

command_logout.go

Move to the mattermost/go-i18n fork (#10669 )

2019-04-23 09:33:42 -04:00

command_me_test.go

MM-2954 - Add a separate post type for /me messages and update formatting (#11082 )

2019-06-20 17:16:36 -04:00

command_me.go

MM-2954 - Add a separate post type for /me messages and update formatting (#11082 )

2019-06-20 17:16:36 -04:00

command_msg_test.go

[MM-17919] Add permission check for guest users before sending a /msg command (#11987 )

2019-09-03 22:11:55 +02:00

command_msg.go

[MM-17919] Add permission check for guest users before sending a /msg command (#11987 )

2019-09-03 22:11:55 +02:00

command_mute_test.go

Migrate tests from 'app/command_mute_test.go' to use testify (#12240 )

2019-09-19 18:01:30 +01:00

command_mute.go

Migrates Channel.GetByName to sync by default (#11187 )

2019-06-20 15:21:36 +02:00

command_offline.go

Move to the mattermost/go-i18n fork (#10669 )

2019-04-23 09:33:42 -04:00

command_online.go

Move to the mattermost/go-i18n fork (#10669 )

2019-04-23 09:33:42 -04:00

command_open.go

Move to the mattermost/go-i18n fork (#10669 )

2019-04-23 09:33:42 -04:00

command_remove_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

command_remove.go

[MM-16667] Migrate User.GetByUsername to Sync by default #11453 (#11520 )

2019-07-10 10:46:03 +02:00

command_search.go

Move to the mattermost/go-i18n fork (#10669 )

2019-04-23 09:33:42 -04:00

command_settings.go

Move to the mattermost/go-i18n fork (#10669 )

2019-04-23 09:33:42 -04:00

command_shortcuts.go

Move to the mattermost/go-i18n fork (#10669 )

2019-04-23 09:33:42 -04:00

command_shrug.go

Move to the mattermost/go-i18n fork (#10669 )

2019-04-23 09:33:42 -04:00

command_test.go

fix vettool; run vet on all available packages (#10389 )

2019-03-04 15:27:59 +01:00

command.go

chore: refactor to use structured logging (#12256 )

2019-09-24 18:30:23 +02:00

compliance.go

Migrating compliance store to sync by default (#10660 )

2019-04-24 11:50:25 +01:00

config_test.go

Convert app/config_test.go t.Fatal calls into assert/require c… (#12220 )

2019-09-24 16:49:23 +02:00

config.go

Migrate User.InferSystemInstallDate to sync by default (#11505 )

2019-07-08 07:46:31 +01:00

data_retention.go

PLT-7705: API to get data retention policy. (#7539 )

2017-10-02 12:43:21 +01:00

diagnostics_test.go

MM-18115: fix segment v3 usage (#12317 )

2019-09-26 23:49:43 -03:00

diagnostics.go

MM-18115: fix segment v3 usage (#12317 )

2019-09-26 23:49:43 -03:00

elasticsearch.go

Idiomatic error handling for app/e*.go (#9426 )

2018-09-24 12:52:29 +05:30

email_batching_test.go

[MM-18320] Migrate tests from "app/email_batching_test.go" to… (#12079 )

2019-09-24 15:33:58 +02:00

email_batching.go

Converting to structured logging the file app/email_batching.go (#12127 )

2019-09-16 17:28:13 -04:00

email_test.go

MM-16369: include potential subpath in emails (#11311 )

2019-06-26 09:13:09 -03:00

email.go

Update email templates for guest accounts (#11802 )

2019-08-06 12:07:35 +02:00

emoji.go

MM-18264 Converting to structured logging the file app/emoji.go (#12139 )

2019-09-11 22:49:27 -05:00

enterprise.go

MM-14811: Accepts Server rather than App in account migration interface registration. (#10568 )

2019-04-10 06:04:07 -04:00

export_converters.go

MM-15021: Adding new builtin system schema for Guests (#10601 )

2019-04-30 20:36:21 +02:00

export_test.go

Convert app/export_test.go t.Fatal calls into assert/require calls (#12184 )

2019-09-13 11:51:46 +02:00

export.go

MM-17224 - Bulk export fails due to missing user (#11738 )

2019-08-01 09:19:37 -03:00

file_bench_test.go

Migrate FileInfo store to Sync by default (#10837 )

2019-05-15 22:07:03 +02:00

file_test.go

fix: migrate the test to testify (#12158 )

2019-09-14 12:53:37 +02:00

file.go

Converting to structured logging the file app/file.go (#12124 )

2019-09-17 13:48:22 -04:00

group_test.go

Changes method name, removes error case. (#11427 )

2019-06-28 07:31:32 -04:00

group.go

MM-17383: Update query to include users who are not members of any gr… (#11730 )

2019-07-30 12:04:08 -04:00

helper_test.go

Convert app/helper_test.go t.Fatal calls into assert/require calls (#12223 )

2019-09-16 18:11:17 -04:00

import_functions_test.go

MM-16366 - Prevent attachment duplication on import (#11770 )

2019-08-04 13:05:33 +03:00

import_functions.go

GH-12196 Converting to structured logging in app/import_functions.go (#12205 )

2019-09-20 12:45:28 -06:00

import_test.go

MM-16548: Fixing bug with empty type in the second line of the bulk import (#11567 )

2019-07-08 16:17:06 +01:00

import_types.go

MM-16888 - Fix canonical vs. migration mismatches (#11825 )

2019-08-14 14:58:01 +03:00

import_validators_test.go

MM-18317 Migrate tests from import_validators_test.go to use t… (#12129 )

2019-09-24 15:37:47 +02:00

import_validators.go

MM-15021: Adding new builtin system schema for Guests (#10601 )

2019-04-30 20:36:21 +02:00

import.go

MM-16548: Fixing bug with empty type in the second line of the bulk import (#11567 )

2019-07-08 16:17:06 +01:00

integration_action_test.go

[MM-15220] Add generic error field to SubmitDialogResponse (#12081 )

2019-09-11 11:35:51 -04:00

integration_action.go

MM-10982 Support relative links in interactive message buttons (#11477 )

2019-07-08 08:50:55 -03:00

job_test.go

Migrate Jobs store to sync by default (#11183 )

2019-06-15 17:55:06 +02:00

job.go

Migrate Jobs store to sync by default (#11183 )

2019-06-15 17:55:06 +02:00

ldap.go

MM-15162: Changes for LDAP groups removals. (#10701 )

2019-05-10 11:47:21 -04:00

license_test.go

Convert app/license_test.go t.Fatal calls into assert/require calls (#12218 )

2019-09-18 10:38:28 -06:00

license.go

Converting to structured logging the file app/license.go (#12170 )

2019-09-13 09:07:00 -04:00

login_test.go

Convert app/login_test.go t.Fatal calls into assert/require ca… (#12221 )

2019-09-24 15:25:24 +02:00

Guest accounts feature (#11428 )

2019-07-22 22:13:39 +02:00

main_test.go

Move to the mattermost/go-i18n fork (#10669 )

2019-04-23 09:33:42 -04:00

migrations.go

Migrate SchemeStore to sync by default (#11522 )

2019-07-06 09:07:54 +02:00

notification_email_test.go

Convert app/notification_email_test.go t.Fatal calls into asse… (#12227 )

2019-09-20 09:04:10 -06:00

notification_email.go

MM-18126 Respect show full name config setting in push and email notifications (#11996 )

2019-09-03 10:33:49 -04:00

notification_push_test.go

[MM-18319] Replace t.Fatal with assert.Equal (#12082 )

2019-09-09 13:32:30 +02:00

notification_push.go

Converting to structured logging the file app/notification_pus… (#12126 )

2019-09-24 17:10:47 +02:00

notification_test.go

MM-18126 Respect show full name config setting in push and email notifications (#11996 )

2019-09-03 10:33:49 -04:00

notification.go

Converting to structured logging the file app/notification.go (#12140 )

2019-09-11 07:52:12 -07:00

oauth_test.go

Migrate tests from 'app/oauth_test.go' to use testify (#12155 )

2019-09-24 15:32:13 +02:00

oauth.go

[MM-16512] Migrate Token.Save to Sync by default (#11353 )

2019-06-26 16:06:41 +05:30

opengraph_test.go

Fix. Replace t.fatal() calls to testify assert/require calls (#12084 )

2019-09-09 20:10:17 +02:00

opengraph.go

MM-17043 Downgrade OpenGraph logging to debug level (#11649 )

2019-07-18 15:46:54 -04:00

options.go

Tracking Push Notifications in a structured logger (notifications.log) (#10823 )

2019-05-13 07:53:46 -07:00

permissions_migrations_test.go

MM-14845: Updates default permissions. (#10590 )

2019-04-12 18:00:57 +01:00

permissions_migrations.go

Guest accounts feature (#11428 )

2019-07-22 22:13:39 +02:00

permissions_test.go

Migrate System store to Sync by default (#10838 )

2019-05-21 18:22:27 +02:00

permissions.go

Migrate "Team.ClearAllCustomRoleAssignments" to Sync by default (#11587 )

2019-07-11 14:54:56 +01:00

plugin_api_test.go

chore: migrate t.fatal to testify (#12231 )

2019-09-19 18:33:24 -04:00

plugin_api.go

MM-17468 - Improving performance of fetching threads (#11980 )

2019-09-17 14:37:10 +01:00

plugin_commands_test.go

MM-17489: fixed racy tryExecutePluginCommand (#11780 )

2019-09-10 12:28:12 -04:00

plugin_commands.go

MM-17489: fixed racy tryExecutePluginCommand (#11780 )

2019-09-10 12:28:12 -04:00

plugin_context.go

MM-12855 Plugin Context (#9922 )

2018-12-05 10:46:08 -08:00

plugin_deadlock_test.go

migrated plugin_deadlock_test.go to use testify (#12077 )

2019-09-14 23:08:04 +02:00

plugin_event.go

MM-16261: Synchronize plugins in HA (#11657 )

2019-07-18 15:05:53 -03:00

plugin_hooks_test.go

MM-17489: fixed racy tryExecutePluginCommand (#11780 )

2019-09-10 12:28:12 -04:00

plugin_install.go

MM-17087 - Disable plugin on removal (#11779 )

2019-08-22 15:17:47 -04:00

plugin_key_value_store.go

MM-16821 - Add a KVCompareAndDelete to the plugin API (#11804 )

2019-08-21 23:25:38 -03:00

plugin_requests.go

Enhance logging of CSRF Warning (#11630 )

2019-07-17 09:08:58 -04:00

plugin_shutdown_test.go

improved OnDeactivate handling (#11988 )

2019-09-05 17:27:36 -03:00

plugin_statuses.go

MM-12974: guard app plugins with mutex (#9818 )

2018-11-20 08:52:51 -05:00

plugin_test.go

Tweak docker compose setup (#11785 )

2019-08-02 18:46:32 -03:00

plugin.go

MM-17023: Plugin Marketplace (#12183 )

2019-09-17 15:02:26 -04:00

post_metadata_test.go

[MM-18628] Fix flaky OpenGraph test (#12365 )

2019-09-26 13:54:51 -04:00

post_metadata.go

Return POST_EMBED_LINK for links that are not images nor og (#11723 )

2019-08-22 23:00:37 +02:00

post_test.go

Replace t.fatal() to testify require/assert calls (#12174 )

2019-09-24 15:23:30 +02:00

post.go

MM-17468 - Improving performance of fetching threads (#11980 )

2019-09-17 14:37:10 +01:00

preference.go

[MM-15302] Migrate Preference.Delete to Sync by default #10715 (#11101 )

2019-06-11 10:51:55 +02:00

ratelimit_test.go

Migrate Status.SaveOrUpdate to Sync by default (#11359 )

2019-06-24 12:03:29 +02:00

ratelimit.go

Converting to structured logging the file app/ratelimit.go (#12176 )

2019-09-12 13:35:07 +02:00

reaction.go

MM-15498 - removed redundant post_edited event on reaction change (#10873 )

2019-06-17 15:39:14 +03:00

role.go

Migrate Roles Layered store to Sync by default (#10790 )

2019-05-17 12:03:04 -03:00

saml.go

MM-14143 config cleanup final (#10374 )

2019-03-06 15:06:45 -05:00

scheme.go

Team.GetTeamsByScheme migrated to sync by default. (#11563 )

2019-07-08 21:30:32 +02:00

security_update_check.go

MM-18290 Using structured logging in file "security_update_che… (#12123 )

2019-09-11 07:33:07 -04:00

server_app_adapters.go

Initial cache migration to new layers system (#11878 )

2019-08-21 20:23:06 +02:00

server_license.go

Cleanup related to context refactor (#9988 )

2018-12-17 08:51:46 -08:00

server_test.go

Move to the mattermost/go-i18n fork (#10669 )

2019-04-23 09:33:42 -04:00

server.go

MM-18115: fix segment v3 usage (#12317 )

2019-09-26 23:49:43 -03:00

session_test.go

Guest accounts feature (#11428 )

2019-07-22 22:13:39 +02:00

session.go

Guest accounts feature (#11428 )

2019-07-22 22:13:39 +02:00

slack_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

slack.go

Migrate User.GetProfileByIds to sync by default (#11510 )

2019-07-04 11:57:12 +02:00

slackimport_test.go

add support for new slack post format and multiple attachments in slack importer (#11415 )

2019-07-11 10:47:51 +01:00

slackimport.go

Converting to structured logging the file app/slackimport.go (#12137 )

2019-09-16 13:37:14 +02:00

status_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

status.go

[MM-16522] Migrate "Status.UpdateLastActivityAt" to Sync by default (#11444 )

2019-07-03 08:35:39 -04:00

svg_test.go

[MM-13158] Initial attempt at extracting SVG dimensions (#10332 )

2019-02-27 14:06:56 -05:00

svg.go

[MM-13158] Initial attempt at extracting SVG dimensions (#10332 )

2019-02-27 14:06:56 -05:00

syncables_test.go

Changes method name, removes error case. (#11427 )

2019-06-28 07:31:32 -04:00

syncables.go

MM-17496: Skip adding user to default channel (rather than failing) when user has already left the parent team. (#11790 )

2019-08-08 03:39:23 +05:30

team_test.go

Migrate app/team_test.go to use testify (#12215 ) (#12226 )

2019-09-17 14:38:22 +01:00

team.go

[MM-18119] Add methods for getting teams and count when query… (#12020 )

2019-09-10 11:50:27 -05:00

terms_of_service.go

Migrate TermsOfService and UserTermsOfService stores to sync by default (#11282 )

2019-07-02 16:22:20 +02:00

user_agent_test.go

Convert app/user_agent_test.go t.Fatal calls into assert/requi… (#12224 )

2019-09-20 16:53:48 +02:00

user_agent.go

[MM-12536] Migrate to idiomatic error handling the file app/user_agent.go in the mattermost-server (#9575 ) (#9576 )

2018-10-15 20:01:35 +01:00

user_terms_of_service_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

user_terms_of_service.go

Migrate TermsOfService and UserTermsOfService stores to sync by default (#11282 )

2019-07-02 16:22:20 +02:00

user_test.go

Remove premature optimization that was generating a bad users isolation (#12128 )

2019-09-10 11:45:08 +02:00

user_viewmembers_test.go

MM-18512 Use options struct for GetProfilesWithoutTeam and add filtering to API (#12200 )

2019-09-17 20:13:17 +01:00

user.go

MM-18512 Use options struct for GetProfilesWithoutTeam and add filtering to API (#12200 )

2019-09-17 20:13:17 +01:00

web_conn_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

web_conn.go

MM-18266 Converting to structured logging the file app/web_con… (#12141 )

2019-09-11 11:16:33 -04:00

web_hub_test.go

Convert app/web_hub_test.go t.Fatal calls into assert/require… (#12222 )

2019-09-24 16:44:01 +02:00

web_hub.go

MM-18288 Converting to structured logging the file app/web_hub… (#12133 )

2019-09-24 15:35:20 +02:00

webhook_test.go

Convert app/webhooks_test.go t.Fatal calls into assert/require calls (#12039 )

2019-09-06 12:52:51 +02:00

webhook.go

Converting to structured logging the file app/webhook.go (#12142 )

2019-09-13 01:31:59 -04:00

websocket_router.go

MM-18268 Converting to structured logging the file app/websock… (#12143 )

2019-09-12 20:30:41 -04:00