48256721c4
After registering the conn in the hub, we proceeded to send a direct message to the user. We had changed it to send the direct message in the same hub goroutine that handles the registration. This was the correct behavior and fixes chances of having panics due to sending to closed channels. However, often fixing something unearths some deeper underlying bug. This was such a case :) The issue was that register channel had a buffer size of 1. And we were sending a direct message after registration. In the code to send direct message, we were checking if the user has been registered or not, and if not, then skip it. Therefore, since the register channel buffer was 1, it could very well be that the select case would pick up the direct message send case first - in which case it would not have been registered, and therefore no hello message would be sent. The fix is to unbuffer the register and unregister channels. There does not seem to be a valid reason to make these buffered channels. They are meant to be synchronous operations, because the code following them assumes that the user has been registered. While here, we also remove all the time.Sleeps before waiting on the Response channel because they are not required at all. Waiting on a channel is already blocking. Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
Mattermost is an open source, private cloud, Slack-alternative from https://mattermost.com.
It's written in Golang and React and runs as a single Linux binary with MySQL or PostgreSQL. Every month on the 16th a new compiled version is released under an MIT license.
Try out Mattermost
- Join the Mattermost Contributor's server to join community discussions about contributions, development and more
- Join the Mattermost Demo server to try out Mattermost and explore sample use cases
Deploy on Heroku
Note: Heroku preview does not include email or persistent storage
Deploy on a Cloud Platform via Bitnami
Auto-deploy Mattermost to Amazon Web Services, Azure, Google Cloud Platform, or Oracle Cloud Platform via Bitnami.
Install on Your Own Machine
- One-line Docker Preview
- Developer Machine Setup
- Production Install Guides using Linux Binary
- Production Docker Install
Native Mobile and Desktop Apps
In addition to the web interface, you can also download Mattermost clients for Android, iOS, Windows PC, Mac OSX, and Linux.
Get Security Bulletins
Receive notifications of critical security updates. The sophistication of online attackers is perpetually increasing. If you are deploying Mattermost it is highly recommended you subscribe to the Mattermost Security Bulletin mailing list for updates on critical security releases.
Get Involved
- Contribute Code
- Find "Help Wanted" projects
- Join Developer Discussion on a Mattermost Server for contributors
- File Bugs
- Share Feature Ideas
- Get Troubleshooting Help
- Help translate Mattermost
Learn More
- API Options - webhooks, slash commands, drivers and web service
- See who's using Mattermost
- Browse over 700 Mattermost integrations
Get the Latest News
- Twitter - Follow Mattermost
- Blog - Get the latest updates from the Mattermost blog.
- Email - Subscribe to our newsletter (1 or 2 per month)
- Mattermost - Join the ~contributors channel on the Mattermost Community Server.
- IRC - Join the #matterbridge channel on Freenode (thanks to matterircd).
Any other questions, mail us at info@mattermost.com. We’d love to meet you!