* MM-17087 - Disable plugin on removal
* Updated documentation
* Got reid of notifyPluginEvents
* Updated documentation
* Added plugin installation/activatoin flow as a toplevel go doc in plugin_install.go
* Generating webapp bundle on plugin installation
* Fixed shadowing issue
* Updated doc to include unguarded race condition
* Renamed GenerateWebappBundle
* Added a debug log when peers are not ready to notify
* Updated docs
* Removed extra line
* Implement KVCompareAndDelete and KVCompareAndDeleteJSON
* Add tests for KVCompareAndDelete
* Update minimum server version
* Handle nil value on CompareAndSet so that it deletes it
* Fix comments
* Tweaks from PR comments
* Go back to deleted, err
* Send notifications when bot converted to user
* Revert notification sending from CLI.
If user is a bot, set email to CLI email, not the previous email because
previous email <botname>@localhost
* Add comment describing the additional if statement
* Rewording
* remove duplicate word
* Update Comment
* Add tests for bots. In both cases of RequireEmailVerification settings,
the Email should be set to the value passed to the UpdateUser function
and the previous faked localhost email ignored
* MM-17483 Add Pre-packaged plugins to telemetry
Telemetry is triggered whenever Jenkins, Skype for Business, Antivirus or Gitlab is activated
https://mattermost.atlassian.net/browse/MM-17483
* Remove Skype4Business from telemetry
It isn't being pre-packaged this quarter.
* Add update user check for guests and tests
* [MM-17213] Fix domain check when inviting guests
* Fix i18n strings
* Fix tests
* Add missing translation
* Adds test case for non guest user
* revert 4e5f6fcfbc
This reverts the configuration setting to disable plugin health checks, preferring instead to retain this functionality for advanced cases. In part, this was driven by the discovery that the health checks were failing on Windows, though that will be addressed separately.
Fixes: MM-16378
* simplify interval handling/logging
Also shutdown the job when plugins are altogether disabled.
* MM-17071 Extract and add tests for handling of out of channel mentions
* Rename checkForOutOfChannelMentions back to sendOutOfChannelMentions
* Log errors returned by sendOutOfChannelMentions
* Time Layer for measure the Store methods calls time
* Fixing build
* Fixing a formating problem
* Fixing tests
* generating store mocks
* Fixing build
* Updating generated timer layer
* Updating timer layer to the last store interface
* Updating timer layer
* Generating time layer
* MM-16479: panic on io.Copy error in test
I'm unable to reproduce the original report on MM-16479, but in a bid to help track down a potential failure in the future, I've added a panic on err returned from `io.Copy` within the plugin, as this seems like the only path on which the hook could return successfully but fail to show the updated contents.
* assert number of copied bytes
* log n on io.Copy error too
* changes for channel and post import for corp slack
* add fix for missing dms in import
* add suggestions from PR review
* Apply suggestions from code review
Co-Authored-By: George Goldberg <george@gberg.me>
* fix gofmt
* MM-17383: Update query to include users who are not members of any groups.
* MM-17383: Fixes govet complaint.
* MM-17383: Sorts by username.
* MM-17383: Removes accidental staging.
* Filtered incoming webhooks for users wihtout PERMISSION_MANAGE_OTHERS_INCOMING_WEBHOOKS
* Filtered outgoing webhooks for users without PERMISSION_MANAGE_OTHERS_OUTGOING_WEBHOOKS
* Refactored GetOutgoingByTeamByUser to its own method in app and store
* Fixed paging condition for outgoing webhooks in store
* Separated test cases into separate t.run in WebhookStore
* Improved unit test. PR Feedback
* Filtered outgoing webhooks by channel for users without PERMISSION_MANAGE_OTHERS
* Filtered getting full list of outgoing webhooks for users without PERMISSION_MANAGE_OTHERS
* Added missing signature for GetOutgoingWebhooksPage in app
* Expanded permissions in test to SYSTEM_USER_ROLE
* Filtered getting full list of incoming webhooks for users without PERMISSION_MANAGE_OTHERS
* Removed unnecessary sq.and operator
Revert https://mattermost.atlassian.net/browse/MM-14559. The tests were refactored, but all the hooks were be run as:
_, ret := hooks.MessageWillBePosted(nil, nil)
and the plugins were panicking, but then nothing was actually failing because this hook doesn't support returning a "proper" error. Good news is that the old tests are still passing, so nothing has regressed in the toolkit, but thinking we should revisit this holistically instead of trying to fix in place.
* [MM-17194] Add search channels for user in case the user doesn't have the list channels permission
* Add tests for the API layer and control the case of a user not being a team member
* Remove unnecessary empty line
* MM-16997: Simplified TestUploadFiles
Tickets:
https://mattermost.atlassian.net/browse/MM-16997https://mattermost.atlassian.net/browse/MM-16760
- The tests now fully buffer the data vefore uploading it. The prior
code was much more complex because it was intended to eventually
mature into generic client code; not a priority, definitely not
valuable for this test.
- Also improved error handling in TestHookFileWillBeUploaded for
MM-16760
* PR feedback: typo
Track if the default value is used for NetworkInterface, BindAddress and AdvertiseAddress.
Do not track the actual value, as this could expose sensitive data of the system.
The job workers and cluster discovery components require access to the
database during shutdown. To avoid issues, we leave the database open
until the last step of the shutdown process.
