Devin Binnie
929caaff3d
[MM-39374] Remove DesktopLatestVersion and DesktopMinVersion ( #18979 )
2021-11-12 10:37:43 -05:00
Nathaniel Allred
a7d9b83968
Mm 38799 invite to team ( #18987 )
...
* Add in-screen invitation modal invite to team feature flag
2021-11-12 09:20:15 -06:00
Allan Guwatudde
e3240a2ddd
[MM-40022] - Expose telemetry service in the server ( #18976 )
...
* [MM-40022] - Expose telemetry service in the server
* make app-layers
* feedback impl
2021-11-12 10:16:19 +03:00
Agniva De Sarker
a850704afe
Move pluginCommands into Channels ( #18974 )
...
* Move pluginCommands into Channels
We move pluginCommands, pluginCommandsLock
into Channels.
We also move the plugin related route handlers
under Channels and move the init code under
NewChannels. To achieve this, the router initialization
is bumped up.
Along with it, we clean up some App methods
which were just wrappers over Channel methods.
Instead, we call the Channel method directly
to make things more readable and easy to understand.
```release-note
NONE
```
* fix tests
```release-note
NONE
```
2021-11-12 10:35:14 +05:30
Sharath Huddar
27559c1c7b
GH-18288: Allow configuring unsafe-eval and unsafe-inline ( #18801 )
...
* GH-18288: Allow configuring unsafe-eval and unsafe-inline
* Add developer flags to telemetry
* wip
* wip
* Refactor based on review
* Refactor based on review
* fix expected vs. actual in assert.Equal
* Add unit tests, rework to check only supported flags.
* Update model/config.go
Co-authored-by: Jesse Hallam <jesse@thehallams.ca >
* Fix failing tests
* Refactor based on review
* Refactor based on review
* Refactor based on review
Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com >
Co-authored-by: Jesse Hallam <jesse@thehallams.ca >
2021-11-12 05:41:11 +08:00
Penthaa Patel
df3ed307df
[MM-39639] - Migrate from gorp to sqlx in store/sqlstore/user_access_token_store.go ( #18888 )
...
Automatic Merge
2021-11-11 05:40:13 +01:00
Scott Bishel
e3051b0df8
prepackage boards to 0.10.0 ( #18973 )
...
Co-authored-by: Mattermod <mattermod@users.noreply.github.com >
2021-11-10 15:58:36 -07:00
Harrison Healey
7677a93494
MM-40003 Fix patch route for Town Square ( #18971 )
...
Automatic Merge
2021-11-10 23:10:13 +01:00
Michael Kochell
ba1b279c5f
[MM-39820] Add AppBarEnabled feature flag ( #18967 )
...
Automatic Merge
2021-11-10 19:10:14 +01:00
Carlos Tadeu Panato Junior
19de373498
update client function to match the new format and fix bad merge ( #18978 )
2021-11-10 12:38:02 -05:00
Carlos Tadeu Panato Junior
bb5a74a42b
[MM-34076] Add Plugin API User custom status ( #17435 )
...
* add missing client for custom user status
* add custom user status plugin api
* update based on feedback review
* add GetCustomStatus
* update interfaces
2021-11-10 11:11:20 -05:00
Agniva De Sarker
0a3e7f4d55
Ordering clarifications ( #18964 )
...
Automatic Merge
2021-11-09 10:15:15 +01:00
jprusch
ba5f1f3f5c
Translated using Weblate (German)
...
Currently translated at 100.0% (2314 of 2314 strings)
Translation: mattermost-languages-shipped/mattermost-server
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/de/
2021-11-08 11:39:45 -06:00
kaakaa
4be195327c
Translated using Weblate (Japanese)
...
Currently translated at 100.0% (2313 of 2313 strings)
Translation: mattermost-languages-shipped/mattermost-server
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ja/
2021-11-08 11:39:45 -06:00
Tóth Csaba // Online ERP Hungary Kft
3a168226b4
Translated using Weblate (Hungarian)
...
Currently translated at 100.0% (2313 of 2313 strings)
Translation: mattermost-languages-shipped/mattermost-server
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/hu/
2021-11-08 11:39:45 -06:00
Berke Kalkan
e70c5a605a
MM-32396 Create endpoint for listing all the roles ( #16988 )
...
* Create an endpoint for listing roles
* Add function to client model
* Create tests for listing roles endpoint
* Apply code review suggestions
* Restore GetAllRoles app method
* Use AppContext instead of App
* Minor fix
* Refactor according to new changes
Co-authored-by: Mattermod <mattermod@users.noreply.github.com >
2021-11-08 16:38:41 +03:00
Agniva De Sarker
25257d6ef6
Move plugins under Channels ( #18938 )
...
* Move plugins under Channels
We move all plugin related fields under *Channels.
This essentially migrates several methods from being under
*Server to under *Channels.
We also move the plugin startup and shutdown code
to be under Channels.Start and Channels.Shutdown.
While here, we remove the getPluginPublicKeyFiles
method which was a one-line method which uselessly
returned an error.
Lastly, we fix the product initialization order which
was incorrect previously. Products are dependent on
the main server.
So startup should be products -> server.
And shutdown should be server -> products.
```release-note
NONE
```
* Added app layer
```release-note
NONE
```
* Incorporate suggestions
```release-note
NONE
```
2021-11-08 11:57:22 +05:30
Agniva De Sarker
24248dc764
Add JobSettings.CleanupJobsThresholdDays to telemetry ( #18936 )
...
* Add JobSettings.CleanupJobsThresholdDays to telemetry
```release-note
NONE
```
* Moved telemetry to more specific fields
```release-note
NONE
```
* Add missing space
```release-note
NONE
```
2021-11-08 11:45:59 +05:30
Penthaa Patel
c88c9b6625
[MM-39630] - Migrate from gorp to sqlx in store/sqlstore/tokens_store.go ( #18887 )
...
* migrate from gorp to sqlx
Signed-off-by: Penthaa Patel <penthaapatel@gmail.com >
* fixes
Signed-off-by: Penthaa Patel <penthaapatel@gmail.com >
2021-11-05 10:00:03 +05:30
Agniva De Sarker
3c3e1cb9e7
Remove DND run debug log ( #18802 )
...
This was being run every 5 minutes and unnecessarily clogs up
the logs. No other job makes a debug log before starting up.
```release-note
NONE
```
2021-11-05 09:27:19 +05:30
Jesse Hallam
5cca781c62
MM-39314: Pre-package Playbooks 1.21.0 ( #18935 )
2021-11-04 17:42:58 -03:00
Agniva De Sarker
3bc151bbda
Revert "Ordering clarifications ( #18937 )" ( #18948 )
...
Automatic Merge
2021-11-04 19:15:15 +01:00
Maria A Nunez
7e728d0b6f
MM-39804 - Remove license expiration checks for cloud ( #18921 )
2021-11-04 12:26:28 -04:00
Agniva De Sarker
f921e69fe8
Ordering clarifications ( #18937 )
...
* Ordering clarifications
Clearly outline the dependency graph
during server bootup.
```release-note
NONE
```
* More clarifications
```release-note
NONE
```
* lint fix
```release-note
NONE
```
2021-11-04 19:22:23 +05:30
Martin Kraft
412e52894c
MM-39420: Checks for presence of slice before index access. ( #18826 )
...
* MM-39420: Checks for presence of slice before index access.
* MM-39420: Sanitize all embeds with single method.
* MM-39420: Already checking len in method.
2021-11-04 09:41:19 -04:00
Allan Guwatudde
7287da6391
[MM-39503] - Remove DownloadApps Feature Flag ( #18902 )
2021-11-04 16:28:46 +03:00
Agniva De Sarker
83b3090eb9
Fix PluginHealthCheckJob ( #18927 )
...
* Fix PluginHealthCheckJob
We were incorrectly calling to start PluginHealthCheckJob
without initializing the plugins environment.
To fix this, we move the code inside initPlugins right after
the environment is initialized.
To respond to config changes, we call it again from pluginsEnvironment.Shutdown
which gets called from ConfigListener when plugins are disabled. And initPlugins
is anyways called again from ConfigListener which plugins are enabled,
so we can avoid checking for PluginSettings.Enable again in the call.
We also rename the method to better indicate its nature.
During this, we also uncover and fix another bug where disabling
plugins would not shut down plugins at all because we were calling
s.GetPluginsEnvironment() directly which returns nil if plugins
were disabled. The approach we follow is to manually acquire the lock
whenever we need access to the struct ignoring config setting.
We fix that as well.
https://community-daily.mattermost.com/boards/workspace/zyoahc9uapdn3xdptac6jb69ic/285b80a3-257d-41f6-8cf4-ed80ca9d92e5/495cdb4d-c13a-4992-8eb9-80cfee2819a4?c=6ef6178c-3512-4e57-8edd-1d2b66a09c9e
```release-note
NONE
```
* Fix test
```release-note
NONE
```
2021-11-04 08:54:03 +05:30
Agniva De Sarker
5ad7fb5b6f
Remove job server dependency searchengine ( #18908 )
...
* Remove job server dependency searchengine
The job server field was not being used. We remove it
as part of a cleanup of server initialization refactor.
https://community-daily.mattermost.com/boards/workspace/zyoahc9uapdn3xdptac6jb69ic/285b80a3-257d-41f6-8cf4-ed80ca9d92e5/495cdb4d-c13a-4992-8eb9-80cfee2819a4?c=8a171d5e-4398-4bc9-8fbf-8b9b14f37069
```release-note
NONE
```
* Fix missing field
```release-note
NONE
```
2021-11-03 18:44:57 +01:00
Carlos Tadeu Panato Junior
69eb0ca773
db: upgrade db to 6.0 and prepare for 6.1 ( #18923 )
...
* db: upgrade db to 6.1
* db: prepare db upgrade to 6.2
Co-authored-by: Mattermod <mattermod@users.noreply.github.com >
2021-11-03 16:16:33 +01:00
Carlos Tadeu Panato Junior
2865ad9221
Revert "DOPS-602: Change how mmctl gets packaged and locally fetched. ( #18335 )" ( #18930 )
...
This reverts commit 5ede63badc .
2021-11-03 14:54:34 +01:00
Agniva De Sarker
7a0131ee14
Use the correct error variable from provider.GetSSOSettings ( #18920 )
...
```release-note
NONE
```
2021-11-03 19:12:30 +05:30
Claudio Costa
13c0ba6e8a
Strip arguments from logged command ( #18862 )
2021-11-03 08:30:33 +01:00
Elisabeth Kulzer
5ede63badc
DOPS-602: Change how mmctl gets packaged and locally fetched. ( #18335 )
...
* DOPS-602: Change how mmctl gets packaged and locally fetched.
2021-11-02 14:45:02 +01:00
Kaya Zeren
fc1e11c3d7
Translated using Weblate (Turkish)
...
Currently translated at 100.0% (2313 of 2313 strings)
Translation: mattermost-languages-shipped/mattermost-server
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/tr/
2021-11-01 11:51:31 -06:00
aeomin
6a34179eeb
Translated using Weblate (Chinese (Simplified))
...
Currently translated at 100.0% (2313 of 2313 strings)
Translation: mattermost-languages-shipped/mattermost-server
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/zh_Hans/
2021-11-01 11:51:31 -06:00
Elias Nahum
b5135bb760
Translated using Weblate (Spanish)
...
Currently translated at 100.0% (2313 of 2313 strings)
Translation: mattermost-languages-shipped/mattermost-server
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/es/
2021-11-01 11:51:31 -06:00
MArtin Johnson
8e6c0fe6b8
Translated using Weblate (Swedish)
...
Currently translated at 100.0% (2313 of 2313 strings)
Translation: mattermost-languages-shipped/mattermost-server
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/sv/
2021-11-01 11:51:31 -06:00
Tóth Csaba // Online ERP Hungary Kft
ff409b4e70
Translated using Weblate (Hungarian)
...
Currently translated at 100.0% (2313 of 2313 strings)
Translation: mattermost-languages-shipped/mattermost-server
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/hu/
2021-11-01 11:51:31 -06:00
Matthew Williams
6e94368baa
Translated using Weblate (English (Australia))
...
Currently translated at 100.0% (2313 of 2313 strings)
Translation: mattermost-languages-shipped/mattermost-server
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/en_AU/
2021-11-01 11:51:31 -06:00
master7
bc5a7e4558
Translated using Weblate (Polish)
...
Currently translated at 100.0% (2313 of 2313 strings)
Translation: mattermost-languages-shipped/mattermost-server
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/pl/
2021-11-01 11:51:31 -06:00
Tom De Moor
e3f3474465
Translated using Weblate (Dutch)
...
Currently translated at 100.0% (2313 of 2313 strings)
Translation: mattermost-languages-shipped/mattermost-server
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/nl/
2021-11-01 11:51:31 -06:00
jprusch
a57117f707
Translated using Weblate (German)
...
Currently translated at 100.0% (2313 of 2313 strings)
Translation: mattermost-languages-shipped/mattermost-server
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/de/
2021-11-01 11:51:31 -06:00
JtheBAB
c76ca59bd7
Translated using Weblate (German)
...
Currently translated at 100.0% (2313 of 2313 strings)
Translation: mattermost-languages-shipped/mattermost-server
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/de/
2021-11-01 11:51:31 -06:00
kaakaa
2747f8f5ce
Translated using Weblate (Japanese)
...
Currently translated at 100.0% (2311 of 2311 strings)
Translation: mattermost-languages-shipped/mattermost-server
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ja/
2021-11-01 11:51:31 -06:00
Ben Cooke
3181a3765d
adding check for name change and new tests ( #18531 )
...
Co-authored-by: Benjamin Cooke <benjamincooke@Benjamins-MacBook-Pro.local >
Co-authored-by: Mattermod <mattermod@users.noreply.github.com >
2021-10-29 13:46:50 -04:00
Md_ZubairAhmed
bf589c2995
MM-36893 : Specially crafted message request crashes the webapp for users who view the message ( #18835 )
...
* strip away delete
* added tests
2021-10-29 10:46:00 -04:00
James Addison
8c4e6a85b3
Add .gitlab-ci.yml-compatible continuous integration configuration ( #17844 )
...
* Add .gitlab-ci.collabora.yml continuous integration configuration
* Relocate custom GitLab CI/CD configuration file to 'contrib' directory
* Fixup: .gitlab-ci.collabora.yml -> .gitlab-ci.yml
Co-authored-by: Mattermod <mattermod@users.noreply.github.com >
2021-10-29 13:16:45 +02:00
Agniva De Sarker
5f4199db4f
Revert "Optimize TotalUnreadMentions ( #18789 )" ( #18889 )
...
This reverts commit ec56cac42d .
2021-10-29 14:54:11 +05:30
Agniva De Sarker
ec56cac42d
Optimize TotalUnreadMentions ( #18789 )
...
* Optimize TotalUnreadMentions
We avoid joining with the Threads table entirely
as ChannelId is available from Posts table directly.
Also we replace left joins by inner joins.
https://community-daily.mattermost.com/boards/workspace/zyoahc9uapdn3xdptac6jb69ic/285b80a3-257d-41f6-8cf4-ed80ca9d92e5/495cdb4d-c13a-4992-8eb9-80cfee2819a4?c=c9aa17f3-b918-4a78-86aa-01562e418634
Old plan
```
Finalize Aggregate (cost=30869.29..30869.30 rows=1 width=32) (actual time=27.216..31.674 rows=1 loops=1)
-> Gather (cost=30869.18..30869.29 rows=1 width=32) (actual time=27.089..31.665 rows=2 loops=1)
Workers Planned: 1
Workers Launched: 1
-> Partial Aggregate (cost=29869.18..29869.19 rows=1 width=32) (actual time=18.442..18.445 rows=1 loops=2)
-> Nested Loop (cost=1881.68..29869.11 rows=25 width=8) (actual time=2.052..18.417 rows=72 loops=2)
-> Hash Join (cost=1881.12..29771.45 rows=25 width=62) (actual time=2.028..17.744 rows=72 loops=2)
Hash Cond: ((threads.channelid)::text = (channels.id)::text)
-> Nested Loop (cost=0.84..27883.40 rows=2963 width=89) (actual time=0.220..15.849 rows=163 loops=2)
-> Parallel Index Scan using threadmemberships_pkey on threadmemberships (cost=0.41..7423.65 rows=2963 width=35) (actual time=0.031..3.937 rows=2504 loops=2)
Index Cond: ((userid)::text = 'tc3p1yqw67d8idcp3g98awexqe'::text)
Filter: following
-> Index Scan using threads_pkey on threads (cost=0.42..6.91 rows=1 width=54) (actual time=0.004..0.004 rows=0 loops=5007)
Index Cond: ((postid)::text = (threadmemberships.postid)::text)
-> Hash (cost=1866.60..1866.60 rows=1094 width=27) (actual time=1.763..1.764 rows=1002 loops=2)
Buckets: 2048 Batches: 1 Memory Usage: 74kB
-> Index Scan using idx_channels_team_id_type on channels (cost=0.42..1866.60 rows=1094 width=27) (actual time=0.022..1.493 rows=1002 loops=2)
Index Cond: ((teamid)::text = '8ywxyw9ocp8smxrmjzrkqhrdwe'::text)
-> Index Scan using posts_pkey on posts (cost=0.56..3.91 rows=1 width=27) (actual time=0.009..0.009 rows=1 loops=145)
Index Cond: ((id)::text = (threads.postid)::text)
Filter: (deleteat = 0)
Planning Time: 2.415 ms
Execution Time: 31.798 ms
```
New plan
```
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Finalize Aggregate (cost=34717.01..34717.02 rows=1 width=32) (actual time=42.375..48.143 rows=1 loops=1)
-> Gather (cost=34716.89..34717.00 rows=1 width=32) (actual time=42.249..48.117 rows=2 loops=1)
Workers Planned: 1
Workers Launched: 1
-> Partial Aggregate (cost=33716.89..33716.90 rows=1 width=32) (actual time=30.960..30.962 rows=1 loops=2)
-> Hash Join (cost=1881.25..33716.83 rows=25 width=8) (actual time=2.438..30.780 rows=1058 loops=2)
Hash Cond: ((posts.channelid)::text = (channels.id)::text)
-> Nested Loop (cost=0.98..31828.77 rows=2963 width=35) (actual time=0.091..27.374 rows=2504 loops=2)
-> Parallel Index Scan using threadmemberships_pkey on threadmemberships (cost=0.41..6815.65 rows=2963 width=35) (actual time=0.034..4.674 rows=2504 loops=2)
Index Cond: ((userid)::text = 'tc3p1yqw67d8idcp3g98awexqe'::text)
Filter: following
-> Index Scan using posts_pkey on posts (cost=0.56..8.44 rows=1 width=54) (actual time=0.008..0.008 rows=1 loops=5007)
Index Cond: ((id)::text = (threadmemberships.postid)::text)
Filter: (deleteat = 0)
-> Hash (cost=1866.60..1866.60 rows=1094 width=27) (actual time=2.289..2.289 rows=1002 loops=2)
Buckets: 2048 Batches: 1 Memory Usage: 74kB
-> Index Scan using idx_channels_team_id_type on channels (cost=0.42..1866.60 rows=1094 width=27) (actual time=0.028..1.927 rows=1002 loops=2)
Index Cond: ((teamid)::text = '8ywxyw9ocp8smxrmjzrkqhrdwe'::text)
```
```release-note
NONE
```
* Bring back coalesce
```release-note
NONE
```
2021-10-29 09:07:10 +05:30
Saul Pinales
b877e2a95e
Migrate from gorp to sqlx in store/sqlstore/group_store.go ( #18543 )
...
Automatic Merge
2021-10-28 20:25:26 +02:00