899 Коммитов

Автор SHA1 Сообщение Дата
Alenoda
891b2144df Fix errcheck issues in server/channels/app/login_test (#29119)
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
2024-11-13 20:08:23 +01:00
Arya Khochare
a19ec14967 Fixed errcheck issues in server/channels/app/product_notices_test.go (#29194) 2024-11-13 20:04:22 +01:00
Ben Schumacher
053d0b5f0a [MM-61140] Allow plugins to add Support Packet data without UI elements (#28833)
Co-authored-by: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com>
2024-11-13 11:20:39 +01:00
Harshil Sharma
c79a8a8b4a MM-61484 - Deleting scheduled posts when permanently deleting a user (#29152)
* Deleting scheduled posts when permanently deleting a user

* Updated tests

* CI

* Testing CI

* Restored a test change

* Skipping flaky test
2024-11-13 12:41:31 +05:30
Ivy Gesare
4a92e9f9bf [MM-61516] Fix errcheck issues in server/channels/app/plugin_api_test.go (#29220) 2024-11-12 15:56:35 -05:00
Rohan Sharma
73f1383f5f [MM-61465] Fix errcheck issues in server/channels/app/post_metadata_test.go (#29206) 2024-11-12 15:54:51 -05:00
Pablo Vélez
4e0fc5734c MM - 60506 - notify user failed scheduled msgs (#29208)
* MM-60506 - notify user for failed scheduled messages

* add unit tests for handleFailedScheduledMessages and send system-bot message

* fix vet issues

* adjust test for vet report

* make sure to send the message to every user there was a failed message

---------

Co-authored-by: Harshil Sharma <harshil.sharma@mattermost.com>
2024-11-12 11:33:29 +01:00
Harshil Sharma
7c3d71c089 Scheudled post test enhancement (#29187)
* Added test for user beloonging to channel but not team

* Added test for read onmly channel

* Added test for fetching scheduled posts for team you don;'t belong to

* Added more tests

* test enhancements

* CI
2024-11-12 12:29:29 +05:30
Harshil Sharma
56260e93d4 Added debug settings for testing and e2e tests (#29175) 2024-11-12 11:26:14 +05:30
Agniva De Sarker
847f42fd4c MM-61700: Fix race conditions from web_hub initialization (#29214)
The Store variable was written to _after_ the server
started which was causing the race.

We simply move it to before we start the server.

While we are here, we fix yet another race condition
which was unrelated, but doing it in one sweep. This
was related to the user props access. When a user is updated,
there was 3 ws events that get sent out, 2 were deep-copied
whereas 1 was not. This led to race condition in postgres
binary-param mode where we were trying to set the user props.



https://mattermost.atlassian.net/browse/MM-61700
2024-11-12 08:46:18 +05:30
Arya Khochare
2461d0fed6 errcheck issues fixed (#29196) 2024-11-11 16:55:10 +01:00
Arya Khochare
ead2a7c018 Fixed errcheck issues in server/channels/app/imaging/decode.go (#28937) 2024-11-08 15:39:03 +01:00
Daniel Espino García
118d0346ee Add test notification tool (#28334)
* Add test notification tool

* Add frontend styles

* Remove option from admin view

* Refactor create post and add translations

* Fix several CI errors

* Fix API and frontend snapshots

* Refactor trailing and leading icon on buttons

* Add different button states

* i18n-extract

* Fix wrong text

* Add tests

* Fix wrong string

* Fix test

* feat: E2E send test notifications (#28371)

* Refactor send desktop notification

* Address rest of the feedback

* Fix tests

* Add correct link

* Fix test

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
Co-authored-by: yasserfaraazkhan <attitude3cena.yf@gmail.com>
2024-11-08 13:57:06 +01:00
Pablo Vélez
2593860063 MM-61068 - send ws event on scheduled message job send (#29153)
Co-authored-by: Mattermost Build <build@mattermost.com>
2024-11-08 10:48:23 +01:00
Niharika Goulikar
f377399c4c Fixed errcheck isssues in Auto_responder_test.go (#28987)
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
2024-11-08 08:54:03 +01:00
Agniva De Sarker
bd8774bdce MM-61130: Use a channelMember map at web_hub level (#28810)
Tests at very high scale indicates that the iteration
of all connections during websocket broadcast starts
to become a bottleneck.

To optimize this, we move the channelMember cache from
inside web_conn.go to the hubConnectionIndex.

This involves adding a new map keyed by the channelID
and containing all webConns where the user is a member
of that channel. Subsequently, a new method needed to
be added to invalidate the cache which previously
used to happen in web_conn.

And as a last step, we remove the cache from web_conn
to reduce SQL queries to the DB.

https://mattermost.atlassian.net/browse/MM-61130

```release-note
NONE
```
2024-11-08 09:57:54 +05:30
Nicolas Le Cam
c90e562528 Migrate mockery to packages feature (#29013) 2024-11-07 12:48:11 +01:00
Nicolas Le Cam
5ebdea506f MM-39918: mmctl: list archived private channels in channel list command with system admin user (#28676) 2024-11-07 12:07:30 +01:00
Ivy Gesare
7846ac86b4 [MM-61506] Fix errcheck issues in server/channels/app/teams/helper_test.go (#29144) 2024-11-07 10:11:55 +01:00
molejnik88
e40d7b442a [MM-61458] Fix errcheck issues in server/channels/app/plugin_requests.go (#29121) 2024-11-07 09:09:11 +01:00
Arya Khochare
efa93a3dd3 Fixed errcheck issues in server/channels/app/onboarding_test.go (#29066) 2024-11-06 11:50:21 +01:00
Harshil Sharma
f812104a92 MM-60331 - Scheduled post telemetry (#29132)
* Added scheduled posts telemetry

* Tracking scheudled post creation via webapp to filter by platform

* Fixed keys

* Lint fix
2024-11-06 10:39:52 +00:00
Arya Khochare
4d4af7dc39 errcheck issues fixed (#29061)
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
2024-11-06 00:55:33 +01:00
Alenoda
74b33c73fb Fix errcheck issues in server/channels/app/plugin_deadlock_test.go (#29113)
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
2024-11-05 19:17:56 +01:00
Rohan Sharma
6b5732a6af [MM-61100] Fix errcheck issues in server/channels/app/busy_test.go (#28786) 2024-11-05 19:17:22 +01:00
Guillermo Vayá
751d84bf13 [MM-59363] Shared channel event telemetry (#29024)
* shared channel event tracking

* Update notification.go

Co-authored-by: Miguel de la Cruz <miguel@mcrx.me>

---------

Co-authored-by: Miguel de la Cruz <miguel@mcrx.me>
2024-11-05 16:26:18 +01:00
Arya Khochare
373e21c5a1 Fixed errcheck issues in server/channels/app/plugin_hooks_test.go (#29059) 2024-11-05 15:36:19 +01:00
Pablo Vélez
fbee99e870 MM-60124-emit and read create scheduled post WS event (#28844)
* MM-60124-emit and read create scheduled post WS event

* fix unit test; reorder get team id logic; use userid for ws events

* MM-60145 - ws events on update scheduled posts (#28871)

* MM-60145 - ws events on update scheduled posts

* MM-60147 - ws events on delete scheduled posts (#28872)

* MM-60147 - ws events on delete scheduled posts

* remove unnecessary channelID

* remove unnecesary memoization
2024-11-05 14:24:50 +01:00
Ivy Gesare
cb8f152089 [MM-61094] Fix errcheck issues in server/channels/app/app_test.go (#29124) 2024-11-05 12:13:41 +01:00
Alenoda
4b9eb73bd2 Fix errcheck issues in server/channels/app/plugin_reattach (#29115)
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
2024-11-05 09:59:24 +01:00
Ivy Gesare
795b2ad068 [MM-61488] Fix errcheck issues in server/channels/app/role_test.go (#29125) 2024-11-05 09:58:54 +01:00
Arya Khochare
9ecf9f8ade Fixed errcheck issues in server/channels/app/notification_test.go (#29068) 2024-11-05 08:59:48 +01:00
Arya Khochare
6fd464a398 errcheck issues fixed (#29045) 2024-11-04 17:38:09 +01:00
Ben Schumacher
63bf746d60 [MM-61523] Skip flaky TestGetUserTeamScheduledPosts/should_get_created_scheduled_posts (#29104) 2024-11-04 14:45:22 +01:00
Arya Khochare
ef1be57f64 errcheck issues fixed (#29063)
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
2024-11-04 14:33:47 +01:00
Arya Khochare
e3f6b16927 errcheck issues fixed (#29065) 2024-11-04 07:49:02 -05:00
Kyrillos Isaac
3780887629 [MM-61106] fix server/channels/app/desktop_login.go errcheck issues (#28818)
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
2024-11-04 13:27:07 +01:00
Dishika Vaishkiyar
19865329ca Fix: authorization-test errcheck issue (#28788)
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
2024-11-04 13:04:06 +01:00
Ivy Gesare
89ea59f590 [MM-61259] Fix errcheck issues in server/channels/app/import_utils_test.go (#28955) 2024-11-04 12:33:53 +01:00
Harshit Vashisht
59c42c06ef Fixes errcheck in email_test.go (#28910)
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
2024-11-04 12:16:35 +01:00
Arya Khochare
a21e8f9b13 Fixed errcheck issues in server/channels/app/ldap.go (#29038) 2024-11-04 12:05:43 +01:00
Arya Khochare
93b0fece12 Fixed errcheck issues in server/channels/app/oauth_test.go (#29043) 2024-11-04 11:13:16 +01:00
Samarth Mishra
e86560d04c Fix errcheck issues in server/channels/app/imaging/decode_test.go (#28958)
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
2024-11-04 10:55:48 +01:00
TheInvincible
fdd5bb9c02 Update file_helper_test.go (fix errcheck issue) (#28983) 2024-11-04 09:31:30 +01:00
Rohan Sharma
f2182d806b [MM-61097] Fix errcheck issues in server/channels/app/bot.go (#28785)
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
2024-11-04 08:56:59 +01:00
Harshil Sharma
e281b3f37e Feature scheduled messages (#28932)
* Create scheduled post api (#27920)

* Added migration files for Postgres

* Added migrations for MySQL

* Added store method

* Added API and store tests

* Renamed migration after syncing with master

* Added app layer tests

* API is ready

* API is ready

* API is ready

* Renamed migration after syncing with master

* Updated migration list

* Fixed retry layer tests

* Allowed posts with empty messages

* Review fixes

* Reverted an incorrect change

* Renamed migration and fixed ID assignment

* CI

* Send post button changes (#28019)

* added Split button

* WIP

* Added core menu options

* WIP

* WIP

* WIP

* Handled displaying error in creating scheduled post

* lint fixes

* webapp i18n fix

* Review fixes

* Fixed a webapp test

* A few more fixes

* Removed a duplicate comment

* Scheduled post job (#28088)

* Added the job function

* Added query for fetching scheduled posts for pricessing

* WIP

* WIP

* WIP

* WIP

* WIP

* WIP

* Reafactoring of scheduled post job

* Lint fixes

* Updated i18n files

* FInishing touches

* Added tests for GetScheduledPosts

* Added tests for PermanentlyDeleteScheduledPosts

* Updated all layer

* Some changes as discussed with team

* Added tests for UpdatedScheduledPost

* Code review refactoring

* Added job test

* MM-60120 - Custom time selection (#28120)

* Added a common date time picker modal and used it for post reminder

* Added a common date time picker modal and used it for post reminderggp

* Added modal for custom schedule time and fixed TZ issue

* WIP

* Removed event from useSubmit hook

* Removed event from useSubmit hook

* Added timezone handling

* fixed type error

* Updated i18n strings

* Minor cleanup

* updated snapshots

* review fixes

* Handled event

* Supported for having a DM thread open in RHS while in a regular channel

* Review fixes

* MM-60136 - Scheduled messages tab (#28133)

* WIP

* WIP

* Created Tabs and Tab wrapper with added styling

* Added API to get scheduled posts

* WIP

* Displated scheduled post count

* i18n fix

* Added tests

* Handled asetting active tab absed on URL:

* Reverted unintended change

* Added API to client ad OpenAPI specs

* Renamed file

* Adding fileinfo to schedule posts

* Partial review fixes

* Made get scheduled post API return posts by teamID

* review fixes

* Moved scheduled post redux code to MM-redux package

* Usedd selector factory

* WIP:

* WIP:

* Lint fix

* Fixed an incorrect openapi spec file

* Removed redundent permission check

* Clreaed scheduled post data on logout

* Removed unused i18n string:

* lint fix

* Render scheduled posts (#28208)

* WIP

* WIP

* Created Tabs and Tab wrapper with added styling

* Added API to get scheduled posts

* WIP

* Displated scheduled post count

* i18n fix

* Added tests

* Handled asetting active tab absed on URL:

* Reverted unintended change

* Added API to client ad OpenAPI specs

* Renamed file

* Created common component for draft list item

* WIP

* WIP

* Adding fileinfo to schedule posts

* Basic rendering

* Added count badge to tabs

* WIP

* Made the Drafts LHS iteam appear if no drafts exist but scheduled posts do

* Fixed icon size

* Partial review fixes

* Made get scheduled post API return posts by teamID

* Handled initial vs team switch load

* Displayed scheduled date in panel header

* Added error message and error indiocator

* WIP

* review fixes

* WIP Adding error reason tag

* Added error codes

* Moved scheduled post redux code to MM-redux package

* Usedd selector factory

* WIP:

* WIP:

* Lint fix

* Fixed an incorrect openapi spec file

* Removed redundent permission check

* Clreaed scheduled post data on logout

* Removed unused i18n string:

* lint fix

* Opened rescheduling modal

* Updated graphic for empty state of schduled post list

* Added delete scheduled post option and modal

* Badge and timezone fix

* WIP:

* Added send now confirmation modal

* lint

* Webapp i18n fix

* Fixed webapp test

* Fixed a bug where DM/GM scheduled posts weren't immideatly showing up in UI

* Minor fixes

* WIP

* Review fixes

* Review fixes

* Optimisations

* Fixed reducer name

* Moment optimizatin

* Updated route check

* MM-60144 - added API to update a scheduled post (#28248)

* WIP

* Added api and ap layer for update scheduled post ̛̦̄

* Added API to OpenAI specs, Go client and TS client

* removed permissio check

* Added tests

* Fixed tests

* Added PreUpdate method on scheduled post model

* MM-60131 - Reschedule post integration (#28281)

* Handled rescheduling post in webapp

* Added error handling

* MM-60146 - Delete scheduled post api (#28265)

* WIP

* Added api and ap layer for update scheduled post ̛̦̄

* Added API to OpenAI specs, Go client and TS client

* removed permissio check

* Added tests

* Fixed tests

* Added PreUpdate method on scheduled post model

* Added delete scheduled post API

* Added API to Go client and OpenAPI specs

* Added API to TS client

* Added tests

* CI

* Rmeoved two incorrect code comments

* MM-60653 - Integrated delete scheduled post API (#28296)

* Integrated delete scheduled apost API

* Lint fix

* Review fixes

* Excluded draft checks from scheduled posts (#28370)

* Excluded draft checks from scheduled posts

* Added a removed todo

* MM-60125 - Scheduled post channel indicator (#28320)

* Integrated delete scheduled apost API

* Lint fix

* Added state for storing scheduled posts by channel ID

* Refactored redux store to store scheudled posts by ID, thens tore IDs everywhere

* Refactored redux store to store scheudled posts by ID, thens tore IDs everywhere

* WIP

* Added scheduled post indiocator

* Handled single and multiple scheudled posts

* Review fixes

* Fixed styling and handled center channel, RHS and threads view

* Lint fix

* i18n fix

* Fixed a cycling dependency

* Lint fix

* Added some more comments

* Updated styling

* Review fixes

* Added common component for remote user time and scheduled post indicator

* Updated scheduled post count

* Minor change

* Moved CSS code around

* Fixed a bug where files in scheduled post didn't show up until refresh (#28359)

---------

Co-authored-by: Daniel Espino García <larkox@gmail.com>

* Scheduled post config (#28485)

* Added config

* Added config on server and webapp side

* Added config check in server and webapp

* Added license check

* Added license check

* Added placeholder help text

* Added license check to job

* Fixed job test

* Review fixes

* Updated English text

* Review fixes

* MM-60118 - Added index on ScheduledPosts table (#28579)

* Added index

* Updated indexes

* Scheduled posts misc fixes (#28625)

* Added detailed logging for scheduled post job

* Limited scheduled posts processing to 24 hours

* Marked old scheduled posts as unable to send

* Added t5ests

* converted some logs to trace level

* Fixed a bug causing error message to show up on deleting a scheduled post in a deleted thread (#28630)

* Fixed scheduled posts link in RHS (#28659)

* Fixed scheduled posts link in RHS

* Review fixes

* Fix permission name in scheduled posts by team (#28580)

* Fix permission name

* fix wording

---------

Co-authored-by: Mattermost Build <build@mattermost.com>

* FIxed width of generic modal header to fix browser channel modal (#28639)

* Only consider error-free scheduled posts for indicator in channel and RHS (#28683)

* Show only errro free scheudled posts in post box indicator

* Fixed a bug to handle no scheduled posts

* Fixed draft and scheudled post UI in mobile view (#28680)

* MM-60873 and MM-60872 - Fixed a bug with updating scheduled posts (#28656)

* Fixed a bug with updating scheduled posts

* Better selectors

* MOved shceuled post message length validation to app layer

* MM-60732 - Scheduled posts channel link now takes you to the first scheduled post in channel/thread in list (#28768)

* Ordered scheudle dposts by schgeudled at nad create at

* Ordered in client

* Added scroll to target

* Removed classname prop

* Fixed tests

* Added doc

* Import fix

* MM-60961 - Fixed a bug where API used incoming create at date for scheduled post (#28703)

* Fixed a bug where API used incoming create at date for scheduled post

* Stopped sending created at value for scheduled post

* MM-60785 - Fixed a bug where scheduled posts of channel we are no longer member of didn't show up (#28637)

* Fixed a bug where scheduled posts of channel we are no longer member of didn't show up

* Added a comment

* CI

* Used data loader to optimise laoding missing channels

* Minor refactoring

* MM-60963 - Added common checks for post and scheduled posts (#28713)

* Added commen checks for post and scheuled posts

* Sanitised scheduled posts

* Fixed tests

* Splitted post checks into app and context functions

* Added checks on scheduiled posts job as well:

* i18n fix

* Fixed a test

* Renamed a func

* removed duplicate check

* Scheduled posts UI fixes (#28828)

* Fixed send button and time picker borders

* Fixed center alignment of time picker

* Removed on for today and tomorrow

* Lint fix

* Date time modal hover state fix

* Badge fix

* Fixed a mnerge issue

* Scheduled Post send now and add schedule on draft (#28851)

* Added send now option on scheduled posts

* Minor refactoring

* WIP

* WIP

* WIP

* Lint fix

* i18n fix

* Snapshot update

* Review fixes

* Scheduled post inline editing (#28893)

* Added send now option on scheduled posts

* Minor refactoring

* WIP

* WIP

* WIP

* Lint fix

* i18n fix

* Snapshot update

* Displayed editing component in scheduled post

* Added handling for updating scheduled post

* Handle events

* Fixed escape key issue in scheudled post editing

* Fixes

* Displayed error message for editing error

* Don't show mention warning

* Handled dev mode (#28918)

* MInor fixes

* client fix

* Fixes

* CI

* Removed dev mode behaviour temperorily (#29008)

---------

Co-authored-by: Daniel Espino García <larkox@gmail.com>
Co-authored-by: Eva Sarafianou <eva.sarafianou@gmail.com>
Co-authored-by: Mattermost Build <build@mattermost.com>
2024-11-04 11:39:35 +05:30
Ibrahim Serdar Acikgoz
f41d2d7774 [MM-58745] export/import: enable exporting and importing bots canonically (#28214) 2024-11-01 19:44:30 +01:00
Ben Schumacher
2d2c039a27 [MM-61071] Fix errcheck issues in channels/app/admin.go (#28756) 2024-10-31 14:59:32 +01:00
Harshit Vashisht
fd70b0a0cd Fixes errcheck in helper_test.go (#28909) 2024-10-29 16:16:58 +01:00
Ben Schumacher
2424358b7d [MM-61302] Use model.NewPointer throughout the code base (#28957) 2024-10-29 13:29:53 +01:00