Fixed errcheck issues in server/channels/app/onboarding_test.go (#29066)

server/.golangci.yml

@@ -107,7 +107,6 @@ issues:
         channels/app/job_test.go|\
         channels/app/login_test.go|\
         channels/app/migrations.go|\
-        channels/app/onboarding_test.go|\
         channels/app/permissions.go|\
         channels/app/permissions_test.go|\
         channels/app/platform/busy_test.go|\

server/channels/app/onboarding_test.go

@@ -15,12 +15,13 @@ func TestOnboardingSavesOrganizationName(t *testing.T) {
 	th := Setup(t)
 	defer th.TearDown()
 
-	err := th.App.CompleteOnboarding(th.Context, &mm_model.CompleteOnboardingRequest{
+	appErr := th.App.CompleteOnboarding(th.Context, &mm_model.CompleteOnboardingRequest{
 		Organization: "Mattermost In Tests",
 	})
-	require.Nil(t, err)
+	require.Nil(t, appErr)
 	defer func() {
-		th.App.Srv().Store().System().PermanentDeleteByName(mm_model.SystemOrganizationName)
+		_, err := th.App.Srv().Store().System().PermanentDeleteByName(mm_model.SystemOrganizationName)
+		require.NoError(t, err)
 	}()
 
 	sys, storeErr := th.App.Srv().Store().System().GetByName(mm_model.SystemOrganizationName)