Cleanup dead code (#12929)

* Cleanup dead code

* Remove unneeded translation string

api4/file.go

@@ -65,92 +65,6 @@ func (api *API) InitFile() {
 
 }
 
-func uploadFile(c *Context, w http.ResponseWriter, r *http.Request) {
-	defer io.Copy(ioutil.Discard, r.Body)
-
-	if !*c.App.Config().FileSettings.EnableFileAttachments {
-		c.Err = model.NewAppError("uploadFile", "api.file.attachments.disabled.app_error", nil, "", http.StatusNotImplemented)
-		return
-	}
-
-	if r.ContentLength > *c.App.Config().FileSettings.MaxFileSize {
-		c.Err = model.NewAppError("uploadFile", "api.file.upload_file.too_large.app_error", nil, "", http.StatusRequestEntityTooLarge)
-		return
-	}
-
-	now := time.Now()
-	var resStruct *model.FileUploadResponse
-	var appErr *model.AppError
-
-	if err := r.ParseMultipartForm(*c.App.Config().FileSettings.MaxFileSize); err != nil && err != http.ErrNotMultipart {
-		http.Error(w, err.Error(), http.StatusInternalServerError)
-		return
-	} else if err == http.ErrNotMultipart {
-		defer r.Body.Close()
-
-		c.RequireChannelId()
-		c.RequireFilename()
-
-		if c.Err != nil {
-			return
-		}
-
-		channelId := c.Params.ChannelId
-		filename := c.Params.Filename
-
-		if !c.App.SessionHasPermissionToChannel(c.App.Session, channelId, model.PERMISSION_UPLOAD_FILE) {
-			c.SetPermissionError(model.PERMISSION_UPLOAD_FILE)
-			return
-		}
-
-		resStruct, appErr = c.App.UploadFiles(
-			FILE_TEAM_ID,
-			channelId,
-			c.App.Session.UserId,
-			[]io.ReadCloser{r.Body},
-			[]string{filename},
-			[]string{},
-			now,
-		)
-	} else {
-		m := r.MultipartForm
-
-		props := m.Value
-		if len(props["channel_id"]) == 0 {
-			c.SetInvalidParam("channel_id")
-			return
-		}
-		channelId := props["channel_id"][0]
-		c.Params.ChannelId = channelId
-		c.RequireChannelId()
-		if c.Err != nil {
-			return
-		}
-
-		if !c.App.SessionHasPermissionToChannel(c.App.Session, channelId, model.PERMISSION_UPLOAD_FILE) {
-			c.SetPermissionError(model.PERMISSION_UPLOAD_FILE)
-			return
-		}
-
-		resStruct, appErr = c.App.UploadMultipartFiles(
-			FILE_TEAM_ID,
-			channelId,
-			c.App.Session.UserId,
-			m.File["files"],
-			m.Value["client_ids"],
-			now,
-		)
-	}
-
-	if appErr != nil {
-		c.Err = appErr
-		return
-	}
-
-	w.WriteHeader(http.StatusCreated)
-	w.Write([]byte(resStruct.ToJson()))
-}
-
 func parseMultipartRequestHeader(req *http.Request) (boundary string, err error) {
 	v := req.Header.Get("Content-Type")
 	if v == "" {

config/utils_test.go

@@ -204,7 +204,3 @@ func sToP(s string) *string {
 func bToP(b bool) *bool {
 	return &b
 }
-
-func iToP(i int) *int {
-	return &i
-}

i18n/en.json

@@ -1320,10 +1320,6 @@
     "id": "api.file.upload_file.storage.app_error",
     "translation": "Unable to upload file. Image storage is not configured."
   },
-  {
-    "id": "api.file.upload_file.too_large.app_error",
-    "translation": "Unable to upload file. File is too large."
-  },
   {
     "id": "api.file.upload_file.too_large_detailed.app_error",
     "translation": "Unable to upload file {{.Filename}}. {{.Length}} bytes exceeds the maximum allowed {{.Limit}} bytes."

store/sqlstore/integrity_test.go

@@ -86,10 +86,6 @@ func createChannelMemberWithChannelId(ss store.Store, id string) *model.ChannelM
 	return createChannelMember(ss, id, model.NewId())
 }
 
-func createChannelMemberWithUserId(ss store.Store, id string) *model.ChannelMember {
-	return createChannelMember(ss, model.NewId(), id)
-}
-
 func createCommandWebhook(ss store.Store, commandId, userId, channelId string) *model.CommandWebhook {
 	m := model.CommandWebhook{}
 	m.CommandId = commandId

store/sqlstore/upgrade.go

@@ -4,7 +4,6 @@
 package sqlstore
 
 import (
-	"database/sql"
 	"encoding/json"
 	"os"
 	"strings"
@@ -602,33 +601,6 @@ func UpgradeDatabaseToVersion57(sqlStore SqlStore) {
 	}
 }
 
-func getRole(sqlStore SqlStore, name string) (*model.Role, error) {
-	var dbRole Role
-
-	if err := sqlStore.GetReplica().SelectOne(&dbRole, "SELECT * from Roles WHERE Name = :Name", map[string]interface{}{"Name": name}); err != nil {
-		if err == sql.ErrNoRows {
-			return nil, errors.Wrapf(err, "failed to find role %s", name)
-		} else {
-			return nil, errors.Wrapf(err, "failed to query role %s", name)
-		}
-	}
-
-	return dbRole.ToModel(), nil
-}
-
-func saveRole(sqlStore SqlStore, role *model.Role) error {
-	dbRole := NewRoleFromModel(role)
-
-	dbRole.UpdateAt = model.GetMillis()
-	if rowsChanged, err := sqlStore.GetMaster().Update(dbRole); err != nil {
-		return errors.Wrap(err, "failed to update role")
-	} else if rowsChanged != 1 {
-		return errors.New("found no role to update")
-	}
-
-	return nil
-}
-
 func UpgradeDatabaseToVersion58(sqlStore SqlStore) {
 	if shouldPerformUpgrade(sqlStore, VERSION_5_7_0, VERSION_5_8_0) {
 		// idx_channels_txt was removed in `UpgradeDatabaseToVersion50`, but merged as part of

store/storetest/oauth_store.go

@@ -213,7 +213,7 @@ func testOAuthStoreRemoveAccessData(t *testing.T, ss store.Store) {
 	require.Nil(t, result, "did not delete access token")
 }
 
-func testOAuthStoreRemoveAllAccessData(t *testing.T, ss store.Store) {
+func TestOAuthStoreRemoveAllAccessData(t *testing.T, ss store.Store) {
 	a1 := model.AccessData{}
 	a1.ClientId = model.NewId()
 	a1.UserId = model.NewId()

store/storetest/webhook_store.go

@@ -228,7 +228,7 @@ func TestWebhookStoreGetIncomingByTeamByUser(t *testing.T, ss store.Store) {
 	})
 }
 
-func testWebhookStoreGetIncomingByChannel(t *testing.T, ss store.Store) {
+func TestWebhookStoreGetIncomingByChannel(t *testing.T, ss store.Store) {
 	o1 := buildIncomingWebhook()
 
 	o1, err := ss.Webhook().SaveIncoming(o1)

utils/test_files_compiler.go

@@ -10,21 +10,11 @@ import (
 	"os/exec"
 	"path/filepath"
 	"runtime"
-	"strings"
 	"testing"
 
 	"github.com/stretchr/testify/require"
 )
 
-func goMod(t *testing.T, dir string, args ...string) {
-	cmd := exec.Command("go", append([]string{"mod"}, args...)...)
-	cmd.Dir = dir
-	output, err := cmd.CombinedOutput()
-	if err != nil {
-		t.Fatalf("Failed to %s: %s", strings.Join(args, " "), string(output))
-	}
-}
-
 func CompileGo(t *testing.T, sourceCode, outputPath string) {
 	dir, err := ioutil.TempDir(".", "")
 	require.NoError(t, err)