PLT-7976: Configurable timeout for Elasticsearch requests. (#7716)
Этот коммит содержится в:
коммит произвёл
Joram Wilander
родитель
4491b5ecdf
Коммит
dcb59058cf
@@ -318,7 +318,8 @@
|
||||
"PostsAggregatorJobStartTime": "03:00",
|
||||
"IndexPrefix": "",
|
||||
"LiveIndexingBatchSize": 1,
|
||||
"BulkIndexingTimeWindowSeconds": 3600
|
||||
"BulkIndexingTimeWindowSeconds": 3600,
|
||||
"RequestTimeoutSeconds": 30
|
||||
},
|
||||
"DataRetentionSettings": {
|
||||
"EnableMessageDeletion": false,
|
||||
|
||||
@@ -3887,6 +3887,10 @@
|
||||
"id": "model.config.is_valid.elastic_search.bulk_indexing_time_window_seconds.app_error",
|
||||
"translation": "Elasticsearch Bulk Indexing Time Window must be at least 1 second."
|
||||
},
|
||||
{
|
||||
"id": "model.config.is_valid.elastic_search.request_timeout_seconds.app_error",
|
||||
"translation": "Elasticsearch Request Timeout must be at least 1 second."
|
||||
},
|
||||
{
|
||||
"id": "ent.emoji.licence_disable.app_error",
|
||||
"translation": "Custom emoji restrictions disabled by current license. Please contact your system administrator about upgrading your enterprise license."
|
||||
|
||||
@@ -142,6 +142,7 @@ const (
|
||||
ELASTICSEARCH_SETTINGS_DEFAULT_INDEX_PREFIX = ""
|
||||
ELASTICSEARCH_SETTINGS_DEFAULT_LIVE_INDEXING_BATCH_SIZE = 1
|
||||
ELASTICSEARCH_SETTINGS_DEFAULT_BULK_INDEXING_TIME_WINDOW_SECONDS = 3600
|
||||
ELASTICSEARCH_SETTINGS_DEFAULT_REQUEST_TIMEOUT_SECONDS = 30
|
||||
|
||||
DATA_RETENTION_SETTINGS_DEFAULT_MESSAGE_RETENTION_DAYS = 365
|
||||
DATA_RETENTION_SETTINGS_DEFAULT_FILE_RETENTION_DAYS = 365
|
||||
@@ -491,6 +492,7 @@ type ElasticsearchSettings struct {
|
||||
IndexPrefix *string
|
||||
LiveIndexingBatchSize *int
|
||||
BulkIndexingTimeWindowSeconds *int
|
||||
RequestTimeoutSeconds *int
|
||||
}
|
||||
|
||||
type DataRetentionSettings struct {
|
||||
@@ -1431,6 +1433,10 @@ func (o *Config) SetDefaults() {
|
||||
*o.ElasticsearchSettings.BulkIndexingTimeWindowSeconds = ELASTICSEARCH_SETTINGS_DEFAULT_BULK_INDEXING_TIME_WINDOW_SECONDS
|
||||
}
|
||||
|
||||
if o.ElasticsearchSettings.RequestTimeoutSeconds == nil {
|
||||
o.ElasticsearchSettings.RequestTimeoutSeconds = NewInt(ELASTICSEARCH_SETTINGS_DEFAULT_REQUEST_TIMEOUT_SECONDS)
|
||||
}
|
||||
|
||||
if o.DataRetentionSettings.EnableMessageDeletion == nil {
|
||||
o.DataRetentionSettings.EnableMessageDeletion = NewBool(false)
|
||||
}
|
||||
@@ -1824,6 +1830,10 @@ func (ess *ElasticsearchSettings) isValid() *AppError {
|
||||
return NewAppError("Config.IsValid", "model.config.is_valid.elastic_search.bulk_indexing_time_window_seconds.app_error", nil, "", http.StatusBadRequest)
|
||||
}
|
||||
|
||||
if *ess.RequestTimeoutSeconds < 1 {
|
||||
return NewAppError("Config.IsValid", "model.config.is_valid.elastic_search.request_timeout_seconds.app_error", nil, "", http.StatusBadRequest)
|
||||
}
|
||||
|
||||
return nil
|
||||
}
|
||||
|
||||
|
||||
Ссылка в новой задаче
Block a user