Removed space bar from autocompletes

Этот коммит содержится в:
hmhealey
2015-12-09 09:14:46 -05:00
родитель f006951959
Коммит c7e84696f5
3 изменённых файлов: 2 добавлений и 16 удалений

Просмотреть файл

@@ -39,7 +39,6 @@ export default class CommandProvider {
handlePretextChanged(suggestionId, pretext) {
if (pretext.startsWith('/')) {
SuggestionStore.setMatchedPretext(suggestionId, pretext);
SuggestionStore.setCompleteOnSpace(suggestionId, false);
AsyncClient.getSuggestedCommands(pretext, suggestionId, CommandSuggestion);
}

Просмотреть файл

@@ -94,7 +94,7 @@ export default class SuggestionBox extends React.Component {
} else if (e.which === KeyCodes.DOWN) {
EventHelpers.emitSelectNextSuggestion(this.suggestionId);
e.preventDefault();
} else if (e.which === KeyCodes.ENTER || e.which === KeyCodes.TAB || (e.which === KeyCodes.SPACE && SuggestionStore.shouldCompleteOnSpace(this.suggestionId))) {
} else if (e.which === KeyCodes.ENTER || e.which === KeyCodes.TAB) {
EventHelpers.emitCompleteWordSuggestion(this.suggestionId);
e.preventDefault();
} else if (this.props.onKeyDown) {

Просмотреть файл

@@ -38,7 +38,6 @@ class SuggestionStore extends EventEmitter {
// items: a list of objects backing the terms which may be used in rendering
// components: a list of react components that can be used to render their corresponding item
// selection: the term currently selected by the keyboard
// completeOnSpace: whether or not space will trigger the term to be autocompleted
this.suggestions = new Map();
}
@@ -79,8 +78,7 @@ class SuggestionStore extends EventEmitter {
terms: [],
items: [],
components: [],
selection: '',
completeOnSpace: true
selection: ''
});
}
@@ -95,7 +93,6 @@ class SuggestionStore extends EventEmitter {
suggestion.terms = [];
suggestion.items = [];
suggestion.components = [];
suggestion.completeOnSpace = true;
}
clearSelection(id) {
@@ -120,12 +117,6 @@ class SuggestionStore extends EventEmitter {
suggestion.matchedPretext = matchedPretext;
}
setCompleteOnSpace(id, completeOnSpace) {
const suggestion = this.suggestions.get(id);
suggestion.completeOnSpace = completeOnSpace;
}
addSuggestion(id, term, item, component) {
const suggestion = this.suggestions.get(id);
@@ -189,10 +180,6 @@ class SuggestionStore extends EventEmitter {
return this.suggestions.get(id).selection;
}
shouldCompleteOnSpace(id) {
return this.suggestions.get(id).completeOnSpace;
}
selectNext(id) {
this.setSelectionByDelta(id, 1);
}