Fix Flaky test failing on prod and in master branch (#31407)

e2e-tests/cypress/tests/integration/channels/archived_channel/archive_channel_operations_spec.ts

@@ -40,7 +40,7 @@ describe('Leave an archived channel', () => {
         });
     });
 
-    it.skip('MM-T1704 Archived channels appear in channel switcher after refresh', () => {
+    it('MM-T1704 Archived channels appear in channel switcher after refresh', () => {
         // # Archive the channel
         cy.apiLogin(testUser);
         cy.uiArchiveChannel();

e2e-tests/cypress/tests/integration/channels/enterprise/ldap/ldap_guest_spec.ts

@@ -209,6 +209,7 @@ describe('LDAP guest', () => {
 
                     // # Save settings
                     cy.get('#saveSetting').should('be.enabled').click();
+                    cy.get('#genericModalLabel > span').should('be.visible').and('have.text', 'Save and remove 1 user?');
 
                     // # Accept confirmation modal
                     cy.get('#confirmModalButton').should('be.visible').click();
@@ -227,6 +228,7 @@ describe('LDAP guest', () => {
                     cy.uiOpenTeamMenu('Invite people');
 
                     cy.wait(TIMEOUTS.TWO_SEC);
+                    cy.get('#invitation_modal_title').should('be.visible');
 
                     // # Option to invite guest should not be visible
                     cy.findByTestId('inviteGuestLink').should('not.exist');

e2e-tests/cypress/tests/integration/channels/keyboard_shortcuts/ctrl_cmd_k_open_gm_with_mouse_spec.js

@@ -44,6 +44,8 @@ describe('Keyboard Shortcuts', () => {
             // # Press Cmd/Ctrl-K to open "Switch Channels" modal
             cy.uiGetPostTextBox().cmdOrCtrlShortcut('K');
 
+            cy.waitUntil(() => cy.findAllByTestId('suggestionList').should('be.visible'));
+
             // # Click on the GM link to go to channel
             cy.get('.status--group').click();
 

e2e-tests/cypress/tests/integration/channels/notifications/message_posted_while_scrolled_up_spec.js

@@ -28,7 +28,7 @@ describe('Notifications', () => {
         });
     });
 
-    it.skip('MM-T562 New message bar - Message posted while scrolled up in same channel', () => {
+    it('MM-T562 New message bar - Message posted while scrolled up in same channel', () => {
         // # Post 30 random messages from the 'otherUser' account in off-topic
         Cypress._.times(numberOfPosts, (num) => {
             cy.postMessageAs({sender: otherUser, message: `${num} ${getRandomId()}`, channelId: offTopicChannelId});

e2e-tests/playwright/lib/src/ui/pages/threads.ts

@@ -35,6 +35,7 @@ export default class ThreadsPage {
     }
 
     async toNotHaveThreadSelected() {
+        await this.noThreadSelected.waitFor({state: 'visible'});
         await expect(this.noThreadSelected).toBeVisible();
     }