Merge pull request #1085 from mattermost/plt-633

PLT-633 Add default username and icon to incoming webhooks.

model/webhook.go

@@ -8,6 +8,11 @@ import (
 	"io"
 )
 
+const (
+	DEFAULT_WEBHOOK_USERNAME = "webhook"
+	DEFAULT_WEBHOOK_ICON     = "/static/images/webhook_icon.jpg"
+)
+
 type IncomingWebhook struct {
 	Id        string `json:"id"`
 	CreateAt  int64  `json:"create_at"`

web/web.go

@@ -971,12 +971,20 @@ func incomingWebhook(c *api.Context, w http.ResponseWriter, r *http.Request) {
 	post := &model.Post{UserId: hook.UserId, ChannelId: channel.Id, Message: text}
 	post.AddProp("from_webhook", "true")
 
-	if len(overrideUsername) != 0 && utils.Cfg.ServiceSettings.EnablePostUsernameOverride {
-		post.AddProp("override_username", overrideUsername)
+	if utils.Cfg.ServiceSettings.EnablePostUsernameOverride {
+		if len(overrideUsername) != 0 {
+			post.AddProp("override_username", overrideUsername)
+		} else {
+			post.AddProp("override_username", model.DEFAULT_WEBHOOK_USERNAME)
+		}
 	}
 
-	if len(overrideIconUrl) != 0 && utils.Cfg.ServiceSettings.EnablePostIconOverride {
-		post.AddProp("override_icon_url", overrideIconUrl)
+	if utils.Cfg.ServiceSettings.EnablePostIconOverride {
+		if len(overrideIconUrl) != 0 {
+			post.AddProp("override_icon_url", overrideIconUrl)
+		} else {
+			post.AddProp("override_icon_url", model.DEFAULT_WEBHOOK_ICON)
+		}
 	}
 
 	if !c.HasPermissionsToChannel(pchan, "createIncomingHook") && channel.Type != model.CHANNEL_OPEN {