[MM-18871] Update session in app instance in app layer (#12540)

api4/user.go

@@ -1422,8 +1422,6 @@ func login(c *Context, w http.ResponseWriter, r *http.Request) {
 		user.TermsOfServiceCreateAt = userTermsOfService.CreateAt
 	}
 
-	c.App.Session = *session
-
 	user.Sanitize(map[string]bool{})
 
 	w.Write([]byte(user.ToJson()))

app/login.go

@@ -162,6 +162,7 @@ func (a *App) DoLogin(w http.ResponseWriter, r *http.Request, user *model.User,
 	}
 
 	w.Header().Set(model.HEADER_TOKEN, session.Token)
+	a.Session = *session
 
 	if pluginsEnvironment := a.GetPluginsEnvironment(); pluginsEnvironment != nil {
 		a.Srv.Go(func() {