MM-17006: An http 404 response code is returned when deleting a non existent plugin (#11631)

Automatic Merge

api4/plugin_test.go

@@ -181,11 +181,11 @@ func TestPlugin(t *testing.T) {
 
 	// Activate error case
 	ok, resp = th.SystemAdminClient.EnablePlugin("junk")
-	CheckBadRequestStatus(t, resp)
+	CheckNotFoundStatus(t, resp)
 	assert.False(t, ok)
 
 	ok, resp = th.SystemAdminClient.EnablePlugin("JUNK")
-	CheckBadRequestStatus(t, resp)
+	CheckNotFoundStatus(t, resp)
 	assert.False(t, ok)
 
 	// Successful deactivate

app/plugin.go

@@ -334,7 +334,7 @@ func (a *App) EnablePlugin(id string) *model.AppError {
 	}
 
 	if manifest == nil {
-		return model.NewAppError("EnablePlugin", "app.plugin.not_installed.app_error", nil, "", http.StatusBadRequest)
+		return model.NewAppError("EnablePlugin", "app.plugin.not_installed.app_error", nil, "", http.StatusNotFound)
 	}
 
 	a.UpdateConfig(func(cfg *model.Config) {

app/plugin_statuses.go

@@ -28,7 +28,7 @@ func (a *App) GetPluginStatus(id string) (*model.PluginStatus, *model.AppError)
 			return status, nil
 		}
 	}
-	return nil, model.NewAppError("GetPluginStatus", "app.plugin.not_installed.app_error", nil, "", http.StatusBadRequest)
+	return nil, model.NewAppError("GetPluginStatus", "app.plugin.not_installed.app_error", nil, "", http.StatusNotFound)
 }
 
 // GetPluginStatuses returns the status for plugins installed on this server.