MM-36947: Fix TestHeaderProviderDoCommand (#17901)
Setting AutomaticPrepackagedPlugins to true was making the test to download the plugin from the marketplace and initialize it. While this wasn't wrong in itself but that's not what the test does and just part of the app initialization and it unnecessarily slowed down the test by downloading the plugin zip file. And initializing a plugin from inside a test has some issues to work properly. While those could be solved, a cleaner way is to just not download the plugin at all. https://mattermost.atlassian.net/browse/MM-36947 ```release-note NONE ```
Этот коммит содержится в:
коммит произвёл
GitHub
родитель
54b0ef574b
Коммит
58e002888d
@@ -55,6 +55,7 @@ func setupTestHelper(dbStore store.Store, enterprise bool, includeCacheLayer boo
|
||||
}
|
||||
*config.PluginSettings.Directory = filepath.Join(tempWorkspace, "plugins")
|
||||
*config.PluginSettings.ClientDirectory = filepath.Join(tempWorkspace, "webapp")
|
||||
*config.PluginSettings.AutomaticPrepackagedPlugins = false
|
||||
*config.LogSettings.EnableSentry = false // disable error reporting during tests
|
||||
memoryStore.Set(config)
|
||||
|
||||
@@ -133,7 +134,6 @@ func setup(tb testing.TB) *TestHelper {
|
||||
if testing.Short() {
|
||||
tb.SkipNow()
|
||||
}
|
||||
tb.Skip("MM-36947")
|
||||
dbStore := mainHelper.GetStore()
|
||||
dbStore.DropAllTables()
|
||||
dbStore.MarkSystemRanUnitTests()
|
||||
|
||||
Ссылка в новой задаче
Block a user