Remove unncessary recover() calls (#14066)

* Remove unncessary recover() calls

A recover which is not called inside a defer will always return nil.
So there's no use of calling it.

And even if we did call it inside a defer, recovering and immediately
panicking does not make sense either. So we just remove it.

* Fixed another instance

api4/apitestlib.go

@@ -246,10 +246,6 @@ func (me *TestHelper) TearDown() {
 	me.ShutdownApp()
 
 	utils.EnableDebugLogForTest()
-
-	if err := recover(); err != nil {
-		panic(err)
-	}
 }
 
 var initBasicOnce sync.Once

app/helper_test.go

@@ -567,9 +567,6 @@ func (me *TestHelper) TearDown() {
 		me.App.InvalidateAllCaches()
 	}
 	me.ShutdownApp()
-	if err := recover(); err != nil {
-		panic(err)
-	}
 	if me.tempWorkspace != "" {
 		os.RemoveAll(me.tempWorkspace)
 	}

migrations/helper_test.go

@@ -250,9 +250,6 @@ func (me *TestHelper) TearDown() {
 	// Clean all the caches
 	me.App.InvalidateAllCaches()
 	me.Server.Shutdown()
-	if err := recover(); err != nil {
-		panic(err)
-	}
 	if me.tempWorkspace != "" {
 		os.RemoveAll(me.tempWorkspace)
 	}

web/web_test.go

@@ -158,9 +158,6 @@ func (th *TestHelper) TearDown() {
 		th.App.InvalidateAllCaches()
 	}
 	th.Server.Shutdown()
-	if err := recover(); err != nil {
-		panic(err)
-	}
 }
 
 func TestStaticFilesRequest(t *testing.T) {