fix default field type if missing value_type in attrs (#30913)

webapp/channels/src/components/admin_console/system_properties/user_properties_type_menu.test.tsx

@@ -48,6 +48,21 @@ describe('UserPropertyTypeMenu', () => {
         expect(screen.getByText('Text')).toBeInTheDocument();
     });
 
+    it('renders legacy text field with no value_type in attrs', () => {
+        const legacyField = {
+            ...baseField,
+            type: 'text' as const,
+            attrs: {
+                sort_order: 0,
+            },
+        };
+
+        renderComponent(legacyField as UserPropertyField);
+
+        // The menu button should show the current type
+        expect(screen.getByText('Text')).toBeInTheDocument();
+    });
+
     it('disables menu button when field is marked for deletion', () => {
         const deletedField = {
             ...baseField,

webapp/channels/src/components/admin_console/system_properties/user_properties_type_menu.tsx

@@ -119,12 +119,15 @@ export default SelectType;
 
 const getTypeDescriptor = (field: UserPropertyField): TypeDescriptor => {
     for (const descriptor of Object.values(TYPE_DESCRIPTOR)) {
-        if (descriptor.fieldType === field.type && descriptor.valueType === field.attrs?.value_type) {
+        if (
+            descriptor.fieldType === field.type &&
+            descriptor.valueType === (field.attrs?.value_type ?? '')
+        ) {
             return descriptor;
         }
     }
 
-    throw new Error('Invalid type');
+    return TYPE_DESCRIPTOR.text;
 };
 
 type TypeID = 'text' | 'email' | 'phone' | 'url' | 'select' | 'multiselect';