Ashish Bhate ff4406e8b2 MM-46402: Use pointer to pointer to set pointer to nil (#20827) ...

Summary
We need a pointer to a pointer to set the original pointer to nil
The original task was not being set to nil (the local variable containing the pointer was being set to nil). The cancel function was being called even though the task had already been cancelled. This repeated cancellation was causing a panic because we were trying to close a channel that had already been closed the first time the task was cancelled.

Ticket Link
https://mattermost.atlassian.net/browse/MM-46402

2022-08-19 07:27:16 +05:30

..

email

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

featureflag

Use any instead of interface{} (#20577)

2022-07-05 09:46:50 +03:00

imaging

Replace deprecated ioutil with io and os (#20776)

2022-08-09 14:25:46 +03:00

layer_generators

Replace deprecated ioutil with io and os (#20776)

2022-08-09 14:25:46 +03:00

opentracing

MM-38702: Do not fail during importing without attachment (#20800)

2022-08-17 13:36:36 +05:30

platform

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

plugin_api_tests

Use any instead of interface{} (#20577)

2022-07-05 09:46:50 +03:00

request

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

slashcommands

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

teams

MM-45120: Track team join times. Add API to retrieve new team members since a given time. (#20708)

2022-08-11 10:38:52 -04:00

users

Replace deprecated ioutil with io and os (#20776)

2022-08-09 14:25:46 +03:00

admin_advisor.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

admin_test.go

Growth spike: Get latest MM version (#19366)

2022-02-02 09:19:47 -05:00

admin.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

analytics.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

app_iface.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

app_test.go

[MM-41576] Add schema version to the client configuration (#19757)

2022-03-15 16:39:23 +03:00

app.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

audit.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

authentication_test.go

MM-42714: Trim token sizes to 50 characters (#20412)

2022-06-09 14:56:26 +05:30

authentication.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

authorization_test.go

Replace deprecated ioutil with io and os (#20776)

2022-08-09 14:25:46 +03:00

authorization.go

MM-45715: Fix incorrect permissions (Round 2) (#20731)

2022-07-29 09:58:44 +05:30

auto_responder_test.go

MM-45194: Switch app/user and api4/user to logger context (#20674)

2022-07-28 10:04:21 +05:30

auto_responder.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

bot_test.go

MM-45194: Switch app/user and api4/user to logger context (#20674)

2022-07-28 10:04:21 +05:30

bot.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

brand.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

busy_test.go

MM-45725: Skip BusySet (#20647)

2022-07-14 12:17:52 +05:30

busy.go

[MM-22051] Remove To/From JSON (#18070)

2021-09-01 14:43:12 +02:00

channel_category_test.go

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

channel_category.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

channel_test.go

Move config store into Platform Service (#20718)

2022-08-08 16:52:31 +03:00

channel.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

channels.go

add userService to the services provided by channels product (#20840)

2022-08-17 11:21:22 -04:00

cloud.go

Fix broken master; ensure all product service APIs have correct implementations (#20663)

2022-07-15 13:20:40 -04:00

cluster_discovery_test.go

MM-36271: Bump major version to 6.0 (#17973)

2021-07-22 12:21:47 +05:30

cluster_discovery.go

Move config store into Platform Service (#20718)

2022-08-08 16:52:31 +03:00

cluster_handlers.go

Move plugins under Channels (#18938)

2021-11-08 11:57:22 +05:30

cluster.go

Fix broken master; ensure all product service APIs have correct implementations (#20663)

2022-07-15 13:20:40 -04:00

command_autocomplete_test.go

MM-45196: Migration api4/command and app/cmd to logger context (#20730)

2022-08-02 20:48:54 +05:30

command_autocomplete.go

[MM-45991] Check and return JSON errors (#20735)

2022-08-10 10:56:58 +02:00

command_test.go

Move some variables out of model (#17909)

2021-07-21 16:38:39 +02:00

command.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

compliance.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

config_test.go

Move config store into Platform Service (#20718)

2022-08-08 16:52:31 +03:00

config.go

Move config store into Platform Service (#20718)

2022-08-08 16:52:31 +03:00

constants.go

MM-31063: Change constants to use CamelCase (#16608)

2021-01-04 11:32:29 +05:30

context.go

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

data_retention.go

MM-36271: Bump major version to 6.0 (#17973)

2021-07-22 12:21:47 +05:30

download_test.go

[MM-37772] Idiomatic naming (URL, URI, API) (#18128)

2021-08-16 19:46:44 +02:00

download.go

Replace deprecated ioutil with io and os (#20776)

2022-08-09 14:25:46 +03:00

email_test.go

MM-39058 - invite people to join team and channels (#19849)

2022-04-08 12:20:44 -05:00

emoji.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

enterprise_test.go

[MM-41576] Add schema version to the client configuration (#19757)

2022-03-15 16:39:23 +03:00

enterprise.go

re-assign cluster interface after initializing enterprise interfaces (#20839)

2022-08-17 23:07:04 +03:00

expirynotify_test.go

Working on refactoring jobs service (#19205)

2022-02-14 18:21:18 +01:00

expirynotify.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

export_converters.go

[MM-41115] Add server-side username colorize preference (#19382)

2022-06-24 12:37:07 -04:00

export_test.go

Replace deprecated ioutil with io and os (#20776)

2022-08-09 14:25:46 +03:00

export.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

extract_plugin_tar_test.go

Replace deprecated ioutil with io and os (#20776)

2022-08-09 14:25:46 +03:00

extract_plugin_tar.go

[GH-19267] Spelling comments (#19268)

2022-01-20 10:07:27 +05:30

file_bench_test.go

Fix minio client breakage with bifrost round 2 (#20758)

2022-08-04 11:21:51 +05:30

file_test.go

MM-45871: Do not try to extract content from images (#20698)

2022-07-26 12:17:23 +05:30

file.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

group_test.go

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

group.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

helper_test.go

Replace deprecated ioutil with io and os (#20776)

2022-08-09 14:25:46 +03:00

image.go

Add MaxImageResolution config setting (#17941)

2021-08-12 17:43:10 +02:00

import_functions_test.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

import_functions.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

import_test.go

MM-45198: Migrate app/import and api4/import (#20799)

2022-08-17 19:58:52 +05:30

import_types.go

[MM-41115] Add server-side username colorize preference (#19382)

2022-06-24 12:37:07 -04:00

import_utils_test.go

[MM-33794] Improve password generation during bulk import (#17147)

2021-03-24 10:32:16 +01:00

import_utils.go

[MM-33794] Improve password generation during bulk import (#17147)

2021-03-24 10:32:16 +01:00

import_validators_test.go

MM-43878: don't err when reply createAt before parent createAt (#20292)

2022-05-27 15:48:00 +05:30

import_validators.go

[MM-45991] Check and return JSON errors (#20735)

2022-08-10 10:56:58 +02:00

import.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

integration_action_test.go

Replace deprecated ioutil with io and os (#20776)

2022-08-09 14:25:46 +03:00

integration_action.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

integrations_test.go

Cloud Freemium - Integrations (#20185)

2022-05-25 12:36:08 -04:00

integrations.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

job_test.go

MM-36271: Bump major version to 6.0 (#17973)

2021-07-22 12:21:47 +05:30

job.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

ldap.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

license_test.go

[MM-40962-2] - Fix unnecessary logging in license expiration check (#19826)

2022-03-31 18:25:46 +03:00

license.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

login_test.go

MM-36271: Bump major version to 6.0 (#17973)

2021-07-22 12:21:47 +05:30

login.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

main_test.go

MM-36764 mlog refactor (#18118)

2021-08-17 16:08:04 -04:00

migrations.go

Move config store into Platform Service (#20718)

2022-08-08 16:52:31 +03:00

notification_email_test.go

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

notification_email.go

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

notification_push_test.go

Move config store into Platform Service (#20718)

2022-08-08 16:52:31 +03:00

notification_push.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

notification_test.go

MM-45194: Switch app/user and api4/user to logger context (#20674)

2022-07-28 10:04:21 +05:30

notification.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

oauth_test.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

oauth.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

onboarding.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

opengraph_test.go

[MM-37755] Idiomatic naming (SMTP, TLS, TCP, XML, CSS, HTML, HTTP) (#18103)

2021-08-12 11:49:16 +02:00

opengraph.go

Improve API4 initialization (#18680)

2021-10-15 19:57:05 +05:30

options.go

Move config store into Platform Service (#20718)

2022-08-08 16:52:31 +03:00

permissions_migrations_test.go

MM-36271: Bump major version to 6.0 (#17973)

2021-07-22 12:21:47 +05:30

permissions_migrations.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

permissions_test.go

Use any instead of interface{} (#20577)

2022-07-05 09:46:50 +03:00

permissions.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

plugin_api_test.go

Replace deprecated ioutil with io and os (#20776)

2022-08-09 14:25:46 +03:00

plugin_api.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

plugin_commands_test.go

Use any instead of interface{} (#20577)

2022-07-05 09:46:50 +03:00

plugin_commands.go

MM-45196: Migration api4/command and app/cmd to logger context (#20730)

2022-08-02 20:48:54 +05:30

plugin_context.go

Migrate to stateless app.App (#17542)

2021-05-11 13:00:44 +03:00

plugin_db_driver.go

Use any instead of interface{} (#20577)

2022-07-05 09:46:50 +03:00

plugin_deadlock_test.go

Use any instead of interface{} (#20577)

2022-07-05 09:46:50 +03:00

plugin_event.go

Move plugins under Channels (#18938)

2021-11-08 11:57:22 +05:30

plugin_health_check_test.go

MM-36271: Bump major version to 6.0 (#17973)

2021-07-22 12:21:47 +05:30

plugin_hooks_test.go

Replace deprecated ioutil with io and os (#20776)

2022-08-09 14:25:46 +03:00

plugin_install_test.go

Move pluginCommands into Channels (#18974)

2021-11-12 10:35:14 +05:30

plugin_install.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

plugin_key_value_store.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

plugin_public_keys.go

[MM-20309] production public key (#13244)

2019-12-05 23:41:52 +04:00

plugin_requests_test.go

Move pluginCommands into Channels (#18974)

2021-11-12 10:35:14 +05:30

plugin_requests.go

Replace deprecated ioutil with io and os (#20776)

2022-08-09 14:25:46 +03:00

plugin_shutdown_test.go

Move plugins under Channels (#18938)

2021-11-08 11:57:22 +05:30

plugin_signature_test.go

Replace deprecated ioutil with io and os (#20776)

2022-08-09 14:25:46 +03:00

plugin_signature.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

plugin_statuses.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

plugin_test.go

Replace deprecated ioutil with io and os (#20776)

2022-08-09 14:25:46 +03:00

plugin.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

post_helpers_test.go

Mm 43609 (#20657)

2022-07-25 16:01:59 -05:00

post_helpers.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

post_metadata_test.go

Move config store into Platform Service (#20718)

2022-08-08 16:52:31 +03:00

post_metadata.go

Move config store into Platform Service (#20718)

2022-08-08 16:52:31 +03:00

post_test.go

Move config store into Platform Service (#20718)

2022-08-08 16:52:31 +03:00

post.go

[MM-45730] Fix Sentry crash: nil deference in model/post_list.go:152 (#20742)

2022-08-18 14:33:33 +05:30

preference.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

product_notices_test.go

[MM-45769] Properly initialize the request.Context for imports and tests (#20659)

2022-07-18 10:58:06 +02:00

product_notices.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

product_test.go

Use any instead of interface{} (#20577)

2022-07-05 09:46:50 +03:00

product.go

Use any instead of interface{} (#20577)

2022-07-05 09:46:50 +03:00

ratelimit_test.go

MM-36271: Bump major version to 6.0 (#17973)

2021-07-22 12:21:47 +05:30

ratelimit.go

[MM-23279] Idiomatic naming (IP) (#18152)

2021-08-19 10:33:29 +02:00

reaction_test.go

Move config store into Platform Service (#20718)

2022-08-08 16:52:31 +03:00

reaction.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

remote_cluster_service_mock.go

MM-36271: Bump major version to 6.0 (#17973)

2021-07-22 12:21:47 +05:30

remote_cluster_test.go

spelling: strings (#19542)

2022-02-28 15:01:00 +05:30

remote_cluster.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

response_transfer.go

Replace deprecated ioutil with io and os (#20776)

2022-08-09 14:25:46 +03:00

role_test.go

Replace deprecated ioutil with io and os (#20776)

2022-08-09 14:25:46 +03:00

role.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

saml.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

scheme.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

searchengine.go

Move Channels into App (#18623)

2021-10-12 11:39:49 +05:30

security_update_check.go

[MM-45991] Check and return JSON errors (#20735)

2022-08-10 10:56:58 +02:00

server_inactivity.go

Move config store into Platform Service (#20718)

2022-08-08 16:52:31 +03:00

server_test.go

MM-46402: Use pointer to pointer to set pointer to nil (#20827)

2022-08-19 07:27:16 +05:30

server.go

MM-46402: Use pointer to pointer to set pointer to nil (#20827)

2022-08-19 07:27:16 +05:30

session_test.go

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

session.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

shared_channel_notifier_test.go

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

shared_channel_notifier.go

MM-36271: Bump major version to 6.0 (#17973)

2021-07-22 12:21:47 +05:30

shared_channel_service_iface.go

MM-36271: Bump major version to 6.0 (#17973)

2021-07-22 12:21:47 +05:30

shared_channel_test.go

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

shared_channel.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

slack_test.go

MM-36271: Bump major version to 6.0 (#17973)

2021-07-22 12:21:47 +05:30

slack.go

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

status_test.go

Move config store into Platform Service (#20718)

2022-08-08 16:52:31 +03:00

status.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

support_packet_test.go

Replace deprecated ioutil with io and os (#20776)

2022-08-09 14:25:46 +03:00

support_packet.go

Replace deprecated ioutil with io and os (#20776)

2022-08-09 14:25:46 +03:00

syncables_test.go

MM-45194: Switch app/user and api4/user to logger context (#20674)

2022-07-28 10:04:21 +05:30

syncables.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

team_test.go

MM-45120: Track team join times. Add API to retrieve new team members since a given time. (#20708)

2022-08-11 10:38:52 -04:00

team.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

telemetry.go

[MM-40022] - Expose telemetry service in the server (#18976)

2021-11-12 10:16:19 +03:00

terms_of_service.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

upload_test.go

Replace deprecated ioutil with io and os (#20776)

2022-08-09 14:25:46 +03:00

upload.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

usage_test.go

[MM-43917] Cloud Freemium limits API: messages/posts (#20152)

2022-05-17 13:30:40 +02:00

usage.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

user_agent_test.go

[MM-22167] Add mmctl to the User-Agent parser (#13894)

2020-03-19 11:18:17 +01:00

user_agent.go

[MM-22167] Add mmctl to the User-Agent parser (#13894)

2020-03-19 11:18:17 +01:00

user_terms_of_service_test.go

Migration of UserTermsOfServiceStore to return plain errors (#14788)

2020-06-19 17:49:30 +05:30

user_terms_of_service.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

user_test.go

Move config store into Platform Service (#20718)

2022-08-08 16:52:31 +03:00

user_viewmembers_test.go

MM-45194: Switch app/user and api4/user to logger context (#20674)

2022-07-28 10:04:21 +05:30

user.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

web_conn_test.go

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

web_conn.go

Fix incorrect dead queue clear logic (#20624)

2022-07-11 23:26:47 +05:30

web_hub_test.go

Move config store into Platform Service (#20718)

2022-08-08 16:52:31 +03:00

web_hub.go

Move metrics under platform service (continued) (#20732)

2022-08-02 10:59:29 +03:00

webhook_test.go

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

webhook.go

MM-45991 Wrap errors (#20785)

2022-08-18 11:01:37 +02:00

webhub_fuzz.go

Replace deprecated ioutil with io and os (#20776)

2022-08-09 14:25:46 +03:00

websocket_router.go

MM-39612: Make acquiring and removing connections atomic (#18982)

2021-11-16 19:43:43 +05:30