mirrors/mostlymatter
1
0
Форкнуть 0
Код Задачи Запросы на слияние Действия Пакеты Проекты Релизы Вики Активность
Files
fc444204b3749106d6d0d436445bf26f8a656c2f
mostlymatter/api4
История
Kyriakos Z b15cd9d29f MM-41565,MM-42473: fixes incorrect unread thread count (#19962) 
* MM-41565,MM-42473: fixes incorrect unread thread count

The infamous "-1 unread threads" bug, was due to incorrectly counting
previous unread mentions and replies.

When we calculate the previous counts, we didn't take into account if
a thread was newly followed one or not. So when a user gets added to a
thread via a mention receives a WS event with the previous count values
calculated by subtracting "1" from the current count values.
In the result the webapp subtracts the previous values for the thread
from the total values of all threads for the user.

This is wrong since the user just followed the thread those previous values
should be 0. Which results into showing a negative value of unread
threads to the user.

This commit fixes this issue by zeroing the previous count values when
the user was not following the thread previously.

* Adds test, and addresses comments

* Changes test's description

* Removes unneeded assertion

* Empty commit just to re-build
2022-04-15 12:47:04 -04:00
..
api.go
GraphQL (part 2): Model changes and resolvers (#19486)
2022-02-11 12:37:05 +05:30
apitestlib.go
[MM-41998] Channel Info RHS: display number of files for a channel (#19822)
2022-03-25 13:28:14 -07:00
bleve_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
bleve.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
bot_local.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
bot_test.go
spelling: strings (#19542)
2022-02-28 15:01:00 +05:30
bot.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
brand_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
brand.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
channel_category_test.go
MM-42652: Skip Flaky test in CreateCategoryForTeamForUser (#19857)
2022-03-29 19:36:50 +05:30
channel_category.go
GraphQL (part 1): Store layer (#19465)
2022-02-02 22:44:22 +05:30
channel_local.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
channel_test.go
Disambiguates some units. (#19875)
2022-04-07 13:58:40 -04:00
channel.go
[MM-41998] Channel Info RHS: display number of files for a channel (#19822)
2022-03-25 13:28:14 -07:00
cloud.go
spelling (#19956)
2022-04-11 19:31:19 +05:30
cluster_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
cluster.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
command_help_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
command_local.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
command_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
command.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
commands_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
compliance.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
config_local.go
[MM-41147] Remove cloud sysadmin access to migrate config API (#19373)
2022-01-19 23:05:32 +03:00
config_test.go
MM-41323: Secure plugin marketplace modification (#19889)
2022-04-06 15:29:51 +05:30
config.go
MM-41323: Secure plugin marketplace modification (#19889)
2022-04-06 15:29:51 +05:30
cors_test.go
Fix race condition in telemetry (#18734)
2021-10-20 09:58:25 +02:00
data_retention_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
data_retention.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
elasticsearch_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
elasticsearch.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
emoji_test.go
spelling: strings (#19542)
2022-02-28 15:01:00 +05:30
emoji.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
export_local.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
export_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
export.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
file_test.go
MM-42877: Fix TestGetFileHeaders (#20002)
2022-04-15 14:49:48 +05:30
file.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
graphql_client.go
GraphQL (part 2): Model changes and resolvers (#19486)
2022-02-11 12:37:05 +05:30
graphql_test.go
GraphQL (part 2): Model changes and resolvers (#19486)
2022-02-11 12:37:05 +05:30
graphql.go
MM-43144: Add teams loader (#19960)
2022-04-11 20:51:33 +05:30
group_local.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
group_test.go
MM-42201: Enforce group is not the same as username. (#19660)
2022-03-08 09:14:22 -05:00
group.go
MM-40817: Use license interface in Channels (#19678)
2022-03-10 09:00:29 +05:30
handlers_test.go
GraphQL (part 2): Model changes and resolvers (#19486)
2022-02-11 12:37:05 +05:30
handlers.go
MM-40817: Use license interface in Channels (#19678)
2022-03-10 09:00:29 +05:30
helpers.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
image_test.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
image.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
import_local.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
import_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
import.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
integration_action_test.go
spelling: strings (#19542)
2022-02-28 15:01:00 +05:30
integration_action.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
job_local.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
job_test.go
Working on refactoring jobs service (#19205)
2022-02-14 18:21:18 +01:00
job.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
ldap_local.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
ldap_test.go
MM-40818: Refactor product initialization to happen late (#19658)
2022-03-03 12:22:10 +05:30
ldap.go
MM-40817: Use license interface in Channels (#19678)
2022-03-10 09:00:29 +05:30
license_local.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
license_test.go
[MM-42822] Check for and return HTTP 451 for all trial requests (#19873)
2022-04-04 09:48:14 -04:00
license.go
api4/license: Return 400 instead of 501 if format is not passed (#19856)
2022-04-04 10:27:29 +05:30
main_test.go
MM-36764 mlog refactor (#18118)
2021-08-17 16:08:04 -04:00
oauth_test.go
GraphQL (part 2): Model changes and resolvers (#19486)
2022-02-11 12:37:05 +05:30
oauth.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
openGraph_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
openGraph.go
Improve API4 initialization (#18680)
2021-10-15 19:57:05 +05:30
permission.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
permissions_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
plugin_local.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
plugin_test.go
[MM-41981] Always install the latest compatible version via the Marketplace (#19613)
2022-03-03 22:53:01 +01:00
plugin.go
[MM-41981] Always install the latest compatible version via the Marketplace (#19613)
2022-03-03 22:53:01 +01:00
post_local.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
post_test.go
[MM-43073] broadcast post unread websocket when CRT off (#19927)
2022-04-06 16:42:31 -04:00
post.go
MM-38164: Paginate the GetPostThread API (#19485)
2022-03-24 12:51:41 +05:30
preference_test.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
preference.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
reaction_test.go
[MM-42742] Add top reactions endpoint (#19850)
2022-04-14 13:09:35 -04:00
reaction.go
[MM-42742] Add top reactions endpoint (#19850)
2022-04-14 13:09:35 -04:00
remote_cluster.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
resolver_channel_member_test.go
GraphQL (part 2): Model changes and resolvers (#19486)
2022-02-11 12:37:05 +05:30
resolver_channel_member.go
MM-43145: channels loader (#19957)
2022-04-11 13:41:09 +05:30
resolver_channel_test.go
graphql: Add channel stats under channel (#19804)
2022-03-25 11:59:57 +03:00
resolver_channel.go
graphql: Add channel stats under channel (#19804)
2022-03-25 11:59:57 +03:00
resolver_team_member_test.go
GraphQL (part 2): Model changes and resolvers (#19486)
2022-02-11 12:37:05 +05:30
resolver_team_member.go
MM-43143: Dataloaders for roles (#19936)
2022-04-08 15:32:35 +05:30
resolver_team.go
MM-43340: Fix racy test TestGraphQLChannelMembers (#19968)
2022-04-13 18:50:33 +05:30
resolver_test.go
MM-43143: Dataloaders for roles (#19936)
2022-04-08 15:32:35 +05:30
resolver_user_test.go
MM-42268: We add more fields to Channel and Team (#19675)
2022-03-07 20:14:53 +05:30
resolver_user.go
MM-43143: Dataloaders for roles (#19936)
2022-04-08 15:32:35 +05:30
resolver.go
MM-43144: Add teams loader (#19960)
2022-04-11 20:51:33 +05:30
role_local.go
MM-32396 Create endpoint for listing all the roles (#16988)
2021-11-08 16:38:41 +03:00
role_test.go
MM-32396 Create endpoint for listing all the roles (#16988)
2021-11-08 16:38:41 +03:00
role.go
MM-40817: Use license interface in Channels (#19678)
2022-03-10 09:00:29 +05:30
saml_test.go
MM-40818: Refactor product initialization to happen late (#19658)
2022-03-03 12:22:10 +05:30
saml.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
schema.graphqls
graphql: Add channel stats under channel (#19804)
2022-03-25 11:59:57 +03:00
scheme_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
scheme.go
MM-40817: Use license interface in Channels (#19678)
2022-03-10 09:00:29 +05:30
shared_channel_test.go
MM-38611 getSharedChannels: only return channels user is member of (#18417)
2021-09-20 15:00:47 -04:00
shared_channel.go
MM-38611 getSharedChannels: only return channels user is member of (#18417)
2021-09-20 15:00:47 -04:00
status_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
status.go
remove timedDND feature flag (#18346)
2021-10-14 11:54:09 -04:00
system_local.go
[MM-41576] Add schema version to the client configuration (#19757)
2022-03-15 16:39:23 +03:00
system_test.go
api4/system: add check if model.FileSettings is empty (#19876)
2022-04-04 15:03:31 +03:00
system.go
MM-42813: Fallback to default config if nil is passed (#19920)
2022-04-06 08:30:16 +05:30
team_local.go
MM-39058 - invite people to join team and channels (#19849)
2022-04-08 12:20:44 -05:00
team_test.go
MM-39058 - invite people to join team and channels (#19849)
2022-04-08 12:20:44 -05:00
team.go
MM-39058 - invite people to join team and channels (#19849)
2022-04-08 12:20:44 -05:00
terms_of_service_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
terms_of_service.go
MM-40817: Use license interface in Channels (#19678)
2022-03-10 09:00:29 +05:30
upload_local.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
upload_test.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
upload.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
user_local.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
user_test.go
MM-41565,MM-42473: fixes incorrect unread thread count (#19962)
2022-04-15 12:47:04 -04:00
user_viewmembers_test.go
spelling: strings (#19542)
2022-02-28 15:01:00 +05:30
user.go
[MM-41185]: new API to mark thread as unread (#19951)
2022-04-15 10:55:47 +03:00
webhook_local.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
webhook_test.go
spelling: strings (#19542)
2022-02-28 15:01:00 +05:30
webhook.go
spelling (#19956)
2022-04-11 19:31:19 +05:30
websocket_norace_test.go
Custom groups (#18839)
2022-02-17 12:34:39 -05:00
websocket_test.go
[MM-40485] Enable receiving binary websocket messages (#19128)
2021-12-07 15:24:18 +01:00
websocket.go
Remove reliable websockets configuration (#19040)
2021-12-03 20:29:57 +05:30