* [MM-28779] Fix errcheck issues in server/channels/app/brand.go Remove brand.go from the errcheck exclusion list in .golangci.yml and fixed the error by properly handling the return value from a.MoveFile(). 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * [MM-28779] Add test to verify brand image backup functionality Add a new test that verifies backup of the original brand image happens when a new one is uploaded. This helps to ensure the fix for errcheck issues is working as expected. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * use seperate temporary filestore for each test * Use FileSettings.Directory instead of finding the dir programatically * Fix another test * Fix defer * Update server/channels/api4/job_test.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix bad bot commit * Cleanup logs message * cleanup file path * Fix error variable names * WIP:cleanup panic ussage * Revert "WIP:cleanup panic ussage" This reverts commit c3284e4427a41c818acc161926cd2535dee9a6b9. * cleanup error checks --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Mattermost Build <build@mattermost.com>
234 строки
6.7 KiB
Go
234 строки
6.7 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package api4
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/mattermost/mattermost/server/public/model"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestListExports(t *testing.T) {
|
|
th := Setup(t)
|
|
defer th.TearDown()
|
|
|
|
t.Run("no permissions", func(t *testing.T) {
|
|
exports, _, err := th.Client.ListExports(context.Background())
|
|
require.Error(t, err)
|
|
CheckErrorID(t, err, "api.context.permissions.app_error")
|
|
require.Nil(t, exports)
|
|
})
|
|
|
|
th.TestForSystemAdminAndLocal(t, func(t *testing.T, c *model.Client4) {
|
|
exports, _, err := c.ListExports(context.Background())
|
|
require.NoError(t, err)
|
|
require.Empty(t, exports)
|
|
}, "no exports")
|
|
|
|
dataDir := *th.App.Config().FileSettings.Directory
|
|
|
|
th.TestForSystemAdminAndLocal(t, func(t *testing.T, c *model.Client4) {
|
|
exportDir := filepath.Join(dataDir, *th.App.Config().ExportSettings.Directory)
|
|
err := os.Mkdir(exportDir, 0700)
|
|
require.NoError(t, err)
|
|
defer func() {
|
|
err = os.RemoveAll(exportDir)
|
|
require.NoError(t, err)
|
|
}()
|
|
|
|
f, err := os.Create(filepath.Join(exportDir, "export.zip"))
|
|
require.NoError(t, err)
|
|
err = f.Close()
|
|
require.NoError(t, err)
|
|
|
|
exports, _, err := c.ListExports(context.Background())
|
|
require.NoError(t, err)
|
|
require.Len(t, exports, 1)
|
|
require.Equal(t, exports[0], "export.zip")
|
|
}, "expected exports")
|
|
|
|
th.TestForSystemAdminAndLocal(t, func(t *testing.T, c *model.Client4) {
|
|
originalExportDir := *th.App.Config().ExportSettings.Directory
|
|
th.App.UpdateConfig(func(cfg *model.Config) { *cfg.ExportSettings.Directory = "new" })
|
|
defer th.App.UpdateConfig(func(cfg *model.Config) {
|
|
*cfg.ExportSettings.Directory = originalExportDir
|
|
})
|
|
|
|
exportDir := filepath.Join(dataDir, *th.App.Config().ExportSettings.Directory)
|
|
err := os.Mkdir(exportDir, 0700)
|
|
require.NoError(t, err)
|
|
defer func() {
|
|
err = os.RemoveAll(exportDir)
|
|
require.NoError(t, err)
|
|
}()
|
|
|
|
exports, _, err := c.ListExports(context.Background())
|
|
require.NoError(t, err)
|
|
require.Empty(t, exports)
|
|
|
|
f, err := os.Create(filepath.Join(exportDir, "export.zip"))
|
|
require.NoError(t, err)
|
|
err = f.Close()
|
|
require.NoError(t, err)
|
|
|
|
exports, _, err = c.ListExports(context.Background())
|
|
require.NoError(t, err)
|
|
require.Len(t, exports, 1)
|
|
require.Equal(t, "export.zip", exports[0])
|
|
}, "change export directory")
|
|
}
|
|
|
|
func TestDeleteExport(t *testing.T) {
|
|
th := Setup(t)
|
|
defer th.TearDown()
|
|
|
|
t.Run("no permissions", func(t *testing.T) {
|
|
_, err := th.Client.DeleteExport(context.Background(), "export.zip")
|
|
require.Error(t, err)
|
|
CheckErrorID(t, err, "api.context.permissions.app_error")
|
|
})
|
|
|
|
dataDir := *th.App.Config().FileSettings.Directory
|
|
exportDir := filepath.Join(dataDir, *th.App.Config().ExportSettings.Directory)
|
|
|
|
th.TestForSystemAdminAndLocal(t, func(t *testing.T, c *model.Client4) {
|
|
err := os.Mkdir(exportDir, 0700)
|
|
require.NoError(t, err)
|
|
defer func() {
|
|
err = os.RemoveAll(exportDir)
|
|
require.NoError(t, err)
|
|
}()
|
|
exportName := "export.zip"
|
|
f, err := os.Create(filepath.Join(exportDir, exportName))
|
|
require.NoError(t, err)
|
|
err = f.Close()
|
|
require.NoError(t, err)
|
|
|
|
exports, _, err := c.ListExports(context.Background())
|
|
require.NoError(t, err)
|
|
require.Len(t, exports, 1)
|
|
require.Equal(t, exports[0], exportName)
|
|
|
|
_, err = c.DeleteExport(context.Background(), exportName)
|
|
require.NoError(t, err)
|
|
|
|
exports, _, err = c.ListExports(context.Background())
|
|
require.NoError(t, err)
|
|
require.Empty(t, exports)
|
|
|
|
// verify idempotence
|
|
_, err = c.DeleteExport(context.Background(), exportName)
|
|
require.NoError(t, err)
|
|
}, "successfully delete export")
|
|
}
|
|
|
|
func TestDownloadExport(t *testing.T) {
|
|
th := Setup(t)
|
|
defer th.TearDown()
|
|
|
|
t.Run("no permissions", func(t *testing.T) {
|
|
var buf bytes.Buffer
|
|
n, _, err := th.Client.DownloadExport(context.Background(), "export.zip", &buf, 0)
|
|
require.Error(t, err)
|
|
CheckErrorID(t, err, "api.context.permissions.app_error")
|
|
require.Zero(t, n)
|
|
})
|
|
|
|
dataDir := *th.App.Config().FileSettings.Directory
|
|
exportDir := filepath.Join(dataDir, *th.App.Config().ExportSettings.Directory)
|
|
|
|
th.TestForSystemAdminAndLocal(t, func(t *testing.T, c *model.Client4) {
|
|
var buf bytes.Buffer
|
|
n, _, err := c.DownloadExport(context.Background(), "export.zip", &buf, 0)
|
|
require.Error(t, err)
|
|
CheckErrorID(t, err, "api.export.export_not_found.app_error")
|
|
require.Zero(t, n)
|
|
}, "not found")
|
|
|
|
th.TestForSystemAdminAndLocal(t, func(t *testing.T, c *model.Client4) {
|
|
err := os.Mkdir(exportDir, 0700)
|
|
require.NoError(t, err)
|
|
defer func() {
|
|
err = os.RemoveAll(exportDir)
|
|
require.NoError(t, err)
|
|
}()
|
|
|
|
data := randomBytes(t, 1024*1024)
|
|
var buf bytes.Buffer
|
|
exportName := "export.zip"
|
|
err = os.WriteFile(filepath.Join(exportDir, exportName), data, 0600)
|
|
require.NoError(t, err)
|
|
|
|
n, _, err := c.DownloadExport(context.Background(), exportName, &buf, 0)
|
|
require.NoError(t, err)
|
|
require.Equal(t, len(data), int(n))
|
|
require.Equal(t, data, buf.Bytes())
|
|
}, "full download")
|
|
|
|
th.TestForSystemAdminAndLocal(t, func(t *testing.T, c *model.Client4) {
|
|
err := os.Mkdir(exportDir, 0700)
|
|
require.NoError(t, err)
|
|
defer func() {
|
|
err = os.RemoveAll(exportDir)
|
|
require.NoError(t, err)
|
|
}()
|
|
|
|
data := randomBytes(t, 1024*1024)
|
|
var buf bytes.Buffer
|
|
exportName := "export.zip"
|
|
err = os.WriteFile(filepath.Join(exportDir, exportName), data, 0600)
|
|
require.NoError(t, err)
|
|
|
|
offset := 1024 * 512
|
|
n, _, err := c.DownloadExport(context.Background(), exportName, &buf, int64(offset))
|
|
require.NoError(t, err)
|
|
require.Equal(t, len(data)-offset, int(n))
|
|
require.Equal(t, data[offset:], buf.Bytes())
|
|
}, "download with offset")
|
|
}
|
|
|
|
func BenchmarkDownloadExport(b *testing.B) {
|
|
th := Setup(b)
|
|
defer th.TearDown()
|
|
|
|
dataDir := *th.App.Config().FileSettings.Directory
|
|
exportDir := filepath.Join(dataDir, *th.App.Config().ExportSettings.Directory)
|
|
|
|
err := os.Mkdir(exportDir, 0700)
|
|
require.NoError(b, err)
|
|
defer func() {
|
|
err = os.RemoveAll(exportDir)
|
|
require.NoError(b, err)
|
|
}()
|
|
|
|
exportName := "export.zip"
|
|
f, err := os.Create(filepath.Join(exportDir, exportName))
|
|
require.NoError(b, err)
|
|
err = f.Close()
|
|
require.NoError(b, err)
|
|
|
|
err = os.Truncate(filepath.Join(exportDir, exportName), 1024*1024*1024)
|
|
require.NoError(b, err)
|
|
|
|
b.ResetTimer()
|
|
for i := 0; i < b.N; i++ {
|
|
outFilePath := filepath.Join(dataDir, fmt.Sprintf("export%d.zip", i))
|
|
outFile, err := os.Create(outFilePath)
|
|
require.NoError(b, err)
|
|
_, _, err = th.SystemAdminClient.DownloadExport(context.Background(), exportName, outFile, 0)
|
|
require.NoError(b, err)
|
|
err = outFile.Close()
|
|
require.NoError(b, err)
|
|
err = os.Remove(outFilePath)
|
|
require.NoError(b, err)
|
|
}
|
|
}
|