* initial * Revert "initial" This reverts commit 3d631aeecdc2324cd5d17c0ecdc431a8ccc15060. * [MM-32352] Add Experimental Subsections BACKEND (#16887) Automatic Merge * update appiface * Fix app layers * Ancillary Permissions on backend (#17061) Automatic Merge * [MM-32799] Add About Section (#17015) * Add About Section * add mock key * Update role.go * Update role.go Co-authored-by: Mattermod <mattermod@users.noreply.github.com> * [MM-33437] Fix config access tags for experimental settings (#17111) Automatic Merge * [MM-32794] Reporting Sub Section (#17035) * test * revert * add permissions * add new permission stuff * add store mock * fix bad merge * gofmt fix Co-authored-by: Mattermod <mattermod@users.noreply.github.com> * [MM-32343] Environment SubSection (#17054) * pre-checkout commit * fix permission for testSiteURL * pre-merge commit * increase size of Permissions column in Roles table * add entry for ENVIRONMENT to testlib/store.go * use TEXT for Permissions column in Roles table * use environment subsection permissions for API endpoints * use subsections permissions for /config/environment * add suggestions from hahmadia * update tests to use subsection permissions * add permissions column back in * comment out code in upgradeDatabaseToVersion534 Co-authored-by: Mattermod <mattermod@users.noreply.github.com> Co-authored-by: Scott Bishel <scott.bishel@mattermost.com> * MM-32351: Add Compliance Subsections (#17023) * add subsections for compliance sectin * add to mock functions * updates for read job * fixes * fix test * update tests * update tests * another test fix * some cleanup * update mlog * fix linting * Fix bad merges Co-authored-by: Mattermod <mattermod@users.noreply.github.com> Co-authored-by: Hossein <hahmadia@users.noreply.github.com> Co-authored-by: Hossein Ahmadian-Yazdi <hyazdi1997@gmail.com> * MM-32347 Site Subsections (#17095) * Init * Added migration key in testlib store * Fix syntax error * fix bad merge * fix lint Co-authored-by: Mattermod <mattermod@users.noreply.github.com> Co-authored-by: Scott Bishel <scott.bishel@mattermost.com> * MM-32350 Integrations (#17097) * implement server subsections * fix tests * update test * go fmt Co-authored-by: Hossein Ahmadian-Yazdi <hyazdi1997@gmail.com> * patch forgotten endpoints * Adding subsection permissions for Authentication (#17087) * adding new permissions, migrations to do * permission migrations and ancilary permissions * running make app-layers * fixing tests and lint * adding permissions to saml * ldap write permissions * running make app-layers * fixing conflict * making app layers * clean up and fix tests * change job type * fix js error, if site url not returned Co-authored-by: Benjamin Cooke <benjamincooke@Benjamins-MacBook-Pro.local> Co-authored-by: Hossein Ahmadian-Yazdi <hyazdi1997@gmail.com> Co-authored-by: Mattermod <mattermod@users.noreply.github.com> Co-authored-by: Scott Bishel <scott.bishel@mattermost.com> * Update permissions_migrations.go * gofmt * upgrade to 535 * gofmt Co-authored-by: Mattermod <mattermod@users.noreply.github.com> Co-authored-by: Max Erenberg <max.erenberg@mattermost.com> Co-authored-by: Scott Bishel <scott.bishel@mattermost.com> Co-authored-by: Anurag Shivarathri <anurag6713@gmail.com> Co-authored-by: Ben Cooke <benkcooke@gmail.com> Co-authored-by: Benjamin Cooke <benjamincooke@Benjamins-MacBook-Pro.local>
201 строка
5.9 KiB
Go
201 строка
5.9 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package api4
|
|
|
|
import (
|
|
"net/http"
|
|
|
|
"github.com/mattermost/mattermost-server/v5/audit"
|
|
"github.com/mattermost/mattermost-server/v5/model"
|
|
)
|
|
|
|
var allowedPermissions = []string{
|
|
model.PERMISSION_CREATE_TEAM.Id,
|
|
model.PERMISSION_MANAGE_INCOMING_WEBHOOKS.Id,
|
|
model.PERMISSION_MANAGE_OUTGOING_WEBHOOKS.Id,
|
|
model.PERMISSION_MANAGE_SLASH_COMMANDS.Id,
|
|
model.PERMISSION_MANAGE_OAUTH.Id,
|
|
model.PERMISSION_MANAGE_SYSTEM_WIDE_OAUTH.Id,
|
|
model.PERMISSION_CREATE_EMOJIS.Id,
|
|
model.PERMISSION_DELETE_EMOJIS.Id,
|
|
model.PERMISSION_EDIT_OTHERS_POSTS.Id,
|
|
}
|
|
|
|
var notAllowedPermissions = []string{
|
|
model.PERMISSION_SYSCONSOLE_WRITE_USERMANAGEMENT_SYSTEM_ROLES.Id,
|
|
model.PERMISSION_SYSCONSOLE_READ_USERMANAGEMENT_SYSTEM_ROLES.Id,
|
|
model.PERMISSION_MANAGE_ROLES.Id,
|
|
}
|
|
|
|
func (api *API) InitRole() {
|
|
api.BaseRoutes.Roles.Handle("/{role_id:[A-Za-z0-9]+}", api.ApiSessionRequiredTrustRequester(getRole)).Methods("GET")
|
|
api.BaseRoutes.Roles.Handle("/name/{role_name:[a-z0-9_]+}", api.ApiSessionRequiredTrustRequester(getRoleByName)).Methods("GET")
|
|
api.BaseRoutes.Roles.Handle("/names", api.ApiSessionRequiredTrustRequester(getRolesByNames)).Methods("POST")
|
|
api.BaseRoutes.Roles.Handle("/{role_id:[A-Za-z0-9]+}/patch", api.ApiSessionRequired(patchRole)).Methods("PUT")
|
|
}
|
|
|
|
func getRole(c *Context, w http.ResponseWriter, r *http.Request) {
|
|
c.RequireRoleId()
|
|
if c.Err != nil {
|
|
return
|
|
}
|
|
|
|
role, err := c.App.GetRole(c.Params.RoleId)
|
|
if err != nil {
|
|
c.Err = err
|
|
return
|
|
}
|
|
|
|
w.Write([]byte(role.ToJson()))
|
|
}
|
|
|
|
func getRoleByName(c *Context, w http.ResponseWriter, r *http.Request) {
|
|
c.RequireRoleName()
|
|
if c.Err != nil {
|
|
return
|
|
}
|
|
|
|
role, err := c.App.GetRoleByName(c.Params.RoleName)
|
|
if err != nil {
|
|
c.Err = err
|
|
return
|
|
}
|
|
|
|
w.Write([]byte(role.ToJson()))
|
|
}
|
|
|
|
func getRolesByNames(c *Context, w http.ResponseWriter, r *http.Request) {
|
|
rolenames := model.ArrayFromJson(r.Body)
|
|
|
|
if len(rolenames) == 0 {
|
|
c.SetInvalidParam("rolenames")
|
|
return
|
|
}
|
|
|
|
cleanedRoleNames, valid := model.CleanRoleNames(rolenames)
|
|
if !valid {
|
|
c.SetInvalidParam("rolename")
|
|
return
|
|
}
|
|
|
|
roles, err := c.App.GetRolesByNames(cleanedRoleNames)
|
|
if err != nil {
|
|
c.Err = err
|
|
return
|
|
}
|
|
|
|
w.Write([]byte(model.RoleListToJson(roles)))
|
|
}
|
|
|
|
func patchRole(c *Context, w http.ResponseWriter, r *http.Request) {
|
|
c.RequireRoleId()
|
|
if c.Err != nil {
|
|
return
|
|
}
|
|
|
|
patch := model.RolePatchFromJson(r.Body)
|
|
if patch == nil {
|
|
c.SetInvalidParam("role")
|
|
return
|
|
}
|
|
|
|
auditRec := c.MakeAuditRecord("patchRole", audit.Fail)
|
|
defer c.LogAuditRec(auditRec)
|
|
|
|
oldRole, err := c.App.GetRole(c.Params.RoleId)
|
|
if err != nil {
|
|
c.Err = err
|
|
return
|
|
}
|
|
auditRec.AddMeta("role", oldRole)
|
|
|
|
// manage_system permission is required to patch system_admin
|
|
requiredPermission := model.PERMISSION_SYSCONSOLE_WRITE_USERMANAGEMENT_PERMISSIONS
|
|
specialProtectedSystemRoles := append(model.NewSystemRoleIDs, model.SYSTEM_ADMIN_ROLE_ID)
|
|
for _, roleID := range specialProtectedSystemRoles {
|
|
if oldRole.Name == roleID {
|
|
requiredPermission = model.PERMISSION_MANAGE_SYSTEM
|
|
}
|
|
}
|
|
if !c.App.SessionHasPermissionTo(*c.App.Session(), requiredPermission) {
|
|
c.SetPermissionError(requiredPermission)
|
|
return
|
|
}
|
|
|
|
isGuest := oldRole.Name == model.SYSTEM_GUEST_ROLE_ID || oldRole.Name == model.TEAM_GUEST_ROLE_ID || oldRole.Name == model.CHANNEL_GUEST_ROLE_ID
|
|
if c.App.Srv().License() == nil && patch.Permissions != nil {
|
|
if isGuest {
|
|
c.Err = model.NewAppError("Api4.PatchRoles", "api.roles.patch_roles.license.error", nil, "", http.StatusNotImplemented)
|
|
return
|
|
}
|
|
|
|
changedPermissions := model.PermissionsChangedByPatch(oldRole, patch)
|
|
for _, permission := range changedPermissions {
|
|
allowed := false
|
|
for _, allowedPermission := range allowedPermissions {
|
|
if permission == allowedPermission {
|
|
allowed = true
|
|
}
|
|
}
|
|
|
|
if !allowed {
|
|
c.Err = model.NewAppError("Api4.PatchRoles", "api.roles.patch_roles.license.error", nil, "", http.StatusNotImplemented)
|
|
return
|
|
}
|
|
}
|
|
}
|
|
|
|
if patch.Permissions != nil {
|
|
deltaPermissions := model.PermissionsChangedByPatch(oldRole, patch)
|
|
|
|
for _, permission := range deltaPermissions {
|
|
notAllowed := false
|
|
for _, notAllowedPermission := range notAllowedPermissions {
|
|
if permission == notAllowedPermission {
|
|
notAllowed = true
|
|
}
|
|
}
|
|
|
|
if notAllowed {
|
|
c.Err = model.NewAppError("Api4.PatchRoles", "api.roles.patch_roles.not_allowed_permission.error", nil, "Cannot add or remove permission: "+permission, http.StatusNotImplemented)
|
|
return
|
|
}
|
|
}
|
|
|
|
ancillaryPermissions := model.AddAncillaryPermissions(*patch.Permissions)
|
|
*patch.Permissions = append(*patch.Permissions, ancillaryPermissions...)
|
|
|
|
*patch.Permissions = model.UniqueStrings(*patch.Permissions)
|
|
}
|
|
|
|
if c.App.Srv().License() != nil && isGuest && !*c.App.Srv().License().Features.GuestAccountsPermissions {
|
|
c.Err = model.NewAppError("Api4.PatchRoles", "api.roles.patch_roles.license.error", nil, "", http.StatusNotImplemented)
|
|
return
|
|
}
|
|
|
|
if oldRole.Name == model.TEAM_ADMIN_ROLE_ID || oldRole.Name == model.CHANNEL_ADMIN_ROLE_ID || oldRole.Name == model.SYSTEM_USER_ROLE_ID || oldRole.Name == model.TEAM_USER_ROLE_ID || oldRole.Name == model.CHANNEL_USER_ROLE_ID || oldRole.Name == model.SYSTEM_GUEST_ROLE_ID || oldRole.Name == model.TEAM_GUEST_ROLE_ID || oldRole.Name == model.CHANNEL_GUEST_ROLE_ID {
|
|
if !c.App.SessionHasPermissionTo(*c.App.Session(), model.PERMISSION_SYSCONSOLE_WRITE_USERMANAGEMENT_PERMISSIONS) {
|
|
c.SetPermissionError(model.PERMISSION_SYSCONSOLE_WRITE_USERMANAGEMENT_PERMISSIONS)
|
|
return
|
|
}
|
|
} else {
|
|
if !c.App.SessionHasPermissionTo(*c.App.Session(), model.PERMISSION_SYSCONSOLE_WRITE_USERMANAGEMENT_SYSTEM_ROLES) {
|
|
c.SetPermissionError(model.PERMISSION_SYSCONSOLE_WRITE_USERMANAGEMENT_SYSTEM_ROLES)
|
|
return
|
|
}
|
|
}
|
|
|
|
role, err := c.App.PatchRole(oldRole, patch)
|
|
if err != nil {
|
|
c.Err = err
|
|
return
|
|
}
|
|
|
|
auditRec.Success()
|
|
auditRec.AddMeta("patch", role)
|
|
c.LogAudit("")
|
|
|
|
w.Write([]byte(role.ToJson()))
|
|
}
|