mirrors/mostlymatter
1
0
Форкнуть 0
Код Задачи Запросы на слияние Действия Пакеты Проекты Релизы Вики Активность
Files
ec56cac42da7c647c8b35714092f52a10c0bef0a
mostlymatter/store/sqlstore
История
Agniva De Sarker ec56cac42d Optimize TotalUnreadMentions (#18789) 
* Optimize TotalUnreadMentions

We avoid joining with the Threads table entirely
as ChannelId is available from Posts table directly.

Also we replace left joins by inner joins.

https://community-daily.mattermost.com/boards/workspace/zyoahc9uapdn3xdptac6jb69ic/285b80a3-257d-41f6-8cf4-ed80ca9d92e5/495cdb4d-c13a-4992-8eb9-80cfee2819a4?c=c9aa17f3-b918-4a78-86aa-01562e418634

Old plan

```
 Finalize Aggregate  (cost=30869.29..30869.30 rows=1 width=32) (actual time=27.216..31.674 rows=1 loops=1)
   ->  Gather  (cost=30869.18..30869.29 rows=1 width=32) (actual time=27.089..31.665 rows=2 loops=1)
         Workers Planned: 1
         Workers Launched: 1
         ->  Partial Aggregate  (cost=29869.18..29869.19 rows=1 width=32) (actual time=18.442..18.445 rows=1 loops=2)
               ->  Nested Loop  (cost=1881.68..29869.11 rows=25 width=8) (actual time=2.052..18.417 rows=72 loops=2)
                     ->  Hash Join  (cost=1881.12..29771.45 rows=25 width=62) (actual time=2.028..17.744 rows=72 loops=2)
                           Hash Cond: ((threads.channelid)::text = (channels.id)::text)
                           ->  Nested Loop  (cost=0.84..27883.40 rows=2963 width=89) (actual time=0.220..15.849 rows=163 loops=2)
                                 ->  Parallel Index Scan using threadmemberships_pkey on threadmemberships  (cost=0.41..7423.65 rows=2963 width=35) (actual time=0.031..3.937 rows=2504 loops=2)
                                       Index Cond: ((userid)::text = 'tc3p1yqw67d8idcp3g98awexqe'::text)
                                       Filter: following
                                 ->  Index Scan using threads_pkey on threads  (cost=0.42..6.91 rows=1 width=54) (actual time=0.004..0.004 rows=0 loops=5007)
                                       Index Cond: ((postid)::text = (threadmemberships.postid)::text)
                           ->  Hash  (cost=1866.60..1866.60 rows=1094 width=27) (actual time=1.763..1.764 rows=1002 loops=2)
                                 Buckets: 2048  Batches: 1  Memory Usage: 74kB
                                 ->  Index Scan using idx_channels_team_id_type on channels  (cost=0.42..1866.60 rows=1094 width=27) (actual time=0.022..1.493 rows=1002 loops=2)
                                       Index Cond: ((teamid)::text = '8ywxyw9ocp8smxrmjzrkqhrdwe'::text)
                     ->  Index Scan using posts_pkey on posts  (cost=0.56..3.91 rows=1 width=27) (actual time=0.009..0.009 rows=1 loops=145)
                           Index Cond: ((id)::text = (threads.postid)::text)
                           Filter: (deleteat = 0)
 Planning Time: 2.415 ms
 Execution Time: 31.798 ms
```

New plan

```
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 Finalize Aggregate  (cost=34717.01..34717.02 rows=1 width=32) (actual time=42.375..48.143 rows=1 loops=1)
   ->  Gather  (cost=34716.89..34717.00 rows=1 width=32) (actual time=42.249..48.117 rows=2 loops=1)
         Workers Planned: 1
         Workers Launched: 1
         ->  Partial Aggregate  (cost=33716.89..33716.90 rows=1 width=32) (actual time=30.960..30.962 rows=1 loops=2)
               ->  Hash Join  (cost=1881.25..33716.83 rows=25 width=8) (actual time=2.438..30.780 rows=1058 loops=2)
                     Hash Cond: ((posts.channelid)::text = (channels.id)::text)
                     ->  Nested Loop  (cost=0.98..31828.77 rows=2963 width=35) (actual time=0.091..27.374 rows=2504 loops=2)
                           ->  Parallel Index Scan using threadmemberships_pkey on threadmemberships  (cost=0.41..6815.65 rows=2963 width=35) (actual time=0.034..4.674 rows=2504 loops=2)
                                 Index Cond: ((userid)::text = 'tc3p1yqw67d8idcp3g98awexqe'::text)
                                 Filter: following
                           ->  Index Scan using posts_pkey on posts  (cost=0.56..8.44 rows=1 width=54) (actual time=0.008..0.008 rows=1 loops=5007)
                                 Index Cond: ((id)::text = (threadmemberships.postid)::text)
                                 Filter: (deleteat = 0)
                     ->  Hash  (cost=1866.60..1866.60 rows=1094 width=27) (actual time=2.289..2.289 rows=1002 loops=2)
                           Buckets: 2048  Batches: 1  Memory Usage: 74kB
                           ->  Index Scan using idx_channels_team_id_type on channels  (cost=0.42..1866.60 rows=1094 width=27) (actual time=0.028..1.927 rows=1002 loops=2)
                                 Index Cond: ((teamid)::text = '8ywxyw9ocp8smxrmjzrkqhrdwe'::text)
```

```release-note
NONE
```

* Bring back coalesce

```release-note
NONE
```
2021-10-29 09:07:10 +05:30
..
adapters_test.go
Using native JSON operations to add thread participants (#18093)
2021-08-12 16:45:03 +02:00
adapters.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
audit_store_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
audit_store.go
Migrate from gorp to sqlx in store/sqlstore/audit_store.go (#18409)
2021-09-20 18:55:36 +05:30
bot_store_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
bot_store.go
Migrating bot store to use sqlx (#18300)
2021-09-02 17:08:11 +02:00
channel_member_history_store_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
channel_member_history_store.go
MM-38624 Migrate ChannelMemberHistoryStore to sqlx (#18496)
2021-10-06 19:50:02 +02:00
channel_store_categories_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
channel_store_categories.go
[MM-28985] Remove pointers to slice (part 1) (#18034)
2021-08-17 11:18:33 +02:00
channel_store_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
channel_store.go
[MM-18946] [MM-26721] [MM-6842] Cross team search+private channel autocomplete (#18468)
2021-10-26 11:30:59 +05:30
cluster_discovery_store_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
cluster_discovery_store.go
Cluster Discovery store sqlx migration (#18605)
2021-10-07 16:50:03 +02:00
command_store_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
command_store.go
Migrate from gorp to sqlx in store/sqlstore/command_store.go (#18728)
2021-10-21 09:57:33 +05:30
command_webhook_store_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
command_webhook_store.go
Migrate from gorp to sqlx in store/sqlstore/command_webhook_store.go (#18517)
2021-10-05 21:22:50 +05:30
compliance_store_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
compliance_store.go
[MM-38996] - Migrate from gorp to sqlx in store/sqlstore/compliance_store.go (#18633)
2021-10-15 20:06:57 +05:30
context_test.go
MM-30882: Fix read-after-write issue for demoting user (#16911)
2021-02-12 19:04:05 +05:30
context.go
Migrating Emoji store to use sqlx (#18301)
2021-09-14 13:46:42 +05:30
emoji_store_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
emoji_store.go
Migrating Emoji store to use sqlx (#18301)
2021-09-14 13:46:42 +05:30
file_info_store_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
file_info_store.go
[GH-18504] Migrate from gorp to sqlx in store/sqlstore/file_info_store.go (#18637)
2021-10-19 19:29:10 +05:30
group_store_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
group_store.go
Migrate from gorp to sqlx in store/sqlstore/group_store.go (#18543)
2021-10-28 20:25:26 +02:00
init_test.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
integrity_test.go
[MM-28985] Remove pointers to slice (part 1) (#18034)
2021-08-17 11:18:33 +02:00
integrity.go
[MM-29217] Remove Posts.ParentId (#17923)
2021-08-17 11:25:22 +03:00
job_store_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
job_store.go
Migrate from gorp to sqlx in store/sqlstore/job_store.go (#18518)
2021-10-19 19:29:24 +05:30
license_store_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
license_store.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
link_metadata_store_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
link_metadata_store.go
[MM-39229] - Migrate from gorp to sqlx in store/sqlstore/link_metadata_store.go (#18702)
2021-10-19 19:49:45 +05:30
main_test.go
MM-36764 mlog refactor (#18118)
2021-08-17 16:08:04 -04:00
oauth_store_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
oauth_store.go
Migrating OAuthStore to sqlx (#18302)
2021-09-13 19:23:58 +05:30
plugin_store_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
plugin_store.go
Migrated from gorp to sqlx in store/sqlstore/plugin_store.go (#18729)
2021-10-21 09:57:49 +05:30
post_store_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
post_store.go
ThreadStore: Remove quadratic complexity for participants population (#18755)
2021-10-28 09:57:54 +05:30
preference_store_test.go
[MM-28985] Remove pointers to slice (part 1) (#18034)
2021-08-17 11:18:33 +02:00
preference_store.go
migrate from gorp to sqlx for Preference store (#18742)
2021-10-26 16:55:27 +02:00
product_notices_store_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
product_notices_store.go
[MM-28985] Remove pointers to slice (part 1) (#18034)
2021-08-17 11:18:33 +02:00
reaction_store_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
reaction_store.go
[MM-39232] Migrate from gorp to sqlx in store/sqlstore/reaction_store.go (#18657)
2021-10-21 09:55:49 +05:30
remote_cluster_store_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
remote_cluster_store.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
retention_policy_store_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
retention_policy_store.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
role_store_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
role_store.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
scheme_store_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
scheme_store.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
session_store_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
session_store.go
[MM-36472] Fix inconsistencies in Roles columns (#18390)
2021-10-01 15:31:29 +02:00
shared_channel_store_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
shared_channel_store.go
MM-38611 getSharedChannels: only return channels user is member of (#18417)
2021-09-20 15:00:47 -04:00
sqlx_wrapper_test.go
Added a sqlXPassThrough layer (#18238)
2021-08-30 10:20:28 +05:30
sqlx_wrapper.go
Migrating bot store to use sqlx (#18300)
2021-09-02 17:08:11 +02:00
status_store_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
status_store.go
[MM-36387] Address db performance audit items (#18078)
2021-08-21 08:05:52 +03:00
store_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
store.go
migrate from gorp to sqlx for Preference store (#18742)
2021-10-26 16:55:27 +02:00
system_store_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
system_store.go
MM-36990: Use upsert for system key update (#18037)
2021-08-03 14:23:47 +05:30
team_store_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
team_store.go
[MM-36472] Fix inconsistencies in Roles columns (#18390)
2021-10-01 15:31:29 +02:00
terms_of_service_store_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
terms_of_service_store.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
thread_store_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
thread_store.go
Optimize TotalUnreadMentions (#18789)
2021-10-29 09:07:10 +05:30
tokens_store.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
upgrade_test.go
[MM-28985] Remove pointers to slice (part 1) (#18034)
2021-08-17 11:18:33 +02:00
upgrade.go
Drop existing default on Users.Timezone prior to column type change (#18669)
2021-10-14 17:18:18 +02:00
upload_session_store_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
upload_session_store.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
user_access_token_store_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
user_access_token_store.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
user_store_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
user_store.go
[MM-36472] Fix inconsistencies in Roles columns (#18390)
2021-10-01 15:31:29 +02:00
user_terms_of_service_store_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
user_terms_of_service.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
utils_test.go
Update channel member notify props to use native JSON (#18114)
2021-08-23 10:04:30 +05:30
utils.go
[MM-39232] Migrate from gorp to sqlx in store/sqlstore/reaction_store.go (#18657)
2021-10-21 09:55:49 +05:30
webhook_store_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
webhook_store.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30