mirrors/mostlymatter
1
0
Форкнуть 0
Код Задачи Запросы на слияние Действия Пакеты Проекты Релизы Вики Активность
Files
e414efac6368bd60837c7fce1006a47974fb4de4
mostlymatter/app
История
Agniva De Sarker 8f9e2669a6 MM-34419: Fix plugin enable race (#17511) 
A race happens when we try to enable plugins
in an HA environment. There is no loss in functionality
here, but it's a timing bug.

There are two bugs here.

The first one is a case of nested config listeners. a.InitPlugins
is called in InitServer, and as well as a config listener. And that
calls a.SyncPluginsActiveState(). But inside a.InitPlugins,
there is yet another config listener which again calls
a.SyncPluginsActiveState(). The first fix is to simply not call
the method again from the nested listener.

The second bug happens because the config changed message is sent
across the cluster only after saving the config locally
in the store. To fix this, we simply change GetPluginStatus
to not fail and return empty status when other nodes don't have plugins
enabled.

https://mattermost.atlassian.net/browse/MM-34419

```release-note
Fix a race condition where enabling plugins would result
in spurious errors in the logs.
```
2021-04-30 07:16:57 -07:00
..
layer_generators
Mm 30807 granular data retention scaffold (#17464)
2021-04-20 13:16:40 -04:00
opentracing
MM-24455: Fix role responses. (#17385)
2021-04-27 18:36:05 +02:00
plugin_api_tests
Fix initialism errors (PR-2) (#17032)
2021-04-03 12:43:22 +05:30
slashcommands
MM-22678 Use more user-friendly errors for channel commands (#17520)
2021-04-28 15:01:44 -04:00
admin.go
[MM-34179] app: move cluster registeration to server creation (#17306)
2021-04-01 11:29:56 +03:00
analytics.go
Mm 30807 granular data retention scaffold (#17464)
2021-04-20 13:16:40 -04:00
app_iface.go
MM-24455: Fix role responses. (#17385)
2021-04-27 18:36:05 +02:00
app_test.go
[MM-32281] SqlRoleStore/GetByName: add context to allow read from master (#17176)
2021-04-21 18:01:02 +03:00
app.go
MM-18818 Prompt admins to set the Support Email (#17296)
2021-04-28 12:05:38 +05:30
audit.go
Moving mlog to corelibs (#16915)
2021-03-05 09:18:37 +01:00
authentication_test.go
goimports (#16640)
2021-01-07 22:42:43 +05:30
authentication.go
MM-27493 Shared channels (MVP) (#17301)
2021-04-01 13:44:56 -04:00
authorization_test.go
Revert "Fix initialism errors (PR-3) (#17062)" (#17202)
2021-03-23 10:32:54 +01:00
authorization.go
[MM-32622] Remove app.WaitForChannelMembership() (#17048)
2021-03-31 09:40:35 +02:00
auto_responder_test.go
MM-31339: Send only one direct message reply within one calendar day. (#17181)
2021-04-22 12:33:45 +08:00
auto_responder.go
MM-31339: Send only one direct message reply within one calendar day. (#17181)
2021-04-22 12:33:45 +08:00
bot_test.go
[MM-34725] app/user: check if username or email is in use before patching a user (#17392)
2021-04-16 23:41:32 +08:00
bot.go
#MM-34893 Completely disabled Admin Advisor (#17422)
2021-04-20 05:43:01 +05:30
brand.go
Add missing wrapped errors (#17339)
2021-04-07 10:44:50 +02:00
busy_test.go
[MM-35077] Add basic support for plugin intra-cluster communication (#17495)
2021-04-28 19:59:32 +02:00
busy.go
MM-31063: Change constants to use CamelCase (#16608)
2021-01-04 11:32:29 +05:30
channel_category_test.go
[MM-32622] Remove app.WaitForChannelMembership() (#17048)
2021-03-31 09:40:35 +02:00
channel_category.go
Revert "Fix initialism errors (PR-3) (#17062)" (#17202)
2021-03-23 10:32:54 +01:00
channel_test.go
[MM-32281] SqlRoleStore/GetByName: add context to allow read from master (#17176)
2021-04-21 18:01:02 +03:00
channel.go
MM-35128 CRT: Global Threads item should not be affected by 'mark as unread' in channel (#17505)
2021-04-27 16:56:06 +03:00
cloud.go
[MM-35039] - Send trial ended email (#17478)
2021-04-23 21:45:47 +03:00
cluster_discovery_test.go
goimports (#16640)
2021-01-07 22:42:43 +05:30
cluster_discovery.go
Moving mlog to corelibs (#16915)
2021-03-05 09:18:37 +01:00
cluster_handlers.go
[MM-35077] Add basic support for plugin intra-cluster communication (#17495)
2021-04-28 19:59:32 +02:00
cluster.go
MM-25154: Fix data race in InvokeClusterLeaderChangedListener (#14610)
2020-05-22 23:52:25 +05:30
command_autocomplete_test.go
MM-27493 Shared channels (MVP) (#17301)
2021-04-01 13:44:56 -04:00
command_autocomplete.go
Moving mlog to corelibs (#16915)
2021-03-05 09:18:37 +01:00
command.go
[MM-32622] Remove app.WaitForChannelMembership() (#17048)
2021-03-31 09:40:35 +02:00
compliance.go
MM-30862: Fix racy test RunComplianceReports (#16377)
2020-11-24 21:36:34 +05:30
config_test.go
Revert "Fix initialism errors (PR-3) (#17062)" (#17202)
2021-03-23 10:32:54 +01:00
config.go
All Sections to SubSections (#16917)
2021-04-06 10:39:48 -04:00
constants.go
MM-31063: Change constants to use CamelCase (#16608)
2021-01-04 11:32:29 +05:30
context.go
[MM-32622] Remove app.WaitForChannelMembership() (#17048)
2021-03-31 09:40:35 +02:00
data_retention.go
Mm 30807 granular data retention scaffold (#17464)
2021-04-20 13:16:40 -04:00
download_test.go
goimports (#16640)
2021-01-07 22:42:43 +05:30
download.go
goimports (#16640)
2021-01-07 22:42:43 +05:30
email_batching_test.go
[MM-32622] Remove app.WaitForChannelMembership() (#17048)
2021-03-31 09:40:35 +02:00
email_batching.go
Extracting html templates into a library (#16946)
2021-03-12 18:46:43 +01:00
email_test.go
Extracting mail service into shared libs (#17030)
2021-03-15 11:50:13 +01:00
email.go
[MM-35039] - Send trial ended email (#17478)
2021-04-23 21:45:47 +03:00
emoji.go
Add missing wrapped errors (#17339)
2021-04-07 10:44:50 +02:00
enterprise_test.go
goimports (#16640)
2021-01-07 22:42:43 +05:30
enterprise.go
[MM-32639] - Resend user invite emails (#17113)
2021-03-31 13:20:53 -04:00
expirynotify_test.go
[Partial Fix #16623]: Fix initialism errors in codebase. (#16979)
2021-02-25 20:22:27 +01:00
expirynotify.go
Moving mlog to corelibs (#16915)
2021-03-05 09:18:37 +01:00
export_converters.go
add support for exporting and importing props (#14034)
2020-03-23 09:21:05 -04:00
export_test.go
[MM-34216] app/import: do not break import process if a dm channel is invalid (#17391)
2021-04-22 12:42:22 +03:00
export.go
[MM-34216] app/import: do not break import process if a dm channel is invalid (#17391)
2021-04-22 12:42:22 +03:00
extract_plugin_tar_test.go
MM-21915: improve tar gz path traversal (#13675)
2020-01-27 11:33:11 -05:00
extract_plugin_tar.go
Moving mlog to corelibs (#16915)
2021-03-05 09:18:37 +01:00
feature_flags.go
Moving mlog to corelibs (#16915)
2021-03-05 09:18:37 +01:00
file_bench_test.go
Revert "Fix initialism errors (PR-3) (#17062)" (#17202)
2021-03-23 10:32:54 +01:00
file_test.go
Bump golangci version to v1.38.0 (#17154)
2021-04-28 16:43:41 +02:00
file.go
[MM-33826] add more detailed S3 error messages (#17182)
2021-04-09 18:16:30 +02:00
group_test.go
Bump golangci version to v1.38.0 (#17154)
2021-04-28 16:43:41 +02:00
group.go
Revert "Fix initialism errors (PR-3) (#17062)" (#17202)
2021-03-23 10:32:54 +01:00
helper_test.go
MM-31339: Send only one direct message reply within one calendar day. (#17181)
2021-04-22 12:33:45 +08:00
image.go
[MM-28638] Improve image thumbnail generation logic (#15534)
2020-10-09 08:47:20 +02:00
import_functions_test.go
Bump golangci version to v1.38.0 (#17154)
2021-04-28 16:43:41 +02:00
import_functions.go
[MM-32281] SqlRoleStore/GetByName: add context to allow read from master (#17176)
2021-04-21 18:01:02 +03:00
import_test.go
[MM-34216] app/import: do not break import process if a dm channel is invalid (#17391)
2021-04-22 12:42:22 +03:00
import_types.go
goimports (#16640)
2021-01-07 22:42:43 +05:30
import_utils_test.go
[MM-33794] Improve password generation during bulk import (#17147)
2021-03-24 10:32:16 +01:00
import_utils.go
[MM-33794] Improve password generation during bulk import (#17147)
2021-03-24 10:32:16 +01:00
import_validators_test.go
goimports (#16640)
2021-01-07 22:42:43 +05:30
import_validators.go
Fix empty string comparison issues in the codebase (#16686)
2021-01-25 11:15:17 +01:00
import.go
[MM-34216] app/import: do not break import process if a dm channel is invalid (#17391)
2021-04-22 12:42:22 +03:00
integration_action_test.go
MM-27493 Shared channels (MVP) (#17301)
2021-04-01 13:44:56 -04:00
integration_action.go
MM-27493 Shared channels (MVP) (#17301)
2021-04-01 13:44:56 -04:00
job_test.go
[MM-32281] SqlRoleStore/GetByName: add context to allow read from master (#17176)
2021-04-21 18:01:02 +03:00
job.go
All Sections to SubSections (#16917)
2021-04-06 10:39:48 -04:00
ldap.go
Moving mlog to corelibs (#16915)
2021-03-05 09:18:37 +01:00
license_test.go
goimports (#16640)
2021-01-07 22:42:43 +05:30
license.go
[MM-32822] Improve JobServer state handling (#16959)
2021-03-26 10:32:16 +01:00
login_test.go
Replacing require.nil in app layer (#16905)
2021-02-16 12:00:01 +01:00
login.go
Moving mlog to corelibs (#16915)
2021-03-05 09:18:37 +01:00
main_test.go
[MM-31094] Replication Lag (#16888)
2021-03-12 12:37:30 -05:00
migrations.go
Add migration to set the ExtractContent settings to true by default (#17545)
2021-04-30 12:26:03 +02:00
notification_email_test.go
Extracting html templates into a library (#16946)
2021-03-12 18:46:43 +01:00
notification_email.go
Extracting html templates into a library (#16946)
2021-03-12 18:46:43 +01:00
notification_push_test.go
Extracting i18n functionality to i18n core library (#16914)
2021-02-26 08:12:49 +01:00
notification_push.go
Moving mlog to corelibs (#16915)
2021-03-05 09:18:37 +01:00
notification_test.go
MM-34002: Improve AddUserToChannel (#17174)
2021-04-02 14:33:23 +05:30
notification.go
MM-35300 CRT: No mention badge on Threads when user is mentioned in both the root post and a reply post (#17541)
2021-04-29 13:59:38 +03:00
oauth_test.go
Replacing require.nil in app layer (#16905)
2021-02-16 12:00:01 +01:00
oauth.go
Add missing wrapped errors (#17339)
2021-04-07 10:44:50 +02:00
opengraph_test.go
Replacing require.nil in app layer (#16905)
2021-02-16 12:00:01 +01:00
opengraph.go
Moving mlog to corelibs (#16915)
2021-03-05 09:18:37 +01:00
options.go
[MM-32822] Improve JobServer state handling (#16959)
2021-03-26 10:32:16 +01:00
permissions_migrations_test.go
goimports (#16640)
2021-01-07 22:42:43 +05:30
permissions_migrations.go
MM-24455: Fix role responses. (#17385)
2021-04-27 18:36:05 +02:00
permissions_test.go
[MM-32281] SqlRoleStore/GetByName: add context to allow read from master (#17176)
2021-04-21 18:01:02 +03:00
permissions.go
[MM-32281] SqlRoleStore/GetByName: add context to allow read from master (#17176)
2021-04-21 18:01:02 +03:00
plugin_api_test.go
[MM-34919] Use Mattermost-Plugin-ID header to pass ID in inter-plugin requests (#17418)
2021-04-19 14:02:00 +02:00
plugin_api.go
[MM-35077] Add basic support for plugin intra-cluster communication (#17495)
2021-04-28 19:59:32 +02:00
plugin_commands_test.go
Extracting i18n functionality to i18n core library (#16914)
2021-02-26 08:12:49 +01:00
plugin_commands.go
[Partial Fix #16623]: Fix initialism errors in codebase. (#16979)
2021-02-25 20:22:27 +01:00
plugin_context.go
goimports (#16640)
2021-01-07 22:42:43 +05:30
plugin_deadlock_test.go
[MM-21378] Add mutex to model.Post to guard against race conditions on Post.Props (#13884)
2020-03-13 21:12:20 +01:00
plugin_event.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
plugin_health_check_test.go
Replacing require.nil in app layer (#16905)
2021-02-16 12:00:01 +01:00
plugin_hooks_test.go
MM-27493 Shared channels (MVP) (#17301)
2021-04-01 13:44:56 -04:00
plugin_install_test.go
Replacing require.nil in app layer (#16905)
2021-02-16 12:00:01 +01:00
plugin_install.go
Add feature flag for apps (#16851)
2021-03-29 15:53:31 +02:00
plugin_key_value_store.go
Moving mlog to corelibs (#16915)
2021-03-05 09:18:37 +01:00
plugin_public_keys.go
[MM-20309] production public key (#13244)
2019-12-05 23:41:52 +04:00
plugin_requests_test.go
Save access on plugin env during ServePluginPublicRequest (#16854)
2021-02-17 12:23:30 +02:00
plugin_requests.go
[MM-34919] Use Mattermost-Plugin-ID header to pass ID in inter-plugin requests (#17418)
2021-04-19 14:02:00 +02:00
plugin_shutdown_test.go
MM-26750: Remove instances of InitBasic when it's not required (#14984)
2020-07-13 19:34:05 +02:00
plugin_signature_test.go
Replacing require.nil in app layer (#16905)
2021-02-16 12:00:01 +01:00
plugin_signature.go
Moving mlog to corelibs (#16915)
2021-03-05 09:18:37 +01:00
plugin_statuses.go
Fix GetPluginStatus in a non-cluster environment (#15363)
2020-09-22 10:57:08 +02:00
plugin_test.go
Moving mlog to corelibs (#16915)
2021-03-05 09:18:37 +01:00
plugin.go
MM-34419: Fix plugin enable race (#17511)
2021-04-30 07:16:57 -07:00
post_metadata_test.go
MM-29726 Allow disabling link previews from certain domains (#16869)
2021-03-09 12:54:54 -05:00
post_metadata.go
[MM-31899] Use a custom user-agent when previewing links (#17186)
2021-04-12 09:30:48 -04:00
post_test.go
Bump golangci version to v1.38.0 (#17154)
2021-04-28 16:43:41 +02:00
post.go
Bump golangci version to v1.38.0 (#17154)
2021-04-28 16:43:41 +02:00
preference.go
Fix initialisms/app (#16818)
2021-02-05 11:22:27 +01:00
product_notices_test.go
[MM-32665] app/product_notices: support notice for deprecating elasticsearch (#16966)
2021-02-23 13:38:50 +03:00
product_notices.go
Moving mlog to corelibs (#16915)
2021-03-05 09:18:37 +01:00
ratelimit_test.go
goimports (#16640)
2021-01-07 22:42:43 +05:30
ratelimit.go
Moving mlog to corelibs (#16915)
2021-03-05 09:18:37 +01:00
reaction_test.go
MM-27493 Shared channels (MVP) (#17301)
2021-04-01 13:44:56 -04:00
reaction.go
[Partial Fix #16623]: Fix initialism errors in codebase. (#16979)
2021-02-25 20:22:27 +01:00
remote_cluster_service_mock.go
MM-32133 shared channel username collisions (#17347)
2021-04-13 10:40:12 -04:00
remote_cluster_test.go
MM-32133 shared channel username collisions (#17347)
2021-04-13 10:40:12 -04:00
remote_cluster.go
MM-27493 Shared channels (MVP) (#17301)
2021-04-01 13:44:56 -04:00
response_transfer.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
role_test.go
MM-24455: Fix role responses. (#17385)
2021-04-27 18:36:05 +02:00
role.go
MM-24455: Fix role responses. (#17385)
2021-04-27 18:36:05 +02:00
saml.go
[MM-32044] Reset SAML auth data (#17161)
2021-04-13 00:46:30 +02:00
scheme.go
ChannelStore migration Part 3 (#15504)
2020-10-04 10:12:29 +05:30
searchengine.go
MM-27169: Remove uneeded fields from App (#15408)
2020-09-16 21:46:44 +05:30
security_update_check.go
Mm 30807 granular data retention scaffold (#17464)
2021-04-20 13:16:40 -04:00
server_license.go
goimports (#16640)
2021-01-07 22:42:43 +05:30
server_test.go
MM-18818 Prompt admins to set the Support Email (#17296)
2021-04-28 12:05:38 +05:30
server.go
MM-18818 Prompt admins to set the Support Email (#17296)
2021-04-28 12:05:38 +05:30
session_test.go
MM-32133 shared channel username collisions (#17347)
2021-04-13 10:40:12 -04:00
session.go
MM-27493 Shared channels (MVP) (#17301)
2021-04-01 13:44:56 -04:00
shared_channel_notifier_test.go
MM-27493 Shared channels (MVP) (#17301)
2021-04-01 13:44:56 -04:00
shared_channel_notifier.go
MM-27493 Shared channels (MVP) (#17301)
2021-04-01 13:44:56 -04:00
shared_channel_service_iface.go
MM-27493 Shared channels (MVP) (#17301)
2021-04-01 13:44:56 -04:00
shared_channel_test.go
MM-27493 Shared channels (MVP) (#17301)
2021-04-01 13:44:56 -04:00
shared_channel.go
MM-34549 shared channels; add users to channel that were already sync'd (#17361)
2021-04-14 14:59:26 -04:00
slack_test.go
Fix initialisms/app (#16818)
2021-02-05 11:22:27 +01:00
slack.go
MM-30882: Fix read-after-write issue for demoting user (#16911)
2021-02-12 19:04:05 +05:30
status_test.go
goimports (#16640)
2021-01-07 22:42:43 +05:30
status.go
Moving mlog to corelibs (#16915)
2021-03-05 09:18:37 +01:00
svg_test.go
unparam lint (#16927)
2021-03-16 12:48:20 +05:30
svg.go
Fix empty string comparison issues in the codebase (#16686)
2021-01-25 11:15:17 +01:00
syncables_test.go
MM-34002: Improve AddUserToChannel (#17174)
2021-04-02 14:33:23 +05:30
syncables.go
MM-34002: Improve AddUserToChannel (#17174)
2021-04-02 14:33:23 +05:30
team_test.go
MM-33913: Fix read-after-write issues with team member (#17173)
2021-04-02 13:20:58 +05:30
team.go
MM-33601: Invalidate team member cache when updating a team scheme. (#17384)
2021-04-29 15:19:57 -04:00
terms_of_service.go
Fix initialisms/app (#16818)
2021-02-05 11:22:27 +01:00
upload_test.go
Replacing require.nil in app layer (#16905)
2021-02-16 12:00:01 +01:00
upload.go
Improve document extraction and including a document extraction command (#17183)
2021-04-07 13:27:20 +02:00
user_agent_test.go
[MM-22167] Add mmctl to the User-Agent parser (#13894)
2020-03-19 11:18:17 +01:00
user_agent.go
[MM-22167] Add mmctl to the User-Agent parser (#13894)
2020-03-19 11:18:17 +01:00
user_terms_of_service_test.go
Migration of UserTermsOfServiceStore to return plain errors (#14788)
2020-06-19 17:49:30 +05:30
user_terms_of_service.go
Fix initialisms/app (#16818)
2021-02-05 11:22:27 +01:00
user_test.go
[MM-32281] SqlRoleStore/GetByName: add context to allow read from master (#17176)
2021-04-21 18:01:02 +03:00
user_viewmembers_test.go
goimports (#16640)
2021-01-07 22:42:43 +05:30
user.go
MM-34871 CRT: Participants of thread include non-replying followers (and past followers) (#17447)
2021-04-21 09:48:30 +03:00
web_conn_test.go
MM-32950: Reliable WebSockets: Basic single server (#17406)
2021-04-26 19:51:25 +05:30
web_conn.go
MM-34878: Add metrics for websocket reconnects (#17522)
2021-04-29 19:42:48 +05:30
web_hub_test.go
MM-35239: Fix racy test HubSessionRevokeRace (#17534)
2021-04-28 11:36:05 +02:00
web_hub.go
MM-32950: Reliable WebSockets: Basic single server (#17406)
2021-04-26 19:51:25 +05:30
webhook_test.go
Replacing require.nil in app layer (#16905)
2021-02-16 12:00:01 +01:00
webhook.go
Moving mlog to corelibs (#16915)
2021-03-05 09:18:37 +01:00
webhub_fuzz.go
Extracting i18n functionality to i18n core library (#16914)
2021-02-26 08:12:49 +01:00
websocket_router.go
MM-34389: Reliable websockets: First commit (#17297)
2021-03-31 10:05:32 +05:30