mostlymatter

Files

Christopher Poile 8bd182c38f MM-14145: The config store Set will now Save automatically (#10377 )

* MM-14145: The config store Set will now Save automatically

When UpdateConfig (and configStore.Set) is called in admin.go and
config.go, commonStore.Set now takes a store-specific persist function.
It uses that persist function to save the configuration automatically.

Removed: Now callers do not have to call configStore.Save or
app.PersistConfig, and those functions have been removed.

Possible downside: this means a "failed to persist config" error can now
be thrown during a app.UpdateConfig or commonStore.Set call. But
considering application code never really sets a config without saving
it (except in the test cases, which were testing that -- see below), it
seems fine to group these responsibilities.

Also removed: tests for 'set without save'. Since that can not happen
anymore, the tests are not needed.

* Removed Save completely, cleaned up formatting, joined save test with
set tests.

* fixed shadowed variable error

2019-02-28 10:51:42 -05:00

admin.go

MM-14145: The config store Set will now Save automatically (#10377 )

2019-02-28 10:51:42 -05:00

analytics.go

Fix shadowed variables in app package: Part 1 of 3 (#10000 )

2019-01-25 17:40:56 +01:00

app_test.go

[MM-13828] Initialize tests in each package with a new temp folder with all test resources (#10261 )

2019-02-19 09:20:11 -05:00

app.go

Enable PluginJobs (#10198 )

2019-02-06 08:25:07 +01:00

audit.go

Migrate to idiomatic error handling app/a*.go and app/b*.go (#9455 )

2018-09-25 08:42:06 -04:00

authentication_test.go

User based rate limiting (#8152 )

2018-01-31 09:49:15 -08:00

authentication.go

MM-14039 Improving password lockout functionality. (#10254 )

2019-02-12 07:56:41 -08:00

authorization_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

authorization.go

MM-12013: Fix post-permission checks to cascade for DM/GM channels. (#9476 )

2018-09-27 12:15:47 -07:00

auto_channels.go

MM-8708 Remove api package (#8784 )

2018-05-16 13:43:22 -04:00

auto_constants.go

general cleanup (#8387 )

2018-03-07 12:36:40 -06:00

auto_environment.go

MM-8708 Remove api package (#8784 )

2018-05-16 13:43:22 -04:00

auto_posts.go

Cleanup related to context refactor (#9988 )

2018-12-17 08:51:46 -08:00

auto_responder_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

auto_responder.go

Use constants for NotifyProps keys. (#9901 )

2018-11-28 11:11:41 -05:00

auto_teams.go

MM-8708 Remove api package (#8784 )

2018-05-16 13:43:22 -04:00

auto_users.go

[MM-13840] Change eMail as a post-verification action (#10253 )

2019-02-20 15:50:52 +01:00

brand.go

Add a delete brand image action on the APIv4 (#9552 )

2018-10-15 15:46:26 +01:00

channel_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

channel.go

[MM-13746] Add GetTeamMembersForUser and GetChannelMembersForUser apis (#10269 )

2019-02-23 11:41:19 -08:00

cluster_discovery_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

cluster_discovery.go

Idiomatic error handling for app/c*.go (#9423 )

2018-09-24 13:27:31 +02:00

cluster_handlers.go

remove remaining Global() calls (outside of tests) (#7521 )

2017-09-28 00:52:34 +08:00

cluster.go

Migrate cluster to use Server struct directly. (#10101 )

2019-01-15 09:09:25 -08:00

command_away.go

more global config ref cleanup (#7802 )

2017-11-09 14:46:20 -06:00

command_channel_header_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

command_channel_header.go

Fix shadowed variables in app package: Part 2 of 3 (#10001 )

2019-01-25 17:33:21 +01:00

command_channel_purpose_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

command_channel_purpose.go

MM-11230: Make permissions checks in commands failsafe. (#9392 )

2018-09-12 10:32:05 -04:00

command_channel_rename_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

command_channel_rename.go

MM-11230: Make permissions checks in commands failsafe. (#9392 )

2018-09-12 10:32:05 -04:00

command_code_test.go

remove more global references (#7442 )

2017-09-14 13:01:44 -04:00

command_code.go

more global config ref cleanup (#7802 )

2017-11-09 14:46:20 -06:00

command_dnd.go

MM-10254 Add plugin APIs for getting/updating user statuses (#9101 )

2018-07-16 15:49:26 -04:00

command_echo.go

MM-12849 Moving all non request scoped items to Server struct (#9806 )

2018-11-07 10:20:07 -08:00

command_expand_collapse.go

remove go Publish(...) idiom (#8373 )

2018-03-02 16:49:18 +00:00

command_groupmsg_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

command_groupmsg.go

MM-11227: Fix group msg slash command. (#9070 )

2018-07-10 10:54:49 +02:00

command_help.go

more global config ref cleanup (#7802 )

2017-11-09 14:46:20 -06:00

command_invite_people_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

command_invite_people.go

MM-10658 Change config fields to pointers (#9033 )

2019-01-31 08:12:01 -05:00

command_invite_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

command_invite.go

MM-12110: Don't /invite or /kick deactivated users. (#9494 )

2018-10-01 13:51:12 +01:00

command_join_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

command_join.go

MM-11230: Make permissions checks in commands failsafe. (#9392 )

2018-09-12 10:32:05 -04:00

command_leave_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

command_leave.go

[MM-12805] Remove ephemeral post after leaving a channel (#9772 )

2018-11-05 17:39:46 +08:00

command_loadtest.go

MM-10658 Change config fields to pointers (#9033 )

2019-01-31 08:12:01 -05:00

command_logout.go

more global config ref cleanup (#7802 )

2017-11-09 14:46:20 -06:00

command_me.go

more global config ref cleanup (#7802 )

2017-11-09 14:46:20 -06:00

command_msg_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

command_msg.go

Refactor Get/Create Direct Channel into one function (#9867 )

2018-11-28 18:01:49 +01:00

command_mute_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

command_mute.go

Fix mute channel when not a member and adding unit tests (#8609 )

2018-04-12 09:12:59 -04:00

command_offline.go

more global config ref cleanup (#7802 )

2017-11-09 14:46:20 -06:00

command_online.go

MM-10254 Add plugin APIs for getting/updating user statuses (#9101 )

2018-07-16 15:49:26 -04:00

command_open.go

more global config ref cleanup (#7802 )

2017-11-09 14:46:20 -06:00

command_remove_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

command_remove.go

MM-12110: Don't /invite or /kick deactivated users. (#9494 )

2018-10-01 13:51:12 +01:00

command_search.go

more global config ref cleanup (#7802 )

2017-11-09 14:46:20 -06:00

command_settings.go

more global config ref cleanup (#7802 )

2017-11-09 14:46:20 -06:00

command_shortcuts.go

more global config ref cleanup (#7802 )

2017-11-09 14:46:20 -06:00

command_shrug.go

more global config ref cleanup (#7802 )

2017-11-09 14:46:20 -06:00

command_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

command.go

MM-10658 Change config fields to pointers (#9033 )

2019-01-31 08:12:01 -05:00

compliance.go

MM-12849 Moving all non request scoped items to Server struct (#9806 )

2018-11-07 10:20:07 -08:00

config_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

config.go

MM-14145: The config store Set will now Save automatically (#10377 )

2019-02-28 10:51:42 -05:00

data_retention.go

PLT-7705: API to get data retention policy. (#7539 )

2017-10-02 12:43:21 +01:00

diagnostics_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

diagnostics.go

deprecate timezones.json (#10311 )

2019-02-25 12:07:45 -04:00

elasticsearch.go

Idiomatic error handling for app/e*.go (#9426 )

2018-09-24 12:52:29 +05:30

email_batching_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

email_batching.go

Moving app from singular to being created for every request (#9889 )

2018-11-28 10:56:21 -08:00

email.go

[MM-13840] Change eMail as a post-verification action (#10253 )

2019-02-20 15:50:52 +01:00

emoji.go

MM-13893: introduce file store (#10243 )

2019-02-12 10:19:01 -08:00

enterprise.go

einterfaces: simply saml.ConfigureSP error handling (#10306 )

2019-02-21 09:51:25 -08:00

export_converters.go

[MM 12458] Include user preferences in bulk export (#9784 )

2019-02-01 11:43:41 +00:00

export_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

export.go

[MM 12458] Include user preferences in bulk export (#9784 )

2019-02-01 11:43:41 +00:00

file_bench_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

file_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

file.go

[MM-13158] Initial attempt at extracting SVG dimensions (#10332 )

2019-02-27 14:06:56 -05:00

group_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

group.go

Ldap groups phase1 (#9752 )

2019-01-10 15:17:31 -05:00

helper_test.go

[MM-13828] Initialize tests in each package with a new temp folder with all test resources (#10261 )

2019-02-19 09:20:11 -05:00

import_functions_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

import_functions.go

[MM-13840] Change eMail as a post-verification action (#10253 )

2019-02-20 15:50:52 +01:00

import_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

import_types.go

[MM 12458] Include user preferences in bulk export (#9784 )

2019-02-01 11:43:41 +00:00

import_validators_test.go

Cleanup related to context refactor (#9988 )

2018-12-17 08:51:46 -08:00

import_validators.go

MM-12670: Accept and use "" for user/pass AuthService in import/export. (#9689 )

2018-10-18 14:32:36 +01:00

import.go

Idiomatic error handling for app/import*.go (#9473 )

2018-09-27 18:55:07 +02:00

integration_action_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

integration_action.go

Add authorization header to request from post action to plugin (#10165 )

2019-02-09 05:22:22 -08:00

job_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

job.go

MM-12849 Moving all non request scoped items to Server struct (#9806 )

2018-11-07 10:20:07 -08:00

ldap.go

Ldap groups phase1 (#9752 )

2019-01-10 15:17:31 -05:00

license_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

license.go

MM-13873: Fix race condition on filesystem licence load (#10196 )

2019-01-29 07:57:38 -08:00

login_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

[MM-13610] Fix Login Hooks for SAML (#10288 )

2019-02-20 18:04:50 +01:00

main_test.go

[MM-13828] Initialize tests in each package with a new temp folder with all test resources (#10261 )

2019-02-19 09:20:11 -05:00

migrations.go

Moving app level migrations to its own file (#9871 )

2018-11-23 09:39:33 -08:00

notification_email_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

notification_email.go

MM-10658 Change config fields to pointers (#9033 )

2019-01-31 08:12:01 -05:00

notification_push_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

notification_push.go

MM-10658 Change config fields to pointers (#9033 )

2019-01-31 08:12:01 -05:00

notification_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

notification.go

MM-10658 Change config fields to pointers (#9033 )

2019-01-31 08:12:01 -05:00

oauth_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

oauth.go

[MM-13610] Fix Login Hooks for SAML (#10288 )

2019-02-20 18:04:50 +01:00

opengraph_test.go

MM-12648: Properly unescape OpenGraph metadata containing HTML entities. (#9891 )

2018-11-28 10:58:12 +00:00

opengraph.go

[MM-13889] Limit OpenGraph data response size (#10213 )

2019-02-01 18:55:43 +01:00

options.go

MM-11262: database config store (#10281 )

2019-02-15 10:05:29 -04:00

permissions_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

permissions.go

add megacheck as makefile target (#9288 )

2018-09-03 14:08:40 +02:00

plugin_api_test.go

[MM-13746] Add GetTeamMembersForUser and GetChannelMembersForUser apis (#10269 )

2019-02-23 11:41:19 -08:00

plugin_api.go

[MM-13746] Add GetTeamMembersForUser and GetChannelMembersForUser apis (#10269 )

2019-02-23 11:41:19 -08:00

plugin_commands_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

plugin_commands.go

MM-13606 Remove consumeAndClose and clean up integration response handling (#10066 )

2019-01-09 17:07:08 -05:00

plugin_context.go

MM-12855 Plugin Context (#9922 )

2018-12-05 10:46:08 -08:00

plugin_deadlock_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

plugin_hooks_test.go

[MM-13610] Fix Login Hooks for SAML (#10288 )

2019-02-20 18:04:50 +01:00

plugin_install.go

Fix shadowed variables in app package: Part 1 of 3 (#10000 )

2019-01-25 17:40:56 +01:00

plugin_key_value_store.go

fix two page, perPage -> offset, limit mistranslations (#9904 )

2018-11-29 13:02:06 -05:00

plugin_requests.go

Make CSRF Logging less verbose if not enforced (#10279 )

2019-02-20 15:21:19 +01:00

plugin_statuses.go

MM-12974: guard app plugins with mutex (#9818 )

2018-11-20 08:52:51 -05:00

plugin_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

plugin.go

Unregistering plugin commands on disabling of plugin. (#10086 )

2019-01-10 15:52:10 -05:00

post_metadata_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

post_metadata.go

MM-13997 Prioritize images over OpenGraph metadata when requesting metadata (#10241 )

2019-02-09 10:44:38 +01:00

post_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

post.go

Logs the errors when indexing and deleting posts with elasticsearch (#10282 )

2019-02-13 16:17:59 +01:00

preference.go

Migrate to idiomatic error handling in app/preference.go (#9594 )

2018-10-18 17:15:30 +01:00

ratelimit_test.go

handle RateLimiter initialization errors (#8199 )

2018-02-05 23:27:34 -06:00

ratelimit.go

MM-10934 Update server dependencies. (#8981 )

2018-06-21 16:10:40 -04:00

reaction.go

MM-13664 Cache external link metadata when populating post metadata (#10128 )

2019-01-28 16:25:08 +01:00

role.go

MM-12849 Moving all non request scoped items to Server struct (#9806 )

2018-11-07 10:20:07 -08:00

saml.go

MM-14145: The config store Set will now Save automatically (#10377 )

2019-02-28 10:51:42 -05:00

scheme.go

MM-12849 Moving all non request scoped items to Server struct (#9806 )

2018-11-07 10:20:07 -08:00

security_update_check.go

MM-13606 Remove consumeAndClose and clean up integration response handling (#10066 )

2019-01-09 17:07:08 -05:00

server_app_adapters.go

Fixing plugin API not having proper access to Cluster. (#10257 )

2019-02-08 18:13:52 -08:00

server_license.go

Cleanup related to context refactor (#9988 )

2018-12-17 08:51:46 -08:00

server_test.go

MM-13893: introduce file store (#10243 )

2019-02-12 10:19:01 -08:00

server.go

deprecate timezones.json (#10311 )

2019-02-25 12:07:45 -04:00

session_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

session.go

MM-12849 Moving all non request scoped items to Server struct (#9806 )

2018-11-07 10:20:07 -08:00

slack_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

slack.go

PLT-7824 Added support for mentions with <@userid> and <!here> (#7615 ) (#7737 )

2017-11-17 11:17:59 -05:00

slackimport_test.go

[MM-13828] Initialize tests in each package with a new temp folder with all test resources (#10261 )

2019-02-19 09:20:11 -05:00

slackimport.go

[MM-13840] Change eMail as a post-verification action (#10253 )

2019-02-20 15:50:52 +01:00

status_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

status.go

[MM-12537] Migrate to idiomatic error handling the file app/status.go in the mattermost-server (#9574 ) (#9589 )

2018-10-14 16:24:06 +01:00

svg_test.go

[MM-13158] Initial attempt at extracting SVG dimensions (#10332 )

2019-02-27 14:06:56 -05:00

svg.go

[MM-13158] Initial attempt at extracting SVG dimensions (#10332 )

2019-02-27 14:06:56 -05:00

syncables_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

syncables.go

Ldap groups phase1 (#9752 )

2019-01-10 15:17:31 -05:00

team_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

team.go

[MM-13746] Add GetTeamMembersForUser and GetChannelMembersForUser apis (#10269 )

2019-02-23 11:41:19 -08:00

terms_of_service.go

Refactored to rename "service terms" to "terms of service" (#9581 )

2018-10-09 20:55:47 -04:00

user_agent_test.go

MM-10495 Updated user agent detection to match output of previous library (#8748 )

2018-05-09 12:25:03 -04:00

user_agent.go

[MM-12536] Migrate to idiomatic error handling the file app/user_agent.go in the mattermost-server (#9575 ) (#9576 )

2018-10-15 20:01:35 +01:00

user_terms_of_service_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

user_terms_of_service.go

#146 Terms of Service Phase 2 (#9731 )

2018-11-08 15:48:14 -05:00

user_test.go

Invalidate password recovery tokens on eMail change (#10302 )

2019-02-21 00:48:28 +01:00

user.go

Invalidate password recovery tokens on eMail change (#10302 )

2019-02-21 00:48:28 +01:00

web_conn_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

web_conn.go

Webhub race condition (#9863 )

2018-11-22 10:53:44 +01:00

web_hub_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

web_hub.go

MM-13678: fix web hub deadlock (#10081 )

2019-01-09 10:14:08 -08:00

webhook_test.go

[MM-13833] Configured unit tests to log through t.Log (#10272 )

2019-02-14 13:52:11 -04:00

webhook.go

MM-10658 Change config fields to pointers (#9033 )

2019-01-31 08:12:01 -05:00

websocket_router.go

MM-12849 Moving all non request scoped items to Server struct (#9806 )

2018-11-07 10:20:07 -08:00