e39b485c4b
If the store fails to initialize (e.g. run a migration), it would `log.Fatal` and then `os.Exit`. Unfortunately, this trips up `TestMain`, which happily keeps running tests, now guaranteed to fail. Avoid this by instead returning an error from the store initialization, handling appropriately at the layer above.
48 строки
1.4 KiB
Go
48 строки
1.4 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package searchlayer_test
|
|
|
|
import (
|
|
"os"
|
|
"sync"
|
|
"testing"
|
|
|
|
"github.com/mattermost/mattermost/server/public/model"
|
|
"github.com/mattermost/mattermost/server/v8/channels/store/searchlayer"
|
|
"github.com/mattermost/mattermost/server/v8/channels/store/sqlstore"
|
|
"github.com/mattermost/mattermost/server/v8/channels/store/storetest"
|
|
"github.com/mattermost/mattermost/server/v8/channels/testlib"
|
|
"github.com/mattermost/mattermost/server/v8/platform/services/searchengine"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
// Test to verify race condition on UpdateConfig. The test must run with -race flag in order to verify
|
|
// that there is no race. Ref: (#MM-30868)
|
|
func TestUpdateConfigRace(t *testing.T) {
|
|
driverName := os.Getenv("MM_SQLSETTINGS_DRIVERNAME")
|
|
if driverName == "" {
|
|
driverName = model.DatabaseDriverPostgres
|
|
}
|
|
settings := storetest.MakeSqlSettings(driverName, false)
|
|
store, err := sqlstore.New(*settings, nil)
|
|
require.NoError(t, err)
|
|
|
|
cfg := &model.Config{}
|
|
cfg.SetDefaults()
|
|
cfg.ClusterSettings.MaxIdleConns = model.NewInt(1)
|
|
searchEngine := searchengine.NewBroker(cfg)
|
|
layer := searchlayer.NewSearchLayer(&testlib.TestStore{Store: store}, searchEngine, cfg)
|
|
var wg sync.WaitGroup
|
|
|
|
wg.Add(5)
|
|
for i := 0; i < 5; i++ {
|
|
go func() {
|
|
defer wg.Done()
|
|
layer.UpdateConfig(cfg.Clone())
|
|
}()
|
|
}
|
|
|
|
wg.Wait()
|
|
}
|