* Audit logging - new schema added, old schema removed. * fix linter error by running goimports * Address review comments * Address review comments * Example usage of new audit logging API for the updateUserAuth call * fixed unit test on auditing updating user record * Changed the `TestUpdateConfigDiffInAuditRecord` testcase---it failed, because this PR changes how the `meta` field is serialized into the audit log records. * fix linter error * use string constants for record keys * new audit api calls for api4/bot * `Auditable` interface implementations for model classes * New audit calls for channel api * New audit calls for channel_local * renamed receivers for required style reasons * New audit calls for api4/command * renamed receiver * New audit calls for api4/command_local * renamed receiver * fix unit test to reflect changes in the Auditable implementation of the user class * new audit calls for compliance * new audit calls for configs * remove auditRec.addMeta from updateConfig and patchConfig * new audit calls for config_local * new audit calls * new audit calls for ldap, license apis * new audit calls * new audit calls * new audit calls * new audit calls * new audit calls * new audit calls * new audit calls * new audit calls * fix linter error * fixed linter error * fixed "user update" test * Don't include all of config when audit logging config changes. Also fix unit test on TestUpdateConfigDiffInAuditRecord * address review comments * Added Auditable() method for UserPatch * Fix duplicative method declaration from merge * Fix styling and API changes issues introduced with merge * Fix broken test Co-authored-by: Daniel Schalla <daniel@schalla.me>
162 строки
4.3 KiB
Go
162 строки
4.3 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package config
|
|
|
|
import (
|
|
"fmt"
|
|
"reflect"
|
|
|
|
"github.com/mattermost/mattermost-server/v6/model"
|
|
)
|
|
|
|
type ConfigDiffs []ConfigDiff
|
|
|
|
type ConfigDiff struct {
|
|
Path string `json:"path"`
|
|
BaseVal any `json:"base_val"`
|
|
ActualVal any `json:"actual_val"`
|
|
}
|
|
|
|
func (c *ConfigDiff) Auditable() map[string]interface{} {
|
|
return map[string]interface{}{
|
|
"path": c.Path,
|
|
"base_val": c.BaseVal,
|
|
"actual_val": c.ActualVal,
|
|
}
|
|
}
|
|
|
|
func (cd *ConfigDiffs) Auditable() map[string]interface{} {
|
|
var s []interface{}
|
|
for _, d := range cd.Sanitize() {
|
|
s = append(s, d.Auditable())
|
|
}
|
|
return map[string]interface{}{
|
|
"config_diffs": s,
|
|
}
|
|
}
|
|
|
|
var configSensitivePaths = map[string]bool{
|
|
"LdapSettings.BindPassword": true,
|
|
"FileSettings.PublicLinkSalt": true,
|
|
"FileSettings.AmazonS3SecretAccessKey": true,
|
|
"SqlSettings.DataSource": true,
|
|
"SqlSettings.AtRestEncryptKey": true,
|
|
"SqlSettings.DataSourceReplicas": true,
|
|
"SqlSettings.DataSourceSearchReplicas": true,
|
|
"EmailSettings.SMTPPassword": true,
|
|
"GitLabSettings.Secret": true,
|
|
"GoogleSettings.Secret": true,
|
|
"Office365Settings.Secret": true,
|
|
"OpenIdSettings.Secret": true,
|
|
"ElasticsearchSettings.Password": true,
|
|
"MessageExportSettings.GlobalRelaySettings.SMTPUsername": true,
|
|
"MessageExportSettings.GlobalRelaySettings.SMTPPassword": true,
|
|
"MessageExportSettings.GlobalRelaySettings.EmailAddress": true,
|
|
"ServiceSettings.GfycatAPISecret": true,
|
|
"ServiceSettings.SplitKey": true,
|
|
"PluginSettings.Plugins": true,
|
|
}
|
|
|
|
// Sanitize replaces sensitive config values in the diff with asterisks filled strings.
|
|
func (cd ConfigDiffs) Sanitize() ConfigDiffs {
|
|
if len(cd) == 1 {
|
|
cfgPtr, ok := cd[0].BaseVal.(*model.Config)
|
|
if ok {
|
|
cfgPtr.Sanitize()
|
|
}
|
|
cfgPtr, ok = cd[0].ActualVal.(*model.Config)
|
|
if ok {
|
|
cfgPtr.Sanitize()
|
|
}
|
|
cfgVal, ok := cd[0].BaseVal.(model.Config)
|
|
if ok {
|
|
cfgVal.Sanitize()
|
|
}
|
|
cfgVal, ok = cd[0].ActualVal.(model.Config)
|
|
if ok {
|
|
cfgVal.Sanitize()
|
|
}
|
|
}
|
|
|
|
for i := range cd {
|
|
if configSensitivePaths[cd[i].Path] {
|
|
cd[i].BaseVal = model.FakeSetting
|
|
cd[i].ActualVal = model.FakeSetting
|
|
}
|
|
}
|
|
|
|
return cd
|
|
}
|
|
|
|
func diff(base, actual reflect.Value, label string) ([]ConfigDiff, error) {
|
|
var diffs []ConfigDiff
|
|
|
|
if base.IsZero() && actual.IsZero() {
|
|
return diffs, nil
|
|
}
|
|
|
|
if base.IsZero() || actual.IsZero() {
|
|
return append(diffs, ConfigDiff{
|
|
Path: label,
|
|
BaseVal: base.Interface(),
|
|
ActualVal: actual.Interface(),
|
|
}), nil
|
|
}
|
|
|
|
baseType := base.Type()
|
|
actualType := actual.Type()
|
|
|
|
if baseType.Kind() == reflect.Ptr {
|
|
base = reflect.Indirect(base)
|
|
actual = reflect.Indirect(actual)
|
|
baseType = base.Type()
|
|
actualType = actual.Type()
|
|
}
|
|
|
|
if baseType != actualType {
|
|
return nil, fmt.Errorf("not same type %s %s", baseType, actualType)
|
|
}
|
|
|
|
switch baseType.Kind() {
|
|
case reflect.Struct:
|
|
if base.NumField() != actual.NumField() {
|
|
return nil, fmt.Errorf("not same number of fields in struct")
|
|
}
|
|
for i := 0; i < base.NumField(); i++ {
|
|
fieldLabel := baseType.Field(i).Name
|
|
if label != "" {
|
|
fieldLabel = label + "." + fieldLabel
|
|
}
|
|
d, err := diff(base.Field(i), actual.Field(i), fieldLabel)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
diffs = append(diffs, d...)
|
|
}
|
|
default:
|
|
if !reflect.DeepEqual(base.Interface(), actual.Interface()) {
|
|
diffs = append(diffs, ConfigDiff{
|
|
Path: label,
|
|
BaseVal: base.Interface(),
|
|
ActualVal: actual.Interface(),
|
|
})
|
|
}
|
|
}
|
|
|
|
return diffs, nil
|
|
}
|
|
|
|
func Diff(base, actual *model.Config) (ConfigDiffs, error) {
|
|
if base == nil || actual == nil {
|
|
return nil, fmt.Errorf("input configs should not be nil")
|
|
}
|
|
baseVal := reflect.Indirect(reflect.ValueOf(base))
|
|
actualVal := reflect.Indirect(reflect.ValueOf(actual))
|
|
return diff(baseVal, actualVal, "")
|
|
}
|
|
|
|
func (cd ConfigDiffs) String() string {
|
|
return fmt.Sprintf("%+v", []ConfigDiff(cd))
|
|
}
|