1e6553704d
* don't report an error on plugin activation if already active * improved plugin logging events Log an error when a plugin's ServeHTTP fails, or when it unexpectedly terminates. Restart a plugin at most three times, allowing its failure to later bubble up under the "failed to stay running" status. * clarified plugin activation/deactivation Avoid repeatedly activating when any configuration bit changes. Improved logging. * constrain plugin ids to ^[a-zA-Z0-9-_\.]+$ and enforce minimum length Previously, the plugin id was used unsanitized to relocate the plugin bundle, which allowed writing outside the `plugins/` directory by using an `id` containing `../`. Similarly, an empty string was accepted as an id and led to unexpected error messages. * remove plugins by manifest path, not id If the id within the manifest ever diverges from the actual plugin location, it becomes impossible to remove via the API. Instead, if the plugin is found by id, remove the path containing the manifest. * ignore plugins with nil manifests If a plugin was detected, but had a manifest that couldn't be parsed, it will be left nil but still be listed among the packages. Skip over these in most cases to avoid segfaults. * leverage mlog more effectively for plugins * build issues
48 строки
1.1 KiB
Go
48 строки
1.1 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See License.txt for license information.
|
|
|
|
package rpcplugin
|
|
|
|
import (
|
|
"bufio"
|
|
"encoding/binary"
|
|
"fmt"
|
|
"log"
|
|
"os"
|
|
)
|
|
|
|
// Makes a set of hooks available via RPC. This function never returns.
|
|
func Main(hooks interface{}) {
|
|
ipc, err := InheritedProcessIPC()
|
|
if err != nil {
|
|
log.Fatal(err.Error())
|
|
}
|
|
muxer := NewMuxer(ipc, true)
|
|
id, conn := muxer.Serve()
|
|
buf := make([]byte, 11)
|
|
buf[0] = 0
|
|
n := binary.PutVarint(buf[1:], id)
|
|
if _, err := muxer.Write(buf[:1+n]); err != nil {
|
|
log.Fatal(err.Error())
|
|
}
|
|
ServeHooks(hooks, conn, muxer)
|
|
os.Exit(0)
|
|
}
|
|
|
|
// Returns the hooks being served by a call to Main.
|
|
func ConnectMain(muxer *Muxer, pluginId string) (*RemoteHooks, error) {
|
|
buf := make([]byte, 1)
|
|
if _, err := muxer.Read(buf); err != nil {
|
|
return nil, err
|
|
} else if buf[0] != 0 {
|
|
return nil, fmt.Errorf("unexpected control byte")
|
|
}
|
|
reader := bufio.NewReader(muxer)
|
|
id, err := binary.ReadVarint(reader)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return ConnectHooks(muxer.Connect(id), muxer, pluginId)
|
|
}
|