* Initial models, API, app, and persistence of groups and group syncing. * Consistent letter casing in ldif. * Moves group-specific migrations into func. * Adds API endpoint to retrieve LDAP groups (and associated MM groups) one tree level at a time. * Adds mattermost group id to SCIMGroup (if available). * Splits user and group creation so that memberOf works. Returns users from ldap interface. * Updates method name. * Returns users IDs instead of User. * Removes non-essential group data. * MM-11807: Add GroupFilter to LDAP config. (#9513) * MM-11807: Add GroupFilter to LDAP config. * Add diagnostic. * Adds new config option for using 'memberOf' overlay. * Adds API endpoint to link a group. * Removes debug statements. * Adds unlink group API endpoint. * Fix to LDAP API. Adds API method to client4 and app. * Adds some missing app methods. Renames API unexported func. * Fixes link/unlink API path to accept valid DNs. * Allow any character for DN portion of path. * Switches from DN to objectGUID or entryUUID as the remote identifier linking LDAP groups to MM groups. * Formatting. * Formatting. * Setting group name field to an ID for phase 1. * Adds an LDAP config field to Setting up configuration for local LDAP. * Changes to LDAP and GroupStore interfaces. * Draft of nesting groups in API response. * Removes unnecessary tree models. * Updates group membershipt create store method to also restore. * Adds new config to test config. * Accept AD format length. * Switches to SetUniqueTogether method. * Updates revert. * Tweaks to syncing queries . * Updates query for pending team and channel memberships. * Removes old GroupSyncableScanner usage. Some formatting and renaming. * Fixes bug setting syncable type in selecting paged. * Adds tests for syncables populator. * Only add users to teams and channels that are not deleted. * Renames method. * Updates test LDAP setup. * Removes memberof config stuff. * Renames. * Updates test data. * Fix for gofmt. * Adds missing license. * Adds missing teardowns. * Test fix. * Adds a cycle to the groups test data. * Changes API to return flat list. * Removes some unused interface and app methods. * Returns empty braces if results are empty. * Adds more LDAP test data. * Fix for test data error. * Adds error. * Moves test groups. * Adds OU for load test data. * Moves load test ou creation to load data. * Adds a new bool flag to SCIMGroups. * Removes SCIMGroup completely. * Removes FULL JOIN because it is not supported in MySQL. * Adds tests for sync queries; renames constant. * Bad merge fix. * Vet fix. * Returning OK on delete ldap group link * Removes foreign key constraints. * Adding total to the ldap getAllGroups api endpoint * Adds get group members page. * Removes pagination from groups syncables list API. * Adding syncable check now that foreign key constraint is removes. * Joins teams and channels to group syncables. * Adds group member count. * Adding GetAllChannels and SearchAllChannels for system admins only * Fix. * Test fix from pagination removal. * Orders groupmembers by createat. * Fixing search of all channels * Test fix after removing pagination. * JSON syntax error fix. * Changing tests (for now) pending investigation. * Adding GetAllChannels and SearchAllChannels tests for the store * Adding GetAllChannels and SearchAllChannels API tests * Omit empty JSON values of group syncables. * Fixing GetAllChannels and SearchAllChannels tests * Fixing GetAllChannels and SearchAllChannels store tests * Fixing GetAllChannels api tests * Adds 'LDAP groups' feature flag. (#9861) * Migrate new client functions to idiomatic error handling * Test fixes. * Simplification of groups api (#9860) * Simplification of groups api * Fixing RequireSyncableType * Test fix. * Update api4/group.go Co-Authored-By: mkraft <martinkraft@gmail.com> * Update api4/group.go Co-Authored-By: mkraft <martinkraft@gmail.com> * Update api4/group.go Co-Authored-By: mkraft <martinkraft@gmail.com> * Update api4/group.go Co-Authored-By: mkraft <martinkraft@gmail.com> * Update api4/group.go Co-Authored-By: mkraft <martinkraft@gmail.com> * Update api4/group.go Co-Authored-By: mkraft <martinkraft@gmail.com> * Update api4/group.go Co-Authored-By: mkraft <martinkraft@gmail.com> * Update api4/group.go Co-Authored-By: mkraft <martinkraft@gmail.com> * Update api4/group.go Co-Authored-By: mkraft <martinkraft@gmail.com> * Update api4/group.go Co-Authored-By: mkraft <martinkraft@gmail.com> * Fix copy/paste error. * Fix copy/paste error. * Adds missing return, changes to correct HTTP status code. * Adds missing return, changes status codes. * Check for license. * Renames variable for new signature. * Adds client method to get a group. * Adds client method and tests for PatchGroup. * Adds more API tests. * Adds groups API tests. * Adds client method and tests for getting group syncables. * Adds tests for patching group teams and channels. * Update to translations. * Removes test. * Fix incorrect conditional. * Removes unnecessary nil check. * Removes unnecessary return. * Updates comment, removes unused variable. * Uses consistent JSON unmarshal pattern. * Uses consistent JSON unmarshal pattern. * Moves const block. * Switches 'already linked' from error to success response. * Removes commented-out code. * Switched to status ok. * Add parens for readability. * Fix copy/paste error. * Unexport some structs. * Removes repeated validity check. * Return without attempting commit if there's a rollback. * Fix incorrect HTTP status code. * Update store/sqlstore/group_supplier.go Co-Authored-By: mkraft <martinkraft@gmail.com> * Adds utility methods for going from groupsyncable to groupteam and groupchannel. * Fixing george suggestions (#9911) * Test fix. * Adds QA data to VC with visualization. * Fixes typo in graph image. * Update display name when re-linking in case it has changed in LDAP. * Adds ability to configure group display name and unique identifier. (#9923) * Adds ability to configure group display name and unique identifier. * Adds some configs to confi-ldap make command. * Fix for move of session. * Exposes method for use by SAML package. * Switches GroupSyncableType from int to string. * Update Jenkins build files. * Removes unused variable assignment. * Removes old unnecessary early return. * Removes unnecessary variable. * Moves param parsing before license and permissions checks. * Removes old code. * Compares agains underlying error rather than error id. * Switches tests to assertions. * Adds more assertions. * Adds missing return. * Adds space after comma for added legibility. * Moves a view model to the api package. * Unexports method. * Uses id validator function. * Fix docker-compose flag. * Typo fix. * Moves index creation to supplier. * Removes bad merge. * Renames parameter. * Re-adds space. * Removes unnecessary transaction. * Escapes the Groups table name with backticks because it is a reserved keyword. * Fix roles cache bug * Removing unnecesiary deserializing function * Switches table name rather than custom SQL everywhere for Postgres without backticks. * Removes redundant check for sql.ErrNoRows. * Removes redundant check for sql.ErrNoRows. * Removes data integrity check and redundant nil conditional. * Removes redundant check for sql.ErrNoRows. * Removes unnecessary query. * Removes ID length validation from persistence tier. * Makes some supplier methods idempotent. * Removes some empty switch defaults. * Renames Group Type field to Source. * Fix for mistaken field name change. * Uses IsValidId function. * Removes comment. * Changes json key name. * Removes test because no longer validating user. * Moves model state validation to app layer. * Don't create Groups.CanLeave column until phase 2. * Removes state validation until properties are used in phase 2. * Removes duplicated check. * Removes state validation until properties are used in phase 2. * Removes some tests until phase 2. * Comment-out a bunch of test related to CanLeave. * Extra unmarshal validation check. Removes more code for CanLeave. * Removes tests for CanLeave. * Explict error msg. * Rewrite queries. * Changes index name. Adds index. * Removes assertion. * Adds experimental feature flag.
623 строки
21 KiB
Go
623 строки
21 KiB
Go
// Copyright (c) 2018-present Mattermost, Inc. All Rights Reserved.
|
|
// See License.txt for license information.
|
|
|
|
package api4
|
|
|
|
import (
|
|
"fmt"
|
|
"net/http"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
"github.com/mattermost/mattermost-server/model"
|
|
)
|
|
|
|
func TestGetGroup(t *testing.T) {
|
|
th := Setup().InitBasic()
|
|
defer th.TearDown()
|
|
|
|
id := model.NewId()
|
|
g, err := th.App.CreateGroup(&model.Group{
|
|
DisplayName: "dn_" + id,
|
|
Name: "name" + id,
|
|
Source: model.GroupSourceLdap,
|
|
Description: "description_" + id,
|
|
RemoteId: model.NewId(),
|
|
})
|
|
assert.Nil(t, err)
|
|
|
|
_, response := th.Client.GetGroup(g.Id, "")
|
|
CheckNotImplementedStatus(t, response)
|
|
|
|
_, response = th.SystemAdminClient.GetGroup(g.Id, "")
|
|
CheckNotImplementedStatus(t, response)
|
|
|
|
th.App.SetLicense(model.NewTestLicense("ldap"))
|
|
|
|
group, response := th.SystemAdminClient.GetGroup(g.Id, "")
|
|
CheckNoError(t, response)
|
|
|
|
assert.Equal(t, g.DisplayName, group.DisplayName)
|
|
assert.Equal(t, g.Name, group.Name)
|
|
assert.Equal(t, g.Source, group.Source)
|
|
assert.Equal(t, g.Description, group.Description)
|
|
assert.Equal(t, g.RemoteId, group.RemoteId)
|
|
assert.Equal(t, g.CreateAt, group.CreateAt)
|
|
assert.Equal(t, g.UpdateAt, group.UpdateAt)
|
|
assert.Equal(t, g.DeleteAt, group.DeleteAt)
|
|
|
|
_, response = th.SystemAdminClient.GetGroup(model.NewId(), "")
|
|
CheckNotFoundStatus(t, response)
|
|
|
|
_, response = th.SystemAdminClient.GetGroup("12345", "")
|
|
CheckBadRequestStatus(t, response)
|
|
|
|
th.SystemAdminClient.Logout()
|
|
_, response = th.SystemAdminClient.GetGroup(group.Id, "")
|
|
CheckUnauthorizedStatus(t, response)
|
|
}
|
|
|
|
func TestPatchGroup(t *testing.T) {
|
|
th := Setup().InitBasic()
|
|
defer th.TearDown()
|
|
|
|
id := model.NewId()
|
|
g, err := th.App.CreateGroup(&model.Group{
|
|
DisplayName: "dn_" + id,
|
|
Name: "name" + id,
|
|
Source: model.GroupSourceLdap,
|
|
Description: "description_" + id,
|
|
RemoteId: model.NewId(),
|
|
})
|
|
assert.Nil(t, err)
|
|
|
|
updateFmt := "%s_updated"
|
|
|
|
newName := fmt.Sprintf(updateFmt, g.Name)
|
|
newDisplayName := fmt.Sprintf(updateFmt, g.DisplayName)
|
|
newDescription := fmt.Sprintf(updateFmt, g.Description)
|
|
|
|
gp := &model.GroupPatch{
|
|
Name: &newName,
|
|
DisplayName: &newDisplayName,
|
|
Description: &newDescription,
|
|
}
|
|
|
|
_, response := th.Client.PatchGroup(g.Id, gp)
|
|
CheckNotImplementedStatus(t, response)
|
|
|
|
_, response = th.SystemAdminClient.PatchGroup(g.Id, gp)
|
|
CheckNotImplementedStatus(t, response)
|
|
|
|
th.App.SetLicense(model.NewTestLicense("ldap"))
|
|
|
|
group2, response := th.SystemAdminClient.PatchGroup(g.Id, gp)
|
|
CheckOKStatus(t, response)
|
|
|
|
group, response := th.SystemAdminClient.GetGroup(g.Id, "")
|
|
CheckNoError(t, response)
|
|
|
|
assert.Equal(t, *gp.DisplayName, group.DisplayName)
|
|
assert.Equal(t, *gp.DisplayName, group2.DisplayName)
|
|
assert.Equal(t, *gp.Name, group.Name)
|
|
assert.Equal(t, *gp.Name, group2.Name)
|
|
assert.Equal(t, *gp.Description, group.Description)
|
|
assert.Equal(t, *gp.Description, group2.Description)
|
|
|
|
assert.Equal(t, group2.UpdateAt, group.UpdateAt)
|
|
|
|
assert.Equal(t, g.Source, group.Source)
|
|
assert.Equal(t, g.Source, group2.Source)
|
|
assert.Equal(t, g.RemoteId, group.RemoteId)
|
|
assert.Equal(t, g.RemoteId, group2.RemoteId)
|
|
assert.Equal(t, g.CreateAt, group.CreateAt)
|
|
assert.Equal(t, g.CreateAt, group2.CreateAt)
|
|
assert.Equal(t, g.DeleteAt, group.DeleteAt)
|
|
assert.Equal(t, g.DeleteAt, group2.DeleteAt)
|
|
|
|
_, response = th.SystemAdminClient.PatchGroup(model.NewId(), gp)
|
|
CheckNotFoundStatus(t, response)
|
|
|
|
th.SystemAdminClient.Logout()
|
|
_, response = th.SystemAdminClient.PatchGroup(group.Id, gp)
|
|
CheckUnauthorizedStatus(t, response)
|
|
}
|
|
|
|
func TestLinkGroupTeam(t *testing.T) {
|
|
th := Setup().InitBasic()
|
|
defer th.TearDown()
|
|
|
|
id := model.NewId()
|
|
g, err := th.App.CreateGroup(&model.Group{
|
|
DisplayName: "dn_" + id,
|
|
Name: "name" + id,
|
|
Source: model.GroupSourceLdap,
|
|
Description: "description_" + id,
|
|
RemoteId: model.NewId(),
|
|
})
|
|
assert.Nil(t, err)
|
|
|
|
patch := &model.GroupSyncablePatch{
|
|
CanLeave: model.NewBool(true),
|
|
AutoAdd: model.NewBool(true),
|
|
}
|
|
|
|
_, response := th.Client.LinkGroupSyncable(g.Id, th.BasicTeam.Id, model.GroupSyncableTypeTeam, patch)
|
|
CheckNotImplementedStatus(t, response)
|
|
|
|
_, response = th.SystemAdminClient.LinkGroupSyncable(g.Id, th.BasicTeam.Id, model.GroupSyncableTypeTeam, patch)
|
|
CheckNotImplementedStatus(t, response)
|
|
|
|
th.App.SetLicense(model.NewTestLicense("ldap"))
|
|
|
|
groupTeam, response := th.SystemAdminClient.LinkGroupSyncable(g.Id, th.BasicTeam.Id, model.GroupSyncableTypeTeam, patch)
|
|
assert.Equal(t, http.StatusCreated, response.StatusCode)
|
|
assert.NotNil(t, groupTeam)
|
|
}
|
|
|
|
func TestLinkGroupChannel(t *testing.T) {
|
|
th := Setup().InitBasic()
|
|
defer th.TearDown()
|
|
|
|
id := model.NewId()
|
|
g, err := th.App.CreateGroup(&model.Group{
|
|
DisplayName: "dn_" + id,
|
|
Name: "name" + id,
|
|
Source: model.GroupSourceLdap,
|
|
Description: "description_" + id,
|
|
RemoteId: model.NewId(),
|
|
})
|
|
assert.Nil(t, err)
|
|
|
|
patch := &model.GroupSyncablePatch{
|
|
CanLeave: model.NewBool(true),
|
|
AutoAdd: model.NewBool(true),
|
|
}
|
|
|
|
_, response := th.Client.LinkGroupSyncable(g.Id, th.BasicChannel.Id, model.GroupSyncableTypeChannel, patch)
|
|
CheckNotImplementedStatus(t, response)
|
|
|
|
_, response = th.SystemAdminClient.LinkGroupSyncable(g.Id, th.BasicChannel.Id, model.GroupSyncableTypeChannel, patch)
|
|
CheckNotImplementedStatus(t, response)
|
|
|
|
th.App.SetLicense(model.NewTestLicense("ldap"))
|
|
|
|
_, response = th.SystemAdminClient.LinkGroupSyncable(g.Id, th.BasicChannel.Id, model.GroupSyncableTypeChannel, patch)
|
|
assert.Equal(t, http.StatusCreated, response.StatusCode)
|
|
}
|
|
|
|
func TestUnlinkGroupTeam(t *testing.T) {
|
|
th := Setup().InitBasic()
|
|
defer th.TearDown()
|
|
|
|
id := model.NewId()
|
|
g, err := th.App.CreateGroup(&model.Group{
|
|
DisplayName: "dn_" + id,
|
|
Name: "name" + id,
|
|
Source: model.GroupSourceLdap,
|
|
Description: "description_" + id,
|
|
RemoteId: model.NewId(),
|
|
})
|
|
assert.Nil(t, err)
|
|
|
|
patch := &model.GroupSyncablePatch{
|
|
CanLeave: model.NewBool(true),
|
|
AutoAdd: model.NewBool(true),
|
|
}
|
|
|
|
th.App.SetLicense(model.NewTestLicense("ldap"))
|
|
|
|
_, response := th.SystemAdminClient.LinkGroupSyncable(g.Id, th.BasicTeam.Id, model.GroupSyncableTypeTeam, patch)
|
|
assert.Equal(t, http.StatusCreated, response.StatusCode)
|
|
|
|
th.App.SetLicense(nil)
|
|
|
|
response = th.Client.UnlinkGroupSyncable(g.Id, th.BasicTeam.Id, model.GroupSyncableTypeTeam)
|
|
CheckNotImplementedStatus(t, response)
|
|
|
|
response = th.SystemAdminClient.UnlinkGroupSyncable(g.Id, th.BasicTeam.Id, model.GroupSyncableTypeTeam)
|
|
CheckNotImplementedStatus(t, response)
|
|
|
|
th.App.SetLicense(model.NewTestLicense("ldap"))
|
|
|
|
response = th.SystemAdminClient.UnlinkGroupSyncable(g.Id, th.BasicTeam.Id, model.GroupSyncableTypeTeam)
|
|
CheckOKStatus(t, response)
|
|
}
|
|
|
|
func TestUnlinkGroupChannel(t *testing.T) {
|
|
th := Setup().InitBasic()
|
|
defer th.TearDown()
|
|
|
|
id := model.NewId()
|
|
g, err := th.App.CreateGroup(&model.Group{
|
|
DisplayName: "dn_" + id,
|
|
Name: "name" + id,
|
|
Source: model.GroupSourceLdap,
|
|
Description: "description_" + id,
|
|
RemoteId: model.NewId(),
|
|
})
|
|
assert.Nil(t, err)
|
|
|
|
patch := &model.GroupSyncablePatch{
|
|
CanLeave: model.NewBool(true),
|
|
AutoAdd: model.NewBool(true),
|
|
}
|
|
|
|
th.App.SetLicense(model.NewTestLicense("ldap"))
|
|
|
|
_, response := th.SystemAdminClient.LinkGroupSyncable(g.Id, th.BasicChannel.Id, model.GroupSyncableTypeChannel, patch)
|
|
assert.Equal(t, http.StatusCreated, response.StatusCode)
|
|
|
|
th.App.SetLicense(nil)
|
|
|
|
response = th.Client.UnlinkGroupSyncable(g.Id, th.BasicChannel.Id, model.GroupSyncableTypeChannel)
|
|
CheckNotImplementedStatus(t, response)
|
|
|
|
response = th.SystemAdminClient.UnlinkGroupSyncable(g.Id, th.BasicChannel.Id, model.GroupSyncableTypeChannel)
|
|
CheckNotImplementedStatus(t, response)
|
|
|
|
th.App.SetLicense(model.NewTestLicense("ldap"))
|
|
|
|
response = th.SystemAdminClient.UnlinkGroupSyncable(g.Id, th.BasicChannel.Id, model.GroupSyncableTypeChannel)
|
|
CheckOKStatus(t, response)
|
|
}
|
|
|
|
func TestGetGroupTeam(t *testing.T) {
|
|
th := Setup().InitBasic()
|
|
defer th.TearDown()
|
|
|
|
id := model.NewId()
|
|
g, err := th.App.CreateGroup(&model.Group{
|
|
DisplayName: "dn_" + id,
|
|
Name: "name" + id,
|
|
Source: model.GroupSourceLdap,
|
|
Description: "description_" + id,
|
|
RemoteId: model.NewId(),
|
|
})
|
|
assert.Nil(t, err)
|
|
|
|
_, response := th.Client.GetGroupSyncable(g.Id, th.BasicTeam.Id, model.GroupSyncableTypeTeam, "")
|
|
CheckNotImplementedStatus(t, response)
|
|
|
|
_, response = th.SystemAdminClient.GetGroupSyncable(g.Id, th.BasicTeam.Id, model.GroupSyncableTypeTeam, "")
|
|
CheckNotImplementedStatus(t, response)
|
|
|
|
th.App.SetLicense(model.NewTestLicense("ldap"))
|
|
|
|
patch := &model.GroupSyncablePatch{
|
|
CanLeave: model.NewBool(true),
|
|
AutoAdd: model.NewBool(true),
|
|
}
|
|
|
|
_, response = th.SystemAdminClient.LinkGroupSyncable(g.Id, th.BasicTeam.Id, model.GroupSyncableTypeTeam, patch)
|
|
assert.Equal(t, http.StatusCreated, response.StatusCode)
|
|
|
|
groupSyncable, response := th.SystemAdminClient.GetGroupSyncable(g.Id, th.BasicTeam.Id, model.GroupSyncableTypeTeam, "")
|
|
CheckOKStatus(t, response)
|
|
assert.NotNil(t, groupSyncable)
|
|
|
|
assert.Equal(t, g.Id, groupSyncable.GroupId)
|
|
assert.Equal(t, th.BasicTeam.Id, groupSyncable.SyncableId)
|
|
assert.Equal(t, *patch.AutoAdd, groupSyncable.AutoAdd)
|
|
// assert.Equal(t, *patch.CanLeave, groupSyncable.CanLeave) // TODO: Re-add this test in phase 2 of LDAP groups sync.
|
|
|
|
_, response = th.SystemAdminClient.GetGroupSyncable(model.NewId(), th.BasicTeam.Id, model.GroupSyncableTypeTeam, "")
|
|
CheckNotFoundStatus(t, response)
|
|
|
|
_, response = th.SystemAdminClient.GetGroupSyncable(g.Id, model.NewId(), model.GroupSyncableTypeTeam, "")
|
|
CheckNotFoundStatus(t, response)
|
|
|
|
_, response = th.SystemAdminClient.GetGroupSyncable("asdfasdfe3", th.BasicTeam.Id, model.GroupSyncableTypeTeam, "")
|
|
CheckBadRequestStatus(t, response)
|
|
|
|
_, response = th.SystemAdminClient.GetGroupSyncable(g.Id, "asdfasdfe3", model.GroupSyncableTypeTeam, "")
|
|
CheckBadRequestStatus(t, response)
|
|
|
|
th.SystemAdminClient.Logout()
|
|
_, response = th.SystemAdminClient.GetGroupSyncable(g.Id, th.BasicTeam.Id, model.GroupSyncableTypeTeam, "")
|
|
CheckUnauthorizedStatus(t, response)
|
|
}
|
|
|
|
func TestGetGroupChannel(t *testing.T) {
|
|
th := Setup().InitBasic()
|
|
defer th.TearDown()
|
|
|
|
id := model.NewId()
|
|
g, err := th.App.CreateGroup(&model.Group{
|
|
DisplayName: "dn_" + id,
|
|
Name: "name" + id,
|
|
Source: model.GroupSourceLdap,
|
|
Description: "description_" + id,
|
|
RemoteId: model.NewId(),
|
|
})
|
|
assert.Nil(t, err)
|
|
|
|
_, response := th.Client.GetGroupSyncable(g.Id, th.BasicChannel.Id, model.GroupSyncableTypeChannel, "")
|
|
CheckNotImplementedStatus(t, response)
|
|
|
|
_, response = th.SystemAdminClient.GetGroupSyncable(g.Id, th.BasicChannel.Id, model.GroupSyncableTypeChannel, "")
|
|
CheckNotImplementedStatus(t, response)
|
|
|
|
th.App.SetLicense(model.NewTestLicense("ldap"))
|
|
|
|
patch := &model.GroupSyncablePatch{
|
|
CanLeave: model.NewBool(true),
|
|
AutoAdd: model.NewBool(true),
|
|
}
|
|
|
|
_, response = th.SystemAdminClient.LinkGroupSyncable(g.Id, th.BasicChannel.Id, model.GroupSyncableTypeChannel, patch)
|
|
assert.Equal(t, http.StatusCreated, response.StatusCode)
|
|
|
|
groupSyncable, response := th.SystemAdminClient.GetGroupSyncable(g.Id, th.BasicChannel.Id, model.GroupSyncableTypeChannel, "")
|
|
CheckOKStatus(t, response)
|
|
assert.NotNil(t, groupSyncable)
|
|
|
|
assert.Equal(t, g.Id, groupSyncable.GroupId)
|
|
assert.Equal(t, th.BasicChannel.Id, groupSyncable.SyncableId)
|
|
assert.Equal(t, *patch.AutoAdd, groupSyncable.AutoAdd)
|
|
// assert.Equal(t, *patch.CanLeave, groupSyncable.CanLeave) // TODO: Re-add this test in phase 2 of LDAP groups sync.
|
|
|
|
_, response = th.SystemAdminClient.GetGroupSyncable(model.NewId(), th.BasicChannel.Id, model.GroupSyncableTypeChannel, "")
|
|
CheckNotFoundStatus(t, response)
|
|
|
|
_, response = th.SystemAdminClient.GetGroupSyncable(g.Id, model.NewId(), model.GroupSyncableTypeChannel, "")
|
|
CheckNotFoundStatus(t, response)
|
|
|
|
_, response = th.SystemAdminClient.GetGroupSyncable("asdfasdfe3", th.BasicChannel.Id, model.GroupSyncableTypeChannel, "")
|
|
CheckBadRequestStatus(t, response)
|
|
|
|
_, response = th.SystemAdminClient.GetGroupSyncable(g.Id, "asdfasdfe3", model.GroupSyncableTypeChannel, "")
|
|
CheckBadRequestStatus(t, response)
|
|
|
|
th.SystemAdminClient.Logout()
|
|
_, response = th.SystemAdminClient.GetGroupSyncable(g.Id, th.BasicChannel.Id, model.GroupSyncableTypeChannel, "")
|
|
CheckUnauthorizedStatus(t, response)
|
|
}
|
|
|
|
func TestGetGroupTeams(t *testing.T) {
|
|
th := Setup().InitBasic()
|
|
defer th.TearDown()
|
|
|
|
id := model.NewId()
|
|
g, err := th.App.CreateGroup(&model.Group{
|
|
DisplayName: "dn_" + id,
|
|
Name: "name" + id,
|
|
Source: model.GroupSourceLdap,
|
|
Description: "description_" + id,
|
|
RemoteId: model.NewId(),
|
|
})
|
|
assert.Nil(t, err)
|
|
|
|
th.App.SetLicense(model.NewTestLicense("ldap"))
|
|
|
|
patch := &model.GroupSyncablePatch{
|
|
CanLeave: model.NewBool(true),
|
|
AutoAdd: model.NewBool(true),
|
|
}
|
|
|
|
for i := 0; i < 10; i++ {
|
|
team := th.CreateTeam()
|
|
_, response := th.SystemAdminClient.LinkGroupSyncable(g.Id, team.Id, model.GroupSyncableTypeTeam, patch)
|
|
assert.Equal(t, http.StatusCreated, response.StatusCode)
|
|
}
|
|
|
|
th.App.SetLicense(nil)
|
|
|
|
_, response := th.Client.GetGroupSyncables(g.Id, model.GroupSyncableTypeTeam, "")
|
|
CheckNotImplementedStatus(t, response)
|
|
|
|
_, response = th.SystemAdminClient.GetGroupSyncables(g.Id, model.GroupSyncableTypeTeam, "")
|
|
CheckNotImplementedStatus(t, response)
|
|
|
|
th.App.SetLicense(model.NewTestLicense("ldap"))
|
|
|
|
_, response = th.Client.GetGroupSyncables(g.Id, model.GroupSyncableTypeTeam, "")
|
|
assert.Equal(t, http.StatusForbidden, response.StatusCode)
|
|
|
|
groupSyncables, response := th.SystemAdminClient.GetGroupSyncables(g.Id, model.GroupSyncableTypeTeam, "")
|
|
CheckOKStatus(t, response)
|
|
|
|
assert.Len(t, groupSyncables, 10)
|
|
|
|
th.SystemAdminClient.Logout()
|
|
_, response = th.SystemAdminClient.GetGroupSyncables(g.Id, model.GroupSyncableTypeTeam, "")
|
|
CheckUnauthorizedStatus(t, response)
|
|
}
|
|
|
|
func TestGetGroupChannels(t *testing.T) {
|
|
th := Setup().InitBasic()
|
|
defer th.TearDown()
|
|
|
|
id := model.NewId()
|
|
g, err := th.App.CreateGroup(&model.Group{
|
|
DisplayName: "dn_" + id,
|
|
Name: "name" + id,
|
|
Source: model.GroupSourceLdap,
|
|
Description: "description_" + id,
|
|
RemoteId: model.NewId(),
|
|
})
|
|
assert.Nil(t, err)
|
|
|
|
th.App.SetLicense(model.NewTestLicense("ldap"))
|
|
|
|
patch := &model.GroupSyncablePatch{
|
|
CanLeave: model.NewBool(true),
|
|
AutoAdd: model.NewBool(true),
|
|
}
|
|
|
|
for i := 0; i < 10; i++ {
|
|
channel := th.CreatePublicChannel()
|
|
_, response := th.SystemAdminClient.LinkGroupSyncable(g.Id, channel.Id, model.GroupSyncableTypeChannel, patch)
|
|
assert.Equal(t, http.StatusCreated, response.StatusCode)
|
|
}
|
|
|
|
th.App.SetLicense(nil)
|
|
|
|
_, response := th.Client.GetGroupSyncables(g.Id, model.GroupSyncableTypeChannel, "")
|
|
CheckNotImplementedStatus(t, response)
|
|
|
|
_, response = th.SystemAdminClient.GetGroupSyncables(g.Id, model.GroupSyncableTypeChannel, "")
|
|
CheckNotImplementedStatus(t, response)
|
|
|
|
th.App.SetLicense(model.NewTestLicense("ldap"))
|
|
|
|
_, response = th.Client.GetGroupSyncables(g.Id, model.GroupSyncableTypeChannel, "")
|
|
assert.Equal(t, http.StatusForbidden, response.StatusCode)
|
|
|
|
groupSyncables, response := th.SystemAdminClient.GetGroupSyncables(g.Id, model.GroupSyncableTypeChannel, "")
|
|
CheckOKStatus(t, response)
|
|
|
|
assert.Len(t, groupSyncables, 10)
|
|
|
|
th.SystemAdminClient.Logout()
|
|
_, response = th.SystemAdminClient.GetGroupSyncables(g.Id, model.GroupSyncableTypeChannel, "")
|
|
CheckUnauthorizedStatus(t, response)
|
|
}
|
|
|
|
func TestPatchGroupTeam(t *testing.T) {
|
|
th := Setup().InitBasic()
|
|
defer th.TearDown()
|
|
|
|
id := model.NewId()
|
|
g, err := th.App.CreateGroup(&model.Group{
|
|
DisplayName: "dn_" + id,
|
|
Name: "name" + id,
|
|
Source: model.GroupSourceLdap,
|
|
Description: "description_" + id,
|
|
RemoteId: model.NewId(),
|
|
})
|
|
assert.Nil(t, err)
|
|
|
|
patch := &model.GroupSyncablePatch{
|
|
CanLeave: model.NewBool(true),
|
|
AutoAdd: model.NewBool(true),
|
|
}
|
|
|
|
th.App.SetLicense(model.NewTestLicense("ldap"))
|
|
|
|
groupSyncable, response := th.SystemAdminClient.LinkGroupSyncable(g.Id, th.BasicTeam.Id, model.GroupSyncableTypeTeam, patch)
|
|
assert.Equal(t, http.StatusCreated, response.StatusCode)
|
|
assert.NotNil(t, groupSyncable)
|
|
// assert.True(t, groupSyncable.CanLeave) // TODO: Re-add this test in phase 2 of LDAP groups sync.
|
|
assert.True(t, groupSyncable.AutoAdd)
|
|
|
|
_, response = th.Client.PatchGroupSyncable(g.Id, th.BasicTeam.Id, model.GroupSyncableTypeTeam, patch)
|
|
assert.Equal(t, http.StatusForbidden, response.StatusCode)
|
|
|
|
th.App.SetLicense(nil)
|
|
|
|
_, response = th.SystemAdminClient.PatchGroupSyncable(g.Id, th.BasicTeam.Id, model.GroupSyncableTypeTeam, patch)
|
|
CheckNotImplementedStatus(t, response)
|
|
|
|
th.App.SetLicense(model.NewTestLicense("ldap"))
|
|
|
|
patch.AutoAdd = model.NewBool(false)
|
|
groupSyncable, response = th.SystemAdminClient.PatchGroupSyncable(g.Id, th.BasicTeam.Id, model.GroupSyncableTypeTeam, patch)
|
|
CheckOKStatus(t, response)
|
|
assert.False(t, groupSyncable.AutoAdd)
|
|
|
|
assert.Equal(t, g.Id, groupSyncable.GroupId)
|
|
assert.Equal(t, th.BasicTeam.Id, groupSyncable.SyncableId)
|
|
assert.Equal(t, model.GroupSyncableTypeTeam, groupSyncable.Type)
|
|
|
|
// TODO: Re-add this test in phase 2 of LDAP groups sync.
|
|
// patch.CanLeave = model.NewBool(false)
|
|
// _, response = th.SystemAdminClient.PatchGroupSyncable(g.Id, th.BasicTeam.Id, model.GroupSyncableTypeTeam, patch)
|
|
// CheckBadRequestStatus(t, response)
|
|
|
|
patch.AutoAdd = model.NewBool(true)
|
|
groupSyncable, response = th.SystemAdminClient.PatchGroupSyncable(g.Id, th.BasicTeam.Id, model.GroupSyncableTypeTeam, patch)
|
|
CheckOKStatus(t, response)
|
|
assert.False(t, groupSyncable.CanLeave)
|
|
|
|
_, response = th.SystemAdminClient.PatchGroupSyncable(model.NewId(), th.BasicTeam.Id, model.GroupSyncableTypeTeam, patch)
|
|
CheckNotFoundStatus(t, response)
|
|
|
|
_, response = th.SystemAdminClient.PatchGroupSyncable(g.Id, model.NewId(), model.GroupSyncableTypeTeam, patch)
|
|
CheckNotFoundStatus(t, response)
|
|
|
|
_, response = th.SystemAdminClient.PatchGroupSyncable("abc", th.BasicTeam.Id, model.GroupSyncableTypeTeam, patch)
|
|
CheckBadRequestStatus(t, response)
|
|
|
|
_, response = th.SystemAdminClient.PatchGroupSyncable(g.Id, "abc", model.GroupSyncableTypeTeam, patch)
|
|
CheckBadRequestStatus(t, response)
|
|
|
|
th.SystemAdminClient.Logout()
|
|
_, response = th.SystemAdminClient.PatchGroupSyncable(g.Id, th.BasicTeam.Id, model.GroupSyncableTypeTeam, patch)
|
|
CheckUnauthorizedStatus(t, response)
|
|
}
|
|
|
|
func TestPatchGroupChannel(t *testing.T) {
|
|
th := Setup().InitBasic()
|
|
defer th.TearDown()
|
|
|
|
id := model.NewId()
|
|
g, err := th.App.CreateGroup(&model.Group{
|
|
DisplayName: "dn_" + id,
|
|
Name: "name" + id,
|
|
Source: model.GroupSourceLdap,
|
|
Description: "description_" + id,
|
|
RemoteId: model.NewId(),
|
|
})
|
|
assert.Nil(t, err)
|
|
|
|
patch := &model.GroupSyncablePatch{
|
|
CanLeave: model.NewBool(true),
|
|
AutoAdd: model.NewBool(true),
|
|
}
|
|
|
|
th.App.SetLicense(model.NewTestLicense("ldap"))
|
|
|
|
groupSyncable, response := th.SystemAdminClient.LinkGroupSyncable(g.Id, th.BasicChannel.Id, model.GroupSyncableTypeChannel, patch)
|
|
assert.Equal(t, http.StatusCreated, response.StatusCode)
|
|
assert.NotNil(t, groupSyncable)
|
|
// assert.True(t, groupSyncable.CanLeave) // TODO: Re-add this test in phase 2 of LDAP groups sync.
|
|
assert.True(t, groupSyncable.AutoAdd)
|
|
|
|
_, response = th.Client.PatchGroupSyncable(g.Id, th.BasicChannel.Id, model.GroupSyncableTypeChannel, patch)
|
|
assert.Equal(t, http.StatusForbidden, response.StatusCode)
|
|
|
|
th.App.SetLicense(nil)
|
|
|
|
_, response = th.SystemAdminClient.PatchGroupSyncable(g.Id, th.BasicChannel.Id, model.GroupSyncableTypeChannel, patch)
|
|
CheckNotImplementedStatus(t, response)
|
|
|
|
th.App.SetLicense(model.NewTestLicense("ldap"))
|
|
|
|
patch.AutoAdd = model.NewBool(false)
|
|
groupSyncable, response = th.SystemAdminClient.PatchGroupSyncable(g.Id, th.BasicChannel.Id, model.GroupSyncableTypeChannel, patch)
|
|
CheckOKStatus(t, response)
|
|
assert.False(t, groupSyncable.AutoAdd)
|
|
|
|
assert.Equal(t, g.Id, groupSyncable.GroupId)
|
|
assert.Equal(t, th.BasicChannel.Id, groupSyncable.SyncableId)
|
|
assert.Equal(t, model.GroupSyncableTypeChannel, groupSyncable.Type)
|
|
|
|
// TODO: Re-add this test in phase 2 of LDAP groups sync.
|
|
// patch.CanLeave = model.NewBool(false)
|
|
// _, response = th.SystemAdminClient.PatchGroupSyncable(g.Id, th.BasicChannel.Id, model.GroupSyncableTypeChannel, patch)
|
|
// CheckBadRequestStatus(t, response)
|
|
|
|
patch.AutoAdd = model.NewBool(true)
|
|
groupSyncable, response = th.SystemAdminClient.PatchGroupSyncable(g.Id, th.BasicChannel.Id, model.GroupSyncableTypeChannel, patch)
|
|
CheckOKStatus(t, response)
|
|
assert.False(t, groupSyncable.CanLeave)
|
|
|
|
_, response = th.SystemAdminClient.PatchGroupSyncable(model.NewId(), th.BasicChannel.Id, model.GroupSyncableTypeChannel, patch)
|
|
CheckNotFoundStatus(t, response)
|
|
|
|
_, response = th.SystemAdminClient.PatchGroupSyncable(g.Id, model.NewId(), model.GroupSyncableTypeChannel, patch)
|
|
CheckNotFoundStatus(t, response)
|
|
|
|
_, response = th.SystemAdminClient.PatchGroupSyncable("abc", th.BasicChannel.Id, model.GroupSyncableTypeChannel, patch)
|
|
CheckBadRequestStatus(t, response)
|
|
|
|
_, response = th.SystemAdminClient.PatchGroupSyncable(g.Id, "abc", model.GroupSyncableTypeChannel, patch)
|
|
CheckBadRequestStatus(t, response)
|
|
|
|
th.SystemAdminClient.Logout()
|
|
_, response = th.SystemAdminClient.PatchGroupSyncable(g.Id, th.BasicChannel.Id, model.GroupSyncableTypeChannel, patch)
|
|
CheckUnauthorizedStatus(t, response)
|
|
}
|