mirrors/mostlymatter
1
0
Форкнуть 0
Код Задачи Запросы на слияние Действия Пакеты Проекты Релизы Вики Активность
Files
af36c02e2182ebe31f5fbbcfcc36602dd5b2b7fc
mostlymatter/api4
История
Agniva De Sarker b7a7d8e7b6 MM-39612: Make acquiring and removing connections atomic (#18982) 
* MM-39612: Make acquiring and removing connections atomic

The reconnect phase of a websocket was split into two parts:
one where we check if a connection with a given connectionID
exists or not. And second, where we remove that connection
and insert the new connection again in the index.

This would lead to a race where it would be possible
for 2 concurrent requests for the same connectionID to go through
which would lead to separate goroutines working on the same dead queue.

We simplify this by removing the connection from the index
in the check connection stage itself. And then just add that
during register phase.

And to distinguish between a fresh and an old connection, we add
a new field called reuseCount.

While here, we also cleanup some old comments and add more
in some places.

https://mattermost.atlassian.net/browse/MM-39612

```release-note
NONE
```

* remove unused method

```release-note
NONE
```

* race test

```release-note
NONE
```
2021-11-16 19:43:43 +05:30
..
api.go
Improve API4 initialization (#18680)
2021-10-15 19:57:05 +05:30
apitestlib.go
MM-39612: Make acquiring and removing connections atomic (#18982)
2021-11-16 19:43:43 +05:30
bleve_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
bleve.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
bot_local.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
bot_test.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
bot.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
brand_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
brand.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
channel_category_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
channel_category.go
[MM-18946] [MM-26721] [MM-6842] Cross team search+private channel autocomplete (#18468)
2021-10-26 11:30:59 +05:30
channel_local.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
channel_test.go
adding check for name change and new tests (#18531)
2021-10-29 13:46:50 -04:00
channel.go
MM-40003 Fix patch route for Town Square (#18971)
2021-11-10 23:10:13 +01:00
cloud.go
Allow webapp to request legacy cloud products. (#18528)
2021-10-07 11:48:56 -05:00
cluster_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
cluster.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
command_help_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
command_local.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
command_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
command.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
commands_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
compliance.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
config_local.go
[MM-39597] Implement ConfigDiffs.Sanitize() (#18855)
2021-10-28 14:07:35 +02:00
config_test.go
[MM-38082] Add local-mode handler for config reload endpoint (#18252)
2021-08-25 20:29:41 +02:00
config.go
[MM-39597] Implement ConfigDiffs.Sanitize() (#18855)
2021-10-28 14:07:35 +02:00
cors_test.go
Fix race condition in telemetry (#18734)
2021-10-20 09:58:25 +02:00
data_retention_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
data_retention.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
elasticsearch_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
elasticsearch.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
emoji_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
emoji.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
export_local.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
export_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
export.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
file_test.go
MM-38774 - partial fix for: Community running out of memory (#18445)
2021-09-23 13:17:37 -04:00
file.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
group_local.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
group_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
group.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
handlers_test.go
Improve API4 initialization (#18680)
2021-10-15 19:57:05 +05:30
handlers.go
Improve API4 initialization (#18680)
2021-10-15 19:57:05 +05:30
helpers.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
image_test.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
image.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
import_local.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
import_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
import.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
integration_action_test.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
integration_action.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
job_local.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
job_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
job.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
ldap_local.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
ldap_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
ldap.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
license_local.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
license_test.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
license.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
main_test.go
MM-36764 mlog refactor (#18118)
2021-08-17 16:08:04 -04:00
oauth_test.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
oauth.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
openGraph_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
openGraph.go
Improve API4 initialization (#18680)
2021-10-15 19:57:05 +05:30
permission.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
permissions_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
plugin_local.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
plugin_test.go
Move pluginCommands into Channels (#18974)
2021-11-12 10:35:14 +05:30
plugin.go
Move pluginCommands into Channels (#18974)
2021-11-12 10:35:14 +05:30
post_local.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
post_test.go
MM-36893 : Specially crafted message request crashes the webapp for users who view the message (#18835)
2021-10-29 10:46:00 -04:00
post.go
MM-36893 : Specially crafted message request crashes the webapp for users who view the message (#18835)
2021-10-29 10:46:00 -04:00
preference_test.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
preference.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
reaction_test.go
[MM-36444] Manage config deprecations for 6.0 (#18035)
2021-09-14 13:22:59 -04:00
reaction.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
remote_cluster.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
role_local.go
MM-32396 Create endpoint for listing all the roles (#16988)
2021-11-08 16:38:41 +03:00
role_test.go
MM-32396 Create endpoint for listing all the roles (#16988)
2021-11-08 16:38:41 +03:00
role.go
MM-32396 Create endpoint for listing all the roles (#16988)
2021-11-08 16:38:41 +03:00
saml_test.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
saml.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
scheme_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
scheme.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
shared_channel_test.go
MM-38611 getSharedChannels: only return channels user is member of (#18417)
2021-09-20 15:00:47 -04:00
shared_channel.go
MM-38611 getSharedChannels: only return channels user is member of (#18417)
2021-09-20 15:00:47 -04:00
status_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
status.go
remove timedDND feature flag (#18346)
2021-10-14 11:54:09 -04:00
system_local.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
system_test.go
MM-36687 CRT push notifications (#18347)
2021-11-15 10:41:47 +05:30
system.go
MM-36687 CRT push notifications (#18347)
2021-11-15 10:41:47 +05:30
team_local.go
[MM-39060] - A/B Test: Reminder to Join Workspace email (#18894)
2021-11-15 18:42:15 +03:00
team_test.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
team.go
[MM-39060] - A/B Test: Reminder to Join Workspace email (#18894)
2021-11-15 18:42:15 +03:00
terms_of_service_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
terms_of_service.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
upload_local.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
upload_test.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
upload.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
user_local.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
user_test.go
[MM-18946] [MM-26721] [MM-6842] Cross team search+private channel autocomplete (#18468)
2021-10-26 11:30:59 +05:30
user_viewmembers_test.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
user.go
MM-36687 CRT push notifications (#18347)
2021-11-15 10:41:47 +05:30
webhook_local.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
webhook_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
webhook.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
websocket_norace_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
websocket_test.go
MM-39612: Make acquiring and removing connections atomic (#18982)
2021-11-16 19:43:43 +05:30
websocket.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00