* [MM-45564] - Notify Admin v2 * add dummy data * update dummy data * add store methods * experiment with recurring task * complete saving of the notification * make improvements * make improvements * add store layer tests * fix lint * update store layer tests * add app layer unit tests * add store layers * add app layer tests * fix lint * fix lint * fix tests * fix tests lint * fix lint * fix lint * fix retry layer test * add notifications manual trigger * filter notifications based on current plan * add test case * temp change * feedback impl * fix translations * change job scheduler * refactor job * fix store layer tests * extract i18n * fix lint * fix translations * fix translations * add license statement for new file * feedback impl-2 * fix lint * update make file * add intl ids * improve * fix lint * feedback impl * move code and rename files * fix lint * feedback impl * add config for trigger notifications api * fix tests * tmp change * undo temp changes Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
156 строки
5.2 KiB
Go
156 строки
5.2 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
package api4
|
|
|
|
import (
|
|
"net/http"
|
|
"testing"
|
|
|
|
"github.com/mattermost/mattermost-server/v6/model"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestNotifyAdmin(t *testing.T) {
|
|
t.Run("error when plan is unknown when notifying on upgrade", func(t *testing.T) {
|
|
th := Setup(t).InitBasic().InitLogin()
|
|
defer th.TearDown()
|
|
|
|
statusCode, err := th.Client.NotifyAdmin(&model.NotifyAdminToUpgradeRequest{
|
|
RequiredPlan: "Unknown plan",
|
|
RequiredFeature: model.PaidFeatureAllProfessionalfeatures,
|
|
})
|
|
|
|
require.Error(t, err)
|
|
require.Equal(t, err.Error(), ": Unable to save notify data.")
|
|
require.Equal(t, http.StatusInternalServerError, statusCode)
|
|
|
|
})
|
|
|
|
t.Run("error when plan is unknown when notifying to trial", func(t *testing.T) {
|
|
th := Setup(t).InitBasic().InitLogin()
|
|
defer th.TearDown()
|
|
|
|
statusCode, err := th.Client.NotifyAdmin(&model.NotifyAdminToUpgradeRequest{
|
|
RequiredPlan: "Unknown plan",
|
|
RequiredFeature: model.PaidFeatureAllProfessionalfeatures,
|
|
TrialNotification: true,
|
|
})
|
|
|
|
require.Error(t, err)
|
|
require.Equal(t, err.Error(), ": Unable to save notify data.")
|
|
require.Equal(t, http.StatusInternalServerError, statusCode)
|
|
|
|
})
|
|
|
|
t.Run("error when feature is unknown when notifying on upgrade", func(t *testing.T) {
|
|
th := Setup(t).InitBasic().InitLogin()
|
|
defer th.TearDown()
|
|
|
|
statusCode, err := th.Client.NotifyAdmin(&model.NotifyAdminToUpgradeRequest{
|
|
RequiredPlan: model.LicenseShortSkuProfessional,
|
|
RequiredFeature: "Unknown feature",
|
|
})
|
|
|
|
require.Error(t, err)
|
|
require.Equal(t, err.Error(), ": Unable to save notify data.")
|
|
require.Equal(t, http.StatusInternalServerError, statusCode)
|
|
})
|
|
|
|
t.Run("error when feature is unknown when notifying to trial", func(t *testing.T) {
|
|
th := Setup(t).InitBasic().InitLogin()
|
|
defer th.TearDown()
|
|
|
|
statusCode, err := th.Client.NotifyAdmin(&model.NotifyAdminToUpgradeRequest{
|
|
RequiredPlan: model.LicenseShortSkuProfessional,
|
|
RequiredFeature: "Unknown feature",
|
|
TrialNotification: true,
|
|
})
|
|
|
|
require.Error(t, err)
|
|
require.Equal(t, err.Error(), ": Unable to save notify data.")
|
|
require.Equal(t, http.StatusInternalServerError, statusCode)
|
|
})
|
|
|
|
t.Run("error when user tries to notify again on same feature within the cool off period", func(t *testing.T) {
|
|
th := Setup(t).InitBasic().InitLogin()
|
|
defer th.TearDown()
|
|
|
|
statusCode, err := th.Client.NotifyAdmin(&model.NotifyAdminToUpgradeRequest{
|
|
RequiredPlan: model.LicenseShortSkuProfessional,
|
|
RequiredFeature: model.PaidFeatureAllProfessionalfeatures,
|
|
})
|
|
require.NoError(t, err)
|
|
require.Equal(t, http.StatusOK, statusCode)
|
|
|
|
// second attempt to notify for all professional features
|
|
statusCode, err = th.Client.NotifyAdmin(&model.NotifyAdminToUpgradeRequest{
|
|
RequiredPlan: model.LicenseShortSkuProfessional,
|
|
RequiredFeature: model.PaidFeatureAllProfessionalfeatures,
|
|
})
|
|
require.Error(t, err)
|
|
|
|
require.Equal(t, err.Error(), ": Already notified admin")
|
|
require.Equal(t, http.StatusForbidden, statusCode)
|
|
})
|
|
|
|
t.Run("successfully save upgrade notification", func(t *testing.T) {
|
|
th := Setup(t).InitBasic().InitLogin()
|
|
defer th.TearDown()
|
|
|
|
statusCode, err := th.Client.NotifyAdmin(&model.NotifyAdminToUpgradeRequest{
|
|
RequiredPlan: model.LicenseShortSkuProfessional,
|
|
RequiredFeature: model.PaidFeatureAllProfessionalfeatures,
|
|
})
|
|
|
|
require.NoError(t, err)
|
|
require.Equal(t, http.StatusOK, statusCode)
|
|
})
|
|
}
|
|
|
|
func TestTriggerNotifyAdmin(t *testing.T) {
|
|
t.Run("error when EnableAPITriggerAdminNotifications is not true", func(t *testing.T) {
|
|
th := Setup(t).InitBasic().InitLogin()
|
|
defer th.TearDown()
|
|
|
|
th.App.UpdateConfig(func(cfg *model.Config) { *cfg.ServiceSettings.EnableAPITriggerAdminNotifications = false })
|
|
|
|
statusCode, err := th.SystemAdminClient.TriggerNotifyAdmin(&model.NotifyAdminToUpgradeRequest{})
|
|
|
|
require.Error(t, err)
|
|
require.Equal(t, err.Error(), ": Internal error during cloud api request.")
|
|
require.Equal(t, http.StatusForbidden, statusCode)
|
|
|
|
})
|
|
|
|
t.Run("error when non admins try to trigger notifications", func(t *testing.T) {
|
|
th := Setup(t).InitBasic().InitLogin()
|
|
defer th.TearDown()
|
|
|
|
th.App.UpdateConfig(func(cfg *model.Config) { *cfg.ServiceSettings.EnableAPITriggerAdminNotifications = true })
|
|
|
|
statusCode, err := th.Client.TriggerNotifyAdmin(&model.NotifyAdminToUpgradeRequest{})
|
|
|
|
require.Error(t, err)
|
|
require.Equal(t, err.Error(), ": You do not have the appropriate permissions.")
|
|
require.Equal(t, http.StatusForbidden, statusCode)
|
|
})
|
|
|
|
t.Run("happy path", func(t *testing.T) {
|
|
th := Setup(t)
|
|
defer th.TearDown()
|
|
|
|
th.App.UpdateConfig(func(cfg *model.Config) { *cfg.ServiceSettings.EnableAPITriggerAdminNotifications = true })
|
|
|
|
statusCode, err := th.Client.NotifyAdmin(&model.NotifyAdminToUpgradeRequest{
|
|
RequiredPlan: model.LicenseShortSkuProfessional,
|
|
RequiredFeature: model.PaidFeatureAllProfessionalfeatures,
|
|
})
|
|
require.NoError(t, err)
|
|
require.Equal(t, http.StatusOK, statusCode)
|
|
|
|
statusCode, err = th.SystemAdminClient.TriggerNotifyAdmin(&model.NotifyAdminToUpgradeRequest{})
|
|
require.NoError(t, err)
|
|
require.Equal(t, http.StatusOK, statusCode)
|
|
})
|
|
}
|