mirrors/mostlymatter
1
0
Форкнуть 0
Код Задачи Запросы на слияние Действия Пакеты Проекты Релизы Вики Активность
Files
7ce68e89d7effff65e64d8ce711452e431165333
mostlymatter/app
История
Agniva De Sarker 7ce68e89d7 MM-22044: Fix panic on web_conn send hello (#13799) 
* MM-22044: Fix panic on web_conn send hello

(*Hub).Start is the central place for sending all web connection
related traffic. However, there was this one call to (*WebConn).Hello
which tried to send a message to a webconn separately.

This was a rare case, but it did occur under stress conditions generated
from a load test.

When the websocket send SEND_QUEUE_SIZE would get filled up and we would
attempt to make a broadcast, the non-blocking send would close the Send
channel of the web connection. During that time, if a web connection
would try to perform a broadcast, it would try to send to a closed channel
and cause a panic.

The solution is to bring back the sending of hello into the same goroutine
inside (*Hub).Start so that all state is centralised and we avoid
sending to a closed channel by sending the hello message inside the registering
code itself.

* Adding non-blocking send

* Simplify things

* Remove test

* Bring sendHello back

* Improve code further

Co-authored-by: mattermod <mattermod@users.noreply.github.com>
2020-03-30 18:12:40 +05:30
..
layer_generators
Adding the new search engine abstraction (#13304)
2020-03-13 15:33:18 +01:00
plugin_api_tests
…
admin.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
analytics.go
MM-23222 mirror audit logs to file (#14062)
2020-03-17 16:12:56 -04:00
app_iface.go
Removing some unneded FakeApp instance (#14139)
2020-03-27 14:52:57 +01:00
app_test.go
MM-22212 & MM-22208: Read from the higher-scoped scheme if the permission is non-moderated. (#13813)
2020-03-23 13:44:20 -04:00
app.go
Removing some unneded FakeApp instance (#14139)
2020-03-27 14:52:57 +01:00
audit.go
MM-23222 mirror audit logs to file (#14062)
2020-03-17 16:12:56 -04:00
authentication_test.go
…
authentication.go
MM-21976: Include cache layer to be tested (#13749)
2020-03-04 14:18:03 +01:00
authorization_test.go
MM-22212 & MM-22208: Read from the higher-scoped scheme if the permission is non-moderated. (#13813)
2020-03-23 13:44:20 -04:00
authorization.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
auto_channels.go
…
auto_constants.go
…
auto_environment.go
…
auto_posts.go
…
auto_responder_test.go
…
auto_responder.go
…
auto_teams.go
…
auto_users.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
bot_test.go
[MM-22485] Sync bot message to message displayed in webapp (#13867)
2020-03-02 15:57:29 -06:00
bot.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
brand.go
…
busy_test.go
Passing t to all tests setup functions (#13841)
2020-02-10 19:31:41 +01:00
busy.go
…
channel_test.go
[MM-21378] Add mutex to model.Post to guard against race conditions on Post.Props (#13884)
2020-03-13 21:12:20 +01:00
channel.go
MM-22212 & MM-22208: Read from the higher-scoped scheme if the permission is non-moderated. (#13813)
2020-03-23 13:44:20 -04:00
cluster_discovery_test.go
…
cluster_discovery.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
cluster_handlers.go
MM-23254: Add nil checks to WebSocketEventFromJson (#14050)
2020-03-25 21:43:25 -07:00
cluster.go
…
command_away.go
…
command_channel_header_test.go
…
command_channel_header.go
…
command_channel_purpose_test.go
…
command_channel_purpose.go
…
command_channel_rename_test.go
…
command_channel_rename.go
…
command_code_test.go
…
command_code.go
…
command_dnd.go
…
command_echo.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
command_expand_collapse.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
command_groupmsg_test.go
…
command_groupmsg.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
command_help.go
…
command_invite_people_test.go
…
command_invite_people.go
…
command_invite_test.go
…
command_invite.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
command_join_test.go
…
command_join.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
command_leave_test.go
…
command_leave.go
…
command_loadtest.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
command_logout.go
…
command_me_test.go
…
command_me.go
…
command_msg_test.go
…
command_msg.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
command_mute_test.go
…
command_mute.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
command_offline.go
…
command_online.go
…
command_open.go
…
command_remove_test.go
…
command_remove.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
command_search.go
…
command_settings.go
…
command_shortcuts.go
…
command_shrug.go
…
command_test.go
MM-21343: Recognize multi-line slash commands without requiring trailing space after trigger word (#13646)
2020-03-23 14:38:21 -03:00
command.go
MM-21343: Recognize multi-line slash commands without requiring trailing space after trigger word (#13646)
2020-03-23 14:38:21 -03:00
compliance.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
config_test.go
Adding the new search engine abstraction (#13304)
2020-03-13 15:33:18 +01:00
config.go
Adding the new search engine abstraction (#13304)
2020-03-13 15:33:18 +01:00
data_retention.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
diagnostics_test.go
MM-22619: check for nil plugins environment (#13901)
2020-02-15 17:46:26 -05:00
diagnostics.go
Setting to enable new experimental channel sidebar (#14036)
2020-03-17 12:01:59 -04:00
download.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
email_batching_test.go
Adding changes to separate unit tests and integration tests (#13670)
2020-03-02 08:13:39 -08:00
email_batching.go
Making private some methods that are not needed publicly (#13959)
2020-03-03 22:43:48 +01:00
email_test.go
…
email.go
Making private some methods that are not needed publicly (#13959)
2020-03-03 22:43:48 +01:00
emoji.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
enterprise_test.go
Adding changes to separate unit tests and integration tests (#13670)
2020-03-02 08:13:39 -08:00
enterprise.go
Removing some unneded FakeApp instance (#14139)
2020-03-27 14:52:57 +01:00
export_converters.go
add support for exporting and importing props (#14034)
2020-03-23 09:21:05 -04:00
export_test.go
add support for exporting and importing props (#14034)
2020-03-23 09:21:05 -04:00
export.go
Making private some methods that are not needed publicly (#13959)
2020-03-03 22:43:48 +01:00
extract_plugin_tar_test.go
…
extract_plugin_tar.go
…
file_bench_test.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
file_test.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
file.go
Removing some unneded FakeApp instance (#14139)
2020-03-27 14:52:57 +01:00
group_test.go
…
group.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
helper_test.go
Team/Channel members bulk save/update/delete (#14053)
2020-03-27 13:29:17 +01:00
import_functions_test.go
Team/Channel members bulk save/update/delete (#14053)
2020-03-27 13:29:17 +01:00
import_functions.go
Team/Channel members bulk save/update/delete (#14053)
2020-03-27 13:29:17 +01:00
import_test.go
add support for exporting and importing props (#14034)
2020-03-23 09:21:05 -04:00
import_types.go
add support for exporting and importing props (#14034)
2020-03-23 09:21:05 -04:00
import_validators_test.go
…
import_validators.go
MM-22783: Fix scopelint issues (#13969)
2020-03-13 08:44:39 +05:30
import.go
MM-21552: Adding SaveMultiple to posts (#13766)
2020-03-11 14:29:32 +01:00
integration_action_test.go
[MM-21378] Add mutex to model.Post to guard against race conditions on Post.Props (#13884)
2020-03-13 21:12:20 +01:00
integration_action.go
[GH-13968] Add "skip_slack_parsing" to PostActionIntegration… (#13976)
2020-03-26 14:27:55 +01:00
job_test.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
job.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
ldap.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
license_test.go
…
license.go
MM-22235: Fixing stop/start behavior on Elasticsearch engine (#13887)
2020-03-04 00:52:59 +08:00
login_test.go
…
login.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
main_test.go
…
migrations.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
notification_email_test.go
Adding changes to separate unit tests and integration tests (#13670)
2020-03-02 08:13:39 -08:00
notification_email.go
Making private some methods that are not needed publicly (#13959)
2020-03-03 22:43:48 +01:00
notification_push_test.go
MM-23460: Reuse a single HTTP client across all push notifications (#14122)
2020-03-28 09:33:38 +05:30
notification_push.go
MM-23460: Reuse a single HTTP client across all push notifications (#14122)
2020-03-28 09:33:38 +05:30
notification_test.go
MM-23211: Fix user not being notified in out of channel mentions (#14097)
2020-03-24 13:43:25 -07:00
notification.go
MM-23211: Fix user not being notified in out of channel mentions (#14097)
2020-03-24 13:43:25 -07:00
oauth_test.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
oauth.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
opengraph_test.go
…
opengraph.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
opentracing_layer.go
Removing some unneded FakeApp instance (#14139)
2020-03-27 14:52:57 +01:00
options.go
Adding the new search engine abstraction (#13304)
2020-03-13 15:33:18 +01:00
permissions_migrations_test.go
…
permissions_migrations.go
MM-22212 & MM-22208: Read from the higher-scoped scheme if the permission is non-moderated. (#13813)
2020-03-23 13:44:20 -04:00
permissions_test.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
permissions.go
MM-22212 & MM-22208: Read from the higher-scoped scheme if the permission is non-moderated. (#13813)
2020-03-23 13:44:20 -04:00
plugin_api_test.go
MM-23508: Fix plugin API's GetPostsForChannel (#14125)
2020-03-25 10:24:42 +01:00
plugin_api.go
MM-23508: Fix plugin API's GetPostsForChannel (#14125)
2020-03-25 10:24:42 +01:00
plugin_commands_test.go
Remove remaining t.Fatal from the codebase (#13876)
2020-02-13 17:53:23 +01:00
plugin_commands.go
MM-21987 Resolve mentions in slash commands (#13762)
2020-03-11 11:50:12 +01:00
plugin_context.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
plugin_deadlock_test.go
[MM-21378] Add mutex to model.Post to guard against race conditions on Post.Props (#13884)
2020-03-13 21:12:20 +01:00
plugin_event.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
plugin_hooks_test.go
MM-21626, MM-21627 - Plugin API/Hooks Prometheus instrumentati… (#13825)
2020-02-14 15:47:43 -05:00
plugin_install_test.go
…
plugin_install.go
…
plugin_key_value_store.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
plugin_public_keys.go
…
plugin_requests.go
MM-22355 - Fix typos detected by goreportcad.com (#13842)
2020-03-02 17:10:40 +01:00
plugin_shutdown_test.go
Remove remaining t.Fatal from the codebase (#13876)
2020-02-13 17:53:23 +01:00
plugin_signature_test.go
Adding changes to separate unit tests and integration tests (#13670)
2020-03-02 08:13:39 -08:00
plugin_signature.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
plugin_statuses.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
plugin_test.go
[MM-18150] plugin panic trace should not be lost (#13559)
2020-03-11 11:41:11 +04:00
plugin.go
MM-2276: Fix flaky TestPlugin in cmd/mattermost/commands (#14064)
2020-03-17 21:26:59 +05:30
post_metadata_test.go
MM-22707: improved image upload tests and logging (#14018)
2020-03-17 10:20:29 +05:30
post_metadata.go
[MM-21378] Add mutex to model.Post to guard against race conditions on Post.Props (#13884)
2020-03-13 21:12:20 +01:00
post_test.go
MM-22212 & MM-22208: Read from the higher-scoped scheme if the permission is non-moderated. (#13813)
2020-03-23 13:44:20 -04:00
post.go
[MM-21378] Add mutex to model.Post to guard against race conditions on Post.Props (#13884)
2020-03-13 21:12:20 +01:00
preference.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
ratelimit_test.go
…
ratelimit.go
…
reaction.go
Making private some methods that are not needed publicly (#13959)
2020-03-03 22:43:48 +01:00
response_transfer.go
…
role_test.go
MM-22212 & MM-22208: Read from the higher-scoped scheme if the permission is non-moderated. (#13813)
2020-03-23 13:44:20 -04:00
role.go
MM-22212 & MM-22208: Read from the higher-scoped scheme if the permission is non-moderated. (#13813)
2020-03-23 13:44:20 -04:00
saml.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
scheme.go
MM-22212 & MM-22208: Read from the higher-scoped scheme if the permission is non-moderated. (#13813)
2020-03-23 13:44:20 -04:00
searchengine.go
Adding the new search engine abstraction (#13304)
2020-03-13 15:33:18 +01:00
security_update_check.go
…
server_app_adapters.go
Removing some unneded FakeApp instance (#14139)
2020-03-27 14:52:57 +01:00
server_license.go
…
server_test.go
…
server.go
MM-23460: Reuse a single HTTP client across all push notifications (#14122)
2020-03-28 09:33:38 +05:30
session_test.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
session.go
Making private some methods that are not needed publicly (#13959)
2020-03-03 22:43:48 +01:00
slack_test.go
…
slack.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
slackimport_test.go
MM-22560: Fix crash during slack import (#14054)
2020-03-16 21:52:06 +05:30
slackimport.go
MM-22560: Fix crash during slack import (#14054)
2020-03-16 21:52:06 +05:30
status_test.go
…
status.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
svg_test.go
…
svg.go
…
syncables_test.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
syncables.go
MM-22355 - Fix typos detected by goreportcad.com (#13842)
2020-03-02 17:10:40 +01:00
team_test.go
MM-21976: Include cache layer to be tested (#13749)
2020-03-04 14:18:03 +01:00
team.go
Adding the new search engine abstraction (#13304)
2020-03-13 15:33:18 +01:00
terms_of_service.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
user_agent_test.go
[MM-22167] Add mmctl to the User-Agent parser (#13894)
2020-03-19 11:18:17 +01:00
user_agent.go
[MM-22167] Add mmctl to the User-Agent parser (#13894)
2020-03-19 11:18:17 +01:00
user_terms_of_service_test.go
…
user_terms_of_service.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00
user_test.go
[MM-22791] Prevent account creation if new user does not have allowed domain for the team (#14012)
2020-03-17 17:23:59 +03:00
user_viewmembers_test.go
…
user.go
[MM-22791] Prevent account creation if new user does not have allowed domain for the team (#14012)
2020-03-17 17:23:59 +03:00
web_conn_test.go
MM-22265 - Restrict the WS "update_team" event broadcast (#13848)
2020-02-11 03:41:55 -05:00
web_conn.go
MM-22044: Fix panic on web_conn send hello (#13799)
2020-03-30 18:12:40 +05:30
web_hub_test.go
Include Mutex for Hubs property (#13917)
2020-03-02 19:37:57 +01:00
web_hub.go
MM-22044: Fix panic on web_conn send hello (#13799)
2020-03-30 18:12:40 +05:30
webhook_test.go
[MM-21378] Add mutex to model.Post to guard against race conditions on Post.Props (#13884)
2020-03-13 21:12:20 +01:00
webhook.go
[MM-21378] Add mutex to model.Post to guard against race conditions on Post.Props (#13884)
2020-03-13 21:12:20 +01:00
websocket_router.go
MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)
2020-02-13 13:26:58 +01:00