* MM-49845: fixes acknowledgements in getpostsince GetPostsSince returns posts updated after a user requested date. If a user acknowledges a post the post's update at won't change thus not getting that post returned from GetPostsSince. This is troublesome particularly for the mobile client since it relies a lot to GetPostsSince for keeping the data up to date. This commit updates the post's update_at when a user acknowledges/un-acknowledges a post fixing this way the issue above. * Fixes linter * Apply suggestions from code review style changes Co-authored-by: Jesse Hallam <jesse@thehallams.ca> * Rename ack to acknowledgement Co-authored-by: Jesse Hallam <jesse@thehallams.ca>
137 строки
4.6 KiB
Go
137 строки
4.6 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package app
|
|
|
|
import (
|
|
"encoding/json"
|
|
"errors"
|
|
"net/http"
|
|
|
|
"github.com/mattermost/mattermost-server/v6/app/request"
|
|
"github.com/mattermost/mattermost-server/v6/model"
|
|
"github.com/mattermost/mattermost-server/v6/shared/mlog"
|
|
"github.com/mattermost/mattermost-server/v6/store"
|
|
)
|
|
|
|
func (a *App) SaveAcknowledgementForPost(c *request.Context, postID, userID string) (*model.PostAcknowledgement, *model.AppError) {
|
|
post, err := a.GetSinglePost(postID, false)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
channel, err := a.GetChannel(c, post.ChannelId)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if channel.DeleteAt > 0 {
|
|
return nil, model.NewAppError("SaveAcknowledgementForPost", "api.acknowledgement.save.archived_channel.app_error", nil, "", http.StatusForbidden)
|
|
}
|
|
|
|
acknowledgedAt := model.GetMillis()
|
|
acknowledgement, nErr := a.Srv().Store().PostAcknowledgement().Save(postID, userID, acknowledgedAt)
|
|
|
|
if nErr != nil {
|
|
var appErr *model.AppError
|
|
switch {
|
|
case errors.As(nErr, &appErr):
|
|
return nil, appErr
|
|
default:
|
|
return nil, model.NewAppError("SaveAcknowledgementForPost", "app.acknowledgement.save.save.app_error", nil, "", http.StatusInternalServerError).Wrap(nErr)
|
|
}
|
|
}
|
|
|
|
// The post is always modified since the UpdateAt always changes
|
|
a.invalidateCacheForChannelPosts(channel.Id)
|
|
|
|
a.Srv().Go(func() {
|
|
a.sendAcknowledgementEvent(model.WebsocketEventAcknowledgementAdded, acknowledgement, post)
|
|
})
|
|
|
|
return acknowledgement, nil
|
|
}
|
|
|
|
func (a *App) DeleteAcknowledgementForPost(c *request.Context, postID, userID string) *model.AppError {
|
|
post, err := a.GetSinglePost(postID, false)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
channel, err := a.GetChannel(c, post.ChannelId)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if channel.DeleteAt > 0 {
|
|
return model.NewAppError("DeleteAcknowledgementForPost", "api.acknowledgement.delete.archived_channel.app_error", nil, "", http.StatusForbidden)
|
|
}
|
|
|
|
oldAck, nErr := a.Srv().Store().PostAcknowledgement().Get(postID, userID)
|
|
|
|
if nErr != nil {
|
|
var nfErr *store.ErrNotFound
|
|
switch {
|
|
case errors.As(nErr, &nfErr):
|
|
return model.NewAppError("GetPostAcknowledgement", "app.acknowledgement.get.app_error", nil, "", http.StatusNotFound).Wrap(nErr)
|
|
default:
|
|
return model.NewAppError("GetPostAcknowledgement", "app.acknowledgement.get.app_error", nil, "", http.StatusInternalServerError).Wrap(nErr)
|
|
}
|
|
}
|
|
|
|
if model.GetMillis()-oldAck.AcknowledgedAt > 5*60*1000 {
|
|
return model.NewAppError("DeleteAcknowledgementForPost", "api.acknowledgement.delete.deadline.app_error", nil, "", http.StatusForbidden)
|
|
}
|
|
|
|
nErr = a.Srv().Store().PostAcknowledgement().Delete(oldAck)
|
|
if nErr != nil {
|
|
return model.NewAppError("DeleteAcknowledgementForPost", "app.acknowledgement.delete.app_error", nil, "", http.StatusInternalServerError).Wrap(nErr)
|
|
}
|
|
|
|
// The post is always modified since the UpdateAt always changes
|
|
a.invalidateCacheForChannelPosts(channel.Id)
|
|
|
|
a.Srv().Go(func() {
|
|
a.sendAcknowledgementEvent(model.WebsocketEventAcknowledgementRemoved, oldAck, post)
|
|
})
|
|
|
|
return nil
|
|
}
|
|
|
|
func (a *App) GetAcknowledgementsForPost(postID string) ([]*model.PostAcknowledgement, *model.AppError) {
|
|
acknowledgements, nErr := a.Srv().Store().PostAcknowledgement().GetForPost(postID)
|
|
if nErr != nil {
|
|
return nil, model.NewAppError("GetAcknowledgementsForPost", "app.acknowledgement.getforpost.get.app_error", nil, "", http.StatusInternalServerError).Wrap(nErr)
|
|
}
|
|
|
|
return acknowledgements, nil
|
|
}
|
|
|
|
func (a *App) GetAcknowledgementsForPostList(postList *model.PostList) (map[string][]*model.PostAcknowledgement, *model.AppError) {
|
|
acknowledgements, err := a.Srv().Store().PostAcknowledgement().GetForPosts(postList.Order)
|
|
|
|
if err != nil {
|
|
return nil, model.NewAppError("GetPostAcknowledgementsForPostList", "app.acknowledgement.get.app_error", nil, "", http.StatusInternalServerError).Wrap(err)
|
|
}
|
|
|
|
acknowledgementsMap := make(map[string][]*model.PostAcknowledgement)
|
|
|
|
for _, ack := range acknowledgements {
|
|
acknowledgementsMap[ack.PostId] = append(acknowledgementsMap[ack.PostId], ack)
|
|
}
|
|
|
|
return acknowledgementsMap, nil
|
|
}
|
|
|
|
func (a *App) sendAcknowledgementEvent(event string, acknowledgement *model.PostAcknowledgement, post *model.Post) {
|
|
// send out that a acknowledgement has been added/removed
|
|
message := model.NewWebSocketEvent(event, "", post.ChannelId, "", nil, "")
|
|
|
|
acknowledgementJSON, err := json.Marshal(acknowledgement)
|
|
if err != nil {
|
|
a.Log().Warn("Failed to encode acknowledgement to JSON", mlog.Err(err))
|
|
}
|
|
message.Add("acknowledgement", string(acknowledgementJSON))
|
|
a.Publish(message)
|
|
}
|