Files
mostlymatter/server/public/model/custom_profile_attributes.go
Julien Tant cb89e5646e [MM-62695] Extend property types for CPA (#30201)
* test: Add unit tests for custom profile attributes select options

* feat: Add custom profile attributes model with validation and constants

* refactor: Trim spaces from name and color in custom profile attribute select option constructor

* gofmt

* refactor: Fix typo in custom profile attributes select option function name

* feat: Add IsValid method to validate CustomProfileAttributesSelectOptions

* refactor: Replace map[string]bool with map[string]struct{} for key existence check

* refactor: Rename NewCustomProfileAttributeSelectOption to NewCustomProfileAttributesSelectOption

* feat: Add validation to prevent empty custom profile attribute options

* refactor: Add validation and creation methods for custom profile attributes

* feat: Add index number to validation error messages in custom profile attributes

* fix tests

* add default visibility

* feat: Add comprehensive test cases for custom profile attributes field validation

* fix: Update custom profile attributes map keys to use capitalized names

* feat: Add support for lowercase and title case keys in custom profile attributes map

* test: Add comprehensive test for NewCustomProfileAttributesSelectOptionFromMap

* feat: Add validation for custom profile attributes fields

* refactor: Update CustomProfileAttributesSelectOption constructor to prioritize ID parameter

* test: Add test cases for preserving IDs in custom profile attributes

* feat: Enhance ID validation and trimming in custom profile attributes

* don't do validation in constructor

* test: Add test case for preserving option IDs when patching select field

* improve test

* i18n

* refactor: Modify CustomProfileAttributesSelectOption to use lowercase JSON keys

* fix casing in custom profilte attributes test

* refactor: Use consistent "ValidateCPAField" in error messages for custom profile attributes

* use custom types rather than string

* lint

* fix api test

* refactor: Make color field optional in custom profile attributes

* style

* generic options

* removed unused i18n

* test: Add tests for NewCPAFieldFromPropertyField and CPAFieldToPropertyField

* test: Add test case for property field with empty attributes

* refactor: Cleanup whitespace and remove empty Attrs in custom profile attributes test

* test: Add test case for CPA field with empty attributes

* refactor: Improve custom profile attributes field handling and validation

* refactor: Move validateCustomProfileAttributesField to Validate method on CPAField struct

* use CPAField

* code style

* add validation and tests

* tests

* i18n

* err->appErr

* fix TestDeleteCPAField test

* i18n

* Add SAML and LDAP attr

* rename CustomProfileAttributes in method to CPA

* rename CPASortOrder method

* rearrange consts

* use Len test method

* sanitize and validate

* manage error the same way property field and value do

* fix: Update test error ID for custom profile attributes validation

* test: Update error ID expectations in custom profile attributes tests

* refactor: Convert CPAAttrs.SortOrder from string to int

* json uses float64

* feat: Add length validation for custom profile attribute option name and color

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
2025-03-20 18:47:40 +00:00

212 строки
5.7 KiB
Go

// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
// See LICENSE.txt for license information.
package model
import (
"encoding/json"
"errors"
"fmt"
"net/http"
"strings"
)
const CustomProfileAttributesPropertyGroupName = "custom_profile_attributes"
func CPASortOrder(p *PropertyField) int {
value, ok := p.Attrs[CustomProfileAttributesPropertyAttrsSortOrder]
if !ok {
return 0
}
sortOrder, ok := value.(float64)
if !ok {
return 0
}
return int(sortOrder)
}
const (
// Attributes keys
CustomProfileAttributesPropertyAttrsSortOrder = "sort_order"
CustomProfileAttributesPropertyAttrsValueType = "value_type"
CustomProfileAttributesPropertyAttrsVisibility = "visibility"
CustomProfileAttributesPropertyAttrsLDAP = "ldap"
CustomProfileAttributesPropertyAttrsSAML = "saml"
// Value Types
CustomProfileAttributesValueTypeEmail = "email"
CustomProfileAttributesValueTypeURL = "url"
CustomProfileAttributesValueTypePhone = "phone"
// Visibility
CustomProfileAttributesVisibilityHidden = "hidden"
CustomProfileAttributesVisibilityWhenSet = "when_set"
CustomProfileAttributesVisibilityAlways = "always"
CustomProfileAttributesVisibilityDefault = CustomProfileAttributesVisibilityWhenSet
)
const (
CPAOptionNameMaxLength = 128
CPAOptionColorMaxLength = 128
)
func IsKnownCPAValueType(valueType string) bool {
switch valueType {
case CustomProfileAttributesValueTypeEmail,
CustomProfileAttributesValueTypeURL,
CustomProfileAttributesValueTypePhone:
return true
}
return false
}
func IsKnownCPAVisibility(visibility string) bool {
switch visibility {
case CustomProfileAttributesVisibilityHidden,
CustomProfileAttributesVisibilityWhenSet,
CustomProfileAttributesVisibilityAlways:
return true
}
return false
}
type CustomProfileAttributesSelectOption struct {
ID string `json:"id"`
Name string `json:"name"`
Color string `json:"color"`
}
func (c CustomProfileAttributesSelectOption) GetID() string {
return c.ID
}
func (c CustomProfileAttributesSelectOption) GetName() string {
return c.Name
}
func (c *CustomProfileAttributesSelectOption) SetID(id string) {
c.ID = id
}
func (c CustomProfileAttributesSelectOption) IsValid() error {
if c.ID == "" {
return errors.New("id cannot be empty")
}
if !IsValidId(c.ID) {
return errors.New("id is not a valid ID")
}
if c.Name == "" {
return errors.New("name cannot be empty")
}
if len(c.Name) > CPAOptionNameMaxLength {
return fmt.Errorf("name is too long, max length is %d", CPAOptionNameMaxLength)
}
if c.Color != "" && len(c.Color) > CPAOptionColorMaxLength {
return fmt.Errorf("color is too long, max length is %d", CPAOptionColorMaxLength)
}
return nil
}
type CPAField struct {
PropertyField
Attrs CPAAttrs
}
type CPAAttrs struct {
Visibility string `json:"visibility"`
SortOrder int `json:"sort_order"`
Options PropertyOptions[*CustomProfileAttributesSelectOption] `json:"options"`
ValueType string `json:"value_type"`
LDAP string `json:"ldap"`
SAML string `json:"saml"`
}
func (c *CPAField) ToPropertyField() *PropertyField {
pf := c.PropertyField
pf.Attrs = StringInterface{
CustomProfileAttributesPropertyAttrsVisibility: c.Attrs.Visibility,
CustomProfileAttributesPropertyAttrsSortOrder: c.Attrs.SortOrder,
CustomProfileAttributesPropertyAttrsValueType: c.Attrs.ValueType,
PropertyFieldAttributeOptions: c.Attrs.Options,
CustomProfileAttributesPropertyAttrsLDAP: c.Attrs.LDAP,
CustomProfileAttributesPropertyAttrsSAML: c.Attrs.SAML,
}
return &pf
}
func (c *CPAField) SanitizeAndValidate() *AppError {
switch c.Type {
case PropertyFieldTypeText:
if valueType := strings.TrimSpace(c.Attrs.ValueType); valueType != "" {
if !IsKnownCPAValueType(valueType) {
return NewAppError("SanitizeAndValidate", "app.custom_profile_attributes.sanitize_and_validate.app_error", map[string]any{
"AttributeName": CustomProfileAttributesPropertyAttrsValueType,
"Reason": "unknown value type",
}, "", http.StatusUnprocessableEntity)
}
c.Attrs.ValueType = valueType
}
case PropertyFieldTypeSelect, PropertyFieldTypeMultiselect:
options := c.Attrs.Options
// add an ID to options with no ID
for i := range options {
if options[i].ID == "" {
options[i].ID = NewId()
}
}
if err := options.IsValid(); err != nil {
return NewAppError("SanitizeAndValidate", "app.custom_profile_attributes.sanitize_and_validate.app_error", map[string]any{
"AttributeName": PropertyFieldAttributeOptions,
"Reason": err.Error(),
}, "", http.StatusUnprocessableEntity).Wrap(err)
}
c.Attrs.Options = options
}
visibility := CustomProfileAttributesVisibilityDefault
if visibilityAttr := strings.TrimSpace(c.Attrs.Visibility); visibilityAttr != "" {
if !IsKnownCPAVisibility(visibilityAttr) {
return NewAppError("SanitizeAndValidate", "app.custom_profile_attributes.sanitize_and_validate.app_error", map[string]any{
"AttributeName": CustomProfileAttributesPropertyAttrsVisibility,
"Reason": "unknown visibility",
}, "", http.StatusUnprocessableEntity)
}
visibility = visibilityAttr
}
c.Attrs.Visibility = visibility
return nil
}
func NewCPAFieldFromPropertyField(pf *PropertyField) (*CPAField, error) {
attrsJSON, err := json.Marshal(pf.Attrs)
if err != nil {
return nil, err
}
var attrs CPAAttrs
err = json.Unmarshal(attrsJSON, &attrs)
if err != nil {
return nil, err
}
return &CPAField{
PropertyField: *pf,
Attrs: attrs,
}, nil
}