0e9ad9f7f8
* Replacing require.Nil with require.NoError * More replacements * More Nil/NotNill to NoError/Error * Other detected errors * renaming apperr to err * Removed not needed line * Rename old appErr variables that are no longer model.AppError values * Fixing tiny typo * Reverting changes outside the store (accidentally added) * Apply suggestions from code review Co-authored-by: Doug Lauder <wiggin77@warpmail.net> Co-authored-by: Doug Lauder <wiggin77@warpmail.net>
83 строки
2.6 KiB
Go
83 строки
2.6 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package sqlstore
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/mattermost/mattermost-server/v5/model"
|
|
"github.com/mattermost/mattermost-server/v5/store"
|
|
"github.com/mattermost/mattermost-server/v5/store/storetest"
|
|
)
|
|
|
|
func TestPreferenceStore(t *testing.T) {
|
|
StoreTest(t, storetest.TestPreferenceStore)
|
|
}
|
|
|
|
func TestDeleteUnusedFeatures(t *testing.T) {
|
|
StoreTest(t, func(t *testing.T, ss store.Store) {
|
|
userId1 := model.NewId()
|
|
userId2 := model.NewId()
|
|
category := model.PREFERENCE_CATEGORY_ADVANCED_SETTINGS
|
|
feature1 := "feature1"
|
|
feature2 := "feature2"
|
|
|
|
features := model.Preferences{
|
|
{
|
|
UserId: userId1,
|
|
Category: category,
|
|
Name: store.FeatureTogglePrefix + feature1,
|
|
Value: "true",
|
|
},
|
|
{
|
|
UserId: userId2,
|
|
Category: category,
|
|
Name: store.FeatureTogglePrefix + feature1,
|
|
Value: "false",
|
|
},
|
|
{
|
|
UserId: userId1,
|
|
Category: category,
|
|
Name: store.FeatureTogglePrefix + feature2,
|
|
Value: "false",
|
|
},
|
|
{
|
|
UserId: userId2,
|
|
Category: category,
|
|
Name: store.FeatureTogglePrefix + feature2,
|
|
Value: "true",
|
|
},
|
|
}
|
|
|
|
err := ss.Preference().Save(&features)
|
|
require.NoError(t, err)
|
|
|
|
ss.Preference().(*SqlPreferenceStore).deleteUnusedFeatures()
|
|
|
|
//make sure features with value "false" have actually been deleted from the database
|
|
if val, err := ss.Preference().(*SqlPreferenceStore).GetReplica().SelectInt(`SELECT COUNT(*)
|
|
FROM Preferences
|
|
WHERE Category = :Category
|
|
AND Value = :Val
|
|
AND Name LIKE '`+store.FeatureTogglePrefix+`%'`, map[string]interface{}{"Category": model.PREFERENCE_CATEGORY_ADVANCED_SETTINGS, "Val": "false"}); err != nil {
|
|
require.NoError(t, err)
|
|
} else if val != 0 {
|
|
require.Fail(t, "Found %d features with value 'false', expected all to be deleted", val)
|
|
}
|
|
//
|
|
// make sure features with value "true" remain saved
|
|
if val, err := ss.Preference().(*SqlPreferenceStore).GetReplica().SelectInt(`SELECT COUNT(*)
|
|
FROM Preferences
|
|
WHERE Category = :Category
|
|
AND Value = :Val
|
|
AND Name LIKE '`+store.FeatureTogglePrefix+`%'`, map[string]interface{}{"Category": model.PREFERENCE_CATEGORY_ADVANCED_SETTINGS, "Val": "true"}); err != nil {
|
|
require.NoError(t, err)
|
|
} else if val == 0 {
|
|
require.Fail(t, "Found %d features with value 'true', expected to find at least %d features", val, 2)
|
|
}
|
|
})
|
|
}
|