* refactor: refactored deleteUnusedFeatures * refactor: refactored Get to remove hardcoded sql queries * refactor: remove debug log * refactor: refactored getcategory * refactor: refactored GetAll to replace with sq * refactor: refactor delete with sq * refactor: refactored delete category with sq * refactor: refactored cleanup flagsbatch * refactor: refactor save to usq sq * fix: fixed missing wildcard in LIKE operator * refactor: fixed previous double call to database with a cleaner approach * refactor: removed debug logs * refactor: removed debug logs * fix: added a new error checking as Limit accepts uint and the function parameter accepts int * fix: golangcilint error Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
308 строки
10 KiB
Go
308 строки
10 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package sqlstore
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
sq "github.com/Masterminds/squirrel"
|
|
"github.com/mattermost/gorp"
|
|
"github.com/mattermost/mattermost-server/v5/model"
|
|
"github.com/mattermost/mattermost-server/v5/shared/mlog"
|
|
"github.com/mattermost/mattermost-server/v5/store"
|
|
"github.com/pkg/errors"
|
|
)
|
|
|
|
type SqlPreferenceStore struct {
|
|
*SqlStore
|
|
}
|
|
|
|
func newSqlPreferenceStore(sqlStore *SqlStore) store.PreferenceStore {
|
|
s := &SqlPreferenceStore{sqlStore}
|
|
|
|
for _, db := range sqlStore.GetAllConns() {
|
|
table := db.AddTableWithName(model.Preference{}, "Preferences").SetKeys(false, "UserId", "Category", "Name")
|
|
table.ColMap("UserId").SetMaxSize(26)
|
|
table.ColMap("Category").SetMaxSize(32)
|
|
table.ColMap("Name").SetMaxSize(32)
|
|
table.ColMap("Value").SetMaxSize(2000)
|
|
}
|
|
|
|
return s
|
|
}
|
|
|
|
func (s SqlPreferenceStore) createIndexesIfNotExists() {
|
|
s.CreateIndexIfNotExists("idx_preferences_user_id", "Preferences", "UserId")
|
|
s.CreateIndexIfNotExists("idx_preferences_category", "Preferences", "Category")
|
|
s.CreateIndexIfNotExists("idx_preferences_name", "Preferences", "Name")
|
|
}
|
|
|
|
func (s SqlPreferenceStore) deleteUnusedFeatures() {
|
|
mlog.Debug("Deleting any unused pre-release features")
|
|
sql, args, err := s.getQueryBuilder().
|
|
Delete("Preferences").
|
|
Where(sq.Eq{"Category": model.PREFERENCE_CATEGORY_ADVANCED_SETTINGS}).
|
|
Where(sq.Eq{"Value": "false"}).
|
|
Where(sq.Like{"Name": store.FeatureTogglePrefix + "%"}).ToSql()
|
|
if err != nil {
|
|
mlog.Warn(errors.Wrap(err, "could not build sql query to delete unused features!").Error())
|
|
}
|
|
if _, err = s.GetMaster().Exec(sql, args...); err != nil {
|
|
mlog.Warn("Failed to delete unused features", mlog.Err(err))
|
|
}
|
|
}
|
|
|
|
func (s SqlPreferenceStore) Save(preferences *model.Preferences) error {
|
|
// wrap in a transaction so that if one fails, everything fails
|
|
transaction, err := s.GetMaster().Begin()
|
|
if err != nil {
|
|
return errors.Wrap(err, "begin_transaction")
|
|
}
|
|
|
|
defer finalizeTransaction(transaction)
|
|
for _, preference := range *preferences {
|
|
preference := preference
|
|
if upsertErr := s.save(transaction, &preference); upsertErr != nil {
|
|
return upsertErr
|
|
}
|
|
}
|
|
|
|
if err := transaction.Commit(); err != nil {
|
|
// don't need to rollback here since the transaction is already closed
|
|
return errors.Wrap(err, "commit_transaction")
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (s SqlPreferenceStore) save(transaction *gorp.Transaction, preference *model.Preference) error {
|
|
preference.PreUpdate()
|
|
|
|
if err := preference.IsValid(); err != nil {
|
|
return err
|
|
}
|
|
|
|
if s.DriverName() == model.DATABASE_DRIVER_MYSQL {
|
|
queryString, args, err := s.getQueryBuilder().
|
|
Insert("Preferences").
|
|
Columns("UserId", "Category", "Name", "Value").
|
|
Values(preference.UserId, preference.Category, preference.Name, preference.Value).
|
|
SuffixExpr(sq.Expr("ON DUPLICATE KEY UPDATE Value = ?", preference.Value)).
|
|
ToSql()
|
|
|
|
if err != nil {
|
|
return errors.Wrap(err, "failed to generate sqlquery")
|
|
}
|
|
|
|
if _, err = transaction.Exec(queryString, args...); err != nil {
|
|
return errors.Wrap(err, "failed to save Preference")
|
|
}
|
|
return nil
|
|
} else if s.DriverName() == model.DATABASE_DRIVER_POSTGRES {
|
|
|
|
// postgres has no way to upsert values until version 9.5 and trying inserting and then updating causes transactions to abort
|
|
queryString, args, err := s.getQueryBuilder().
|
|
Select("count(0)").
|
|
From("Preferences").
|
|
Where(sq.Eq{"UserId": preference.UserId}).
|
|
Where(sq.Eq{"Category": preference.Category}).
|
|
Where(sq.Eq{"Name": preference.Name}).
|
|
ToSql()
|
|
|
|
if err != nil {
|
|
return errors.Wrap(err, "failed to generate sqlquery")
|
|
}
|
|
|
|
count, err := transaction.SelectInt(queryString, args...)
|
|
if err != nil {
|
|
return errors.Wrap(err, "failed to count Preferences")
|
|
}
|
|
|
|
if count == 1 {
|
|
return s.update(transaction, preference)
|
|
}
|
|
return s.insert(transaction, preference)
|
|
}
|
|
return store.NewErrNotImplemented("failed to update preference because of missing driver")
|
|
}
|
|
|
|
func (s SqlPreferenceStore) insert(transaction *gorp.Transaction, preference *model.Preference) error {
|
|
if err := transaction.Insert(preference); err != nil {
|
|
if IsUniqueConstraintError(err, []string{"UserId", "preferences_pkey"}) {
|
|
return store.NewErrInvalidInput("Preference", "<userId, category, name>", fmt.Sprintf("<%s, %s, %s>", preference.UserId, preference.Category, preference.Name))
|
|
}
|
|
return errors.Wrapf(err, "failed to save Preference with userId=%s, category=%s, name=%s", preference.UserId, preference.Category, preference.Name)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (s SqlPreferenceStore) update(transaction *gorp.Transaction, preference *model.Preference) error {
|
|
if _, err := transaction.Update(preference); err != nil {
|
|
return errors.Wrapf(err, "failed to update Preference with userId=%s, category=%s, name=%s", preference.UserId, preference.Category, preference.Name)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (s SqlPreferenceStore) Get(userId string, category string, name string) (*model.Preference, error) {
|
|
var preference *model.Preference
|
|
query, args, err := s.getQueryBuilder().
|
|
Select("*").
|
|
From("Preferences").
|
|
Where(sq.Eq{"UserId": userId}).
|
|
Where(sq.Eq{"Category": category}).
|
|
Where(sq.Eq{"Name": name}).
|
|
ToSql()
|
|
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "could not build sql query to get preference")
|
|
}
|
|
if err = s.GetReplica().SelectOne(&preference, query, args...); err != nil {
|
|
return nil, errors.Wrapf(err, "failed to find Preference with userId=%s, category=%s, name=%s", userId, category, name)
|
|
}
|
|
|
|
return preference, nil
|
|
}
|
|
|
|
func (s SqlPreferenceStore) GetCategory(userId string, category string) (model.Preferences, error) {
|
|
var preferences model.Preferences
|
|
query, args, err := s.getQueryBuilder().
|
|
Select("*").
|
|
From("Preferences").
|
|
Where(sq.Eq{"UserId": userId}).
|
|
Where(sq.Eq{"Category": category}).
|
|
ToSql()
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "could not build sql query to get preference")
|
|
}
|
|
if _, err = s.GetReplica().Select(&preferences, query, args...); err != nil {
|
|
return nil, errors.Wrapf(err, "failed to find Preference with userId=%s, category=%s", userId, category)
|
|
}
|
|
return preferences, nil
|
|
|
|
}
|
|
|
|
func (s SqlPreferenceStore) GetAll(userId string) (model.Preferences, error) {
|
|
var preferences model.Preferences
|
|
query, args, err := s.getQueryBuilder().
|
|
Select("*").
|
|
From("Preferences").
|
|
Where(sq.Eq{"UserId": userId}).
|
|
ToSql()
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "could not build sql query to get preference")
|
|
}
|
|
if _, err = s.GetReplica().Select(&preferences, query, args...); err != nil {
|
|
return nil, errors.Wrapf(err, "failed to find Preference with userId=%s", userId)
|
|
}
|
|
return preferences, nil
|
|
}
|
|
|
|
func (s SqlPreferenceStore) PermanentDeleteByUser(userId string) error {
|
|
sql, args, err := s.getQueryBuilder().
|
|
Delete("Preferences").
|
|
Where(sq.Eq{"UserId": userId}).ToSql()
|
|
if err != nil {
|
|
return errors.Wrap(err, "could not build sql query to get delete preference by user")
|
|
}
|
|
if _, err := s.GetMaster().Exec(sql, args...); err != nil {
|
|
return errors.Wrapf(err, "failed to delete Preference with userId=%s", userId)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (s SqlPreferenceStore) Delete(userId, category, name string) error {
|
|
|
|
sql, args, err := s.getQueryBuilder().
|
|
Delete("Preferences").
|
|
Where(sq.Eq{"UserId": userId}).
|
|
Where(sq.Eq{"Category": category}).
|
|
Where(sq.Eq{"Name": name}).ToSql()
|
|
|
|
if err != nil {
|
|
return errors.Wrap(err, "could not build sql query to get delete preference")
|
|
}
|
|
|
|
if _, err = s.GetMaster().Exec(sql, args...); err != nil {
|
|
return errors.Wrapf(err, "failed to delete Preference with userId=%s, category=%s and name=%s", userId, category, name)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (s SqlPreferenceStore) DeleteCategory(userId string, category string) error {
|
|
|
|
sql, args, err := s.getQueryBuilder().
|
|
Delete("Preferences").
|
|
Where(sq.Eq{"UserId": userId}).
|
|
Where(sq.Eq{"Category": category}).ToSql()
|
|
|
|
if err != nil {
|
|
return errors.Wrap(err, "could not build sql query to get delete preference by category")
|
|
}
|
|
|
|
if _, err = s.GetMaster().Exec(sql, args...); err != nil {
|
|
return errors.Wrapf(err, "failed to delete Preference with userId=%s and category=%s", userId, category)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (s SqlPreferenceStore) DeleteCategoryAndName(category string, name string) error {
|
|
sql, args, err := s.getQueryBuilder().
|
|
Delete("Preferences").
|
|
Where(sq.Eq{"Name": name}).
|
|
Where(sq.Eq{"Category": category}).ToSql()
|
|
|
|
if err != nil {
|
|
return errors.Wrap(err, "could not build sql query to get delete preference by category and name")
|
|
}
|
|
|
|
if _, err = s.GetMaster().Exec(sql, args...); err != nil {
|
|
return errors.Wrapf(err, "failed to delete Preference with category=%s and name=%s", category, name)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (s SqlPreferenceStore) CleanupFlagsBatch(limit int64) (int64, error) {
|
|
if limit < 0 {
|
|
// uint64 does not throw an error, it overflows if it is negative.
|
|
// it is better to manually check here, or change the function type to uint64
|
|
return int64(0), errors.Errorf("Received a negative limit")
|
|
}
|
|
nameInQ, nameInArgs, err := sq.Select("*").
|
|
FromSelect(
|
|
sq.Select("Preferences.Name").
|
|
From("Preferences").
|
|
LeftJoin("Posts ON Preferences.Name = Posts.Id").
|
|
Where(sq.Eq{"Preferences.Category": model.PREFERENCE_CATEGORY_FLAGGED_POST}).
|
|
Where(sq.Eq{"Posts.Id": nil}).
|
|
Limit(uint64(limit)),
|
|
"t").
|
|
ToSql()
|
|
if err != nil {
|
|
return int64(0), errors.Wrap(err, "could not build nested sql query to delete preference")
|
|
}
|
|
query, args, err := s.getQueryBuilder().Delete("Preferences").
|
|
Where(sq.Eq{"Category": model.PREFERENCE_CATEGORY_FLAGGED_POST}).
|
|
Where(sq.Expr("name IN ("+nameInQ+")", nameInArgs...)).
|
|
ToSql()
|
|
|
|
if err != nil {
|
|
return int64(0), errors.Wrap(err, "could not build sql query to delete preference")
|
|
}
|
|
|
|
sqlResult, err := s.GetMaster().Exec(query, args...)
|
|
if err != nil {
|
|
return int64(0), errors.Wrap(err, "failed to delete Preference")
|
|
}
|
|
rowsAffected, err := sqlResult.RowsAffected()
|
|
if err != nil {
|
|
return int64(0), errors.Wrap(err, "unable to get rows affected")
|
|
}
|
|
|
|
return rowsAffected, nil
|
|
}
|