* Adding Upgrade to Enterprise version feature * Addressing PR review comments, and adding some minor improvements * Add tests file * Addressing PR comments * fix linter checks * Storing and exposing the upgraded from TE info * Fix showing errors on mac * A more appropiate status code for not-supported upgrade * Fixing tests * Handling permissions errors * More server logging around upgrade failures * Apply text changes suggested from code review Co-authored-by: Eric Sadur <57730300+esadur@users.noreply.github.com> * Address PR review comments * Only allow to restart the system after an upgrade * Verify file signature before upgrade * Adding limit to the downloaded file * Simplifying the upgrade binary process with backup in memory * Fixing backup/restore mechanism for the binary file * Improve file permissions handling * Askin the permissions for the right place (the parent directory) * Fixing tests * Addressing PR review comments * Fix license headers * Fixing retry layer * Making it work on windows builds * Adding license header * Fixing 2 tests * Fixing tests that need UpgradeFromTE System key mock * Extracting i18n translation * Apply suggestions from code review Co-authored-by: Eric Sadur <57730300+esadur@users.noreply.github.com> * Improving how the errors are written * Fixing another error text * Removing unneeded translation * Fixing upgrade status strings * Update i18n/en.json Co-authored-by: Eric Sadur <57730300+esadur@users.noreply.github.com> * Fixing tests Co-authored-by: Eric Sadur <57730300+esadur@users.noreply.github.com> Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
163 строки
5.4 KiB
Go
163 строки
5.4 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package app
|
|
|
|
import (
|
|
"strconv"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/mock"
|
|
|
|
"github.com/mattermost/mattermost-server/v5/model"
|
|
"github.com/mattermost/mattermost-server/v5/store/storetest/mocks"
|
|
"github.com/mattermost/mattermost-server/v5/utils"
|
|
)
|
|
|
|
func TestConfigListener(t *testing.T) {
|
|
th := Setup(t)
|
|
defer th.TearDown()
|
|
|
|
originalSiteName := th.App.Config().TeamSettings.SiteName
|
|
|
|
listenerCalled := false
|
|
listener := func(oldConfig *model.Config, newConfig *model.Config) {
|
|
assert.False(t, listenerCalled, "listener called twice")
|
|
|
|
assert.Equal(t, *originalSiteName, *oldConfig.TeamSettings.SiteName, "old config contains incorrect site name")
|
|
assert.Equal(t, "test123", *newConfig.TeamSettings.SiteName, "new config contains incorrect site name")
|
|
|
|
listenerCalled = true
|
|
}
|
|
listenerId := th.App.AddConfigListener(listener)
|
|
defer th.App.RemoveConfigListener(listenerId)
|
|
|
|
listener2Called := false
|
|
listener2 := func(oldConfig *model.Config, newConfig *model.Config) {
|
|
assert.False(t, listener2Called, "listener2 called twice")
|
|
|
|
listener2Called = true
|
|
}
|
|
listener2Id := th.App.AddConfigListener(listener2)
|
|
defer th.App.RemoveConfigListener(listener2Id)
|
|
|
|
th.App.UpdateConfig(func(cfg *model.Config) {
|
|
*cfg.TeamSettings.SiteName = "test123"
|
|
})
|
|
|
|
assert.True(t, listenerCalled, "listener should've been called")
|
|
assert.True(t, listener2Called, "listener 2 should've been called")
|
|
}
|
|
|
|
func TestAsymmetricSigningKey(t *testing.T) {
|
|
th := SetupWithStoreMock(t)
|
|
defer th.TearDown()
|
|
assert.NotNil(t, th.App.AsymmetricSigningKey())
|
|
assert.NotEmpty(t, th.App.ClientConfig()["AsymmetricSigningPublicKey"])
|
|
}
|
|
|
|
func TestPostActionCookieSecret(t *testing.T) {
|
|
th := SetupWithStoreMock(t)
|
|
defer th.TearDown()
|
|
assert.Equal(t, 32, len(th.App.PostActionCookieSecret()))
|
|
}
|
|
|
|
func TestClientConfigWithComputed(t *testing.T) {
|
|
th := SetupWithStoreMock(t)
|
|
defer th.TearDown()
|
|
|
|
mockStore := th.App.Srv().Store.(*mocks.Store)
|
|
mockUserStore := mocks.UserStore{}
|
|
mockUserStore.On("Count", mock.Anything).Return(int64(10), nil)
|
|
mockPostStore := mocks.PostStore{}
|
|
mockPostStore.On("GetMaxPostSize").Return(65535, nil)
|
|
mockSystemStore := mocks.SystemStore{}
|
|
mockSystemStore.On("GetByName", "UpgradedFromTE").Return(&model.System{Name: "UpgradedFromTE", Value: "false"}, nil)
|
|
mockSystemStore.On("GetByName", "InstallationDate").Return(&model.System{Name: "InstallationDate", Value: "10"}, nil)
|
|
mockStore.On("User").Return(&mockUserStore)
|
|
mockStore.On("Post").Return(&mockPostStore)
|
|
mockStore.On("System").Return(&mockSystemStore)
|
|
|
|
config := th.App.ClientConfigWithComputed()
|
|
_, ok := config["NoAccounts"]
|
|
assert.True(t, ok, "expected NoAccounts in returned config")
|
|
_, ok = config["MaxPostSize"]
|
|
assert.True(t, ok, "expected MaxPostSize in returned config")
|
|
}
|
|
|
|
func TestEnsureInstallationDate(t *testing.T) {
|
|
th := Setup(t)
|
|
defer th.TearDown()
|
|
|
|
tt := []struct {
|
|
Name string
|
|
PrevInstallationDate *int64
|
|
UsersCreationDates []int64
|
|
ExpectedInstallationDate *int64
|
|
}{
|
|
{
|
|
Name: "New installation: no users, no installation date",
|
|
PrevInstallationDate: nil,
|
|
UsersCreationDates: nil,
|
|
ExpectedInstallationDate: model.NewInt64(utils.MillisFromTime(time.Now())),
|
|
},
|
|
{
|
|
Name: "Old installation: users, no installation date",
|
|
PrevInstallationDate: nil,
|
|
UsersCreationDates: []int64{10000000000, 30000000000, 20000000000},
|
|
ExpectedInstallationDate: model.NewInt64(10000000000),
|
|
},
|
|
{
|
|
Name: "New installation, second run: no users, installation date",
|
|
PrevInstallationDate: model.NewInt64(80000000000),
|
|
UsersCreationDates: []int64{10000000000, 30000000000, 20000000000},
|
|
ExpectedInstallationDate: model.NewInt64(80000000000),
|
|
},
|
|
{
|
|
Name: "Old installation already updated: users, installation date",
|
|
PrevInstallationDate: model.NewInt64(90000000000),
|
|
UsersCreationDates: []int64{10000000000, 30000000000, 20000000000},
|
|
ExpectedInstallationDate: model.NewInt64(90000000000),
|
|
},
|
|
}
|
|
|
|
for _, tc := range tt {
|
|
t.Run(tc.Name, func(t *testing.T) {
|
|
sqlStore := th.GetSqlSupplier()
|
|
sqlStore.GetMaster().Exec("DELETE FROM Users")
|
|
|
|
for _, createAt := range tc.UsersCreationDates {
|
|
user := th.CreateUser()
|
|
user.CreateAt = createAt
|
|
sqlStore.GetMaster().Exec("UPDATE Users SET CreateAt = :CreateAt WHERE Id = :UserId", map[string]interface{}{"CreateAt": createAt, "UserId": user.Id})
|
|
}
|
|
|
|
if tc.PrevInstallationDate == nil {
|
|
th.App.Srv().Store.System().PermanentDeleteByName(model.SYSTEM_INSTALLATION_DATE_KEY)
|
|
} else {
|
|
th.App.Srv().Store.System().SaveOrUpdate(&model.System{
|
|
Name: model.SYSTEM_INSTALLATION_DATE_KEY,
|
|
Value: strconv.FormatInt(*tc.PrevInstallationDate, 10),
|
|
})
|
|
}
|
|
|
|
err := th.App.Srv().ensureInstallationDate()
|
|
|
|
if tc.ExpectedInstallationDate == nil {
|
|
assert.Error(t, err)
|
|
} else {
|
|
assert.NoError(t, err)
|
|
|
|
data, err := th.App.Srv().Store.System().GetByName(model.SYSTEM_INSTALLATION_DATE_KEY)
|
|
assert.Nil(t, err)
|
|
value, _ := strconv.ParseInt(data.Value, 10, 64)
|
|
assert.True(t, *tc.ExpectedInstallationDate <= value && *tc.ExpectedInstallationDate+1000 >= value)
|
|
}
|
|
|
|
sqlStore.GetMaster().Exec("DELETE FROM Users")
|
|
})
|
|
}
|
|
}
|