Jesse Hallam fa6f7f3a62 MM-13678: fix web hub deadlock (#10081) ...

The websocket hub, on stopping, closes all associated websocket connections, and each connection
in turn tries to unregister itself with the hub, but this naturally creates a deadlock.

This PR reverts the line commented (incorretly...) at
https://github.com/mattermost/mattermost-server/pull/9863/files#r235583929.

2019-01-09 10:14:08 -08:00

..

admin.go

Moving app from singular to being created for every request (#9889)

2018-11-28 10:56:21 -08:00

analytics.go

Migrate to idiomatic error handling app/a*.go and app/b*.go (#9455)

2018-09-25 08:42:06 -04:00

app_test.go

Dockerized build updated tests (#9943)

2018-12-06 13:19:32 -05:00

app.go

Cleanup related to context refactor (#9988)

2018-12-17 08:51:46 -08:00

audit.go

Migrate to idiomatic error handling app/a*.go and app/b*.go (#9455)

2018-09-25 08:42:06 -04:00

authentication_test.go

User based rate limiting (#8152)

2018-01-31 09:49:15 -08:00

authentication.go

MM-12976: Moving MFA to Team edition (#9971)

2018-12-12 11:50:19 +01:00

authorization_test.go

Fixing misspell errors (#8544)

2018-03-29 10:04:54 -04:00

authorization.go

MM-12013: Fix post-permission checks to cascade for DM/GM channels. (#9476)

2018-09-27 12:15:47 -07:00

auto_channels.go

MM-8708 Remove api package (#8784)

2018-05-16 13:43:22 -04:00

auto_constants.go

general cleanup (#8387)

2018-03-07 12:36:40 -06:00

auto_environment.go

MM-8708 Remove api package (#8784)

2018-05-16 13:43:22 -04:00

auto_posts.go

Cleanup related to context refactor (#9988)

2018-12-17 08:51:46 -08:00

auto_responder_test.go

Fix for OOO bug that reply message does not get inserted consistently. (#9742)

2018-10-30 14:30:15 -07:00

auto_responder.go

Use constants for NotifyProps keys. (#9901)

2018-11-28 11:11:41 -05:00

auto_teams.go

MM-8708 Remove api package (#8784)

2018-05-16 13:43:22 -04:00

auto_users.go

MM-8708 Remove api package (#8784)

2018-05-16 13:43:22 -04:00

brand.go

Add a delete brand image action on the APIv4 (#9552)

2018-10-15 15:46:26 +01:00

channel_test.go

Moving app from singular to being created for every request (#9889)

2018-11-28 10:56:21 -08:00

channel.go

Send clear push notification when DM has unread messages (#10065)

2019-01-07 13:05:47 -03:00

cluster_discovery_test.go

Fix races / finally remove global app for good (#7570)

2017-10-04 13:09:41 -07:00

cluster_discovery.go

Idiomatic error handling for app/c*.go (#9423)

2018-09-24 13:27:31 +02:00

cluster_handlers.go

remove remaining Global() calls (outside of tests) (#7521)

2017-09-28 00:52:34 +08:00

cluster.go

MM-12849 Moving all non request scoped items to Server struct (#9806)

2018-11-07 10:20:07 -08:00

command_away.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

command_channel_header_test.go

MM-11230: Make permissions checks in commands failsafe. (#9392)

2018-09-12 10:32:05 -04:00

command_channel_header.go

MM-11230: Make permissions checks in commands failsafe. (#9392)

2018-09-12 10:32:05 -04:00

command_channel_purpose_test.go

MM-11230: Make permissions checks in commands failsafe. (#9392)

2018-09-12 10:32:05 -04:00

command_channel_purpose.go

MM-11230: Make permissions checks in commands failsafe. (#9392)

2018-09-12 10:32:05 -04:00

command_channel_rename_test.go

MM-11230: Make permissions checks in commands failsafe. (#9392)

2018-09-12 10:32:05 -04:00

command_channel_rename.go

MM-11230: Make permissions checks in commands failsafe. (#9392)

2018-09-12 10:32:05 -04:00

command_code_test.go

remove more global references (#7442)

2017-09-14 13:01:44 -04:00

command_code.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

command_dnd.go

MM-10254 Add plugin APIs for getting/updating user statuses (#9101)

2018-07-16 15:49:26 -04:00

command_echo.go

MM-12849 Moving all non request scoped items to Server struct (#9806)

2018-11-07 10:20:07 -08:00

command_expand_collapse.go

remove go Publish(...) idiom (#8373)

2018-03-02 16:49:18 +00:00

command_groupmsg_test.go

MM-11227: Fix group msg slash command. (#9070)

2018-07-10 10:54:49 +02:00

command_groupmsg.go

MM-11227: Fix group msg slash command. (#9070)

2018-07-10 10:54:49 +02:00

command_help.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

command_invite_people_test.go

fix TestInvitePeopleProvider test (#9084)

2018-07-10 15:43:06 +02:00

command_invite_people.go

MM-11229: Fix invite people slash command and add test case. (#9074)

2018-07-10 10:56:04 +02:00

command_invite_test.go

MM-12110: Don't /invite or /kick deactivated users. (#9494)

2018-10-01 13:51:12 +01:00

command_invite.go

MM-12110: Don't /invite or /kick deactivated users. (#9494)

2018-10-01 13:51:12 +01:00

command_join_test.go

MM-11230: Make permissions checks in commands failsafe. (#9392)

2018-09-12 10:32:05 -04:00

command_join.go

MM-11230: Make permissions checks in commands failsafe. (#9392)

2018-09-12 10:32:05 -04:00

command_leave_test.go

[MM-12805] Remove ephemeral post after leaving a channel (#9772)

2018-11-05 17:39:46 +08:00

command_leave.go

[MM-12805] Remove ephemeral post after leaving a channel (#9772)

2018-11-05 17:39:46 +08:00

command_loadtest.go

MM-8708 Remove api package (#8784)

2018-05-16 13:43:22 -04:00

command_logout.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

command_me.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

command_msg_test.go

MM-11174: Fix /msg slash command. (#9059)

2018-07-10 10:53:51 +02:00

command_msg.go

Refactor Get/Create Direct Channel into one function (#9867)

2018-11-28 18:01:49 +01:00

command_mute_test.go

Refactor Get/Create Direct Channel into one function (#9867)

2018-11-28 18:01:49 +01:00

command_mute.go

Fix mute channel when not a member and adding unit tests (#8609)

2018-04-12 09:12:59 -04:00

command_offline.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

command_online.go

MM-10254 Add plugin APIs for getting/updating user statuses (#9101)

2018-07-16 15:49:26 -04:00

command_open.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

command_remove_test.go

MM-12110: Don't /invite or /kick deactivated users. (#9494)

2018-10-01 13:51:12 +01:00

command_remove.go

MM-12110: Don't /invite or /kick deactivated users. (#9494)

2018-10-01 13:51:12 +01:00

command_search.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

command_settings.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

command_shortcuts.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

command_shrug.go

more global config ref cleanup (#7802)

2017-11-09 14:46:20 -06:00

command_test.go

[MM-9937] Add support for sending a message to a different channel than where the slash command was issued from (#9878)

2018-12-12 07:43:31 +01:00

command.go

[MM-9937] Add support for sending a message to a different channel than where the slash command was issued from (#9878)

2018-12-12 07:43:31 +01:00

compliance.go

MM-12849 Moving all non request scoped items to Server struct (#9806)

2018-11-07 10:20:07 -08:00

config_test.go

Cleanup related to context refactor (#9988)

2018-12-17 08:51:46 -08:00

config.go

MM-13349: Fix TOS not displaying using sso login in RN apps (#9989)

2018-12-12 10:46:24 -05:00

data_retention.go

PLT-7705: API to get data retention policy. (#7539)

2017-10-02 12:43:21 +01:00

diagnostics_test.go

MM-13027: Don't have a diagnostics segment key in dev builds. (#9938)

2018-12-13 12:31:53 +00:00

diagnostics.go

Revert "Support for Embeded chat (#9129)" (#10017)

2019-01-02 07:57:36 -08:00

elasticsearch.go

Idiomatic error handling for app/e*.go (#9426)

2018-09-24 12:52:29 +05:30

email_batching_test.go

Moving app from singular to being created for every request (#9889)

2018-11-28 10:56:21 -08:00

email_batching.go

Moving app from singular to being created for every request (#9889)

2018-11-28 10:56:21 -08:00

email.go

clean up unused HTML templates (#9830)

2018-11-24 00:55:56 +08:00

emoji.go

MM-11272 Added initial post metadata (#9175)

2018-11-01 15:22:33 -04:00

enterprise.go

MM-12976: Moving MFA to Team edition (#9971)

2018-12-12 11:50:19 +01:00

export_converters.go

MM-13220: Fixes for bulk export problems (#9980)

2018-12-12 14:20:22 +01:00

export_test.go

MM-13220: Fixes for bulk export problems (#9980)

2018-12-12 14:20:22 +01:00

export.go

MM-13220: Fixes for bulk export problems (#9980)

2018-12-12 14:20:22 +01:00

file_bench_test.go

MM-7633: Optimize memory utilization during file uploads (#9835)

2018-12-13 22:32:07 +01:00

file_test.go

Cleanup related to context refactor (#9988)

2018-12-17 08:51:46 -08:00

file.go

MM-7633: Optimize memory utilization during file uploads (#9835)

2018-12-13 22:32:07 +01:00

helper_test.go

Cleanup related to context refactor (#9988)

2018-12-17 08:51:46 -08:00

import_functions_test.go

Cleanup related to context refactor (#9988)

2018-12-17 08:51:46 -08:00

import_functions.go

MM-13190: Fix NotifyProps in Bulk Import. (#9900)

2018-11-28 15:28:51 +00:00

import_test.go

Cleanup related to context refactor (#9988)

2018-12-17 08:51:46 -08:00

import_types.go

Added the changes requested for MM-8860: Bulk import email intervals (#8498) (#9578)

2018-10-08 17:01:27 +01:00

import_validators_test.go

Cleanup related to context refactor (#9988)

2018-12-17 08:51:46 -08:00

import_validators.go

MM-12670: Accept and use "" for user/pass AuthService in import/export. (#9689)

2018-10-18 14:32:36 +01:00

import.go

Idiomatic error handling for app/import*.go (#9473)

2018-09-27 18:55:07 +02:00

integration_action_test.go

MM-13598 Added missing error check to DoActionRequest (#10058)

2019-01-04 10:57:13 -07:00

integration_action.go

MM-13598 Added missing error check to DoActionRequest (#10058)

2019-01-04 10:57:13 -07:00

job_test.go

Fix races / finally remove global app for good (#7570)

2017-10-04 13:09:41 -07:00

job.go

MM-12849 Moving all non request scoped items to Server struct (#9806)

2018-11-07 10:20:07 -08:00

ldap.go

MM-12849 Moving all non request scoped items to Server struct (#9806)

2018-11-07 10:20:07 -08:00

license_test.go

MM-12881 Add license sku fields (#9883)

2018-11-28 09:49:43 -05:00

license.go

Cleanup related to context refactor (#9988)

2018-12-17 08:51:46 -08:00

login_test.go

Prototype for CBA (#8475)

2018-06-12 10:16:39 -07:00

login.go

MM-12855 Plugin Context (#9922)

2018-12-05 10:46:08 -08:00

main_test.go

Dockerized build updated tests (#9943)

2018-12-06 13:19:32 -05:00

migrations.go

Moving app level migrations to its own file (#9871)

2018-11-23 09:39:33 -08:00

notification_email_test.go

Cleanup related to context refactor (#9988)

2018-12-17 08:51:46 -08:00

notification_email.go

MM-12849 Moving all non request scoped items to Server struct (#9806)

2018-11-07 10:20:07 -08:00

notification_push_test.go

Migrate notification_push_test to table testing (#9195)

2018-07-31 20:29:57 +02:00

notification_push.go

MM-13659 More error checks for NewRequest (#10080)

2019-01-09 09:16:32 -08:00

notification_test.go

MM-12941: Fixed problem with not-in-channel mentions users (#9974)

2018-12-11 14:01:38 +01:00

notification.go

MM-12941: Fixed problem with not-in-channel mentions users (#9974)

2018-12-11 14:01:38 +01:00

oauth_test.go

Implement OAuth2 implicit grant flow (#9178)

2018-07-27 17:35:43 -04:00

oauth.go

GH-9672 Idiomatic error handling in app/oauth.go (#9678)

2019-01-07 16:00:43 +01:00

opengraph_test.go

MM-12648: Properly unescape OpenGraph metadata containing HTML entities. (#9891)

2018-11-28 10:58:12 +00:00

opengraph.go

MM-12648: Properly unescape OpenGraph metadata containing HTML entities. (#9891)

2018-11-28 10:58:12 +00:00

options.go

Cleanup related to context refactor (#9988)

2018-12-17 08:51:46 -08:00

permissions_test.go

Relese5.0 merge master 20180608 (#8933)

2018-06-08 17:04:17 +02:00

permissions.go

add megacheck as makefile target (#9288)

2018-09-03 14:08:40 +02:00

plugin_api_test.go

Add GetFile API in app and plugin (#9820)

2018-12-13 10:46:42 +01:00

plugin_api.go

Add GetFile API in app and plugin (#9820)

2018-12-13 10:46:42 +01:00

plugin_commands_test.go

MM-11905: delete plugin commands on removal (#9601)

2018-10-10 10:56:54 -07:00

plugin_commands.go

MM-12855 Plugin Context (#9922)

2018-12-05 10:46:08 -08:00

plugin_context.go

MM-12855 Plugin Context (#9922)

2018-12-05 10:46:08 -08:00

plugin_deadlock_test.go

MM-11575: change plugin nil semantics (#9212)

2018-08-03 13:15:51 -04:00

plugin_hooks_test.go

MM-10856: deduplicate posts with the same pending post id (#10006)

2018-12-17 15:16:57 -08:00

plugin_install.go

MM-8662: Preserve plugin's enabled state when overwriting (#10005)

2018-12-17 08:35:12 -05:00

plugin_key_value_store.go

fix two page, perPage -> offset, limit mistranslations (#9904)

2018-11-29 13:02:06 -05:00

plugin_requests.go

MM-12855 Plugin Context (#9922)

2018-12-05 10:46:08 -08:00

plugin_statuses.go

MM-12974: guard app plugins with mutex (#9818)

2018-11-20 08:52:51 -05:00

plugin_test.go

fix two page, perPage -> offset, limit mistranslations (#9904)

2018-11-29 13:02:06 -05:00

plugin.go

Cleanup related to context refactor (#9988)

2018-12-17 08:51:46 -08:00

post_metadata_test.go

MM-12009 Resolve relative links in posts as the web app does (#9896)

2018-11-28 11:01:35 -05:00

post_metadata.go

MM-13238 Fix link cache being cleared too often with image proxy (#9981)

2018-12-12 13:11:53 -05:00

post_test.go

MM-10856: deduplicate posts with the same pending post id (#10006)

2018-12-17 15:16:57 -08:00

post.go

MM-10856: deduplicate posts with the same pending post id (#10006)

2018-12-17 15:16:57 -08:00

preference.go

Migrate to idiomatic error handling in app/preference.go (#9594)

2018-10-18 17:15:30 +01:00

ratelimit_test.go

handle RateLimiter initialization errors (#8199)

2018-02-05 23:27:34 -06:00

ratelimit.go

MM-10934 Update server dependencies. (#8981)

2018-06-21 16:10:40 -04:00

reaction.go

[GH-6798] added a new api endpoint to get the bulk reactions for posts (#10049)

2019-01-03 08:35:08 -05:00

role.go

MM-12849 Moving all non request scoped items to Server struct (#9806)

2018-11-07 10:20:07 -08:00

saml.go

Cleanup related to context refactor (#9988)

2018-12-17 08:51:46 -08:00

scheme.go

MM-12849 Moving all non request scoped items to Server struct (#9806)

2018-11-07 10:20:07 -08:00

security_update_check.go

Cleanup related to context refactor (#9988)

2018-12-17 08:51:46 -08:00

server_app_adapters.go

Cleanup related to context refactor (#9988)

2018-12-17 08:51:46 -08:00

server_license.go

Cleanup related to context refactor (#9988)

2018-12-17 08:51:46 -08:00

server_test.go

Cleanup related to context refactor (#9988)

2018-12-17 08:51:46 -08:00

server.go

MM-10856: deduplicate posts with the same pending post id (#10006)

2018-12-17 15:16:57 -08:00

session_test.go

MM-12849 Moving all non request scoped items to Server struct (#9806)

2018-11-07 10:20:07 -08:00

session.go

MM-12849 Moving all non request scoped items to Server struct (#9806)

2018-11-07 10:20:07 -08:00

slack_test.go

PLT-7824 Added support for mentions with <@userid> and <!here> (#7615) (#7737)

2017-11-17 11:17:59 -05:00

slack.go

PLT-7824 Added support for mentions with <@userid> and <!here> (#7615) (#7737)

2017-11-17 11:17:59 -05:00

slackimport_test.go

Renaming repo

2017-09-06 23:11:59 -07:00

slackimport.go

MM-7633: Optimize memory utilization during file uploads (#9835)

2018-12-13 22:32:07 +01:00

status_test.go

MM-9274- Sort Users in Channel by status (#8181)

2018-03-09 07:48:30 -05:00

status.go

[MM-12537] Migrate to idiomatic error handling the file app/status.go in the mattermost-server (#9574) (#9589)

2018-10-14 16:24:06 +01:00

team_test.go

[MM-12476] Consistent paging arguments limit/offset vs page/perPage for plugin API (#9838)

2018-11-19 08:43:49 -05:00

team.go

MM-12855 Plugin Context (#9922)

2018-12-05 10:46:08 -08:00

terms_of_service.go

Refactored to rename "service terms" to "terms of service" (#9581)

2018-10-09 20:55:47 -04:00

user_agent_test.go

MM-10495 Updated user agent detection to match output of previous library (#8748)

2018-05-09 12:25:03 -04:00

user_agent.go

[MM-12536] Migrate to idiomatic error handling the file app/user_agent.go in the mattermost-server (#9575) (#9576)

2018-10-15 20:01:35 +01:00

user_terms_of_service_test.go

Moving app from singular to being created for every request (#9889)

2018-11-28 10:56:21 -08:00

user_terms_of_service.go

#146 Terms of Service Phase 2 (#9731)

2018-11-08 15:48:14 -05:00

user_test.go

Gh 9610 add plugin api for update user active method (#9854)

2018-12-12 10:18:40 -05:00

user.go

MM-13512 Prevent getting a user by email based on privacy settings (#10021)

2018-12-18 16:04:25 -05:00

web_conn_test.go

Ensure unittest isolation (#9819)

2018-11-20 20:16:25 -05:00

web_conn.go

Webhub race condition (#9863)

2018-11-22 10:53:44 +01:00

web_hub_test.go

Webhub race condition (#9863)

2018-11-22 10:53:44 +01:00

web_hub.go

MM-13678: fix web hub deadlock (#10081)

2019-01-09 10:14:08 -08:00

webhook_test.go

Fixing formatting. (#9801)

2018-11-06 16:28:55 +08:00

webhook.go

Revert temporary webhook debugging (#9934)

2018-12-03 15:05:52 -05:00

websocket_router.go

MM-12849 Moving all non request scoped items to Server struct (#9806)

2018-11-07 10:20:07 -08:00