bd8774bdce
Tests at very high scale indicates that the iteration of all connections during websocket broadcast starts to become a bottleneck. To optimize this, we move the channelMember cache from inside web_conn.go to the hubConnectionIndex. This involves adding a new map keyed by the channelID and containing all webConns where the user is a member of that channel. Subsequently, a new method needed to be added to invalidate the cache which previously used to happen in web_conn. And as a last step, we remove the cache from web_conn to reduce SQL queries to the DB. https://mattermost.atlassian.net/browse/MM-61130 ```release-note NONE ```
91 строка
3.0 KiB
Go
91 строка
3.0 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package api4
|
|
|
|
import (
|
|
"net/http"
|
|
|
|
"github.com/gorilla/websocket"
|
|
|
|
"github.com/mattermost/mattermost/server/public/model"
|
|
"github.com/mattermost/mattermost/server/public/shared/mlog"
|
|
"github.com/mattermost/mattermost/server/v8/channels/app/platform"
|
|
"github.com/mattermost/mattermost/server/v8/channels/web"
|
|
)
|
|
|
|
const (
|
|
connectionIDParam = "connection_id"
|
|
sequenceNumberParam = "sequence_number"
|
|
postedAckParam = "posted_ack"
|
|
)
|
|
|
|
func (api *API) InitWebSocket() {
|
|
// Optionally supports a trailing slash
|
|
api.BaseRoutes.APIRoot.Handle("/{websocket:websocket(?:\\/)?}", api.APIHandlerTrustRequester(connectWebSocket)).Methods(http.MethodGet)
|
|
}
|
|
|
|
func connectWebSocket(c *Context, w http.ResponseWriter, r *http.Request) {
|
|
upgrader := websocket.Upgrader{
|
|
ReadBufferSize: model.SocketMaxMessageSizeKb,
|
|
WriteBufferSize: model.SocketMaxMessageSizeKb,
|
|
CheckOrigin: c.App.OriginChecker(),
|
|
}
|
|
|
|
ws, err := upgrader.Upgrade(w, r, nil)
|
|
if err != nil {
|
|
params := map[string]any{
|
|
"BlockedOrigin": r.Header.Get("Origin"),
|
|
}
|
|
c.Err = model.NewAppError("connect", "api.web_socket.connect.upgrade.app_error", params, "", http.StatusBadRequest).Wrap(err)
|
|
return
|
|
}
|
|
|
|
// We initialize webconn with all the necessary data.
|
|
// If the queues are empty, they are initialized in the constructor.
|
|
cfg := &platform.WebConnConfig{
|
|
WebSocket: ws,
|
|
Session: *c.AppContext.Session(),
|
|
TFunc: c.AppContext.T,
|
|
Locale: "",
|
|
Active: true,
|
|
PostedAck: r.URL.Query().Get(postedAckParam) == "true",
|
|
RemoteAddress: c.AppContext.IPAddress(),
|
|
XForwardedFor: c.AppContext.XForwardedFor(),
|
|
}
|
|
// The WebSocket upgrade request coming from mobile is missing the
|
|
// user agent so we need to fallback on the session's metadata.
|
|
if c.AppContext.Session().IsMobileApp() {
|
|
cfg.OriginClient = "mobile"
|
|
} else {
|
|
cfg.OriginClient = string(web.GetOriginClient(r))
|
|
}
|
|
|
|
cfg.ConnectionID = r.URL.Query().Get(connectionIDParam)
|
|
if cfg.ConnectionID == "" || c.AppContext.Session().UserId == "" {
|
|
// If not present, we assume client is not capable yet, or it's a fresh connection.
|
|
// We just create a new ID.
|
|
cfg.ConnectionID = model.NewId()
|
|
// In case of fresh connection id, sequence number is already zero.
|
|
} else {
|
|
cfg, err = c.App.Srv().Platform().PopulateWebConnConfig(c.AppContext.Session(), cfg, r.URL.Query().Get(sequenceNumberParam))
|
|
if err != nil {
|
|
c.Logger.Error("Error while populating webconn config", mlog.String("id", r.URL.Query().Get(connectionIDParam)), mlog.Err(err))
|
|
ws.Close()
|
|
return
|
|
}
|
|
}
|
|
|
|
wc := c.App.Srv().Platform().NewWebConn(cfg, c.App, c.App.Srv().Channels())
|
|
if c.AppContext.Session().UserId != "" {
|
|
err = c.App.Srv().Platform().HubRegister(wc)
|
|
if err != nil {
|
|
c.Logger.Error("Error while registering to hub", mlog.String("id", r.URL.Query().Get(connectionIDParam)), mlog.Err(err))
|
|
ws.Close()
|
|
return
|
|
}
|
|
}
|
|
|
|
wc.Pump()
|
|
}
|