mirrors/mostlymatter
1
0
Форкнуть 0
Код Задачи Запросы на слияние Действия Пакеты Проекты Релизы Вики Активность
Files
1edbf67bb2814edfc650a7185fc9636d9707348e
mostlymatter/app
История
Agniva De Sarker 06ad69a406 MM-47465: Fix flaky TestDeleteChannel (#21686) 
Creating the post in a separate goroutine would create a race condition
because that method also calls GetChannel. This can cause a bug
if the cache was wiped before the the other goroutine would get
a chance to update the cache. And if that happens, then
it would populate the cache with the old value.

Pseudo-code

```
func deleteChannel() {
    go func() {
        getFromCache()
    }()
    updateDB()
    wipeCache() // a
}

func getFromCache() {
    err := checkCache()
    if err == ErrNotFound {
        getFromDB() // x
        updateCache() // y
    }
}

func Test() {
    deleteChannel()
    getFromCache()
}
```

If the sequence of events happen like
- x
- a
- y

Then the getFromCache() call later will get the wrong
value from cache.

The fix is to make the call synchronous.

https://mattermost.atlassian.net/browse/MM-47465

Special thanks to @noxer for finding the root cause.

```release-note
NONE
```
2022-11-17 20:44:18 +05:30
..
email
[MM-47415] remove all mentions from Cloud Starter to Cloud Free
2022-10-25 16:17:35 +02:00
featureflag
Use any instead of interface{} (#20577)
2022-07-05 09:46:50 +03:00
imaging
Replace deprecated ioutil with io and os (#20776)
2022-08-09 14:25:46 +03:00
imports
[MM-38705] Move import validators into own package (#20914)
2022-08-31 13:29:37 +02:00
layer_generators
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
opentracing
[MM-44168] Add feature to restore archived user groups (#20369)
2022-11-17 14:53:54 +05:30
platform
Invalidate cloud caches when a new license is loaded (#21579)
2022-11-02 22:40:26 +02:00
plugin_api_tests
Set OwnerId for bots created via EnsureBotUser (#21560)
2022-11-03 06:31:38 +01:00
request
MM-45193 Use context for channel logging (#20575)
2022-07-14 11:01:29 +02:00
slashcommands
[MM-44336] Add timestamp parameter to test data slash commands (#21400)
2022-10-26 09:08:24 -04:00
teams
Adds OmitConnection parameter to broadcast (#20723)
2022-09-02 13:17:22 +03:00
users
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
admin_advisor.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
admin_test.go
MM-46577: Remove empty translation strings (#20876)
2022-08-25 19:59:16 +05:30
admin.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
analytics.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
app_iface.go
[MM-44168] Add feature to restore archived user groups (#20369)
2022-11-17 14:53:54 +05:30
app_test.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
app.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
audit.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
authentication_test.go
MM-42714: Trim token sizes to 50 characters (#20412)
2022-06-09 14:56:26 +05:30
authentication.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
authorization_test.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
authorization.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
auto_responder_test.go
MM-45194: Switch app/user and api4/user to logger context (#20674)
2022-07-28 10:04:21 +05:30
auto_responder.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
bot_test.go
MM-45194: Switch app/user and api4/user to logger context (#20674)
2022-07-28 10:04:21 +05:30
bot.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
brand.go
MM-45991 Wrap errors (#20785)
2022-08-18 11:01:37 +02:00
busy_test.go
fix flaky busy test (#20861)
2022-08-23 11:42:04 +03:00
busy.go
[MM-22051] Remove To/From JSON (#18070)
2021-09-01 14:43:12 +02:00
channel_category_test.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
channel_category.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
channel_test.go
Simplify thread_store/GetThreadForUser (#21588)
2022-11-09 12:16:20 +04:00
channel.go
MM-47465: Fix flaky TestDeleteChannel (#21686)
2022-11-17 20:44:18 +05:30
channels.go
[MM-48161] Change data types for collections and topics (#21634)
2022-11-15 00:57:04 +04:00
cloud.go
[MM-44729] Update payment failed email (#20925)
2022-09-08 11:01:50 -04:00
cluster_discovery.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
cluster_handlers.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
cluster.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
collection.go
[MM-48161] Change data types for collections and topics (#21634)
2022-11-15 00:57:04 +04:00
command_autocomplete_test.go
MM-45196: Migration api4/command and app/cmd to logger context (#20730)
2022-08-02 20:48:54 +05:30
command_autocomplete.go
[MM-45991] Check and return JSON errors (#20735)
2022-08-10 10:56:58 +02:00
command_test.go
Move some variables out of model (#17909)
2021-07-21 16:38:39 +02:00
command.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
compliance.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
config_test.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
config.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
constants.go
MM-31063: Change constants to use CamelCase (#16608)
2021-01-04 11:32:29 +05:30
context.go
MM-45193 Use context for channel logging (#20575)
2022-07-14 11:01:29 +02:00
data_retention.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
download_test.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
download.go
Replace deprecated ioutil with io and os (#20776)
2022-08-09 14:25:46 +03:00
email_test.go
MM-39058 - invite people to join team and channels (#19849)
2022-04-08 12:20:44 -05:00
emoji.go
[MM-48060] Added context for emoji (#21561)
2022-11-03 08:54:59 +01:00
enterprise_test.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
enterprise.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
expirynotify_test.go
Working on refactoring jobs service (#19205)
2022-02-14 18:21:18 +01:00
expirynotify.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
export_converters.go
MM-47171 Export direct channel favorites (#21570)
2022-11-04 17:13:14 +01:00
export_test.go
MM-47171 Export direct channel favorites (#21570)
2022-11-04 17:13:14 +01:00
export.go
MM-47171 Export direct channel favorites (#21570)
2022-11-04 17:13:14 +01:00
extract_plugin_tar_test.go
Replace deprecated ioutil with io and os (#20776)
2022-08-09 14:25:46 +03:00
extract_plugin_tar.go
[GH-19267] Spelling comments (#19268)
2022-01-20 10:07:27 +05:30
file_bench_test.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
file_helper_test.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
file_helper.go
[MM-44489] Cloud limits: enforcing files (#20703)
2022-09-28 12:52:53 -04:00
file_test.go
MM-36295: Do not convert thumbnails/previews to jpeg for png images (#21230)
2022-10-11 19:04:09 +05:30
file.go
Invalidate cloud caches when a new license is loaded (#21579)
2022-11-02 22:40:26 +02:00
group_test.go
[MM-44168] Add feature to restore archived user groups (#20369)
2022-11-17 14:53:54 +05:30
group.go
[MM-44168] Add feature to restore archived user groups (#20369)
2022-11-17 14:53:54 +05:30
helper_test.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
image.go
Add MaxImageResolution config setting (#17941)
2021-08-12 17:43:10 +02:00
import_functions_test.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
import_functions.go
MM-47795 Match teams, channels, and users case insensitively on import (#21458)
2022-11-01 09:37:58 +01:00
import_test.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
import_utils_test.go
[MM-33794] Improve password generation during bulk import (#17147)
2021-03-24 10:32:16 +01:00
import_utils.go
[MM-33794] Improve password generation during bulk import (#17147)
2021-03-24 10:32:16 +01:00
import.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
integration_action_test.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
integration_action.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
integrations_test.go
Cloud Freemium - Integrations (#20185)
2022-05-25 12:36:08 -04:00
integrations.go
Invalidate cloud caches when a new license is loaded (#21579)
2022-11-02 22:40:26 +02:00
job_test.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
job.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
ldap.go
MM-45991 Wrap errors (#20785)
2022-08-18 11:01:37 +02:00
license_test.go
[MM-40962-2] - Fix unnecessary logging in license expiration check (#19826)
2022-03-31 18:25:46 +03:00
license.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
login_test.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
login.go
Invalidate cloud caches when a new license is loaded (#21579)
2022-11-02 22:40:26 +02:00
main_test.go
MM-36764 mlog refactor (#18118)
2021-08-17 16:08:04 -04:00
migrations.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
notification_email_test.go
Slack attachment in email notifications (#20946)
2022-10-20 11:05:22 +05:30
notification_email.go
Slack attachment in email notifications (#20946)
2022-10-20 11:05:22 +05:30
notification_push_test.go
move file backend to the platform service (#21365)
2022-10-21 12:24:36 +03:00
notification_push.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
notification_test.go
Simplify thread_store/GetThreadForUser (#21588)
2022-11-09 12:16:20 +04:00
notification.go
Simplify thread_store/GetThreadForUser (#21588)
2022-11-09 12:16:20 +04:00
notify_admin_test.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
notify_admin.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
oauth_test.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
oauth.go
[MM-46216] P3 Bugfix - Oauth redirectURI with query parameters generates malformed redirect URL (#20854)
2022-11-14 10:27:47 +05:30
onboarding.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
opengraph_test.go
[MM-37755] Idiomatic naming (SMTP, TLS, TCP, XML, CSS, HTML, HTTP) (#18103)
2021-08-12 11:49:16 +02:00
opengraph.go
Improve API4 initialization (#18680)
2021-10-15 19:57:05 +05:30
options.go
move file backend to the platform service (#21365)
2022-10-21 12:24:36 +03:00
permissions_migrations_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
permissions_migrations.go
MM-47250: Add new system console section (#21333)
2022-10-19 15:23:20 -04:00
permissions_test.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
permissions.go
Display board statistics (#21433)
2022-10-21 18:10:45 +02:00
plugin_api_test.go
[MM-47542] Extend Plugin API (#21446)
2022-11-03 22:43:30 +04:00
plugin_api.go
[MM-47542] Extend Plugin API (#21446)
2022-11-03 22:43:30 +04:00
plugin_commands_test.go
Use any instead of interface{} (#20577)
2022-07-05 09:46:50 +03:00
plugin_commands.go
MM-45196: Migration api4/command and app/cmd to logger context (#20730)
2022-08-02 20:48:54 +05:30
plugin_context.go
Migrate to stateless app.App (#17542)
2021-05-11 13:00:44 +03:00
plugin_db_driver.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
plugin_deadlock_test.go
Use any instead of interface{} (#20577)
2022-07-05 09:46:50 +03:00
plugin_event.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
plugin_health_check_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
plugin_hooks_test.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
plugin_install_test.go
Move pluginCommands into Channels (#18974)
2021-11-12 10:35:14 +05:30
plugin_install.go
MM-45991 Wrap errors (#20785)
2022-08-18 11:01:37 +02:00
plugin_key_value_store.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
plugin_public_keys.go
[MM-20309] production public key (#13244)
2019-12-05 23:41:52 +04:00
plugin_requests_test.go
Move pluginCommands into Channels (#18974)
2021-11-12 10:35:14 +05:30
plugin_requests.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
plugin_shutdown_test.go
Move plugins under Channels (#18938)
2021-11-08 11:57:22 +05:30
plugin_signature_test.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
plugin_signature.go
MM-45991 Wrap errors (#20785)
2022-08-18 11:01:37 +02:00
plugin_statuses.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
plugin_test.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
plugin.go
[MM-48161] Change data types for collections and topics (#21634)
2022-11-15 00:57:04 +04:00
post_helpers_test.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
post_helpers.go
MM-45991 Wrap errors (#20785)
2022-08-18 11:01:37 +02:00
post_metadata_test.go
[MM-48060] Added context for emoji (#21561)
2022-11-03 08:54:59 +01:00
post_metadata.go
[MM-48060] Added context for emoji (#21561)
2022-11-03 08:54:59 +01:00
post_test.go
Simplify thread_store/GetThreadForUser (#21588)
2022-11-09 12:16:20 +04:00
post.go
Move Thread.GetPosts to PostStore.GetPostsByThread (#21633)
2022-11-16 13:42:26 +04:00
preference.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
product_notices_test.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
product_notices.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
product_test.go
Use any instead of interface{} (#20577)
2022-07-05 09:46:50 +03:00
product.go
Use any instead of interface{} (#20577)
2022-07-05 09:46:50 +03:00
ratelimit_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
ratelimit.go
[MM-23279] Idiomatic naming (IP) (#18152)
2021-08-19 10:33:29 +02:00
reaction_test.go
[MM-45052] Add error checking in insights API (#21048)
2022-10-20 14:37:24 -04:00
reaction.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
remote_cluster_service_mock.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
remote_cluster_test.go
spelling: strings (#19542)
2022-02-28 15:01:00 +05:30
remote_cluster.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
response_transfer.go
Replace deprecated ioutil with io and os (#20776)
2022-08-09 14:25:46 +03:00
role_test.go
Replace deprecated ioutil with io and os (#20776)
2022-08-09 14:25:46 +03:00
role.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
saml.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
scheme.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
searchengine.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
security_update_check.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
server_inactivity.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
server_test.go
move file backend to the platform service (#21365)
2022-10-21 12:24:36 +03:00
server.go
Invalidate cloud caches when a new license is loaded (#21579)
2022-11-02 22:40:26 +02:00
session_test.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
session.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
shared_channel_service_iface.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
shared_channel_test.go
MM-45193 Use context for channel logging (#20575)
2022-07-14 11:01:29 +02:00
shared_channel.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
slack_test.go
MM-36271: Bump major version to 6.0 (#17973)
2021-07-22 12:21:47 +05:30
slack.go
MM-36295: Do not convert thumbnails/previews to jpeg for png images (#21230)
2022-10-11 19:04:09 +05:30
status_test.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
status.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
support_packet_test.go
Replace deprecated ioutil with io and os (#20776)
2022-08-09 14:25:46 +03:00
support_packet.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
syncables_test.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
syncables.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
team_test.go
MM-46528_Verify Invitation Flow Tracking Telemetry (#21227)
2022-10-24 16:20:56 -05:00
team.go
MM-46528_Verify Invitation Flow Tracking Telemetry (#21227)
2022-10-24 16:20:56 -05:00
telemetry.go
[MM-40022] - Expose telemetry service in the server (#18976)
2021-11-12 10:16:19 +03:00
terms_of_service.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
upload_test.go
Replace deprecated ioutil with io and os (#20776)
2022-08-09 14:25:46 +03:00
upload.go
MM-36295: Do not convert thumbnails/previews to jpeg for png images (#21230)
2022-10-11 19:04:09 +05:30
usage_test.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
usage.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
user_agent_test.go
[MM-22167] Add mmctl to the User-Agent parser (#13894)
2020-03-19 11:18:17 +01:00
user_agent.go
[MM-22167] Add mmctl to the User-Agent parser (#13894)
2020-03-19 11:18:17 +01:00
user_terms_of_service_test.go
Migration of UserTermsOfServiceStore to return plain errors (#14788)
2020-06-19 17:49:30 +05:30
user_terms_of_service.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
user_test.go
[MM-46694] A/B Test: welcome post (#20926)
2022-10-13 14:23:22 -07:00
user_viewmembers_test.go
MM-45194: Switch app/user and api4/user to logger context (#20674)
2022-07-28 10:04:21 +05:30
user.go
Simplify thread_store/GetThreadForUser (#21588)
2022-11-09 12:16:20 +04:00
web_conn_test.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
web_conn.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
web_hub.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
webhook_test.go
MM-45193 Use context for channel logging (#20575)
2022-07-14 11:01:29 +02:00
webhook.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
webhub_fuzz.go
Adds OmitConnection parameter to broadcast (#20723)
2022-09-02 13:17:22 +03:00
websocket_router.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00