Agniva De Sarker 14246abdef MM-45993: Return errors during sending websocket messages (#20760) ...

During attaching an object to a websocket message, we would
marshal it to json and attach the string output. But if the
marshalling failed, we would just log a warning and move on.

This would add an empty string to the message. But the client
assumes that the object is correctly attached and would
fail silently if it cannot find it.

So we become more strict and return the error so that
it reaches the caller.

https://mattermost.atlassian.net/browse/MM-45993

```release-note
NONE
```

2022-08-05 08:49:01 +05:30

..

email

Use any instead of interface{} (#20577)

2022-07-05 09:46:50 +03:00

featureflag

Use any instead of interface{} (#20577)

2022-07-05 09:46:50 +03:00

imaging

[MM-43393]: replace .Decoder() method with .Token() (#19988)

2022-04-27 19:27:06 +03:00

layer_generators

Use any instead of interface{} (#20577)

2022-07-05 09:46:50 +03:00

opentracing

MM-45993: Return errors during sending websocket messages (#20760)

2022-08-05 08:49:01 +05:30

platform

Move metrics under platform service (continued) (#20732)

2022-08-02 10:59:29 +03:00

plugin_api_tests

Use any instead of interface{} (#20577)

2022-07-05 09:46:50 +03:00

request

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

slashcommands

MM-45993: Return errors during sending websocket messages (#20760)

2022-08-05 08:49:01 +05:30

teams

[MM-45769] Properly initialize the request.Context for imports and tests (#20659)

2022-07-18 10:58:06 +02:00

users

[MM-45769] Properly initialize the request.Context for imports and tests (#20659)

2022-07-18 10:58:06 +02:00

admin_advisor.go

Use any instead of interface{} (#20577)

2022-07-05 09:46:50 +03:00

admin_test.go

Growth spike: Get latest MM version (#19366)

2022-02-02 09:19:47 -05:00

admin.go

Replace ioutil.Discard with io.Discard (#20707)

2022-07-27 11:40:33 +02:00

analytics.go

[MM-43917] Cloud Freemium limits API: messages/posts (#20152)

2022-05-17 13:30:40 +02:00

app_iface.go

MM-45993: Return errors during sending websocket messages (#20760)

2022-08-05 08:49:01 +05:30

app_test.go

[MM-41576] Add schema version to the client configuration (#19757)

2022-03-15 16:39:23 +03:00

app.go

Move metrics under platform service (continued) (#20732)

2022-08-02 10:59:29 +03:00

audit.go

Audit logging - new schema (#20447)

2022-07-14 11:19:33 +02:00

authentication_test.go

MM-42714: Trim token sizes to 50 characters (#20412)

2022-06-09 14:56:26 +05:30

authentication.go

Use any instead of interface{} (#20577)

2022-07-05 09:46:50 +03:00

authorization_test.go

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

authorization.go

MM-45715: Fix incorrect permissions (Round 2) (#20731)

2022-07-29 09:58:44 +05:30

auto_responder_test.go

MM-45194: Switch app/user and api4/user to logger context (#20674)

2022-07-28 10:04:21 +05:30

auto_responder.go

MM-45194: Switch app/user and api4/user to logger context (#20674)

2022-07-28 10:04:21 +05:30

bot_test.go

MM-45194: Switch app/user and api4/user to logger context (#20674)

2022-07-28 10:04:21 +05:30

bot.go

MM-45195: Use api4/bot and app/bot to use logger context (#20729)

2022-08-01 13:48:45 +05:30

brand.go

Remove the remaining fields from *app.Server (#19113)

2021-12-07 21:53:24 +05:30

busy_test.go

MM-45725: Skip BusySet (#20647)

2022-07-14 12:17:52 +05:30

busy.go

[MM-22051] Remove To/From JSON (#18070)

2021-09-01 14:43:12 +02:00

channel_category_test.go

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

channel_category.go

MM-45993: Return errors during sending websocket messages (#20760)

2022-08-05 08:49:01 +05:30

channel_test.go

MM-45993: Return errors during sending websocket messages (#20760)

2022-08-05 08:49:01 +05:30

channel.go

MM-45993: Return errors during sending websocket messages (#20760)

2022-08-05 08:49:01 +05:30

channels.go

Hackathon: Post Reminders (#20555)

2022-07-26 16:12:56 +05:30

cloud.go

Fix broken master; ensure all product service APIs have correct implementations (#20663)

2022-07-15 13:20:40 -04:00

cluster_discovery_test.go

MM-36271: Bump major version to 6.0 (#17973)

2021-07-22 12:21:47 +05:30

cluster_discovery.go

MM-22051: Remove ToJson from model (part 1) (#18005)

2021-07-28 13:15:46 +05:30

cluster_handlers.go

Move plugins under Channels (#18938)

2021-11-08 11:57:22 +05:30

cluster.go

Fix broken master; ensure all product service APIs have correct implementations (#20663)

2022-07-15 13:20:40 -04:00

command_autocomplete_test.go

MM-45196: Migration api4/command and app/cmd to logger context (#20730)

2022-08-02 20:48:54 +05:30

command_autocomplete.go

[MM-22051] Remove To/From JSON (#18070)

2021-09-01 14:43:12 +02:00

command_test.go

Move some variables out of model (#17909)

2021-07-21 16:38:39 +02:00

command.go

MM-45196: Migration api4/command and app/cmd to logger context (#20730)

2022-08-02 20:48:54 +05:30

compliance.go

spelling (#19956)

2022-04-11 19:31:19 +05:30

config_test.go

[MM-41576] Add schema version to the client configuration (#19757)

2022-03-15 16:39:23 +03:00

config.go

Move metrics under platform service (continued) (#20732)

2022-08-02 10:59:29 +03:00

constants.go

MM-31063: Change constants to use CamelCase (#16608)

2021-01-04 11:32:29 +05:30

context.go

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

data_retention.go

MM-36271: Bump major version to 6.0 (#17973)

2021-07-22 12:21:47 +05:30

download_test.go

[MM-37772] Idiomatic naming (URL, URI, API) (#18128)

2021-08-16 19:46:44 +02:00

download.go

Replace ioutil.Discard with io.Discard (#20707)

2022-07-27 11:40:33 +02:00

email_test.go

MM-39058 - invite people to join team and channels (#19849)

2022-04-08 12:20:44 -05:00

emoji.go

MM-45993: Return errors during sending websocket messages (#20760)

2022-08-05 08:49:01 +05:30

enterprise_test.go

[MM-41576] Add schema version to the client configuration (#19757)

2022-03-15 16:39:23 +03:00

enterprise.go

Move metrics under platform service (continued) (#20732)

2022-08-02 10:59:29 +03:00

expirynotify_test.go

Working on refactoring jobs service (#19205)

2022-02-14 18:21:18 +01:00

expirynotify.go

Use any instead of interface{} (#20577)

2022-07-05 09:46:50 +03:00

export_converters.go

[MM-41115] Add server-side username colorize preference (#19382)

2022-06-24 12:37:07 -04:00

export_test.go

MM-45196: Migration api4/command and app/cmd to logger context (#20730)

2022-08-02 20:48:54 +05:30

export.go

MM-45196: Migration api4/command and app/cmd to logger context (#20730)

2022-08-02 20:48:54 +05:30

extract_plugin_tar_test.go

MM-35945: handle lots of files in ExtractTarGz (#17669)

2021-05-25 22:00:57 -03:00

extract_plugin_tar.go

[GH-19267] Spelling comments (#19268)

2022-01-20 10:07:27 +05:30

feature_flags.go

Use any instead of interface{} (#20577)

2022-07-05 09:46:50 +03:00

file_bench_test.go

Fix minio client breakage with bifrost round 2 (#20758)

2022-08-04 11:21:51 +05:30

file_test.go

MM-45871: Do not try to extract content from images (#20698)

2022-07-26 12:17:23 +05:30

file.go

Fix minio client breakage with bifrost round 2 (#20758)

2022-08-04 11:21:51 +05:30

group_test.go

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

group.go

MM-45993: Return errors during sending websocket messages (#20760)

2022-08-05 08:49:01 +05:30

helper_test.go

Move metrics under platform service (continued) (#20732)

2022-08-02 10:59:29 +03:00

image.go

Add MaxImageResolution config setting (#17941)

2021-08-12 17:43:10 +02:00

import_functions_test.go

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

import_functions.go

MM-45195: Use api4/bot and app/bot to use logger context (#20729)

2022-08-01 13:48:45 +05:30

import_test.go

[MM-43917] Cloud Freemium limits API: messages/posts (#20152)

2022-05-17 13:30:40 +02:00

import_types.go

[MM-41115] Add server-side username colorize preference (#19382)

2022-06-24 12:37:07 -04:00

import_utils_test.go

[MM-33794] Improve password generation during bulk import (#17147)

2021-03-24 10:32:16 +01:00

import_utils.go

[MM-33794] Improve password generation during bulk import (#17147)

2021-03-24 10:32:16 +01:00

import_validators_test.go

MM-43878: don't err when reply createAt before parent createAt (#20292)

2022-05-27 15:48:00 +05:30

import_validators.go

Use any instead of interface{} (#20577)

2022-07-05 09:46:50 +03:00

import.go

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

integration_action_test.go

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

integration_action.go

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

integrations_test.go

Cloud Freemium - Integrations (#20185)

2022-05-25 12:36:08 -04:00

integrations.go

Use any instead of interface{} (#20577)

2022-07-05 09:46:50 +03:00

job_test.go

MM-36271: Bump major version to 6.0 (#17973)

2021-07-22 12:21:47 +05:30

job.go

Implement content extraction job (#18022)

2021-08-04 11:10:53 +02:00

ldap.go

Use any instead of interface{} (#20577)

2022-07-05 09:46:50 +03:00

license_test.go

[MM-40962-2] - Fix unnecessary logging in license expiration check (#19826)

2022-03-31 18:25:46 +03:00

license.go

MM-45542 - do not fail if site url is not set when requesting trial (#20713)

2022-08-03 23:54:43 +02:00

login_test.go

MM-36271: Bump major version to 6.0 (#17973)

2021-07-22 12:21:47 +05:30

login.go

MM-45194: Switch app/user and api4/user to logger context (#20674)

2022-07-28 10:04:21 +05:30

main_test.go

MM-36764 mlog refactor (#18118)

2021-08-17 16:08:04 -04:00

migrations.go

MM-44351: Creates new Custom Group Admin system role. (#20573)

2022-07-13 09:38:07 +02:00

notification_email_test.go

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

notification_email.go

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

notification_push_test.go

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

notification_push.go

Replace ioutil.Discard with io.Discard (#20707)

2022-07-27 11:40:33 +02:00

notification_test.go

MM-45194: Switch app/user and api4/user to logger context (#20674)

2022-07-28 10:04:21 +05:30

notification.go

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

oauth_test.go

MM-41211: Replaces SessionLength*InDays with SessionLength*InHours. (#19838)

2022-04-28 17:31:35 -04:00

oauth.go

Use any instead of interface{} (#20577)

2022-07-05 09:46:50 +03:00

onboarding.go

Cloud Freemium - Integrations (#20185)

2022-05-25 12:36:08 -04:00

opengraph_test.go

[MM-37755] Idiomatic naming (SMTP, TLS, TCP, XML, CSS, HTML, HTTP) (#18103)

2021-08-12 11:49:16 +02:00

opengraph.go

Improve API4 initialization (#18680)

2021-10-15 19:57:05 +05:30

options.go

Use any instead of interface{} (#20577)

2022-07-05 09:46:50 +03:00

permissions_migrations_test.go

MM-36271: Bump major version to 6.0 (#17973)

2021-07-22 12:21:47 +05:30

permissions_migrations.go

Add new playbooks permissions. (#19661)

2022-03-03 08:10:41 -08:00

permissions_test.go

Use any instead of interface{} (#20577)

2022-07-05 09:46:50 +03:00

permissions.go

Fix broken master; ensure all product service APIs have correct implementations (#20663)

2022-07-15 13:20:40 -04:00

plugin_api_test.go

MM-45196: Migration api4/command and app/cmd to logger context (#20730)

2022-08-02 20:48:54 +05:30

plugin_api.go

MM-45194: Switch app/user and api4/user to logger context (#20674)

2022-07-28 10:04:21 +05:30

plugin_commands_test.go

Use any instead of interface{} (#20577)

2022-07-05 09:46:50 +03:00

plugin_commands.go

MM-45196: Migration api4/command and app/cmd to logger context (#20730)

2022-08-02 20:48:54 +05:30

plugin_context.go

Migrate to stateless app.App (#17542)

2021-05-11 13:00:44 +03:00

plugin_db_driver.go

Use any instead of interface{} (#20577)

2022-07-05 09:46:50 +03:00

plugin_deadlock_test.go

Use any instead of interface{} (#20577)

2022-07-05 09:46:50 +03:00

plugin_event.go

Move plugins under Channels (#18938)

2021-11-08 11:57:22 +05:30

plugin_health_check_test.go

MM-36271: Bump major version to 6.0 (#17973)

2021-07-22 12:21:47 +05:30

plugin_hooks_test.go

Fix minio client breakage with bifrost round 2 (#20758)

2022-08-04 11:21:51 +05:30

plugin_install_test.go

Move pluginCommands into Channels (#18974)

2021-11-12 10:35:14 +05:30

plugin_install.go

Use any instead of interface{} (#20577)

2022-07-05 09:46:50 +03:00

plugin_key_value_store.go

Fix broken master; ensure all product service APIs have correct implementations (#20663)

2022-07-15 13:20:40 -04:00

plugin_public_keys.go

[MM-20309] production public key (#13244)

2019-12-05 23:41:52 +04:00

plugin_requests_test.go

Move pluginCommands into Channels (#18974)

2021-11-12 10:35:14 +05:30

plugin_requests.go

app/plugin: add product middleware and enable products register their routers (#20374)

2022-06-07 09:12:15 +03:00

plugin_shutdown_test.go

Move plugins under Channels (#18938)

2021-11-08 11:57:22 +05:30

plugin_signature_test.go

[MM-41576] Add schema version to the client configuration (#19757)

2022-03-15 16:39:23 +03:00

plugin_signature.go

spelling (#19956)

2022-04-11 19:31:19 +05:30

plugin_statuses.go

MM-40813: Add config interface (#19571)

2022-02-21 21:41:04 +05:30

plugin_test.go

[MM-45990] log JSON parsing errors in API4 (#20724)

2022-07-28 17:05:03 +02:00

plugin.go

Move metrics under platform service (continued) (#20732)

2022-08-02 10:59:29 +03:00

post_helpers_test.go

Mm 43609 (#20657)

2022-07-25 16:01:59 -05:00

post_helpers.go

Mm 43609 (#20657)

2022-07-25 16:01:59 -05:00

post_metadata_test.go

MM-45000: Upgrade to new opengraph module path (#20701)

2022-07-25 14:25:32 +05:30

post_metadata.go

Replace ioutil.Discard with io.Discard (#20707)

2022-07-27 11:40:33 +02:00

post_test.go

[MM-42194] Get file information from a deleted post (#20279)

2022-07-21 11:11:08 -04:00

post.go

MM-45993: Return errors during sending websocket messages (#20760)

2022-08-05 08:49:01 +05:30

preference.go

MM-45993: Return errors during sending websocket messages (#20760)

2022-08-05 08:49:01 +05:30

product_notices_test.go

[MM-45769] Properly initialize the request.Context for imports and tests (#20659)

2022-07-18 10:58:06 +02:00

product_notices.go

Use any instead of interface{} (#20577)

2022-07-05 09:46:50 +03:00

product_test.go

Use any instead of interface{} (#20577)

2022-07-05 09:46:50 +03:00

product.go

Use any instead of interface{} (#20577)

2022-07-05 09:46:50 +03:00

ratelimit_test.go

MM-36271: Bump major version to 6.0 (#17973)

2021-07-22 12:21:47 +05:30

ratelimit.go

[MM-23279] Idiomatic naming (IP) (#18152)

2021-08-19 10:33:29 +02:00

reaction_test.go

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

reaction.go

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

remote_cluster_service_mock.go

MM-36271: Bump major version to 6.0 (#17973)

2021-07-22 12:21:47 +05:30

remote_cluster_test.go

spelling: strings (#19542)

2022-02-28 15:01:00 +05:30

remote_cluster.go

MM-36271: Bump major version to 6.0 (#17973)

2021-07-22 12:21:47 +05:30

response_transfer.go

Consistent license message for all the go files (#13235)

2019-11-29 12:59:40 +01:00

role_test.go

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

role.go

MM-45993: Return errors during sending websocket messages (#20760)

2022-08-05 08:49:01 +05:30

saml.go

Use any instead of interface{} (#20577)

2022-07-05 09:46:50 +03:00

scheme.go

MM-38150 Adding playbooks permissions (#19096)

2021-12-07 09:43:33 -08:00

searchengine.go

Move Channels into App (#18623)

2021-10-12 11:39:49 +05:30

security_update_check.go

[MM-36872] add threading headers to notification emails (#18232)

2022-06-29 15:29:29 -04:00

server_inactivity.go

Use any instead of interface{} (#20577)

2022-07-05 09:46:50 +03:00

server_license.go

MM-36271: Bump major version to 6.0 (#17973)

2021-07-22 12:21:47 +05:30

server_test.go

MM-43832: Fix flaky TestReadReplicaDisabledBasedOnLicense (#20483)

2022-06-16 12:34:08 +05:30

server.go

Move metrics under platform service (continued) (#20732)

2022-08-02 10:59:29 +03:00

session_test.go

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

session.go

Use any instead of interface{} (#20577)

2022-07-05 09:46:50 +03:00

shared_channel_notifier_test.go

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

shared_channel_notifier.go

MM-36271: Bump major version to 6.0 (#17973)

2021-07-22 12:21:47 +05:30

shared_channel_service_iface.go

MM-36271: Bump major version to 6.0 (#17973)

2021-07-22 12:21:47 +05:30

shared_channel_test.go

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

shared_channel.go

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

slack_test.go

MM-36271: Bump major version to 6.0 (#17973)

2021-07-22 12:21:47 +05:30

slack.go

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

status_test.go

MM-45194: Switch app/user and api4/user to logger context (#20674)

2022-07-28 10:04:21 +05:30

status.go

MM-45194: Switch app/user and api4/user to logger context (#20674)

2022-07-28 10:04:21 +05:30

support_packet_test.go

MM-41153: Add seats deployed to support packet (#20125)

2022-05-03 21:13:16 +05:30

support_packet.go

MM-41153: Add seats deployed to support packet (#20125)

2022-05-03 21:13:16 +05:30

syncables_test.go

MM-45194: Switch app/user and api4/user to logger context (#20674)

2022-07-28 10:04:21 +05:30

syncables.go

MM-45993: Return errors during sending websocket messages (#20760)

2022-08-05 08:49:01 +05:30

team_test.go

MM-45993: Return errors during sending websocket messages (#20760)

2022-08-05 08:49:01 +05:30

team.go

MM-45993: Return errors during sending websocket messages (#20760)

2022-08-05 08:49:01 +05:30

telemetry.go

[MM-40022] - Expose telemetry service in the server (#18976)

2021-11-12 10:16:19 +03:00

terms_of_service.go

MM-36271: Bump major version to 6.0 (#17973)

2021-07-22 12:21:47 +05:30

upload_test.go

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

upload.go

[MM-45862] Set size and extension to fileinfo (#20681)

2022-07-22 09:14:01 +02:00

usage_test.go

[MM-43917] Cloud Freemium limits API: messages/posts (#20152)

2022-05-17 13:30:40 +02:00

usage.go

Usage: Round messages to 1K, files to 100MB (#20603)

2022-07-11 07:21:29 -05:00

user_agent_test.go

[MM-22167] Add mmctl to the User-Agent parser (#13894)

2020-03-19 11:18:17 +01:00

user_agent.go

[MM-22167] Add mmctl to the User-Agent parser (#13894)

2020-03-19 11:18:17 +01:00

user_terms_of_service_test.go

Migration of UserTermsOfServiceStore to return plain errors (#14788)

2020-06-19 17:49:30 +05:30

user_terms_of_service.go

MM-36271: Bump major version to 6.0 (#17973)

2021-07-22 12:21:47 +05:30

user_test.go

MM-45194: Switch app/user and api4/user to logger context (#20674)

2022-07-28 10:04:21 +05:30

user_viewmembers_test.go

MM-45194: Switch app/user and api4/user to logger context (#20674)

2022-07-28 10:04:21 +05:30

user.go

MM-45993: Return errors during sending websocket messages (#20760)

2022-08-05 08:49:01 +05:30

web_conn_test.go

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

web_conn.go

Fix incorrect dead queue clear logic (#20624)

2022-07-11 23:26:47 +05:30

web_hub_test.go

Allow per connection WebSocket broadcasts (#19993)

2022-04-22 15:53:42 +02:00

web_hub.go

Move metrics under platform service (continued) (#20732)

2022-08-02 10:59:29 +03:00

webhook_test.go

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

webhook.go

MM-45193 Use context for channel logging (#20575)

2022-07-14 11:01:29 +02:00

webhub_fuzz.go

Use any instead of interface{} (#20577)

2022-07-05 09:46:50 +03:00

websocket_router.go

MM-39612: Make acquiring and removing connections atomic (#18982)

2021-11-16 19:43:43 +05:30