5b6320b7dc
* Stop explicitly passing autocompleteUrlSchemes into text formatting code This is the first part of changing how autocompleteUrlSchemes works so that it can be moved to be part of the parser like in mobile instead of happening in the renderer. I'm not a fan of using the global store directly in utils/markdown, but this seems like the only way to have this apply to all the Markdown that's rendered in various helpers throughout the app. Ideally, we'd have some getMarkdownParser selector and a hook which provides the config, but that's a future improvement to make" * MM-62744 Move URL filtering to the Markdown parser instead of the renderer MM-62744 is caused by two things: 1. URL autolinking takes place in the Markdown parser which occurs before at-mention parsing which (despite the "parsing" part) happens in the Markdown renderer in the web app. 2. The autolinking in marked is very aggressive and identifies anything that looks like some:text as a link. Those lead to remote mentions like `@user:server` being incorrectly parsed by Markdown as a link to `user:server`. It isn't renderered as a link because the URL filtering logic in the Markdown parser blocks that, but at that point, the Markdown renderer won't check if it's an at-mention. By moving the URL filtering to occur earlier, like it does in the mobile app, the Markdown code won't autolink `@user:server` (unless the server has `user` configured as a custom URL scheme for some reason), so it's free to be turned into an at-mention by the renderer code. * MM-62744 Ensure various regexes and features support remote mentions * Update marked back to master
Mattermost Web App
This folder contains the client code for the Mattermost web app. It's broken up into multiple packages each of which either contains an area of the app (such as playbooks) or shared logic used across other packages (such as the packages located in the platform directory). For anyone who's used to working in the mattermost/mattermost-webapp repo, most of that is now located in channels.
npm Workspaces
To interact with a workspace using npm, such as to add a dependency or run a script, use the --workspace (or --workspaces) flag. This can be done when using built-in npm commands such as npm add or when running scripts. Those commands should be run from this directory.
# Add a dependency to a single package
npm add react --workspace=playbooks
# Build multiple packages
npm run build --workspace=platform/client --workspace=platform/components
# Test all workspaces
npm test --workspaces
# Clean all workspaces that have a clean script defined
npm run clean --workspaces --if-present
To install dependencies for a workspace, simply run npm install from this folder as you would do normally. Most packages' dependencies will be included in the root node_modules, and all packages' dependencies will appear in the package-lock.json. A node_modules will only be created inside a package if one of its dependencies conflicts with that of another package.
Useful Links
- Developer setup, now included with the Mattermost server developer setup
- Web app developer documentation