mirrors/mostlymatter
1
0
Форкнуть 0
Код Задачи Запросы на слияние Действия Пакеты Проекты Релизы Вики Активность
Files
06ad69a406dc561d277ec0b0cb32112afee1ffa4
mostlymatter/api4
История
Agniva De Sarker 06ad69a406 MM-47465: Fix flaky TestDeleteChannel (#21686) 
Creating the post in a separate goroutine would create a race condition
because that method also calls GetChannel. This can cause a bug
if the cache was wiped before the the other goroutine would get
a chance to update the cache. And if that happens, then
it would populate the cache with the old value.

Pseudo-code

```
func deleteChannel() {
    go func() {
        getFromCache()
    }()
    updateDB()
    wipeCache() // a
}

func getFromCache() {
    err := checkCache()
    if err == ErrNotFound {
        getFromDB() // x
        updateCache() // y
    }
}

func Test() {
    deleteChannel()
    getFromCache()
}
```

If the sequence of events happen like
- x
- a
- y

Then the getFromCache() call later will get the wrong
value from cache.

The fix is to make the call synchronous.

https://mattermost.atlassian.net/browse/MM-47465

Special thanks to @noxer for finding the root cause.

```release-note
NONE
```
2022-11-17 20:44:18 +05:30
..
api.go
[MM-43917] Cloud Freemium limits API: messages/posts (#20152)
2022-05-17 13:30:40 +02:00
apitestlib.go
MM-46874: Change to 400 for failed to upgrade ws (#21492)
2022-10-26 13:15:16 +05:30
bleve_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
bleve.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
bot_local.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
bot_test.go
Replace deprecated ioutil with io and os (#20776)
2022-08-09 14:25:46 +03:00
bot.go
MM-45195: Use api4/bot and app/bot to use logger context (#20729)
2022-08-01 13:48:45 +05:30
brand_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
brand.go
Replace ioutil.Discard with io.Discard (#20707)
2022-07-27 11:40:33 +02:00
channel_category_test.go
MM-44806: Avoid pointers in JSON parsing in updateCategoryForTeamForUser (#20431)
2022-06-11 00:24:23 +05:30
channel_category.go
[MM-45991] Check and return JSON errors (#20735)
2022-08-10 10:56:58 +02:00
channel_local.go
[MM-45990] log JSON parsing errors in API4 (#20724)
2022-07-28 17:05:03 +02:00
channel_test.go
MM-47465: Fix flaky TestDeleteChannel (#21686)
2022-11-17 20:44:18 +05:30
channel.go
[MM-45991] Check and return JSON errors (#20735)
2022-08-10 10:56:58 +02:00
cloud_test.go
Merge remote-tracking branch 'upstream/master' into MM-47560
2022-10-21 13:08:59 -04:00
cloud.go
Invalidate cloud caches when a new license is loaded (#21579)
2022-11-02 22:40:26 +02:00
cluster_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
cluster.go
[MM-45991] Check and return JSON errors (#20735)
2022-08-10 10:56:58 +02:00
command_help_test.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
command_local.go
[MM-45990] log JSON parsing errors in API4 (#20724)
2022-07-28 17:05:03 +02:00
command_test.go
[MM-45990] log JSON parsing errors in API4 (#20724)
2022-07-28 17:05:03 +02:00
command.go
[MM-45991] Check and return JSON errors (#20735)
2022-08-10 10:56:58 +02:00
commands_test.go
[MM-42191]: Include deleted posts (#19985)
2022-09-27 14:00:42 -04:00
compliance.go
[MM-45990] log JSON parsing errors in API4 (#20724)
2022-07-28 17:05:03 +02:00
config_local.go
[MM-45991] Check and return JSON errors (#20735)
2022-08-10 10:56:58 +02:00
config_test.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
config.go
Invalidate cloud caches when a new license is loaded (#21579)
2022-11-02 22:40:26 +02:00
cors_test.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
data_retention_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
data_retention.go
[MM-45991] Check and return JSON errors (#20735)
2022-08-10 10:56:58 +02:00
elasticsearch_test.go
[MM-43199] api4/elasticsearch: test elasticsearch after checking the config values (#20078)
2022-04-30 09:50:41 +03:00
elasticsearch.go
[MM-45991] Check and return JSON errors (#20735)
2022-08-10 10:56:58 +02:00
emoji_test.go
Replace deprecated ioutil with io and os (#20776)
2022-08-09 14:25:46 +03:00
emoji.go
[MM-48060] Added context for emoji (#21561)
2022-11-03 08:54:59 +01:00
export_local.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
export_test.go
Replace deprecated ioutil with io and os (#20776)
2022-08-09 14:25:46 +03:00
export.go
[MM-45991] Check and return JSON errors (#20735)
2022-08-10 10:56:58 +02:00
file_test.go
MM-36295: Do not convert thumbnails/previews to jpeg for png images (#21230)
2022-10-11 19:04:09 +05:30
file.go
[MM-44489] Cloud limits: enforcing files (#20703)
2022-09-28 12:52:53 -04:00
graphql_client.go
[MM-45990] log JSON parsing errors in API4 (#20724)
2022-07-28 17:05:03 +02:00
graphql_test.go
GraphQL (part 2): Model changes and resolvers (#19486)
2022-02-11 12:37:05 +05:30
graphql.go
move logger under platform (#20831)
2022-08-24 10:10:56 +03:00
group_local.go
[MM-47538] Pass handler functions directly while creating API endpoints (#21441)
2022-10-20 10:08:09 +05:30
group_test.go
[MM-44168] Add feature to restore archived user groups (#20369)
2022-11-17 14:53:54 +05:30
group.go
[MM-44168] Add feature to restore archived user groups (#20369)
2022-11-17 14:53:54 +05:30
handlers_test.go
GraphQL (part 2): Model changes and resolvers (#19486)
2022-02-11 12:37:05 +05:30
handlers.go
[MM-47538] Pass handler functions directly while creating API endpoints (#21441)
2022-10-20 10:08:09 +05:30
helpers.go
Consistent license message for all the go files (#13235)
2019-11-29 12:59:40 +01:00
image_test.go
Replace deprecated ioutil with io and os (#20776)
2022-08-09 14:25:46 +03:00
image.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
import_local.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
import_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
import.go
MM-45198: Migrate app/import and api4/import (#20799)
2022-08-17 19:58:52 +05:30
insights_test.go
[MM-45052] Add error checking in insights API (#21048)
2022-10-20 14:37:24 -04:00
insights.go
[MM-45052] Add error checking in insights API (#21048)
2022-10-20 14:37:24 -04:00
integration_action_test.go
Replace deprecated ioutil with io and os (#20776)
2022-08-09 14:25:46 +03:00
integration_action.go
[MM-45991] Check and return JSON errors (#20735)
2022-08-10 10:56:58 +02:00
job_local.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
job_test.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
job.go
[MM-45991] Check and return JSON errors (#20735)
2022-08-10 10:56:58 +02:00
ldap_local.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
ldap_test.go
MM-40818: Refactor product initialization to happen late (#19658)
2022-03-03 12:22:10 +05:30
ldap.go
[MM-45991] Check and return JSON errors (#20735)
2022-08-10 10:56:58 +02:00
license_local.go
[MM-45990] log JSON parsing errors in API4 (#20724)
2022-07-28 17:05:03 +02:00
license_test.go
Skip flaky test in TestRequestTrialLicense (#21665)
2022-11-15 10:52:54 +01:00
license.go
Invalidate cloud caches when a new license is loaded (#21579)
2022-11-02 22:40:26 +02:00
main_test.go
MM-36764 mlog refactor (#18118)
2021-08-17 16:08:04 -04:00
notify_admin_test.go
[MM-45564] - Notify Admin v2 (#20777)
2022-09-02 13:52:48 +03:00
notify_admin.go
[MM-45564] - Notify Admin v2 (#20777)
2022-09-02 13:52:48 +03:00
oauth_test.go
GraphQL (part 2): Model changes and resolvers (#19486)
2022-02-11 12:37:05 +05:30
oauth.go
[MM-45991] Check and return JSON errors (#20735)
2022-08-10 10:56:58 +02:00
openGraph_test.go
Use any instead of interface{} (#20577)
2022-07-05 09:46:50 +03:00
openGraph.go
Improve API4 initialization (#18680)
2021-10-15 19:57:05 +05:30
permission.go
[MM-45991] Check and return JSON errors (#20735)
2022-08-10 10:56:58 +02:00
permissions_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
plugin_local.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
plugin_test.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
plugin.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
post_local.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
post_test.go
Simplify thread_store/GetThreadForUser (#21588)
2022-11-09 12:16:20 +04:00
post.go
[MM-48060] Added context for emoji (#21561)
2022-11-03 08:54:59 +01:00
preference_test.go
[MM-43785] Hide insights feature intro for new users (#20214)
2022-06-08 14:56:34 -04:00
preference.go
[MM-45990] log JSON parsing errors in API4 (#20724)
2022-07-28 17:05:03 +02:00
reaction_test.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
reaction.go
[MM-45991] Check and return JSON errors (#20735)
2022-08-10 10:56:58 +02:00
remote_cluster.go
[MM-45991] Check and return JSON errors (#20735)
2022-08-10 10:56:58 +02:00
resolver_channel_member_test.go
MM-45193 Use context for channel logging (#20575)
2022-07-14 11:01:29 +02:00
resolver_channel_member.go
MM-45193 Use context for channel logging (#20575)
2022-07-14 11:01:29 +02:00
resolver_channel_test.go
Return empty list of channels when requesting more channels at the end of cursor (#21557)
2022-11-02 15:10:51 +05:30
resolver_channel.go
GraphQL: Remove channel stats from the API (#21377)
2022-10-14 14:17:43 +05:30
resolver_sidebar_categories_test.go
Add missing field "sortOrder" to graphQL schema (#20956)
2022-09-08 09:30:53 +02:00
resolver_team_member_test.go
MM-45715: Fix incorrect permissions (Round 2) (#20731)
2022-07-29 09:58:44 +05:30
resolver_team_member.go
GraphQL: Create dedicated top-level filter for sidebar categories (#20353)
2022-06-28 20:28:50 +05:30
resolver_team.go
[MM-45715] Check for correct permission when requesting teams (#20715)
2022-07-27 19:17:02 +02:00
resolver_test.go
Use any instead of interface{} (#20577)
2022-07-05 09:46:50 +03:00
resolver_user_test.go
MM-45194: Switch app/user and api4/user to logger context (#20674)
2022-07-28 10:04:21 +05:30
resolver_user.go
MM-44044: Fix racy TestGraphQLChannelMembers (#20155)
2022-05-09 13:19:44 +05:30
resolver.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
role_local.go
MM-32396 Create endpoint for listing all the roles (#16988)
2021-11-08 16:38:41 +03:00
role_test.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
role.go
[MM-45991] Check and return JSON errors (#20735)
2022-08-10 10:56:58 +02:00
saml_test.go
MM-40818: Refactor product initialization to happen late (#19658)
2022-03-03 12:22:10 +05:30
saml.go
Replace deprecated ioutil with io and os (#20776)
2022-08-09 14:25:46 +03:00
schema.graphqls
GraphQL: Remove channel stats from the API (#21377)
2022-10-14 14:17:43 +05:30
scheme_test.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
scheme.go
[MM-45991] Check and return JSON errors (#20735)
2022-08-10 10:56:58 +02:00
shared_channel_test.go
MM-45194: Switch app/user and api4/user to logger context (#20674)
2022-07-28 10:04:21 +05:30
shared_channel.go
[MM-45991] Check and return JSON errors (#20735)
2022-08-10 10:56:58 +02:00
status_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
status.go
[MM-45991] Check and return JSON errors (#20735)
2022-08-10 10:56:58 +02:00
system_local.go
[MM-45991] Check and return JSON errors (#20735)
2022-08-10 10:56:58 +02:00
system_test.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
system.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
team_local.go
MM-46528_Verify Invitation Flow Tracking Telemetry (#21227)
2022-10-24 16:20:56 -05:00
team_test.go
MM-47228 - restrict guest invitation flow if subscription plan does n… (#21195)
2022-10-07 15:57:44 +02:00
team.go
Invalidate cloud caches when a new license is loaded (#21579)
2022-11-02 22:40:26 +02:00
terms_of_service_test.go
[MM-37557] Move error out of client4 response (#18101)
2021-08-13 13:12:16 +02:00
terms_of_service.go
[MM-45990] log JSON parsing errors in API4 (#20724)
2022-07-28 17:05:03 +02:00
upload_local.go
[MM-37772] Idiomatic naming (URL, URI, API) (#18128)
2021-08-16 19:46:44 +02:00
upload_test.go
[MM-45862] Set size and extension to fileinfo (#20681)
2022-07-22 09:14:01 +02:00
upload.go
Invalidate cloud caches when a new license is loaded (#21579)
2022-11-02 22:40:26 +02:00
usage_test.go
Move cluster, webhub and store out of Server (#20899)
2022-10-06 11:04:21 +03:00
usage.go
[MM-45991] Check and return JSON errors (#20735)
2022-08-10 10:56:58 +02:00
user_local.go
[MM-45991] Check and return JSON errors (#20735)
2022-08-10 10:56:58 +02:00
user_test.go
[MM-48049] Including users who were removed from group in not_in_group response (#21559)
2022-11-04 19:10:26 +02:00
user_viewmembers_test.go
spelling: strings (#19542)
2022-02-28 15:01:00 +05:30
user.go
Simplify thread_store/GetThreadForUser (#21588)
2022-11-09 12:16:20 +04:00
webhook_local.go
[MM-45990] log JSON parsing errors in API4 (#20724)
2022-07-28 17:05:03 +02:00
webhook_test.go
spelling: strings (#19542)
2022-02-28 15:01:00 +05:30
webhook.go
[MM-45991] Check and return JSON errors (#20735)
2022-08-10 10:56:58 +02:00
websocket_norace_test.go
Custom groups (#18839)
2022-02-17 12:34:39 -05:00
websocket_test.go
MM-46874: Change to 400 for failed to upgrade ws (#21492)
2022-10-26 13:15:16 +05:30
websocket.go
MM-46874: Change to 400 for failed to upgrade ws (#21492)
2022-10-26 13:15:16 +05:30