Files
mostlymatter/server/channels/app/platform/status_test.go
Agniva De Sarker 761bc7549b [AI assisted] MM-64298: Process setting status offline in batches (#31065)
When a user disconnects from the hub, we would spawn off a goroutine
which would make a cluster request, and then update the user status
as offline in the DB.

This was another case of unbounded concurrency where the number of
goroutines spawned was user controlled. Therefore, we would see
a clear spike in DB connections on master when a lot of users
would suddenly disconnect.

To fix this, we implement concurrency control in two areas:
1. In making the cluster request. We implement a counting semaphore
per-hub to avoid making unbounded cluster requests.
2. We use a buffered channel with a periodic flusher to process
status updates.

We also add a new store method to upsert multiple statuses
in a single query. The statusUpdateThreshold is set to 32, which means
no more than 32 rows will be upserted at one time, keeping the
SQL query load reasonable.

https://mattermost.atlassian.net/browse/MM-64298

```release-note
We improve DB connection spikes on user disconnect
by processing status updates in batches.
```
2025-06-17 09:20:34 +05:30

261 строка
7.7 KiB
Go

// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
// See LICENSE.txt for license information.
package platform
import (
"testing"
"time"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/mattermost/mattermost/server/public/model"
)
func TestSaveStatus(t *testing.T) {
th := Setup(t).InitBasic()
defer th.TearDown()
user := th.BasicUser
for _, statusString := range []string{
model.StatusOnline,
model.StatusAway,
model.StatusDnd,
model.StatusOffline,
} {
t.Run(statusString, func(t *testing.T) {
status := &model.Status{
UserId: user.Id,
Status: statusString,
}
th.Service.SaveAndBroadcastStatus(status)
after, err := th.Service.GetStatus(user.Id)
require.Nil(t, err, "failed to get status after save: %v", err)
require.Equal(t, statusString, after.Status, "failed to save status, got %v, expected %v", after.Status, statusString)
})
}
}
func TestTruncateDNDEndTime(t *testing.T) {
// 2025-Jan-20 at 17:13:32 GMT becomes 17:13:00
assert.Equal(t, int64(1737393180), truncateDNDEndTime(1737393212))
// 2025-Jan-20 at 17:13:00 GMT remains unchanged
assert.Equal(t, int64(1737393180), truncateDNDEndTime(1737393180))
// 2025-Jan-20 at 00:00:10 GMT becomes 00:00:00
assert.Equal(t, int64(1737331200), truncateDNDEndTime(1737331210))
// 2025-Jan-20 at 00:00:10 GMT remains unchanged
assert.Equal(t, int64(1737331200), truncateDNDEndTime(1737331200))
}
func TestQueueSetStatusOffline(t *testing.T) {
th := Setup(t).InitBasic()
defer func() {
// First tear down the test environment
th.TearDown()
// Then verify that the status update processor has properly shut down
// by checking that the done signal channel is closed
select {
case _, ok := <-th.Service.statusUpdateDoneSignal:
// If channel is closed, ok will be false
assert.False(t, ok, "statusUpdateDoneSignal channel should be closed after teardown")
case <-time.After(5 * time.Second):
require.Fail(t, "Timed out waiting for status update processor to shut down")
}
}()
// Create multiple user IDs
userIDs := []string{
th.BasicUser.Id,
model.NewId(),
model.NewId(),
model.NewId(),
}
// Add duplicate user IDs to test duplicate handling
// The second occurrence should override the first
userIDs = append(userIDs, userIDs[0], userIDs[1])
// Initially set all users to online
for _, userID := range userIDs {
th.Service.SetStatusOnline(userID, false)
status, err := th.Service.GetStatus(userID)
require.Nil(t, err, "Failed to get initial status")
require.Equal(t, model.StatusOnline, status.Status, "User should be online initially")
}
// Queue status updates to offline
for i, userID := range userIDs {
// Set every other status as manual to test both cases
manual := i%2 == 0
th.Service.QueueSetStatusOffline(userID, manual)
}
// Wait for the background processor to handle the updates
// Use eventually consistent approach with retries
for idx, userID := range userIDs {
var status *model.Status
var err *model.AppError
// Use poll-wait pattern to account for async processing
require.Eventually(t, func() bool {
status, err = th.Service.GetStatus(userID)
return err == nil && status.Status == model.StatusOffline
}, 5*time.Second, 100*time.Millisecond, "Status wasn't updated to offline")
// For the duplicated user IDs, check that manual setting is based on the last call
// User[0] and User[1] are duplicated at the end of the slice
switch idx {
case 0, 4: // first duplicated user
// Last update for userIDs[0] was at index 4 (i%2 == 0, so manual = true)
require.True(t, status.Manual, "User should have manual status (duplicate case)")
case 1, 5:
// Last update for userIDs[1] was at index 5 (i%2 == 1, so manual = false)
require.False(t, status.Manual, "User should have automatic status (duplicate case)")
default:
require.Equal(t, idx%2 == 0, status.Manual, "Manual flag incorrect")
}
}
// Verify all relevant status fields
for _, userID := range model.RemoveDuplicateStrings(userIDs) {
status, err := th.Service.GetStatus(userID)
require.Nil(t, err, "Failed to get status")
require.Equal(t, model.StatusOffline, status.Status, "User should be offline")
require.Equal(t, "", status.ActiveChannel, "ActiveChannel should be empty")
}
}
func TestSetStatusOffline(t *testing.T) {
th := Setup(t).InitBasic()
defer th.TearDown()
user := th.BasicUser
t.Run("when user statuses are disabled", func(t *testing.T) {
th.Service.UpdateConfig(func(cfg *model.Config) {
*cfg.ServiceSettings.EnableUserStatuses = false
})
// Set initial status to online
status := &model.Status{
UserId: user.Id,
Status: model.StatusOnline,
}
th.Service.SaveAndBroadcastStatus(status)
// Try to set offline
th.Service.SetStatusOffline(user.Id, false, false)
// Enable user statuses to see what is really in the database
th.Service.UpdateConfig(func(cfg *model.Config) {
*cfg.ServiceSettings.EnableUserStatuses = true
})
// Status should remain unchanged
after, err := th.Service.GetStatus(user.Id)
require.Nil(t, err)
assert.Equal(t, model.StatusOnline, after.Status)
})
t.Run("when setting status manually over manually set status", func(t *testing.T) {
th.Service.UpdateConfig(func(cfg *model.Config) {
*cfg.ServiceSettings.EnableUserStatuses = true
})
// Set initial status to online manually
status := &model.Status{
UserId: user.Id,
Status: model.StatusOnline,
Manual: true,
}
th.Service.SaveAndBroadcastStatus(status)
// Try to set offline non-manually
th.Service.SetStatusOffline(user.Id, false, false)
// Status should remain unchanged because manual status takes precedence
after, err := th.Service.GetStatus(user.Id)
require.Nil(t, err)
assert.Equal(t, model.StatusOnline, after.Status)
assert.True(t, after.Manual)
})
t.Run("when force flag is true over manually set status", func(t *testing.T) {
th.Service.UpdateConfig(func(cfg *model.Config) {
*cfg.ServiceSettings.EnableUserStatuses = true
})
// Set initial status to online manually
status := &model.Status{
UserId: user.Id,
Status: model.StatusOnline,
Manual: true,
}
th.Service.SaveAndBroadcastStatus(status)
// Try to set offline with force flag
th.Service.SetStatusOffline(user.Id, false, true)
// Status should change despite being manual
after, err := th.Service.GetStatus(user.Id)
require.Nil(t, err)
assert.Equal(t, model.StatusOffline, after.Status)
assert.False(t, after.Manual)
})
t.Run("when setting status normally", func(t *testing.T) {
th.Service.UpdateConfig(func(cfg *model.Config) {
*cfg.ServiceSettings.EnableUserStatuses = true
})
// Set initial status to online
status := &model.Status{
UserId: user.Id,
Status: model.StatusOnline,
Manual: false,
}
th.Service.SaveAndBroadcastStatus(status)
// Set offline
th.Service.SetStatusOffline(user.Id, false, false)
// Status should change
after, err := th.Service.GetStatus(user.Id)
require.Nil(t, err)
assert.Equal(t, model.StatusOffline, after.Status)
assert.False(t, after.Manual)
})
t.Run("when setting status manually over normal status", func(t *testing.T) {
th.Service.UpdateConfig(func(cfg *model.Config) {
*cfg.ServiceSettings.EnableUserStatuses = true
})
// Set initial status to online
status := &model.Status{
UserId: user.Id,
Status: model.StatusOnline,
Manual: false,
}
th.Service.SaveAndBroadcastStatus(status)
// Set offline manually
th.Service.SetStatusOffline(user.Id, true, false)
// Status should change and be marked as manual
after, err := th.Service.GetStatus(user.Id)
require.Nil(t, err)
assert.Equal(t, model.StatusOffline, after.Status)
assert.True(t, after.Manual)
})
}