Files
mostlymatter/server/channels/jobs/batch_worker_test.go
Agniva De Sarker bdce9f42d8 MM-56358: Unskip racy test TestUploadLicenseFile (#26009)
This was already fixed before in https://github.com/mattermost/mattermost/pull/24971.
We just enable the test now.

https://mattermost.atlassian.net/browse/MM-56358

```release-note
NONE
```

Co-authored-by: Mattermost Build <build@mattermost.com>
2024-02-13 21:03:17 +05:30

162 строки
4.2 KiB
Go

// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
// See LICENSE.txt for license information.
package jobs_test
import (
"strconv"
"testing"
"time"
"github.com/mattermost/mattermost/server/public/model"
"github.com/mattermost/mattermost/server/public/shared/request"
"github.com/mattermost/mattermost/server/v8/channels/jobs"
"github.com/stretchr/testify/require"
)
// TestBatchWorkerRace tests race conditions during the start/stop
// cases of the batch worker. Use the -race flag while testing this.
func TestBatchWorkerRace(t *testing.T) {
th := Setup(t)
defer th.TearDown()
worker := jobs.MakeBatchWorker(th.Server.Jobs, th.Server.Store(), 1*time.Second, func(rctx *request.Context, job *model.Job) bool {
return false
})
go worker.Run()
worker.Stop()
}
func TestBatchWorker(t *testing.T) {
createBatchWorker := func(t *testing.T, th *TestHelper, doBatch func(rctx *request.Context, job *model.Job) bool) (*jobs.BatchWorker, *model.Job) {
t.Helper()
worker := jobs.MakeBatchWorker(th.Server.Jobs, th.Server.Store(), 1*time.Second, doBatch)
job := th.SetupBatchWorker(t, worker)
return worker, job
}
getBatchNumberFromData := func(t *testing.T, data model.StringMap) int {
t.Helper()
batchNumber, err := strconv.Atoi(data["batch_number"])
require.NoError(t, err)
return batchNumber
}
incrementBatchNumber := func(t *testing.T, th *TestHelper, job *model.Job) {
t.Helper()
batchNumber, err := strconv.Atoi(job.Data["batch_number"])
require.NoError(t, err)
batchNumber++
job.Data["batch_number"] = strconv.Itoa(batchNumber)
th.Server.Jobs.SetJobProgress(job, 0)
}
t.Run("stop after first batch", func(t *testing.T) {
th := Setup(t).InitBasic()
defer th.TearDown()
var worker *jobs.BatchWorker
worker, job := createBatchWorker(t, th, func(rctx *request.Context, job *model.Job) bool {
batchNumber := getBatchNumberFromData(t, job.Data)
require.Equal(t, 1, batchNumber, "only batch 1 should have run")
// Shut down the worker after the first batch to prevent subsequent ones.
if batchNumber >= 1 {
go worker.Stop()
} else {
incrementBatchNumber(t, th, job)
}
return false
})
// Queue the work to be done
worker.JobChannel() <- *job
th.WaitForJobStatus(t, job, model.JobStatusPending)
th.WaitForBatchNumber(t, job, 1)
})
t.Run("stop after second batch", func(t *testing.T) {
th := Setup(t).InitBasic()
defer th.TearDown()
var worker *jobs.BatchWorker
worker, job := createBatchWorker(t, th, func(rctx *request.Context, job *model.Job) bool {
batchNumber := getBatchNumberFromData(t, job.Data)
require.LessOrEqual(t, batchNumber, 2, "only batches 1 and 2 should have run")
// Shut down the worker after the second batch to prevent subsequent ones.
if batchNumber >= 2 {
go worker.Stop()
} else {
incrementBatchNumber(t, th, job)
}
return false
})
// Queue the work to be done
worker.JobChannel() <- *job
th.WaitForJobStatus(t, job, model.JobStatusPending)
th.WaitForBatchNumber(t, job, 2)
})
t.Run("done after first batch", func(t *testing.T) {
th := Setup(t).InitBasic()
defer th.TearDown()
var worker *jobs.BatchWorker
worker, job := createBatchWorker(t, th, func(rctx *request.Context, job *model.Job) bool {
batchNumber := getBatchNumberFromData(t, job.Data)
require.Equal(t, 1, batchNumber, "only batch 1 should have run")
if batchNumber >= 1 {
go worker.Stop() // Shut down the worker when the job is done
return true
}
incrementBatchNumber(t, th, job)
return false
})
// Queue the work to be done
worker.JobChannel() <- *job
th.WaitForBatchNumber(t, job, 1)
})
t.Run("done after three batches", func(t *testing.T) {
th := Setup(t).InitBasic()
defer th.TearDown()
var worker *jobs.BatchWorker
worker, job := createBatchWorker(t, th, func(rctx *request.Context, job *model.Job) bool {
batchNumber := getBatchNumberFromData(t, job.Data)
require.LessOrEqual(t, batchNumber, 3, "only 3 batches should have run")
if batchNumber >= 3 {
go worker.Stop() // Shut down the worker when the job is done
return true
}
incrementBatchNumber(t, th, job)
return false
})
// Queue the work to be done
worker.JobChannel() <- *job
th.WaitForBatchNumber(t, job, 3)
})
}