Files
mostlymatter/server/channels/app/report_test.go
Pablo Vélez 1690e48db6 MM 60222 - apply filter to export csv (#28212)
* MM-60222_apply filter to export csv

* get the report exporting with the filters ready

* add unit tests

* cover one more file with some tests

* style the confirm modal note

* add translations

* remove unnecessary print line

* disable export button if there is no data to export

* fix linter issues

* fix linter errors

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
2024-10-02 12:23:39 +02:00

208 строки
6.0 KiB
Go

// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
// See LICENSE.txt for license information.
package app
import (
"fmt"
"strconv"
"testing"
"time"
"github.com/mattermost/mattermost/server/public/model"
"github.com/mattermost/mattermost/server/public/shared/request"
"github.com/stretchr/testify/require"
)
type MockReportable struct {
TestField1 string
TestField2 int
TestField3 time.Time
}
func (mr *MockReportable) ToReport() []string {
return []string{
mr.TestField1,
strconv.Itoa(mr.TestField2),
mr.TestField3.Format("2006-01-02"),
}
}
var testData []model.ReportableObject = []model.ReportableObject{
&MockReportable{
TestField1: "some-name",
TestField2: 400,
TestField3: time.Date(2024, 1, 1, 0, 0, 0, 0, time.Local),
},
&MockReportable{
TestField1: "some-other-name",
TestField2: 500,
TestField3: time.Date(2023, 1, 1, 0, 0, 0, 0, time.Local),
},
&MockReportable{
TestField1: "some-other-other-name",
TestField2: 600,
TestField3: time.Date(2022, 1, 1, 0, 0, 0, 0, time.Local),
},
}
func TestSaveReportChunk(t *testing.T) {
th := Setup(t).InitBasic()
defer th.TearDown()
t.Run("should write CSV chunk to file", func(t *testing.T) {
prefix := model.NewId()
err := th.App.SaveReportChunk("csv", prefix, 999, []model.ReportableObject{testData[0]})
require.Nil(t, err)
filePath := fmt.Sprintf("admin_reports/batch_report_%s__999.csv", prefix)
bytes, err := th.App.ReadFile(filePath)
require.Nil(t, err)
require.NotNil(t, bytes)
require.Equal(t, "some-name,400,2024-01-01\n", string(bytes))
})
t.Run("should fail if the report format is not supported", func(t *testing.T) {
err := th.App.SaveReportChunk("zzz", model.NewId(), 999, []model.ReportableObject{testData[0]})
require.NotNil(t, err)
})
}
func TestCompileReportChunks(t *testing.T) {
th := Setup(t).InitBasic()
defer th.TearDown()
prefix := model.NewId()
err := th.App.SaveReportChunk("csv", prefix, 0, []model.ReportableObject{testData[0]})
require.Nil(t, err)
err = th.App.SaveReportChunk("csv", prefix, 1, []model.ReportableObject{testData[1]})
require.Nil(t, err)
err = th.App.SaveReportChunk("csv", prefix, 2, []model.ReportableObject{testData[2]})
require.Nil(t, err)
t.Run("should compile a bunch of report chunks", func(t *testing.T) {
compileErr := th.App.CompileReportChunks("csv", prefix, 3, []string{"Name", "NumPosts", "StartDate"})
require.Nil(t, compileErr)
filePath := fmt.Sprintf("admin_reports/batch_report_%s.csv", prefix)
bytes, readErr := th.App.ReadFile(filePath)
require.Nil(t, readErr)
require.NotNil(t, bytes)
expected :=
`Name,NumPosts,StartDate
some-name,400,2024-01-01
some-other-name,500,2023-01-01
some-other-other-name,600,2022-01-01
`
require.Equal(t, expected, string(bytes))
})
t.Run("should fail if the report format is not supported", func(t *testing.T) {
err = th.App.CompileReportChunks("zzz", prefix, 3, []string{"Name", "NumPosts", "StartDate"})
require.NotNil(t, err)
})
t.Run("should fail if a chunk is missing", func(t *testing.T) {
err = th.App.CompileReportChunks("csv", prefix, 4, []string{"Name", "NumPosts", "StartDate"})
require.NotNil(t, err)
})
}
func TestCheckForExistingJobs(t *testing.T) {
th := Setup(t).InitBasic()
defer th.TearDown()
t.Run("should return error if job with same options exists in pending jobs", func(t *testing.T) {
app := th.App
rctx := request.TestContext(t)
options := map[string]string{
"date_range": "last_30_days",
"requesting_user_id": th.BasicUser.Id,
"role": "user",
"team": "",
"hide_active": "false",
"hide_inactive": "false",
}
jobType := model.JobTypeExportUsersToCSV
// Create a pending job with same options
job, err := app.Srv().Jobs.CreateJob(rctx, jobType, options)
defer func() {
_ = app.Srv().Jobs.RequestCancellation(rctx, job.Id)
}()
require.Nil(t, err)
require.NotNil(t, job)
// checkForExistingJobs
appErr := app.checkForExistingJobs(rctx, options, jobType)
require.NotNil(t, appErr)
require.Equal(t, "app.report.start_users_batch_export.job_exists", appErr.Id)
})
t.Run("should return error if job with same options exists in in-progress jobs", func(t *testing.T) {
app := th.App
rctx := request.TestContext(t)
options := map[string]string{
"date_range": "last_30_days",
"requesting_user_id": th.BasicUser.Id,
"role": "user",
"team": "",
"hide_active": "false",
"hide_inactive": "false",
}
jobType := model.JobTypeExportUsersToCSV
// Create an in-progress job with same options
job, err := app.Srv().Jobs.CreateJob(rctx, jobType, options)
defer func() {
_ = app.Srv().Jobs.RequestCancellation(rctx, job.Id)
}()
require.Nil(t, err)
require.NotNil(t, job)
// Manually set job status to in-progress
err = app.Srv().Jobs.SetJobProgress(job, 60)
require.Nil(t, err)
// Call checkForExistingJobs
appErr := app.checkForExistingJobs(rctx, options, jobType)
require.NotNil(t, appErr)
require.Equal(t, "app.report.start_users_batch_export.job_exists", appErr.Id)
})
t.Run("should not return error if existing jobs have different options", func(t *testing.T) {
app := th.App
rctx := request.TestContext(t)
options := map[string]string{
"date_range": "last_30_days",
"requesting_user_id": th.BasicUser.Id,
"role": "user",
"team": "",
"hide_active": "false",
"hide_inactive": "false",
}
jobType := model.JobTypeExportUsersToCSV
differentOptions := map[string]string{
"date_range": "all_time",
"requesting_user_id": th.BasicUser2.Id,
"role": "admin",
"team": "",
"hide_active": "false",
"hide_inactive": "false",
}
job, err := app.Srv().Jobs.CreateJob(rctx, jobType, differentOptions)
require.Nil(t, err)
require.NotNil(t, job)
// Call checkForExistingJobs
appErr := app.checkForExistingJobs(rctx, options, jobType)
require.Nil(t, appErr)
})
}