* Updated patch/update post API to allow file modification (#29447) * WIP * WIP * Atatched new files ton post * WIP: deleting removed files * Deleted removed files and invalidated file metadata cache * removed file ignore logif from update post API * Added TestFindExclusives * Added tests for DeleteForPostByIds * Added app layer tests * Added tests * Added API level tests * test enhancements * Fixed a test * Edit history include file metadata (#29505) * Send file metadata in edit history metadata * Added app tests * Added store tests * Added tests for populateEditHistoryFileMetadata{ * Added cache to avoid repetitigve DB calls for edits with only message changes * Added API tests * i18m fix * removed commented code * Improved test helper * Show attachments in edit history RHS (#29519) * Send file metadata in edit history metadata * Added app tests * Added store tests * Added tests for populateEditHistoryFileMetadata{ * Added cache to avoid repetitigve DB calls for edits with only message changes * Added API tests * i18m fix * WIUP: displa files in edit * removed commented code * Displayed file in edit history * Handled file icon * Fixed closing history component on clicking on file * Simplified selector * Simplified selector * Improved test helper * Disabled action menu on edit history file * Added tests * Improved selector * Updated snapshot * review Fixes * restructured componnets * Updated test * Updated test * Restore post api (#29643) * Restore post version API WIP * Undelete files WIP * Added store tests * Created post restore API * Updated updatepost safeUpdate signature * review fixex and improvements * Fixed an app test * Added API laer tests * Added API tests and OpenAPI specs * Fixed a typo * Allow editing files when editing posts (#29709) * WIP - basic view files when editing post * Cleanup * bg color * Added text editor tests for files * WIP * WIP * removed debug log * Allowed admin to add and remove files on someone else's post * Handled drafts and scheduled posts * linter fixes * Updated snapshot * server test fix * CI * Added doc * Restore post api integration (#29719) * WIP - basic view files when editing post * Cleanup * bg color * Added text editor tests for files * WIP * WIP * removed debug log * Allowed admin to add and remove files on someone else's post * Handled drafts and scheduled posts * linter fixes * Updated snapshot * server test fix * Used new API to restore post * handled edut limit and undo * lint fix * added comments * Fixed edit post item tests * Fixed buttons * Aded snapshots * fix test * Updated snapshot * Minor fixes * fixed snapshot * Edit file dnd area (#29763) * dnd wip * DND continued * Supported multiple unbind dragster funcs * lint fixes * Got center channel file drop working when editing a post * file dnd working with center channel and rhs * file dnd working with center channel and rhs * removed unneeded stopPropogation calls * cleanup * DND overlay fix * Lint fix * Advanced text editor test updates for file upload overlay * fixed use upload hook tests * Updated some more snapshots * minor cleanup * Updated i18n * removed need of array for dragster unbind events * lint fixes * edit history cursor * Fixed bugu causing faliure to delete empty posts (#29778) * Files in restore confirmation (#29781) * Added files to restore post confirmation dialog * Fixed post restore toast colors * Fixed restore bug * Fixed restore confirmation toast tests * a11y improvement and modal width fix * Edit attachment misc fixes (#29808) * Removed single image actions in restore post confirmation dialog * Fixed file drop overlay size and position * Made edit indiator accessible * Lint fix * Added bunch of more tests * ANother test migrated from enzyme to react testing library * More test enhancements * More test enhancements * More test enhancements * lint fixes * Fixed a test * Added missing snapshots * Test fixes
181 строка
6.9 KiB
Go
181 строка
6.9 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package app
|
|
|
|
import (
|
|
"net/http"
|
|
"testing"
|
|
|
|
"github.com/mattermost/mattermost/server/public/model"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestRestorePostVersion(t *testing.T) {
|
|
th := Setup(t).InitBasic()
|
|
defer th.TearDown()
|
|
|
|
t.Run("is able to restore a post version", func(t *testing.T) {
|
|
post := th.CreatePost(th.BasicChannel, func(p *model.Post) {
|
|
p.Message = "original message"
|
|
})
|
|
th.PostPatch(post, "new message 2")
|
|
th.PostPatch(post, "new message 3")
|
|
|
|
// verify post's state
|
|
fetchedPost, err := th.App.Srv().Store().Post().GetSingle(th.Context, post.Id, true)
|
|
require.NoError(t, err)
|
|
require.Equal(t, "new message 3", fetchedPost.Message)
|
|
|
|
editHistory, appErr := th.App.GetEditHistoryForPost(post.Id)
|
|
require.Nil(t, appErr)
|
|
require.Equal(t, 2, len(editHistory))
|
|
require.Equal(t, "new message 2", editHistory[0].Message)
|
|
|
|
// now we'll restore a post version
|
|
restoredPost, appErr := th.App.RestorePostVersion(th.Context, th.BasicUser.Id, post.Id, editHistory[0].Id)
|
|
require.Nil(t, appErr)
|
|
require.Equal(t, "new message 2", restoredPost.Message)
|
|
|
|
// verify from database
|
|
fetchedPost, err = th.App.Srv().Store().Post().GetSingle(th.Context, post.Id, true)
|
|
require.NoError(t, err)
|
|
require.Equal(t, "new message 2", fetchedPost.Message)
|
|
|
|
// verify that we now have 3 items in post's edit history
|
|
editHistory, appErr = th.App.GetEditHistoryForPost(post.Id)
|
|
require.Nil(t, appErr)
|
|
require.Equal(t, 3, len(editHistory))
|
|
require.Equal(t, "new message 3", editHistory[0].Message)
|
|
require.Equal(t, "new message 2", editHistory[1].Message)
|
|
require.Equal(t, "original message", editHistory[2].Message)
|
|
})
|
|
|
|
t.Run("is able to restore a post version including its files", func(t *testing.T) {
|
|
fileBytes := []byte("file contents")
|
|
fileInfo, appErr := th.App.UploadFile(th.Context, fileBytes, th.BasicChannel.Id, "file.txt")
|
|
require.Nil(t, appErr)
|
|
|
|
post := th.CreatePost(th.BasicChannel, func(p *model.Post) {
|
|
p.FileIds = []string{fileInfo.Id}
|
|
p.Message = "original message"
|
|
})
|
|
|
|
// this update removes all files
|
|
th.PostPatch(post, "new message 2", func(p *model.PostPatch) {
|
|
p.FileIds = &model.StringArray{}
|
|
})
|
|
// this update only changes the message
|
|
th.PostPatch(post, "new message 3")
|
|
|
|
// verify post's state
|
|
fetchedPost, err := th.App.Srv().Store().Post().GetSingle(th.Context, post.Id, true)
|
|
require.NoError(t, err)
|
|
require.Equal(t, "new message 3", fetchedPost.Message)
|
|
require.Empty(t, fetchedPost.FileIds)
|
|
|
|
editHistory, appErr := th.App.GetEditHistoryForPost(post.Id)
|
|
require.Nil(t, appErr)
|
|
require.Equal(t, 2, len(editHistory))
|
|
require.Equal(t, "new message 2", editHistory[0].Message)
|
|
require.Equal(t, 0, len(editHistory[0].FileIds))
|
|
|
|
require.Equal(t, "original message", editHistory[1].Message)
|
|
require.Equal(t, 1, len(editHistory[1].FileIds))
|
|
|
|
// now we'll restore a post version
|
|
restoredPost, appErr := th.App.RestorePostVersion(th.Context, th.BasicUser.Id, post.Id, editHistory[1].Id)
|
|
require.Nil(t, appErr)
|
|
require.Equal(t, "original message", restoredPost.Message)
|
|
require.Equal(t, 1, len(restoredPost.FileIds))
|
|
|
|
// verify from database
|
|
fetchedPost, err = th.App.Srv().Store().Post().GetSingle(th.Context, post.Id, true)
|
|
require.NoError(t, err)
|
|
require.Equal(t, "original message", fetchedPost.Message)
|
|
require.Equal(t, 1, len(fetchedPost.FileIds))
|
|
|
|
// verify edit history\
|
|
editHistory, appErr = th.App.GetEditHistoryForPost(post.Id)
|
|
require.Nil(t, appErr)
|
|
require.Equal(t, 3, len(editHistory))
|
|
|
|
require.Equal(t, "new message 3", editHistory[0].Message)
|
|
require.Equal(t, 0, len(editHistory[0].FileIds))
|
|
|
|
require.Equal(t, "new message 2", editHistory[1].Message)
|
|
require.Equal(t, 0, len(editHistory[1].FileIds))
|
|
|
|
require.Equal(t, "original message", editHistory[2].Message)
|
|
require.Equal(t, 1, len(editHistory[2].FileIds))
|
|
})
|
|
|
|
t.Run("should return an error if trying to restore a post that is not in any edit history", func(t *testing.T) {
|
|
post := th.CreatePost(th.BasicChannel, func(p *model.Post) {
|
|
p.Message = "original message"
|
|
})
|
|
th.PostPatch(post, "new message 2")
|
|
th.PostPatch(post, "new message 3")
|
|
|
|
// verify post's state
|
|
fetchedPost, err := th.App.Srv().Store().Post().GetSingle(th.Context, post.Id, true)
|
|
require.NoError(t, err)
|
|
require.Equal(t, "new message 3", fetchedPost.Message)
|
|
|
|
// now we'll restore a post version
|
|
otherPost := th.CreatePost(th.BasicChannel)
|
|
restoredPost, appErr := th.App.RestorePostVersion(th.Context, th.BasicUser.Id, post.Id, otherPost.Id)
|
|
require.NotNil(t, appErr)
|
|
require.Equal(t, http.StatusBadRequest, appErr.StatusCode)
|
|
require.Equal(t, "app.post.restore_post_version.not_an_history_item.app_error", appErr.Id)
|
|
require.Nil(t, restoredPost)
|
|
|
|
// verify from database that the post wasn't modified
|
|
fetchedPost, err = th.App.Srv().Store().Post().GetSingle(th.Context, post.Id, true)
|
|
require.NoError(t, err)
|
|
require.Equal(t, "new message 3", fetchedPost.Message)
|
|
})
|
|
|
|
t.Run("should return an error if the post does not exist", func(t *testing.T) {
|
|
restoredPost, appErr := th.App.RestorePostVersion(th.Context, th.BasicUser.Id, model.NewId(), model.NewId())
|
|
require.NotNil(t, appErr)
|
|
require.Equal(t, http.StatusNotFound, appErr.StatusCode)
|
|
require.Equal(t, "app.post.restore_post_version.get_single.app_error", appErr.Id)
|
|
require.Nil(t, restoredPost)
|
|
})
|
|
|
|
t.Run("should return an error if the restore post does not exist", func(t *testing.T) {
|
|
post := th.CreatePost(th.BasicChannel)
|
|
|
|
// now we'll restore a post version
|
|
invalidRestorePostIUd := model.NewId()
|
|
restoredPost, appErr := th.App.RestorePostVersion(th.Context, th.BasicUser.Id, post.Id, invalidRestorePostIUd)
|
|
require.NotNil(t, appErr)
|
|
require.Equal(t, http.StatusNotFound, appErr.StatusCode)
|
|
require.Equal(t, "app.post.restore_post_version.get_single.app_error", appErr.Id)
|
|
require.Nil(t, restoredPost)
|
|
})
|
|
|
|
t.Run("should return an error if trying to restore a post that is in some other posts edit history", func(t *testing.T) {
|
|
post := th.CreatePost(th.BasicChannel)
|
|
th.PostPatch(post, "new message 2")
|
|
|
|
otherPost := th.CreatePost(th.BasicChannel, func(post *model.Post) {
|
|
post.Message = "other post original message"
|
|
})
|
|
th.PostPatch(otherPost, "other post new message 2")
|
|
|
|
otherPostEditHistory, appErr := th.App.GetEditHistoryForPost(otherPost.Id)
|
|
require.Nil(t, appErr)
|
|
require.Equal(t, 1, len(otherPostEditHistory))
|
|
require.Equal(t, "other post original message", otherPostEditHistory[0].Message)
|
|
|
|
// we'll specify post's ID and other post's version ID, his should fail
|
|
restoredPost, appErr := th.App.RestorePostVersion(th.Context, th.BasicUser.Id, post.Id, otherPostEditHistory[0].Id)
|
|
require.NotNil(t, appErr)
|
|
require.Equal(t, "app.post.restore_post_version.not_an_history_item.app_error", appErr.Id)
|
|
require.Equal(t, http.StatusBadRequest, appErr.StatusCode)
|
|
require.Nil(t, restoredPost)
|
|
})
|
|
}
|