Jared Shields
3515b4d6c9
GH-15624: Added plugin hooks for ReationHasBeenAdded and ReactionHasBeenRemoved ( #15765 )
2020-10-31 07:06:43 +01:00
Eli Yukelzon
fe352ab57f
MM-29703 Mark threads as read when channels are marked ( #15994 )
...
Co-authored-by: Jesús Espino <jespinog@gmail.com >
2020-10-30 17:00:21 +02:00
Agniva De Sarker
325bff1176
MM-30041: Return correct error message for user save ( #16117 )
...
* MM-30041: Return correct error message for user save
We were collapsing all types of user conflict into a single
error message. Fixed it by inspecting the field of the invalidError type
and returning the correct message.
https://mattermost.atlassian.net/browse/MM-30041
```release-note
NONE
```
* Fix test errors
* Fix wrong message in test when comparing error messages
Co-authored-by: Rodrigo Villablanca <villa061004@gmail.com >
2020-10-30 11:14:06 +05:30
Christopher Speller
1aadd36644
MM-28859 Add feature flag managment system using split.io and remove viper. ( #15954 )
...
* Add feature flag managment system using split.io and remove viper.
* Fixing tests.
* Attempt to fix postgres tests.
* Fix watch filepath for advanced logging.
* Review fixes.
* Some error wrapping.
* Remove unessisary store interface.
* Desanitize SplitKey
* Simplify.
* Review feedback.
* Rename split mlog adatper to split logger.
* fsInner
* Style.
* Restore oldcfg test.
* Downgrading non-actionable feature flag errors to warnings.
Co-authored-by: Mattermod <mattermod@users.noreply.github.com >
2020-10-29 15:54:39 -07:00
Christopher Speller
31dac80e66
Revert "MM-29979: make websocket writes zero-alloc ( #16098 )" ( #16110 )
...
Automatic Merge
2020-10-28 16:24:01 -04:00
Agniva De Sarker
f964be699f
MM-29979: make websocket writes zero-alloc ( #16098 )
...
* MM-29979: make websocket writes zero-alloc
Instead of allocating a new slice every time we write a message,
we create a json encoder for a byte buffer and then reset the buffer
every time we write a new message.
This allocates a buffer of a constant size per-connection, but gets rid
of a new allocation for every single write, reducing pressure on GC.
After taking a distrbution of message sizes from a load test, it was seen that
2k is a good enough buffer size within which 98.5% of messages remain.
Taking a look at the alloc profiles for (*webconn).writepump:
- master branch: 8.01% of total allocations totalling 64GB
- with this PR: 4.92% and 10GB.
https://mattermost.atlassian.net/browse/MM-29979
* Skip writing in case of an encoding error
2020-10-28 21:42:13 +05:30
Agniva De Sarker
27dbe9e182
MM-28984: Add fallback text to push notification ( #16089 )
...
We read the fallback text from message attachments and append that as part
of a push notification.
https://mattermost.atlassian.net/browse/MM-28984
```release-note
NONE
```
2020-10-28 10:42:08 +05:30
Claudio Costa
165c4d2dd1
[MM-29295] Fix data race in app.CreatePost() ( #15880 )
...
* Fix data race
* Better naming
Co-authored-by: Mattermod <mattermod@users.noreply.github.com >
2020-10-27 20:11:38 +01:00
Ben Schumacher
76f1bfb941
[MM-29361] Send cloud flag with Marketplace requests ( #15913 )
2020-10-26 21:57:19 +01:00
Nick Misasi
3697f92045
[MM-28363] User Limit Overage Warning Emails ( #16053 )
...
* Adding files, commit of UI in good shape
* Translations added, working with activation and deactivation
* Add check for error
* Fix i18n?
* Push without subscription check so Steve and Matt can look at it
* Fix font-weight in chrome
* Fix font-weight on button
* UX fixes
* Fixes for PR
* Add back subscription stuff
* Fix tests
Co-authored-by: Mattermod <mattermod@users.noreply.github.com >
2020-10-26 13:24:26 -04:00
Agniva De Sarker
72432ab3ff
MM-27909: Add manage_shared_channels permission ( #15601 )
...
* MM-27909: Add manage_shared_channels permission
We add a new permission to manage shared channels.
It's a channel scoped permission and only the system admin
has that by default.
https://mattermost.atlassian.net/browse/MM-27909
* change to system scoped
* Trigger CI
* Trigger CI
Co-authored-by: Mattermod <mattermod@users.noreply.github.com >
2020-10-26 15:54:50 +05:30
Rodrigo Villablanca
96f1739f8f
UserStore migration ( #15563 )
...
* Migration completed
* Fix tests
* Fix tests
* Fix tests
* Suggestions
* Trigger CI
* Suggestions
* Merge with master
* Trigger CI
Co-authored-by: Mattermod <mattermod@users.noreply.github.com >
Co-authored-by: Agniva De Sarker <agnivade@yahoo.co.in >
2020-10-26 15:11:27 +05:30
Daniel Espino García
910de96a33
Thread autoresponse posts with the post they are autoresponding to ( #15625 )
...
* Thread autoresponse posts with the post they are autoresponding to
* Remove unneeded if
* Remove ParentID references
Co-authored-by: Mattermod <mattermod@users.noreply.github.com >
2020-10-23 16:21:21 +02:00
Scott Bishel
efc3304fe1
MM-29522:fix typo in constant name ( #15933 )
...
* fix type in constant name
* fix lint
Co-authored-by: Mattermod <mattermod@users.noreply.github.com >
2020-10-21 16:59:54 -06:00
George Goldberg
9b23ee659f
MM-29812: Fix a panic in auth code if GetChannel returns an error. ( #16010 )
...
* MM-29812: Don't panic if GetChannel returns an error in auth code.
* Fix gofmt
* Add further mocking.
* Another mock.
* More mocks.
2020-10-21 16:59:32 +01:00
Ed Trist
91bb7d3b11
[MM-24391] Render icon_emoji names surrounded by colons in incoming webhooks ( #15753 )
2020-10-21 14:13:10 +02:00
Ibrahim Serdar Acikgoz
c05ee81c9f
[MM-28125] einterface/oauthprovide: return parsing errors ( #15426 )
...
* einterface/oauthprovide: return parsing errors
* Update app/oauth.go
* reflect review comments
* fix var name error
Co-authored-by: Mattermod <mattermod@users.noreply.github.com >
2020-10-19 18:07:20 +03:00
Eli Yukelzon
8844141df3
MM-28249 Auto follow threads ( #15878 )
...
Co-authored-by: Mattermod <mattermod@users.noreply.github.com >
2020-10-15 18:01:16 +03:00
camgraff
07948ae7bc
[MM-29224] Fix bug where markdown image link doesn't show preview ( #15862 )
...
* Fix bug where markdown image has no preview
* go fmt
* Fix failing test
Co-authored-by: Mattermod <mattermod@users.noreply.github.com >
2020-10-14 20:36:46 +08:00
Eli Yukelzon
c9257b858e
MM-29560 Correct Cloud detection in InProduct Notices ( #15938 )
...
Co-authored-by: Mattermod <mattermod@users.noreply.github.com >
2020-10-13 16:42:21 +03:00
Claudio Costa
00ed2b138b
[MM-27277] Move away from storing uploaded files into memory ( #15616 )
...
* Move away from storing uploaded files into memory
* Improve function readability
* Fix translations
* Revert version bump
* Log error
* Fix possible race condition and goroutine leak
* Improve default case
2020-10-09 10:14:19 +02:00
Claudio Costa
73c41ef808
[MM-28638] Improve image thumbnail generation logic ( #15534 )
...
* Improve image thumbnail generation logic
* Improve naming
2020-10-09 08:47:20 +02:00
Michael Kochell
0af0a4eff4
Normalize plugin path when s3 prefix is present ( #15910 )
...
* Normalize plugin path when s3 prefix is present
* Ensure S3 is enabled and fix unit tests
Co-authored-by: Joram Wilander <jwawilander@gmail.com >
2020-10-08 22:13:27 -04:00
Claudio Costa
7f85991009
Fix possible inconsistencies ( #15770 )
2020-10-07 18:47:36 +02:00
Eli Yukelzon
f2e5e1562d
MM-29400 Mark all current notices as viewed for newly created users ( #15840 )
...
* Added clearing of notices for new users
* ci kick
2020-10-07 17:46:07 +03:00
Shobhit Gupta
0e140dad2f
Remove direct Store calls from the Api layer for the file api4/channe… ( #15754 )
...
Co-authored-by: Agniva De Sarker <agnivade@yahoo.co.in >
2020-10-07 11:59:34 +02:00
Ibrahim Serdar Acikgoz
26e3bc0a24
app/post_metadata: add a check to type casting ( #15821 )
2020-10-07 11:16:36 +03:00
Eli Yukelzon
6222e182ca
MM-29264 Fix invalid server version handling / date constraint in InProduct Notices ( #15756 )
2020-10-06 12:04:26 +03:00
Jorge Vallecillo
f3ce8716bb
Fix typos 4 files: consecutive occurrences of 'the' ( #15789 )
...
Automatic Merge
2020-10-05 14:57:28 -04:00
Michael Kochell
42f539fa57
[MM-27942] Request arch-specific plugin ( #15436 )
...
* request arch-specific plugin
* rename arch/architecture to platform
Co-authored-by: Mattermod <mattermod@users.noreply.github.com >
2020-10-05 13:01:33 -04:00
Rodrigo Villablanca
bb4df5a68e
ChannelStore migration Part 3 ( #15504 )
...
* Migration finished
* Change error var name
* Fix imports
* Fix tests
* Merge with master
* Doing some suggestions
* More suggestions
* Fix i18n
Co-authored-by: Mattermod <mattermod@users.noreply.github.com >
Co-authored-by: Agniva De Sarker <agnivade@yahoo.co.in >
2020-10-04 10:12:29 +05:30
ataboo
2551959504
GH-15742: added db health check method in app ( #15752 )
2020-10-03 11:38:35 +02:00
Florent Peterschmitt
047c76b55f
[MM-29174] fix: enable automatic emoji resize feature ( #15657 )
...
* fix: enable automatic emoji resize feature
* refactor writes by overriding existing buffer, write once, return once
* add testcases
* 🤔
* close file
* automatic formatting with goimports
* ensure image is resized keeping proportions
2020-10-02 19:16:11 +02:00
Eli Yukelzon
b8ceb610e6
MM-27353 Mini image previews ( #15376 )
2020-10-02 11:14:57 +03:00
Ashim Sedhain
2f47cf5994
[MM-24753] Improves error message when plugin crashes during slash command ( #15334 )
...
Co-authored-by: Ali Farooq <ali.farooq0@pm.me >
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com >
2020-10-02 10:02:58 +02:00
Claudio Costa
51d790300f
Fix possible panic during plugin installation ( #15689 )
2020-10-02 09:25:50 +02:00
Eli Yukelzon
2bf03a1982
added TestHasPermissionToCategory ( #15660 )
2020-10-01 11:13:37 -04:00
Eli Yukelzon
11d9958a99
MM-28189 - Sentry CI improvements ( #15547 )
2020-09-30 11:09:48 +03:00
George Goldberg
61f08d397c
MM-28419: Move SetLogger() to Server. ( #15551 )
...
Co-authored-by: Mattermod <mattermod@users.noreply.github.com >
2020-09-29 14:30:15 +01:00
Eli Yukelzon
c298678663
MM-28835 Configure/update notices setting for TeamAdmin ( #15632 )
2020-09-29 15:17:38 +03:00
catalintomai
1c0d590c81
Add AWS Metering service support ( #15290 )
2020-09-28 11:43:08 -07:00
Maria A Nunez
50e37068b5
MM-27147 - /cloud api endpoints ( #15626 )
2020-09-28 12:18:47 -04:00
Agniva De Sarker
85b434c50d
Revert "MM-27147 - /cloud api endpoints ( #15428 )" ( #15615 )
...
This reverts commit 88aed7ec9e .
2020-09-28 09:06:55 +02:00
Maria A Nunez
88aed7ec9e
MM-27147 - /cloud api endpoints ( #15428 )
2020-09-25 21:03:21 -04:00
catalintomai
f74b86ae95
MM-28733 : Admin Advisor v2 ( #15515 )
2020-09-25 14:59:41 -07:00
Agniva De Sarker
d8622d1b07
MM-28370: Fix send on closed channel ( #15508 )
...
Automatic Merge
2020-09-24 23:53:43 -04:00
Daniel Espino García
9449d0e302
[MM-28447] Avoid "ghost mentions" when "First Name" is not set, but "First Name trigger mention" setting is set ( #15577 )
...
* Do not add any keyword regarding first name if the first name is not set
* Add test
Co-authored-by: Mattermod <mattermod@users.noreply.github.com >
2020-09-24 19:01:14 +02:00
Hossein Ahmadian-Yazdi
a1e17fe78a
MM-28530 - Changes are not automatically propagated to system console when a permission is added/removed from a role ( #15562 )
...
* send event for when role updates!!!
* address PR comments
2020-09-24 11:49:57 -04:00
Rodrigo Villablanca
8118cac350
Poststore migration part3 ( #15505 )
...
* Migration completed
* Order in translations file
* Fix: lints
* Trigger CI
* Fix message key
* Change mlog.Error for mlog.Warn
* Fix imports
* Adding translations needed for EE
* Trigger CI
* Fix merge with master
Co-authored-by: Agniva De Sarker <agnivade@yahoo.co.in >
Co-authored-by: Mattermod <mattermod@users.noreply.github.com >
2020-09-24 10:46:36 +05:30
Claudio Costa
1e34bdac1f
Fix possible nil dereference ( #15435 )
...
Co-authored-by: Mattermod <mattermod@users.noreply.github.com >
2020-09-23 08:51:12 +02:00