darkLord19
f6505e1ee6
MM-31339: Send only one direct message reply within one calendar day. ( #17181 )
...
* don't send auto response if already responded today
* update query to get posts from channel for given user and Updatetime requires value in milli seconds
* regenerate mocks and layers
* update function to return true/false on existence of auto responded post in channel and add tests
* add store tests
* bubble up error and propagate upstream
* fix error handling logic
* use require instead of assert
Co-authored-by: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com >
* rename variable for better redability and logging fixes
* update comment explaining function
* use new function to generate test ids
* add comments to clarify NewTestId copies
* add translations for error id
* fix translation
Co-authored-by: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com >
Co-authored-by: Mattermod <mattermod@users.noreply.github.com >
Co-authored-by: Saturnino Abril <saturnino.abril@gmail.com >
2021-04-22 12:33:45 +08:00
Ben Schumacher
730dc6b985
[MM-34919] Use Mattermost-Plugin-ID header to pass ID in inter-plugin requests ( #17418 )
2021-04-19 14:02:00 +02:00
Jesse Hallam
2de65cfb11
MM-33180: Extend Group APIs for plugins. ( #17232 )
...
Add `GetGroupMemberUsers` (mapping to `GetGroupMemberUsersPage`) and `GetGroupsBySource`.
Fixes: https://mattermost.atlassian.net/browse/MM-33180
Co-authored-by: Mattermod <mattermod@users.noreply.github.com >
2021-04-12 14:01:28 -03:00
Jesús Espino
35d00b4644
Enable the errorAssertions govet check for mattermost-server code ( #17346 )
...
* Enable the errorAssertions govet check for mattermost-server code
* Removing unnecesary change
* Fixing some tests
* Fixing tests
* Fixing more after merge
* Fixing new offending entries
* Fixing small vet checks
* Fixing new cases detected by govet
* Fixing remote_cluster_test errors
* Fixing assertion
Co-authored-by: Mattermod <mattermod@users.noreply.github.com >
2021-04-12 12:51:31 +02:00
catalintomai
e37e902ddf
MM-29584: Make apps plugin hook invocation/registration conditional ( #16769 )
2021-04-11 19:54:46 -07:00
Haardik Dharma
343c51830f
Fix initialism errors (PR-2) ( #17032 )
...
* Fix initialism errors
* Fix check-mocks test
* Revert mlog and filestore packages
* Update plugin_hooks_test.go
* Update opentracinglayer.go
* Regenerate mocks and check store layers
* Revert plugin's context changes
* Update context.go
* Update plugin_requests.go
* Update plugin_hooks_test.go
* Regenerate mocks
* Regenerate mocks and store layers
Co-authored-by: Mattermod <mattermod@users.noreply.github.com >
2021-04-03 12:43:22 +05:30
Mario de Frutos Dieguez
c0971970e9
Revert "Fix initialism errors (PR-3) ( #17062 )" ( #17202 )
...
This reverts commit ea61458f16
2021-03-23 10:32:54 +01:00
Haardik Dharma
ea61458f16
Fix initialism errors (PR-3) ( #17062 )
...
* Fix initialism errors
* Revert some changes and regenerate file
* Update client4.go
* Update group_test.go
Co-authored-by: Mattermod <mattermod@users.noreply.github.com >
2021-03-22 22:38:19 +03:00
Jesús Espino
857e18f3ab
Replacing require.nil in plugin package ( #16961 )
...
Co-authored-by: Mattermod <mattermod@users.noreply.github.com >
2021-03-09 09:45:00 +01:00
Jesús Espino
9cc5089af8
Moving mlog to corelibs ( #16915 )
...
* Moving mlog to corelibs
* Regenerating app layers
* Fix golangci-lint problem
* Fixing golangci-lint errors
* Renaming from corelibs to shared
* Renaming from corelibs to shared
* Fixing import
* Fixing merge problems
* Fixing build
2021-03-05 09:18:37 +01:00
Atanas Alexandrov
e44190f4cc
NO-TCIKET fix bad smells - error strings should not be capitalized ( #16930 )
...
Automatic Merge
2021-02-23 06:22:27 +01:00
Haardik Dharma
6356e906e0
[Partial Fix - #16623 ]: Fix initialism errors in codebase. ( #16877 )
...
* Update files in /app
* Update files in /plugin
* Update files in /store
* Update files in /utils
* Update files in /web
* Update store.go
* Update command_response.go
* check-mocks and check-store-layer checks
* Fix build errors
* Revert "Fix build errors"
This reverts commit 4ee38c3d0bf7bd7d8386f46f0985a0d03245a1d4.
* Update .golangci.yml
* make i18n-extract and make i18n-check
* Commit suggestions
* check-mocks and check-store-layers
* Update en.json
* Update product_notices.go
* Update main.go
* Fix translations
* Regenerate mocks
Co-authored-by: Mattermod <mattermod@users.noreply.github.com >
Co-authored-by: Claudio Costa <cstcld91@gmail.com >
2021-02-18 15:36:56 +01:00
Mahmudul Haque
7dd4d4859b
unparam lint ( #16865 )
...
Automatic Merge
2021-02-09 18:52:27 +01:00
Mahmudul Haque
a63dea6c55
unparam lint ( #16771 )
...
* fixed: `identifier` is unused lint error
* make saveMultipleMembersT method saveMultipleMembers
Co-authored-by: Mattermod <mattermod@users.noreply.github.com >
2021-02-04 11:08:05 +05:30
Madhav Hugar
94c24eea20
Fix empty string comparison issues in the codebase ( #16686 )
...
Automatic Merge
2021-01-25 11:15:17 +01:00
Agniva De Sarker
e89b26e8f3
goimports ( #16640 )
...
* format using `goimports -local github.com/mattermost/mattermost-server/v5 -w`
* added goimports lint check to .golangci.yml
* format using `goimports -local github.com/mattermost/mattermost-server/v5 -w` for a corner case
* make app-layers, *-mocks and store-layers for ci check
Co-authored-by: Mahmudul Haque <mahmudulhaque@protonmail.com >
Co-authored-by: Mattermod <mattermod@users.noreply.github.com >
2021-01-07 22:42:43 +05:30
Ibrahim Serdar Acikgoz
f9c0c1072f
[MM-31360] downgrade error logs which doesn't break the flow ( #16612 )
...
* downgrade error logs which doesn't break the flow
* reflect revivew comments
2021-01-04 17:02:34 +03:00
Agniva De Sarker
c1dd23a3c8
MM-31063: Change constants to use CamelCase ( #16608 )
...
* MM-31063: Change constants to use CamelCase
* store package
* change allcaps to camel case (#16615 )
* New tools.mod
Co-authored-by: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com >
2021-01-04 11:32:29 +05:30
Jared Shields
3515b4d6c9
GH-15624: Added plugin hooks for ReationHasBeenAdded and ReactionHasBeenRemoved ( #15765 )
2020-10-31 07:06:43 +01:00
Ibrahim Serdar Acikgoz
1bf4373f3f
[MM-28885] app/plugin: check if plugin manifest has errors ( #15630 )
...
* app/plugin: dont sync plugins with errors
* reflect review comments
* update test
* Update plugin/environment_test.go
Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com >
* reflect review comments
* reflect review comments
Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com >
2020-10-07 10:23:59 +03:00
Jorge Vallecillo
f3ce8716bb
Fix typos 4 files: consecutive occurrences of 'the' ( #15789 )
...
Automatic Merge
2020-10-05 14:57:28 -04:00
Ashim Sedhain
2f47cf5994
[MM-24753] Improves error message when plugin crashes during slash command ( #15334 )
...
Co-authored-by: Ali Farooq <ali.farooq0@pm.me >
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com >
2020-10-02 10:02:58 +02:00
Jesús Espino
44079785eb
Moving diagnostics into a service ( #14832 )
...
* Moving diagnostics into a service
* Fixing golint checks
* Fixing tests
* Renaming from diagnostics to telemetry
* Adding missing files
* Initializing telemetry earlier in the server startup
* Fixing tests
* Adding a log for the telemetryID initialization error
* Addressing PR review comments
* Fixing merge problem
* Removing some extra Diagnostics mentions
* Making tests pass
2020-09-08 20:30:54 +02:00
Christopher Poile
c5c6a5ce53
MM-26057 - Add CreateCommand plugin API ( #14916 )
...
Automatic Merge
2020-07-31 17:40:15 +02:00
Christopher Speller
bebff8156b
MM-26056 Add plugin ability to execute slash command. ( #14898 )
...
* Add plugin ability to execute slash command.
* A test
* Add site url to command args for plugin API
* Remove unessiary complexity.
2020-07-07 09:31:03 -07:00
Claudio Costa
d0e035467c
[MM-16473] Make plugins' ServerHTTP http.ResponseWriter hijackable ( #14822 )
...
* Make plugins' ServerHTTP http.ResponseWriter hijackable
* Rename brw to align with docs
* Fix error handling
2020-06-26 10:51:23 +02:00
Maria A Nunez
668a2aa856
Added SearchPostsInTeamForUser for plugin API ( #14807 )
...
Co-authored-by: Mattermod <mattermod@users.noreply.github.com >
2020-06-23 21:58:44 -04:00
Martin Kraft
88a6cf0bf1
MM-26231: Reverts plugin API breaking change. ( #14852 )
2020-06-18 14:17:36 -04:00
Attila Molnar
66597d0fcb
Expand Plugin and REST APIs to trigger user typing event ( #14331 )
2020-06-16 11:41:05 +02:00
Nisheet Sinvhal
f1c52387ae
MM-25779 - Update apiTimerLayerTemplate and hooksTimerLayerTemplate to record error values ( #14764 )
...
Co-authored-by: Mattermod <mattermod@users.noreply.github.com >
2020-06-12 12:12:37 -04:00
Shota Gvinepadze
77b468e456
[MM-25606] Make plugin API errors encodable ( #14692 )
...
* Make plugin API errors encodable
* Remove newlines
Co-authored-by: Mattermod <mattermod@users.noreply.github.com >
2020-06-11 16:44:50 +04:00
Nassim Bounouas
41ddbeb642
MM-21307 Get/Update/Delete user preferences Plugin API ( #13962 )
...
* MM-21307 Get/Update/Delete user preferences Plugin API
* MM-21307 additional test case on TestPluginAPIDeleteUserPreferences
* MM-21307 remove useless loop
* Update plugin/api.go
* Update plugin/api.go
* Update plugin/api.go
* Update plugin/api.go
* Update plugin/api.go
* Update plugin/api.go
* gofmt -s
Co-authored-by: mattermod <mattermod@users.noreply.github.com >
Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com >
2020-05-28 14:15:47 -03:00
Harshil Sharma
dea705969c
MM-13934 - Plugin helper function EnsureBot doesn't compare bot details ( #14103 )
2020-05-27 14:48:43 +02:00
Shota Gvinepadze
43e606173b
[MM-20684] Slash Command Autocomplete ( #14557 )
...
* [MM-20684] Initial implementation of the Command Autocomplete (#13602 )
* Implement Autocomplete Data
* Change CommandName to Trigger
* Fix Autocomplete test
* Make stylistic changes
* Rename a bunch of fields and methods
* Fix variable names, safer type assertions
* [MM-20684] plugin autocomplete implementation (#14259 )
* Add an endpoint for command autocomplete suggestions
* Add full Suggestion to the AutocompleteSugestion struct
* Add Dynamic Argument support
* Tidy up things
* Fix missed test case
* Add support of the named arguments
* Update autocomplete API
Fix review issues
Implement dynamic args as a local request
* Fix ineffassign
* Add support of the uppercase letters in arguments
* Add support of the optional arguments
* Remove ineffectual assignment
* Add support for icons (#14489 )
* Address couple of nits
* Add comment to IconData
* Add types to all consts
Co-authored-by: mattermod <mattermod@users.noreply.github.com >
2020-05-21 12:24:56 +04:00
catalintomai
41e58d9769
MM-23816: Group Mentions: Add ability to rename group names ( #14338 )
...
* MM-23816: Group Mentions: Add ability to rename group names
2020-05-12 08:35:03 -07:00
Ian Whitlock
8084620911
MM-23824 Clean up orphaned plugin process at test completion ( #14235 )
...
* Clean up orphaned plugin process at test completion
* Add supervisor shutdown to second test for consistency
2020-04-08 09:35:42 -03:00
Michael Kochell
005cc00ccc
[MM-23281] Persist registeredPlugin in plugin.Environment when plugin is deactivated ( #14110 )
...
* store failed timestamps on health check job instead of on registeredPlugin
Update test
* change EnsurePlugin calls
* Make env.SetPluginState private
* Write test for plugin deactivate and PluginStateFailedToStayRunning
* Add license comment
* adjust comments, use time.Since
* Additional PR feedback:
time.Since cleanup
test cleanup
remove duplicate .Store() call
* PR Feedback
- Add test case for reactivating the failed plugin
- Change `crashed` to `healthy` and `hasPluginCrashed` to `isPluginHealthy`
- remove stale timestamps from health check job
* Keep registeredPlugins in env when plugin is deactivated, so the crashed state of a plugin can be persisted.
* PR feedback
* PR feedback from Jesse
Co-authored-by: mattermod <mattermod@users.noreply.github.com >
2020-03-31 21:20:22 -03:00
Federico Martín Alconada Verzini
bf1d9b0ae9
[GH-14136] Document minimum server version required for plugin hooks ( #14153 )
...
* Document minimum server version required for plugin hooks
* change mins < v5.2 for v5.2
Co-authored-by: Federico Martín Alconada Verzini <fedealconada@gmail.com >
2020-03-30 11:22:09 -07:00
Jesse Hallam
f149ada16a
MM-23261 plugin stderr debug logs ( #14166 )
...
* explicitly assert panic as error log
* Revert "[MM-18150] plugin panic trace should not be lost (#13559 )"
This reverts commit 5d928b4f94
2020-03-30 15:00:45 -03:00
Elisabeth Kulzer
0340eb466f
IS-364: Bump golang build image. ( #14134 )
...
* IS-364: Bump Golang CI.
* Fix test failure
* Fix readme
* Update build/README.md
Co-authored-by: Agniva De Sarker <agnivade@yahoo.co.in >
2020-03-25 12:36:06 +01:00
Elisabeth Kulzer
6c6a64c103
Revert "IS-364: Bump Golang CI. ( #14123 )" ( #14133 )
...
This reverts commit 81d6ae2207
2020-03-24 14:01:49 +01:00
Elisabeth Kulzer
81d6ae2207
IS-364: Bump Golang CI. ( #14123 )
...
IS-364: Bump Golang CI.
2020-03-24 08:45:26 +01:00
Claudio Costa
1e53fe85ad
[MM-21378] Add mutex to model.Post to guard against race conditions on Post.Props ( #13884 )
...
* Add mutex to model.Post to guard against race conditions on Post.Props
* Rename mutex
* Add GetProp() method to Post
* Fix more tests
* Fix flaky test
Benchmarks:
BenchmarkPostPropsGet_indirect
BenchmarkPostPropsGet_indirect-2 85026746 13.0 ns/op 0 B/op 0 allocs/op
BenchmarkPostPropsGet_indirect-4 90273747 13.0 ns/op 0 B/op 0 allocs/op
BenchmarkPostPropsGet_indirect-8 88324293 13.0 ns/op 0 B/op 0 allocs/op
BenchmarkPostPropsGet_indirect-16 91427720 13.1 ns/op 0 B/op 0 allocs/op
BenchmarkPostPropsGet_direct
BenchmarkPostPropsGet_direct-2 1000000000 0.242 ns/op 0 B/op 0 allocs/op
BenchmarkPostPropsGet_direct-4 1000000000 0.241 ns/op 0 B/op 0 allocs/op
BenchmarkPostPropsGet_direct-8 1000000000 0.240 ns/op 0 B/op 0 allocs/op
BenchmarkPostPropsGet_direct-16 1000000000 0.241 ns/op 0 B/op 0 allocs/op
BenchmarkPostPropsAdd_indirect
BenchmarkPostPropsAdd_indirect-2 5602224 203 ns/op 336 B/op 2 allocs/op
BenchmarkPostPropsAdd_indirect-4 5959496 206 ns/op 336 B/op 2 allocs/op
BenchmarkPostPropsAdd_indirect-8 5833999 205 ns/op 336 B/op 2 allocs/op
BenchmarkPostPropsAdd_indirect-16 5802493 225 ns/op 336 B/op 2 allocs/op
BenchmarkPostPropsAdd_direct
BenchmarkPostPropsAdd_direct-2 100000000 11.3 ns/op 0 B/op 0 allocs/op
BenchmarkPostPropsAdd_direct-4 100000000 11.3 ns/op 0 B/op 0 allocs/op
BenchmarkPostPropsAdd_direct-8 100000000 11.6 ns/op 0 B/op 0 allocs/op
BenchmarkPostPropsAdd_direct-16 99840794 11.4 ns/op 0 B/op 0 allocs/op
BenchmarkPostPropsDel_indirect
BenchmarkPostPropsDel_indirect-2 18824002 61.9 ns/op 48 B/op 1 allocs/op
BenchmarkPostPropsDel_indirect-4 19470736 63.8 ns/op 48 B/op 1 allocs/op
BenchmarkPostPropsDel_indirect-8 17640460 65.3 ns/op 48 B/op 1 allocs/op
BenchmarkPostPropsDel_indirect-16 18692962 65.4 ns/op 48 B/op 1 allocs/op
BenchmarkPostPropsDel_direct
BenchmarkPostPropsDel_direct-2 516257440 2.34 ns/op 0 B/op 0 allocs/op
BenchmarkPostPropsDel_direct-4 514865216 2.43 ns/op 0 B/op 0 allocs/op
BenchmarkPostPropsDel_direct-8 511330477 2.37 ns/op 0 B/op 0 allocs/op
BenchmarkPostPropsDel_direct-16 499504010 2.38 ns/op 0 B/op 0 allocs/op
2020-03-13 21:12:20 +01:00
Jesús Espino
7c3e651a7b
Not skiping tests on commands, and removing unnecesary main_test.go files ( #14032 )
2020-03-11 16:25:45 +01:00
Shota Gvinepadze
5d928b4f94
[MM-18150] plugin panic trace should not be lost ( #13559 )
...
* Transit panic from debug to error
* Parse plugin's StdErr and output panic to the mlog.Error
* Add unit tests
* Change log test
* Remove buffer from logger
* Remove 'panic' string filter
* Change *Buffer to io.Writer
Co-authored-by: mattermod <mattermod@users.noreply.github.com >
2020-03-11 11:41:11 +04:00
Ogundele Olumide
8327e9b0ba
MM-16819 Helper function to build path to plugin asset ( #13626 )
...
Implement helper method to create a URL to the resource from a directory
2020-03-10 12:41:29 +01:00
ABDUL SATTAR MAPARA
e6d216090b
MM-22679 - Update example plugin documentation ( #13944 )
...
Automatic Merge
2020-03-02 14:22:48 -05:00
Doug Clark
6377bfef35
GH-12936 Add KVListWithOptions function to plugin.Helpers ( #13576 )
...
Automatic Merge
2020-02-17 15:44:34 -05:00
Ali Farooq
bd9d674006
Fixing master ( #13900 )
...
* updating api_timer_layer_generated.go
* Fixing GetFileInfos
* Fixing TestPluginAPIGetFileInfos
* Remove file.go.orig
2020-02-14 18:08:00 -05:00
Ali Farooq
e4fb5791b0
MM-21626, MM-21627 - Plugin API/Hooks Prometheus instrumentati… ( #13825 )
...
* MM-21626,MM-21627 - Plugin API/Hooks Prometheus instrumentation
* Updated einterface mocks
* Fixed supervisor tests
* ignoring golint errors for plugin metrics wrappers
* Making golangci happy
* Using variadic form when generating wrapper code
* Removed artificial delay
* Removed comments from tests
* Renaming plugin wrappers to api/hooks_timer_layer
* updating vendor dir and mod files
* Recording plugin api/hook responses in prometheus
* Updated einterfaces-mocks
* Updating go sum
* Updating go sum
* Fixing conflicts
* More conflicts fixing
Co-authored-by: mattermod <mattermod@users.noreply.github.com >
2020-02-14 15:47:43 -05:00
