mirrors/mostlymatter
1
0
Форкнуть 0
Код Задачи Запросы на слияние Действия Пакеты Проекты Релизы Вики Активность
19 780 коммитов 3 Ветки 0 Теги
3a13dc2d5dd335b05a60d2ff9b032b7ae686bb68
Граф коммитов

1732 Коммитов

Автор SHA1 Сообщение Дата
Agniva De Sarker
4265df8a07 MM-62079: Fix permissions being reset properly (#29574) 
The default role permissions weren't being saved
to a separate variable which would have not restored
them properly. This was a problem in various other
tests, potentially causing side-effects in other
flaky tests as well.

We fix that, as well as clean up the for loop
a bit and mention how many messages were recieved
in the failure message so that it becomes clear
whether no messages were recieved, or atleast some
were received.

https://mattermost.atlassian.net/browse/MM-62079
```release-note
NONE
```
 2025-01-08 20:03:59 +05:30
Nadav Tasher
baf9bf82c9 Bugfix - Enforce URL length check in LinkMetadata before attempting to insert to database (#29589) 
* Add missing URL length validation in LinkMetadata

* Added MaxURLLength constant

* Add test to validate new URL length limit

* Add comment about table constraint

* Use a seperate error string for URL length errors

* Added error string fpr URL length

* Updated error message

* Update en.json

* Fixed gofmt error in link_metadata.go

* use right txn id

```release-note
NONE
```

---------

Co-authored-by: Agniva De Sarker <agnivade@yahoo.co.in>
Co-authored-by: Mattermost Build <build@mattermost.com>
 2025-01-08 20:02:39 +05:30
unified-ci-app[bot]
22856b4d64 Update latest minor version to 10.5.0 (#29779) 
Automatic Merge
 2025-01-08 10:48:31 +02:00
Agniva De Sarker
647c9b6808 [MM-62293]: Remove Elasticsearch from translation strings (#29728) 
We cannot simply use Elasticsearch any more because
we support Opensearch as well.

Therefore changing Elasticsearch to just say Search.

Note: There are still some cases where Elasticsearch
is used. That is intentional and necessary.

```release-note
NONE
```
 2025-01-08 11:11:59 +05:30
Weblate (bot)
06ce7b4a5a Translations update from Mattermost Weblate (#29715) 
* Translated using Weblate (Italian)

Currently translated at 82.4% (2148 of 2605 strings)

Translation: Mattermost/server
Translate-URL: https://translate.mattermost.com/projects/mattermost/server/it/

* Translated using Weblate (Italian)

Currently translated at 56.2% (3385 of 6022 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/it/

* Translated using Weblate (Portuguese (Brazil))

Currently translated at 93.9% (2448 of 2605 strings)

Translation: Mattermost/server
Translate-URL: https://translate.mattermost.com/projects/mattermost/server/pt_BR/

* Translated using Weblate (Kazakh)

Currently translated at 16.1% (973 of 6022 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/kk/

* Translated using Weblate (Norwegian Bokmål)

Currently translated at 60.3% (3635 of 6022 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/nb_NO/

* Translated using Weblate (Kazakh)

Currently translated at 16.2% (978 of 6022 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/kk/

* Translated using Weblate (Norwegian Bokmål)

Currently translated at 60.4% (3639 of 6022 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/nb_NO/

* Translated using Weblate (Russian)

Currently translated at 97.4% (2538 of 2605 strings)

Translation: Mattermost/server
Translate-URL: https://translate.mattermost.com/projects/mattermost/server/ru/

* Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 100.0% (2605 of 2605 strings)

Translation: Mattermost/server
Translate-URL: https://translate.mattermost.com/projects/mattermost/server/zh_Hans/

* Translated using Weblate (Russian)

Currently translated at 94.9% (5720 of 6022 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/ru/

* Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 100.0% (6022 of 6022 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/zh_Hans/

* Translated using Weblate (Portuguese (Brazil))

Currently translated at 95.8% (2497 of 2605 strings)

Translation: Mattermost/server
Translate-URL: https://translate.mattermost.com/projects/mattermost/server/pt_BR/

* Translated using Weblate (German)

Currently translated at 100.0% (2605 of 2605 strings)

Translation: Mattermost/server
Translate-URL: https://translate.mattermost.com/projects/mattermost/server/de/

* Translated using Weblate (German)

Currently translated at 100.0% (6022 of 6022 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/de/

* Translated using Weblate (Czech)

Currently translated at 100.0% (2605 of 2605 strings)

Translation: Mattermost/server
Translate-URL: https://translate.mattermost.com/projects/mattermost/server/cs/

* Translated using Weblate (Czech)

Currently translated at 100.0% (6022 of 6022 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/cs/

* Translated using Weblate (Portuguese (Brazil))

Currently translated at 97.1% (2530 of 2605 strings)

Translation: Mattermost/server
Translate-URL: https://translate.mattermost.com/projects/mattermost/server/pt_BR/

* Translated using Weblate (Ukrainian)

Currently translated at 99.9% (2603 of 2605 strings)

Translation: Mattermost/server
Translate-URL: https://translate.mattermost.com/projects/mattermost/server/uk/

* Translated using Weblate (Kazakh)

Currently translated at 16.5% (999 of 6022 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/kk/

* Translated using Weblate (Kazakh)

Currently translated at 17.1% (1032 of 6022 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/kk/

* Translated using Weblate (Kazakh)

Currently translated at 17.2% (1038 of 6022 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/kk/

* Translated using Weblate (Dutch)

Currently translated at 99.8% (2600 of 2605 strings)

Translation: Mattermost/server
Translate-URL: https://translate.mattermost.com/projects/mattermost/server/nl/

* Translated using Weblate (Dutch)

Currently translated at 99.9% (6021 of 6022 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/nl/

* Translated using Weblate (Dutch)

Currently translated at 99.8% (2602 of 2605 strings)

Translation: Mattermost/server
Translate-URL: https://translate.mattermost.com/projects/mattermost/server/nl/

* Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 100.0% (6022 of 6022 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/zh_Hans/

* Translated using Weblate (Polish)

Currently translated at 100.0% (2605 of 2605 strings)

Translation: Mattermost/server
Translate-URL: https://translate.mattermost.com/projects/mattermost/server/pl/

* Translated using Weblate (Polish)

Currently translated at 100.0% (6022 of 6022 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/pl/

* Translated using Weblate (Czech)

Currently translated at 100.0% (2605 of 2605 strings)

Translation: Mattermost/server
Translate-URL: https://translate.mattermost.com/projects/mattermost/server/cs/

* Translated using Weblate (Czech)

Currently translated at 100.0% (2605 of 2605 strings)

Translation: Mattermost/server
Translate-URL: https://translate.mattermost.com/projects/mattermost/server/cs/

---------

Co-authored-by: Andrea <andrea.biasi@gmail.com>
Co-authored-by: Henrique Latorre <hpflatorre@gmail.com>
Co-authored-by: Akbar Abdrakhmanov <kz.akbar@gmail.com>
Co-authored-by: Frank Paul Silye <frankps@gmail.com>
Co-authored-by: Konstantin <eleferen@gmail.com>
Co-authored-by: ThrRip <coding@thrrip.space>
Co-authored-by: jprusch <rs@schaeferbarthold.de>
Co-authored-by: Martin Mičuda <micuda@rematiptop.cz>
Co-authored-by: Serhii Khomiuk <sergiy.khomiuk@gmail.com>
Co-authored-by: Tom De Moor <tom@controlaltdieliet.be>
Co-authored-by: master7 <marcin.karkosz@rajska.info>
Co-authored-by: Massimo Marassi <backoffice@rematiptop.cz>
Co-authored-by: Mattermost Build <build@mattermost.com>
 2025-01-07 18:57:40 +08:00
Agniva De Sarker
148dff2c24 MM-62378: Initialize status and session cache before loading license (#29686) 
* MM-62378: Initialize status and session cache before loading license

ps.LoadLicense could end up calling InvalidateAllCaches. Therefore,
we need to intialize those caches before calling LoadLicense
to prevent a panic from happening.

While here, we also remove some unused code.

https://mattermost.atlassian.net/browse/MM-62378
```release-note
NONE
```

* fix lint errors

```release-note
NONE
```

* fix test

```release-note
NONE
```
 2025-01-03 10:25:35 +05:30
Thomas Decaux
b61580f87f fix(pluginapi/store): init master db if no replica (#29674) 
* fix(pluginapi/store): init master db if no replica

GetReplicaDB return nil because masterDB is not initialized.

* chore: add test
 2025-01-02 13:51:22 +05:30
Maria A Nunez
64c566a828 Update boards prepackaged to v9.0.2 (#29671) 
Automatic Merge
 2025-01-02 10:18:31 +02:00
Weblate (bot)
f95809ef5d Translations update from Mattermost Weblate (#29677) 2024-12-23 19:09:07 +00:00
Jesse Hallam
06a8c728c4 Fix cases where args... was not spread (#29668) 2024-12-23 11:22:02 -04:00
Yahya Haq
0482b57bf8 [MM-29441] Fix errcheck issues in web_hub.go (#29614) 
* fix errcheck for web_hub.go

* log user id
 2024-12-23 15:09:50 +05:30
Doug Lauder
3b125a4564 Fix bug in SqlPostStore.PermanentDeletebyUser where no error was returned when 10K posts was exceeded. Remaining posts were silently orphaned. (#29642) 
Co-authored-by: Mattermost Build <build@mattermost.com>
 2024-12-20 16:32:16 -05:00
Ibrahim Serdar Acikgoz
5e7e441623 model/config: filtering should work with structs too (#29663) 2024-12-20 19:29:02 +01:00
Jesse Hallam
9e01424b15 Improve system admin permissions to dms and gms (#29656) 
* revert the api4 portion of 57372bd06b

* test: Add system admin channel access tests

* skip a.HasPermissionToTeam for channels without a team

* fix TestPostGetInfo
 2024-12-20 12:49:58 -04:00
TheInvincible
812034f5eb Update export.go (fix errcheck issue) (#28971) 2024-12-20 17:45:13 +01:00
Ibrahim Serdar Acikgoz
902888efd9 server/channels/app/export_test: fix a lint error due to err check (#29650) 2024-12-19 19:34:46 +01:00
Claudio Costa
8c41ec75db httpservice: improve validation of proxied URLs (#29600) 2024-12-19 17:55:42 +00:00
Ibrahim Serdar Acikgoz
e76786278b [MM-60083] export: do not export DMs/GMs if users are deleted (#28854) 2024-12-19 16:47:52 +01:00
Seiya Homma
cf392f7cca [MM-62143] Avoid SELECT * in role_store.go 2024-12-19 13:57:10 +01:00
Ibrahim Serdar Acikgoz
bf4d41954a [MM-53245] export/import: add Props to the replies (#29531) 2024-12-18 17:36:17 +01:00
Harshil Sharma
041c874961 Reduced unnecessary debug logs from scheduled post job (#29560) 
* Reduced unnecessery debug logs from scheduled post job

* Improved log
 2024-12-18 12:58:32 +05:30
Ivy Gesare
0e4e7ca0b9 [MM-61514] Fix errcheck issues in server/channels/app/web_broadcast_hooks_test.go (#29213) 
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
Co-authored-by: Caleb Roseland <caleb@calebroseland.com>
 2024-12-17 15:09:24 -06:00
Ibrahim Serdar Acikgoz
bdbce2f8be server/channels/app/import_functions_test: fix build errors (#29630) 2024-12-17 10:36:58 -05:00
Arya Khochare
cf93d2a14e Fixed errcheck issues in server/channels/app/export_test.go (#29004) 
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
 2024-12-17 16:15:38 +01:00
Scott Bishel
faa7e4f2ea MM-62188 - Revoke user sessions when converted to bot (#29573) 
* revoke user sessions when converted to bot

* lint fixes
 2024-12-17 07:55:10 -07:00
Ibrahim Serdar Acikgoz
de59770797 [MM-51468] import: allow usernames to be uppercase (#29530) 2024-12-17 13:27:53 +00:00
Ibrahim Serdar Acikgoz
74afa1fa78 [MM-60684] GetMaxPostSize: update threshold to V2, it was way overdue (#28662) 2024-12-17 13:26:48 +00:00
Arya Khochare
1f7f0d20cd Fixed errcheck issues in server/channels/app/migrations.go (#29067) 2024-12-17 14:16:37 +01:00
Arya Khochare
cdfadcf47d Fixed errcheck issues in server/channels/app/security_update_check.go (#29200) 2024-12-17 12:52:43 +01:00
Ibrahim Serdar Acikgoz
b59819da68 [MM-56986] imports/import_validators: add valid guest role check (#28658) 2024-12-17 11:49:55 +00:00
Ibrahim Serdar Acikgoz
424ce2b8db [MM-59503] export: enable exporting configuration with mmctl (#28412) 2024-12-17 10:23:52 +01:00
fume4mattermost
4a5994906c [MM-56031] Add DeleteSidebarCategory method and channel category API tests (#29161) 
* Add DeleteSidebarCategory method and channel category API tests

* Add test to verify channels move to default categories when custom category is deleted

* rename channel category tests and remove duplicate context

* TestNotifications fix

---------

Co-authored-by: Fume <contact@fumedev.com>
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
Co-authored-by: Mattermost Build <build@mattermost.com>
 2024-12-16 16:29:43 -05:00
Weblate (bot)
93ed5c445a Translations update from Mattermost Weblate (#29619) 
* Translated using Weblate (Ukrainian)

Currently translated at 100.0% (2602 of 2602 strings)

Translation: Mattermost/server
Translate-URL: https://translate.mattermost.com/projects/mattermost/server/uk/

* Translated using Weblate (Polish)

Currently translated at 100.0% (6021 of 6021 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/pl/

* Translated using Weblate (Ukrainian)

Currently translated at 87.5% (5274 of 6021 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/uk/

* Translated using Weblate (Czech)

Currently translated at 97.7% (5887 of 6021 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/cs/

* Translated using Weblate (Kazakh)

Currently translated at 13.1% (794 of 6021 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/kk/

* Translated using Weblate (German)

Currently translated at 100.0% (2602 of 2602 strings)

Translation: Mattermost/server
Translate-URL: https://translate.mattermost.com/projects/mattermost/server/de/

* Translated using Weblate (German)

Currently translated at 100.0% (6021 of 6021 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/de/

* Translated using Weblate (Ukrainian)

Currently translated at 90.4% (5446 of 6021 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/uk/

* Translated using Weblate (Czech)

Currently translated at 99.5% (5994 of 6021 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/cs/

* Translated using Weblate (Dutch)

Currently translated at 99.9% (6020 of 6021 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/nl/

* Translated using Weblate (Polish)

Currently translated at 100.0% (6021 of 6021 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/pl/

* Translated using Weblate (Ukrainian)

Currently translated at 90.4% (5446 of 6021 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/uk/

* Translated using Weblate (Czech)

Currently translated at 100.0% (6021 of 6021 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/cs/

* Translated using Weblate (Czech)

Currently translated at 78.0% (2032 of 2602 strings)

Translation: Mattermost/server
Translate-URL: https://translate.mattermost.com/projects/mattermost/server/cs/

* Translated using Weblate (Czech)

Currently translated at 100.0% (6021 of 6021 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/cs/

* Translated using Weblate (Kazakh)

Currently translated at 13.5% (817 of 6021 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/kk/

* Translated using Weblate (Ukrainian)

Currently translated at 92.0% (5542 of 6021 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/uk/

* Translated using Weblate (Czech)

Currently translated at 80.1% (2086 of 2602 strings)

Translation: Mattermost/server
Translate-URL: https://translate.mattermost.com/projects/mattermost/server/cs/

* Translated using Weblate (Czech)

Currently translated at 80.2% (2087 of 2602 strings)

Translation: Mattermost/server
Translate-URL: https://translate.mattermost.com/projects/mattermost/server/cs/

* Translated using Weblate (Czech)

Currently translated at 85.0% (2213 of 2602 strings)

Translation: Mattermost/server
Translate-URL: https://translate.mattermost.com/projects/mattermost/server/cs/

* Translated using Weblate (Czech)

Currently translated at 85.1% (2215 of 2602 strings)

Translation: Mattermost/server
Translate-URL: https://translate.mattermost.com/projects/mattermost/server/cs/

* Translated using Weblate (Ukrainian)

Currently translated at 100.0% (2602 of 2602 strings)

Translation: Mattermost/server
Translate-URL: https://translate.mattermost.com/projects/mattermost/server/uk/

* Translated using Weblate (Ukrainian)

Currently translated at 92.6% (5578 of 6021 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/uk/

* Translated using Weblate (Czech)

Currently translated at 86.0% (2238 of 2602 strings)

Translation: Mattermost/server
Translate-URL: https://translate.mattermost.com/projects/mattermost/server/cs/

* Translated using Weblate (Czech)

Currently translated at 86.1% (2242 of 2602 strings)

Translation: Mattermost/server
Translate-URL: https://translate.mattermost.com/projects/mattermost/server/cs/

* Translated using Weblate (Kazakh)

Currently translated at 13.7% (830 of 6021 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/kk/

* Translated using Weblate (Turkish)

Currently translated at 100.0% (2602 of 2602 strings)

Translation: Mattermost/server
Translate-URL: https://translate.mattermost.com/projects/mattermost/server/tr/

* Translated using Weblate (Turkish)

Currently translated at 100.0% (6021 of 6021 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/tr/

* Translated using Weblate (Kazakh)

Currently translated at 13.8% (832 of 6021 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/kk/

* Translated using Weblate (Ukrainian)

Currently translated at 93.0% (5605 of 6021 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/uk/

* Translated using Weblate (Polish)

Currently translated at 100.0% (6021 of 6021 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/pl/

* Translated using Weblate (Czech)

Currently translated at 86.9% (2262 of 2602 strings)

Translation: Mattermost/server
Translate-URL: https://translate.mattermost.com/projects/mattermost/server/cs/

* Translated using Weblate (Kazakh)

Currently translated at 13.9% (839 of 6021 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/kk/

* Translated using Weblate (Czech)

Currently translated at 89.3% (2326 of 2602 strings)

Translation: Mattermost/server
Translate-URL: https://translate.mattermost.com/projects/mattermost/server/cs/

* Translated using Weblate (Norwegian Bokmål)

Currently translated at 53.7% (3236 of 6021 strings)

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/nb_NO/

* Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Translation: Mattermost/server
Translate-URL: https://translate.mattermost.com/projects/mattermost/server/

* Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Translation: Mattermost/webapp
Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/

---------

Co-authored-by: Serhii Khomiuk <sergiy.khomiuk@gmail.com>
Co-authored-by: master7 <marcin.karkosz@rajska.info>
Co-authored-by: Martin Mičuda <micuda@rematiptop.cz>
Co-authored-by: Akbar Abdrakhmanov <kz.akbar@gmail.com>
Co-authored-by: jprusch <rs@schaeferbarthold.de>
Co-authored-by: Tom De Moor <tom@controlaltdieliet.be>
Co-authored-by: Kaya Zeren <kayazeren@gmail.com>
Co-authored-by: Frank Paul Silye <frankps@gmail.com>
 2024-12-16 19:48:31 +00:00
Amy Blais
2b9e85f155 Update minimum supported Safari and Firefox versions (#29576) 
Automatic Merge
 2024-12-16 12:47:38 +02:00
Jesús Espino
d316df6d28 Replacing interface{} with any everywhere (except generated mocks) (#29446) 2024-12-15 21:11:36 +01:00
Seiya Homma
01415bee9c Resolve backward compatibility issues (#29566) 
Co-authored-by: Mattermost Build <build@mattermost.com>
 2024-12-13 12:49:00 -04:00
Agniva De Sarker
42ff2a2639 [Aider assisted]: Templatize rest of the elasticsearch translation strings (#29582) 
After https://github.com/mattermost/mattermost/pull/29209, there were some more
strings which were left out. Sending another PR to fix all of them.

The config validation strings are made generic for simplicity, because they
are called before the search backend is started, and even though you could
check for the config setting, it forces the code order. Therefore, changed
the words to just say "Search" for simplicity.

I tried to use Aider initially for a little while, but ended up fighting
a lot with the search/replace and having to repeat myself over and over again
to get it to do the refactoring. Eventually gave up and did rest of the changes
myself.

```release-note
NONE
```
 2024-12-13 19:25:08 +05:30
Agniva De Sarker
bc22267829 MM-61699: Improve TestDeletePostEvent (#29575) 
This test failed because TestWebHubCloseConnOnDBFail failed
and therefore the ChannelMembers table failed to be
renamed back.

We can see that in the logs:

```
teams","request_id":"sdxjxsd1wibd9mb7kc3ixj6g1w","ip_addr":"127.0.0.1","user_id":"afw9qqjh7pnddqakraxnjf1oph","method":"POST","user_id":"afw9qqjh7pnddqakraxnjf1oph","team_id":"bocubwmn4jyrmc1p9uxrc4pwfc","error":"JoinDefaultChannels: Unable to save direct channel., channel_members_save: Error 1146 (42S02): Table 'dbrt3jzcosj3nb8g6mgwmqyss9rh.ChannelMembers' doesn't exist"}
{"timestamp":"2024-11-10 13:52:34.260 Z","level":"error","msg":"Error while invalidating channel member cache","caller":"platform/web_hub.go:524","user_id":"afw9qqjh7pnddqakraxnjf1oph","error":"failed to find ChannelMembers, TeamScheme and ChannelScheme data: Error 1146 (42S02): Table 'dbrt3jzcosj3nb8g6mgwmqyss9rh.ChannelMembers' doesn't exist"}
{"timestamp":"2024-11-10 13:52:34.260 Z","level":"error","msg":"Error while invalidating channel member cache","caller":"platform/web_hub.go:524","user_id":"afw9qqjh7pnddqakraxnjf1oph","error":"failed to find ChannelMembers, TeamScheme and ChannelScheme data: Error 1146 (42S02): Table 'dbrt3jzcosj3nb8g6mgwmqyss9rh.ChannelMembers' doesn't exist"}
```

There is nothing wrong with this test. And while
we are here, we slightly improve the for-select loop
to exit faster.

https://mattermost.atlassian.net/browse/MM-61699
```release-note
NONE
```
 2024-12-13 13:28:58 +05:30
Claudio Costa
6e2c34bb6b Prepackage Calls v1.4.0 (#29568) 2024-12-12 14:34:59 -06:00
Jesús Espino
31351a48b0 Depublishing some app layer methods (#29559) 
* Depublishing some app layer methods

* Fixing errors

* Addressing PR review comment

* Using goimports formatting now
 2024-12-12 20:15:38 +01:00
Rohan Sharma
a5a92d825a [MM-61102] Fix errcheck issues in server/channels/app/channel_bookmark_test.go (#28789) 
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
 2024-12-12 16:48:48 +01:00
Devin Binnie
3eb95af974 [MM-62086] Don't include deleted DMs/GMs when returning archived channels (#29572) 2024-12-12 15:19:21 +00:00
Devin Binnie
57372bd06b [MM-62092] Allow system admins to pull posts in from DMs they're not in (#29557) 2024-12-12 15:12:21 +00:00
Agniva De Sarker
d20dbc3b88 MM-61698: Fix TestWebHubCloseConnOnDBFail properly (#29577) 
Finally I figured out why the log message for
/api/v4/websocket does not appear. It is because
the log gets generated only when the request returns,
and for websockets, the request doesn't return
until the client closes. And because we were closing
the client in a defer clause, the flushing of the logger
would happen before closing the client, therefore
leading to a race condition of the log not appearing
from time to time.

https://mattermost.atlassian.net/browse/MM-61698
```release-note
NONE
```
 2024-12-12 18:55:44 +05:30
Ivy Gesare
832b5a3332 [MM-61771] Fix errcheck issues in server/channels/app/platform/service_test.go (#29375) 
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
 2024-12-12 13:51:16 +01:00
Seiya Homma
55500b573a [MM-61776] Fix errcheck issues in server/channels/app/platform/web_conn.go (#29515) 2024-12-12 12:19:23 +01:00
Kyrillos Isaac
267c4133b7 [MM-61263] fix: errcheck issues in server/channels/app/job_test.go (#29070) 
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
 2024-12-12 12:17:40 +01:00
AulakhHarsh
1b164c8302 Fix errcheck issues in server/channels/app/platform/service.go (#29366) 2024-12-12 11:22:57 +01:00
Agniva De Sarker
f3309633b2 MM-61698: Unskip TestWebHubCloseConnOnDBFail (#29546) 
https://github.com/mattermost/mattermost/pull/29214 fixed the
race condition in web_hub initialization.

The failure in the test is strange because there's no log
for the websocket request. It's as if th.CreateWebSocketClientWithClient()
never got called at all.

I am re-arranging the lines so that even if it fails,
the table rename happens anyways. But overall, I don't see
any reason for the failure.

https://mattermost.atlassian.net/browse/MM-61698

```release-note
NONE
```
 2024-12-12 10:53:31 +05:30
Agniva De Sarker
bfdf6638ee Adding error context in license validation (#29554) 
While investigating https://mattermost.atlassian.net/browse/MM-61529,
I noticed that we weren't adding the internal error which made
it impossible to understand what was really happening.

```release-note
NONE
```
 2024-12-12 10:33:46 +05:30